[02:49:09] wfan: do you have a phab for that recur-cancel issue? [02:52:17] (03PS1) 10Eileen: Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 [02:52:36] ^^ should work for the patch [03:13:58] (03CR) 10CI reject: [V: 04-1] Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 (owner: 10Eileen) [07:13:48] (03PS2) 10Eileen: Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 [07:30:49] (03CR) 10CI reject: [V: 04-1] Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 (owner: 10Eileen) [07:33:04] (03PS3) 10Eileen: Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 [07:43:27] (03PS3) 10Wangombe: Update reference to namespaced TranslateMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) [07:45:45] (03CR) 10CI reject: [V: 04-1] Update reference to namespaced TranslateMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) (owner: 10Wangombe) [07:51:19] (03CR) 10CI reject: [V: 04-1] Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 (owner: 10Eileen) [08:29:18] (03PS4) 10Eileen: Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 [08:30:34] (03CR) 10Tacsipacsi: Update reference to namespaced TranslateMetadata::class (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) (owner: 10Wangombe) [08:32:17] (03PS5) 10Eileen: Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 [10:25:58] (03PS4) 10Wangombe: Update reference to namespaced TranslateMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) [10:26:05] (03CR) 10Wangombe: Update reference to namespaced TranslateMetadata::class (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) (owner: 10Wangombe) [10:29:07] (03CR) 10CI reject: [V: 04-1] Update reference to namespaced TranslateMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) (owner: 10Wangombe) [11:10:04] (03CR) 10Tacsipacsi: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T348496) (owner: 10Wangombe) [13:49:42] 10Fundraising-Backlog: Records in civicrm.civicrm_contribution_tracking with no time data. Bug or feature? - https://phabricator.wikimedia.org/T353804 (10jgleeson) [13:50:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Records in civicrm.civicrm_contribution_tracking with no time data. Bug or feature? - https://phabricator.wikimedia.org/T353804 (10jgleeson) [16:13:01] 10Fundraising-Backlog, 10fundraising-tech-ops: Fix disk capacity issues on civi1002 - https://phabricator.wikimedia.org/T343071 (10Jgreen) [16:13:03] 10Fundraising-Backlog, 10FR-WMF-Audit: audit processor should bzip completed files - https://phabricator.wikimedia.org/T320742 (10Jgreen) [16:13:57] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review & fix CiviCRM log file management - https://phabricator.wikimedia.org/T247378 (10Jgreen) [16:13:59] 10Fundraising-Backlog, 10fundraising-tech-ops: Fix disk capacity issues on civi1002 - https://phabricator.wikimedia.org/T343071 (10Jgreen) [16:44:00] (03CR) 10Jgleeson: "Thanks for explaining, and thanks for the test! Ok, cool, this looks close then. I have one last question about the default parameter fall" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) (owner: 10Wfan) [16:53:58] (03CR) 10Jgleeson: "Is there a way to test this with the sandbox API? The code looks good, but I was scratching my head, thinking about how to simulate the sc" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) (owner: 10Wfan) [17:29:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Records in civicrm.civicrm_contribution_tracking with no time data. Bug or feature? - https://phabricator.wikimedia.org/T353804 (10AKanji-WMF) p:05Triage→03Medium [17:31:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Add a time limit to contribution tracking queue consume - https://phabricator.wikimedia.org/T329600 (10Cstone) Happened again 2023-12-20 [18:41:20] (03CR) 10Wfan: [C: 03+2] "Works great, thanks Eileen~" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 (owner: 10Eileen) [18:57:56] (03Merged) 10jenkins-bot: Fix hook bypass on ContributionRecur.cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984302 (owner: 10Eileen) [19:22:08] 10Fundraising-Backlog, 10Developer Productivity: Migrate fundraising-dev repo to gitlab - https://phabricator.wikimedia.org/T353374 (10AKanji-WMF) Currently budgeting to work on this Q1 FY2425 [19:25:18] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Move some logic from the GatewayAdapter class to DonationData class - https://phabricator.wikimedia.org/T336667 (10AKanji-WMF) [19:32:17] 10Fundraising-Backlog, 10Fr-tech Refactor, 10MediaWiki-extensions-DonationInterface: Move some logic from the GatewayAdapter class to DonationData class - https://phabricator.wikimedia.org/T336667 (10AKanji-WMF) [19:34:19] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig, 10Fr-tech Refactor: Clean up Adyen SmashPig code - https://phabricator.wikimedia.org/T345878 (10AKanji-WMF) [19:35:32] 10Fundraising-Backlog, 10FR-Smashpig, 10Fr-tech Refactor: Merge DonorDetails.customerId with PaymentDetailResponse.processorContactID - https://phabricator.wikimedia.org/T348991 (10AKanji-WMF) [19:35:34] 10Fundraising-Backlog, 10FR-Paypal, 10FR-Smashpig, 10Fr-tech Refactor: Invalid PayPal message type: mp_cancel - https://phabricator.wikimedia.org/T337326 (10AKanji-WMF) [19:35:36] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Fr-tech Refactor: Add Idempotency headers to PayPal EC API calls - https://phabricator.wikimedia.org/T317696 (10AKanji-WMF) [19:35:39] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Fr-tech Refactor: Implement PayPal EC RefundTransaction in SmashPig - https://phabricator.wikimedia.org/T318882 (10AKanji-WMF) [19:35:41] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Fr-tech Refactor, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10AKanji-WMF) [19:35:50] hmm anilk, that tag is setting off the batsignal every time you apply it to a task [19:35:50] anilk: can I pitch that fr-tech refactor tag or is it for preagreed stuff? [19:36:01] maybe just fundraising-refactor? [19:36:18] LOL made the same suggestion [19:37:20] :) XenoRyet and I are trying it out in Phab. It's totally pitchable - and for sure send alternate tag name suggestions [19:38:10] We were just trying to classify things we were seeing in near future [19:39:56] there's a workboard for the project that would be great if we could build out [19:42:16] when you rename it, I will pinch it [19:42:38] there's one or two recent refactoring tickets floating around [19:50:08] dwisehaupt: I'm just looking at https://phab.wmfusercontent.org/file/data/k3mwzcl3t7jnpyicybtn/PHID-FILE-5k2ohqpptcur6k6urv5j/image.png [19:50:24] & I'm wondering if any server logs show that 500 error [19:50:36] i'll check. [19:52:23] there are a set of them. [19:53:11] you should be able to use this after ssh-ing in to see them: sudo grep redirect-handler/500 /var/log/apache2/access.log [20:19:24] dwisehaupt: ok - it IS url related [20:19:39] or at leas the url in the 500 error is wrong [20:51:06] (03PS1) 10Damilare Adedoyin: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/984638 [21:00:21] (03CR) 10CI reject: [V: 04-1] Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/984638 (owner: 10Damilare Adedoyin) [21:29:47] 10Fundraising-Backlog, 10FR-donorservices: Civi: Endowment ty email - include CNTCT - https://phabricator.wikimedia.org/T353842 (10SHust) [21:32:07] damilare: is that just a test merge to see how it looks now without the security update [21:32:18] yea it was a test merge [21:32:31] (thumbs up emoji) [21:32:44] weechat has its limits :) [21:33:34] ahh, I miss using glowing bear for this reason [21:34:48] I still need to get around to setting that up [21:34:59] it's been on my mental todo list for about four years [21:36:05] after Casey Dentinger explained how it worked to me [21:36:20] he must have left like 5 years ago now [21:36:52] I was pretty new [21:37:38] this csvkit thing looks amazing https://csvkit.readthedocs.io/en/latest/ [21:37:49] Query with SQL: [21:37:52] csvsql --query "select name from data where age > 30" data.csv > new.csv [21:38:11] someone had fun writing that [21:39:40] ohh that's really cool [21:40:12] also I stopped using glowing bear for a while now because of the consistent renewal of certs. I should automate that [21:40:23] ah [21:40:42] I think everyone else uses irccloud something [21:41:46] yh, I'm just not sure it connects to independent servers. [22:02:58] I'm calling it a night. have a safe trip cstone!!! and happy holidays fr-tech folks who are not around tomorrow as I'm out friday [22:03:08] happy holidays jgleeson !! [22:03:14] o// [22:03:20] Happy holiday to u both [22:20:43] happy holidays all! [22:28:37] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Patch-For-Review: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) OK, I have migrated all of the tokens in all of the CSV files from Adyen.... [23:53:13] (03PS1) 10Cstone: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) [23:54:20] (03PS2) 10Cstone: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) [23:54:57] eileen: is there a way to combine those two functions in one place? ^ [23:55:41] bah still hardcoded hah [23:58:03] So I think the way you have done it you could remove these changes https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/984650/2/drupal/sites/default/civicrm/extensions/wmf-thankyou/Civi/Api4/Action/EOYEmail/Render.php & it would still work [23:58:46] (03PS3) 10Cstone: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) [23:59:01] ie if the calling function does not do `setCancelledRecurring()` then `getCancelledRecurring()` will figure it out itself [23:59:21] i seee [23:59:26] the main reason the calling function might set it is if is has already loaded the information more efficiently [23:59:47] (or because you are in the preview UI & it is providing sample data)