[00:00:01] oh well so with just getCancelled it only was working in the temtplate eyeball [00:00:13] but wouldnt actually send me it in the email or in the donor UI [00:00:39] I had to add them to Render to get those to show up [00:15:02] ok - I'll give it a spin [00:16:10] thanks eileen ! [01:03:11] cstone: so we combine active recurring with cancelled recurring to eliminate people who cancelled & re-activated? [01:03:51] yeah dont want to show it to people who have an active and a cancelled [01:04:12] like if (!not active & is cancelled) [01:04:16] er !active [01:05:42] {if !$active_recurring && $cancelled_recurring} [01:13:28] cstone: I think for active recurring we should change the end on the between to 'now' [01:13:56] for when we are bit into the following year & re-sending [01:14:30] on the cancelled one? [01:15:38] both I think [01:15:52] I think it means 'is there an active recurring at the time when we send this' [01:16:39] and then so cancelled would be was a recurring cancelled from jan1 - now? [01:16:42] (api takes 'now' ) [01:19:43] (03PS4) 10Wfan: Do not check submetod metadata for gpay applepay venmo paypal amazon [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) [01:23:21] hmm eileen but what date would we check I do think the status is right there [01:23:39] the active checks dont have a date range [01:25:22] hmm - yeah we have 2 versions of the query confusing me - I can see why - some fixes needed [01:25:36] want me to match the api4 one? [01:25:45] i think they should match whatever the query is [01:26:00] which query [01:26:15] er sorry make the two checkactives match [01:26:48] (03PS4) 10Eileen: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) (owner: 10Cstone) [01:26:50] (03PS1) 10Eileen: wip - why [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984657 [01:27:11] LOL eileen that why was why I was so confused earlier [01:27:29] cstone: so looking at it I don't think we get any benefit from having it in 2 places but it got done (by me) earlier because obviously I didn't spot the real issue / make good choices [01:27:40] oooh was the naming the issue? [01:27:47] yeah [01:28:39] you were bringing back the _ [01:29:04] so we have the token name - which seems to be active_recurring - which is arguably correct - & that is specified in the variable definition - ie @scope tplParams as active_recurring [01:29:36] & then we have the property name & the propertyName & the getter need to match [01:30:23] & I think the propertyName was the bit that was inconsistent with other places [01:32:01] so then the @method one would be setActiveRecurring? ($active_recurring) [01:33:11] niceeee [01:33:32] well the variable name is internal - so it doesn't have any impact - it could be [01:33:32] setActiveRecurring? ($IAmASprintNamingWorthVariableName) [01:33:48] so the only place it needs the _ is in the tpl line? [01:34:23] yeah - that line defines the smarty variable [01:34:41] woohoo deleting the doubles [01:35:13] I don't know what casing we mostly use in our smarty variables - but if we don't look there will be no temptation to do more work changing the variable [01:35:23] its kind of both [01:35:24] haha [01:35:32] everything else is not _ [01:36:22] you looked!! [01:36:43] its nicely on your documentation page [01:36:51] ha [01:37:00] https://wikitech.wikimedia.org/wiki/Fundraising/Internal_Endpoints/End_of_year_emails#Messages_and_tokens [01:37:11] ok i broke the eyeball render now somehow haha [01:37:23] oh ! [01:37:39] naming [01:38:27] :-) [01:39:00] (03PS5) 10Cstone: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) [01:39:04] what patch are you using to expose the values in there - it's not in the patch I'm looking at [01:39:16] now it is [01:39:18] oh yeah i just edited it locally can I force that into this patch [01:40:02] (03PS1) 10Cstone: Add cancelled_reason to EOY template Also clean up variable names and double methods Bug: T353206 Change-Id: I91b1242b99320065745df013b85d12a408822182 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984658 (https://phabricator.wikimedia.org/T353206) [01:40:09] what happened there [01:40:12] so let's say it if June next year & DR sends out a receipt & they cancelled their last recurring in March [01:40:29] should they get the 'activate' message [01:40:34] how did break patch [01:40:40] hmm [01:40:42] ccccccjelcgburnlhdfcftcurgfhlgcfcckitjuridnk [01:40:50] so says my yubikey [01:40:56] yubikey is right [01:41:19] so its june 2024 they cancelled recuring march 2023? [01:42:10] why do i have two patchse now [01:42:33] (03Abandoned) 10Cstone: Add cancelled_reason to EOY template Also clean up variable names and double methods Bug: T353206 Change-Id: I91b1242b99320065745df013b85d12a408822182 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984658 (https://phabricator.wikimedia.org/T353206) (owner: 10Cstone) [01:42:35] (03CR) 10Eileen: Add cancelled_reason to EOY template (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) (owner: 10Cstone) [01:42:49] rogue space [01:43:51] so I should cancel both my patches so they don't confuse [01:44:01] (03Abandoned) 10Eileen: wip - why [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984657 (owner: 10Eileen) [01:44:15] (03Abandoned) 10Eileen: something like this [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984295 (owner: 10Eileen) [01:46:05] (03PS6) 10Cstone: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) [01:49:19] oh cstone setCancelled_recurring -> setCancelledRecurring [01:49:46] oh hang on - this isn't the latest is it? [01:52:40] hmmmmm [01:52:41] yess [01:52:52] oh the latest should ohnly have _ in the tpl [01:53:09] how did that happen let me update [01:53:25] I feel so confused [01:53:38] i think those changes were in my one that went to rebase jail [01:53:49] ah... [01:54:07] ahh it lost all the changes [01:55:30] im confused now too haha [01:56:38] its not even in the rebase jail one! [01:56:59] it keeps putting recieve date there too ok 3rd times the charm [01:57:50] (03PS7) 10Cstone: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) [01:58:28] ok eileen ^ 7 looks right [02:01:27] ok - that worked - at least for our kind donor 'Mel' [02:01:36] make that 'Mei' [02:05:43] (03CR) 10Eileen: [C: 03+2] "7 was the lucky number!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) (owner: 10Cstone) [02:06:03] thanks for being so patient with me eileen I learned a lot LOL [02:06:11] (03PS8) 10Eileen: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) (owner: 10Cstone) [02:06:13] (03PS1) 10Eileen: Set default in year field to cause less brain pain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984659 [02:06:14] :-) [02:06:57] I pushed up one thing that would be helpful - but I wondered if you wanted to create some more examples eg 'active only', 'cancelled only' & 'active & cancelled' (current default) [02:07:23] maybe active only doesn't add anything [02:07:30] so just cancelled [02:08:10] oh yeah lemme do those examples [02:08:22] i started into my box of christmas cookies [02:08:45] got distracted [02:09:33] the `ThankYouExample` class shows it with multiple versions [02:09:42] what sort of cookies.... [02:10:15] it has sugar and gingerbread and im eating some sort of loaf thing with chocolate chips on it [02:13:33] apparently a pumpkin loaf [02:21:24] (03CR) 10Cstone: [C: 03+2] "🧠" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984659 (owner: 10Eileen) [02:23:27] pumpkin loaf sounds very american [02:24:03] - I'm having flashbacks to 🚆 [02:24:19] i do not miss that train [02:24:36] lol - I wondered if you would even recognise that - it's a shit emoji [02:25:05] haha its a shinkansen i think [02:25:31] or at least a speedier train [02:37:59] (03Merged) 10jenkins-bot: Add cancelled_reason to EOY template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984650 (https://phabricator.wikimedia.org/T353206) (owner: 10Cstone) [02:38:02] (03Merged) 10jenkins-bot: Set default in year field to cause less brain pain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984659 (owner: 10Eileen) [02:38:10] cstone / eileen I'll look into that silverpop fail unless someone's already on it [02:38:26] ah I hadn't ejegg [02:38:29] oh I hadn't spotted it yet [02:38:32] Duplicate entry '62843214' for key 'PRIMARY [02:38:46] i think that's probably a weird double relationship bug [02:38:47] oh - we have seen that before haven't we - [02:38:49] let's see [02:40:48] hmm, that should be the email id [02:41:26] and that email is for contact 62682850 who has no relationships [02:41:38] so what's making a duplicate there? [02:42:12] no other contacts with that email [02:44:34] ejegg: not a momentary thing as Acoustic took the snapshot? [02:46:41] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Civi: EoY recurring summary email - include CNTCT - https://phabricator.wikimedia.org/T353372 (10Cstone) `

CNTCT-{contact.id}

` has been added to the bottom of all the templates [02:47:46] eileen oh hmm, maybe? [02:47:57] I forget, how does that happen? [02:48:45] I can't totally recall but it does build the tables as it goes & I think inconsistencies can sneak in what happens if we just re-run the build? [03:02:00] (03PS1) 10Cstone: WIP: Add more EOY examples [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984660 (https://phabricator.wikimedia.org/T353206) [03:02:28] im crashing I might be back if I recover [03:06:15] :-) [03:06:18] nah finish up [03:14:05] ok, I'm re-running it [03:21:44] and... it got past the place where it failed last time [03:24:19] cool - well that gets us off the hook for today [03:24:54] but it will miss Acoustic import window? So we need to let Katie know? [03:33:44] I think we have a pretty decent safety margin [03:35:20] I guess you kicked it pretty quickly? Do you know when it runs? [03:36:26] let's see if I can find it in acoustic [03:38:15] says 4:00 AM but I'm not sure what TZ [03:38:36] if it's UTC that's 20 min from now, and we'd be cutting it pretty close [03:38:52] let's see how long it all took last night [03:39:38] ok, in the import job config it says 'every day at 9 am' [03:39:55] so I'm guessing the config uses UTC and the last run report uses my local TZ [03:40:00] for maximum confusion [03:40:20] but it would fit with the 5 hr difference [03:42:02] ok, so it's taking about 1 hr 15 min during this campaign [03:42:18] as long as that TZ guess is right we should be fine [03:43:00] eileen: can you get into acoustic? [03:44:18] just wondering what time you see if you go to data->data jobs->recurring jobs tab [03:44:29] in the 'last run' column [03:45:01] checkin [03:48:24] I'm n [03:48:35] oh - maybe [03:49:33] no - just past the first screen... [03:51:01] sigh - 232145 [03:51:10] opps - it's saying my account is disabled [03:51:20] ah shoot [03:51:25] lemme see if I can reenable [03:53:02] oh fun, it says i have to delete your account and re-add it [03:54:40] hmm, not seeing the 'manage' section, maybe I don't have access [03:58:09] it's sooo confusing [03:58:29] yeah [03:58:47] i guess in 2 minutes I'll know if it actually runs at 4am utc [03:58:51] Maybe the best thing is just to email Katie & say the job finished a bit late today & she should check it uploaded & if now the file will be there & she can push it through [04:15:12] well, it's not running the import now, so i'm pretty sure it's actuall 9 utc. Katie i think is on that acoustic failmail list so she'll see the email i sent when i kicked it off [04:15:27] going to sign off now. happy holidays! [04:26:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Interesting apache error in logs - https://phabricator.wikimedia.org/T353603 (10Eileenmcnaughton) define interesting :-) [08:10:19] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Patch-For-Review: Check that end of year email receipt templates are ready for January 2024 send - https://phabricator.wikimedia.org/T353206 (10MSuijkerbuijk_WMF) Thanks for this task. @Cstone once you have information on when this could be rel... [12:03:42] (03Abandoned) 10Damilare Adedoyin: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/984638 (owner: 10Damilare Adedoyin) [14:53:30] 10Fundraising Sprint Byzantine Empire Strikes Back, 10Fundraising Sprint CAPS LOCK CULTS, 10Fundraising Sprint Dampness, 10Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (10Francesca_Lissoni_WMIT) (Thank you Camille for introducing us) Hi Eileen, thank yo... [17:03:26] (03PS1) 10Wfan: Use civi webhook to trigger adyen auto rescue cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984868 (https://phabricator.wikimedia.org/T351338) [17:12:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Interesting apache error in logs - https://phabricator.wikimedia.org/T353603 (10AKanji-WMF) p:05Triage→03Low [17:15:51] 10Fundraising-Backlog, 10FR-donorservices: Civi: Endowment ty email - include CNTCT - https://phabricator.wikimedia.org/T353842 (10AKanji-WMF) Moving into sprint for addressing early Jan [19:57:35] 10Fundraising-Backlog: EFT Matching Organization Import - Duplicate error override not working - https://phabricator.wikimedia.org/T353907 (10MDemosWMF) [20:07:26] 10Fundraising-Backlog, 10Recurring-Donations: Recurring Upgrade Thank You Email - https://phabricator.wikimedia.org/T353908 (10AKanji-WMF) [20:18:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10Damilare) Deployed and backfill done. Backfill job of 28k+ contacts had 11 errors due to duplicates and invalid countries entered. Errors... [20:31:54] (03PS1) 10Damilare Adedoyin: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 [20:40:59] (03PS2) 10Damilare Adedoyin: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 [20:50:22] (03CR) 10CI reject: [V: 04-1] Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 (owner: 10Damilare Adedoyin) [20:57:45] (03PS3) 10Damilare Adedoyin: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 [21:06:16] (03CR) 10CI reject: [V: 04-1] Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 (owner: 10Damilare Adedoyin) [21:11:19] (03PS4) 10Damilare Adedoyin: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 [21:23:32] (03CR) 10Damilare Adedoyin: [C: 03+2] "Looks good to me, thanks for all the work on this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981445 (https://phabricator.wikimedia.org/T329807) (owner: 10Wfan) [21:25:19] (03Merged) 10jenkins-bot: Use ja_01A as default for all ja as language forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981445 (https://phabricator.wikimedia.org/T329807) (owner: 10Wfan) [21:26:08] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 (owner: 10Damilare Adedoyin) [21:34:56] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/REL1_39' into fundraising/REL1_39 And update vendor submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/985008 (owner: 10Damilare Adedoyin) [21:42:26] 1c96980a [21:42:33] !log payment-wiki revision 1c96980a -> 3b281d10 [21:42:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log