[08:29:49] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Patch-For-Review: Check that end of year email receipt templates are ready for January 2024 send - https://phabricator.wikimedia.org/T353206 (10MSuijkerbuijk_WMF) @Cstone and @NNgu-WMF I'm sharing below the copy needed for cancelled recurring,... [12:54:51] 10Fundraising-Backlog: Change URL in WMF Recurring Failure template - https://phabricator.wikimedia.org/T354185 (10MSuijkerbuijk_WMF) [17:13:40] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Patch-For-Review: Check that end of year email receipt templates are ready for January 2024 send - https://phabricator.wikimedia.org/T353206 (10NNgu-WMF) Hello! I'm trying to add the copy provided above. Currently in the template it says {if $... [17:25:38] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/987162 [18:01:45] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog: Check that end of year email receipt templates are ready for January 2023 send - https://phabricator.wikimedia.org/T325596 (10jgleeson) The EOY jobs were switched on just now. [18:13:51] (03CR) 10Ejegg: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [18:16:01] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Patch-For-Review: Check that end of year email receipt templates are ready for January 2024 send - https://phabricator.wikimedia.org/T353206 (10Ejegg) Hi @NNgu-WMF it looks like we would want to use ` {if !$active_recurring && $cancelled_recu... [18:27:15] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Suppress failmail on contribution tracking constraint violations - https://phabricator.wikimedia.org/T352321 (10Ejegg) The linked patch was deployed, but it looks like this is still causing failmails. Need to revi... [18:47:21] (03CR) 10Umherirrender: "It seems a qunit test is failing" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [20:11:13] (03PS1) 10Ejegg: Really skip failmail for CT constraint violations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987185 (https://phabricator.wikimedia.org/T352321) [20:23:36] (03CR) 10Ejegg: [C: 04-1] "Getting back into this review with fresh eyes. I think we need to keep the token creation after the hash check and just refactor the same " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [20:24:59] (03CR) 10Jgleeson: [C: 03+2] "Tested locally and can now see the '-3' error code, which the code now detects and suppresses. Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987185 (https://phabricator.wikimedia.org/T352321) (owner: 10Ejegg) [20:26:27] thanks jgleeson [20:27:08] np [20:27:59] (03CR) 10CI reject: [V: 04-1] Really skip failmail for CT constraint violations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987185 (https://phabricator.wikimedia.org/T352321) (owner: 10Ejegg) [20:29:32] oh shoot [20:29:48] Civi\Api4\Action\WMFDonorTest::testWMFDonorGetSegments [20:29:50] 15:27:30 Failed asserting that '35' matches expected 50. [20:30:04] Guessing there's some current_year shenanigans there [20:30:23] Commit headline: update tests for 2024 [20:44:37] thanks for the review ejegg. I'm trying to remember how that stuff worked too [20:50:23] sure thing! I don't want to lose the momentum on that work, even if the code change ends up a bit different than the current patches [20:52:08] (03PS1) 10Ejegg: Use mockable date for WmfDonor calculations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987193 [21:02:57] eileen: does ^^^ look OK? We might need it to make tests pass (or we could just wait til July) [21:03:07] lol [21:03:12] I was just looking at it [21:03:25] thanks! [21:11:47] (03CR) 10CI reject: [V: 04-1] Use mockable date for WmfDonor calculations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987193 (owner: 10Ejegg) [21:12:23] dang! [21:13:19] I shoulda run the other ones locally [21:20:55] ejegg: where is a list of the tests failing without your patch? I assume there is another patch with them [21:21:59] eileen https://gerrit.wikimedia.org/r/987185 is where I noticed it [21:22:43] ok so 1) Civi\Api4\Action\WMFDonorTest::testWMFDonorGetSegments [21:22:43] 09:41:22 Failed asserting that '35' matches expected 50. [21:22:54] - might be worth creating a phab as it might get sticky [21:23:03] ok [21:23:20] so that test seems to pass with the mockable date patch [21:23:38] it just fails on the testDonorSegmentTriggers test [21:24:28] hmm, and that segmentDataProvider seems to be run before setUp [21:25:36] yep, looking sticky [21:27:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WmfDonor test fails when run January-June - https://phabricator.wikimedia.org/T354223 (10Ejegg) [21:28:21] ug new laptop & haven't run tests in my IDE yet - need to figure out why it doesn't work yet [21:36:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WmfDonor test fails when run January-June - https://phabricator.wikimedia.org/T354223 (10Eileenmcnaughton) @Ejegg is that a real bug - 35 is lybunt, 50 is ultralapsed - just trying to get tests going [21:45:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WmfDonor test fails when run January-June - https://phabricator.wikimedia.org/T354223 (10Ejegg) The test mocks the current date to be Aug 1 of the current year. Then it creates a donor whose last contrib is 2 years before that, and expects it to be 'lapse... [21:48:02] hmm, no, 2 years before actual date doesn't fix it either [21:49:25] oh wait, it DOES fix it if I undo the other thing [21:52:03] (03PS2) 10Ejegg: Fix date for test donation in WmfDonor segment tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987193 [21:52:48] hmm, is that bandaid just going to fall off again after 6 mo though? [21:54:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WmfDonor test fails when run January-June - https://phabricator.wikimedia.org/T354223 (10Eileenmcnaughton) Hmm - but the definitions as fiscal related - we need to choose current or last depending on the month? [22:12:32] (03PS1) 10Eileen: Attempt to fix Jan test fail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987201 [22:13:14] (03PS2) 10Eileen: Attempt to fix Jan test fail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987201 (https://phabricator.wikimedia.org/T354223) [22:13:39] (03PS3) 10Eileen: Fix Jan test fail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987201 (https://phabricator.wikimedia.org/T354223) [22:14:11] ejegg|afk: ^^ worked for me locally - will see [22:58:45] (03CR) 10Eileen: "I think this will survive the fiscal cliff better - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/987201/" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987193 (owner: 10Ejegg) [23:00:27] (03CR) 10Ejegg: [C: 03+2] "Yep, I like this better!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987201 (https://phabricator.wikimedia.org/T354223) (owner: 10Eileen) [23:00:45] (03PS2) 10Ejegg: Really skip failmail for CT constraint violations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987185 (https://phabricator.wikimedia.org/T352321) [23:18:06] (03Merged) 10jenkins-bot: Fix Jan test fail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987201 (https://phabricator.wikimedia.org/T354223) (owner: 10Eileen) [23:19:02] https://medium.com/@andreasprega/clockmock-a-convenient-way-to-mock-date-and-time-in-php-ecb4a31c38b5 [23:54:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WmfDonor test fails when run January-June - https://phabricator.wikimedia.org/T354223 (10Ejegg) 05Open→03Resolved a:03Ejegg [23:54:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WmfDonor test fails when run January-June - https://phabricator.wikimedia.org/T354223 (10Ejegg) Eileen's fix: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/987201/3 [23:55:35] (03PS1) 10Wfan: If failed to store addree due to deadlock [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987207 (https://phabricator.wikimedia.org/T334548) [23:59:42] (03PS1) 10Wfan: remove the outdated exception use CRM_Core_Exception and getErrorData now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987208