[00:55:43] <wikibugs>	 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Dedupe Oddity - https://phabricator.wikimedia.org/T339288 (10SHust) @Eileenmcnaughton Sounds like a great plan! I can now stay late on Mondays and Wednesdays if that works for you.
[10:53:55] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal Recurring next_sched_contribution_date in the past - https://phabricator.wikimedia.org/T354327 (10jgleeson)
[13:00:05] <wikibugs>	 10Fundraising Sprint Quill Pencil, 10Fundraising Sprint RadioActivewear, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Deadlock should result in requeueing the message - https://phabricator.wikimedia.org/T118487 (10Damilare) a:03Damilare
[13:03:23] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: wmf_eoy_receipt send error: email is not attached (anymore?) to a valid contact - https://phabricator.wikimedia.org/T354347 (10jgleeson)
[13:42:38] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+1] "Looks good, added a small suggestion inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) (owner: 10Wfan)
[14:42:48] <wikibugs>	 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10krobinson)
[14:56:43] <wikibugs>	 (03CR) 10Jgleeson: "Looking good! One last thing" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) (owner: 10Wfan)
[14:59:15] <wikibugs>	 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10jgleeson) Taking a look now :O
[15:05:36] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10jgleeson)
[15:22:36] <wikibugs>	 10Fundraising Sprint 🐲 Phab the Magic Dragon, 10Fundraising-Backlog, 10FR-tech-data-integrity: Changing some of the imports on the back end - https://phabricator.wikimedia.org/T343758 (10NNichols) 05Resolved→03Open Reopening this task.    All gifts are being coded as Matching Gift or Payroll Deduction, t...
[15:44:13] <wikibugs>	 (03CR) 10Ejegg: "Maybe a better home for functions like this would be the WmfHelpers\ContributionRecur class? I'd rather stick with the CiviCRM entity name" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975286 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson)
[15:46:19] <wikibugs>	 (03CR) 10Ejegg: "As with the parent patch, I'd prefer to create any new classes in the Civi\WMFHelpers namespace in the new extension. And can you help me " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975287 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson)
[16:06:40] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal Recurring next_sched_contribution_date in the past - https://phabricator.wikimedia.org/T354327 (10Ejegg) Since it's PayPal, the next_sched_contribution_date doesn't really matter - they schedule al the charges.  It does look confusing though, and a...
[16:16:49] <icinga-wm>	 PROBLEM - Host frdb1006 is DOWN: PING CRITICAL - Packet loss = 100%
[16:21:15] <icinga-wm>	 RECOVERY - Host frdb1006 is UP: PING OK - Packet loss = 0%, RTA = 0.41 ms
[18:03:08] <wikibugs>	 (03Abandoned) 10Ejegg: Fix date for test donation in WmfDonor segment tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987193 (owner: 10Ejegg)
[18:03:36] <ejegg>	 oh hey fr-tech I wrote a couple of patches on one of my on-call days, and I forgot to send an email asking for review
[18:03:56] <ejegg>	 this one should get Adyen refunds to Civi faster: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/986525 
[18:04:40] <ejegg>	 And this one should help prevent double charges for recurring donors if we mistakenly run the job twice in parallel: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/986521 
[18:04:50] <ejegg>	 If anyone has a minute to review I'd appreciate it
[18:08:31] <jgleeson>	 sure I'll take a peek 
[18:09:05] <ejegg>	 thanks!
[18:09:08] <ejegg>	 gonna grab lunch
[18:24:48] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10EMartin) @jgleeson Is this an issue within the Dlocal infrastructure that we should chase down?
[18:26:42] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10jgleeson) @Damilare has picked this one up and it looking into it now
[18:26:51] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10jgleeson) a:03Damilare
[18:43:03] <jgleeson>	 damilare: did you see Evelyn's note on that thread?
[18:43:56] <damilare>	 no just seeing it now, I'd respond when I find something concrete. thanks jgleeson 
[18:44:08] <jgleeson>	 thanks!
[18:59:12] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "Looks good! nice a clean. Thanks for the tests!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/986525 (https://phabricator.wikimedia.org/T336439) (owner: 10Ejegg)
[18:59:43] <wikibugs>	 (03Merged) 10jenkins-bot: Send message to Civi when we get an Adyen refund IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/986525 (https://phabricator.wikimedia.org/T336439) (owner: 10Ejegg)
[19:21:33] <ejegg>	 thanks jgleeson!
[19:22:39] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/987810
[19:22:57] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/987810 (owner: 10Ejegg)
[19:23:25] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/987810 (owner: 10Ejegg)
[19:23:59] <jgleeson>	 np. ejegg I was just looking at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/986521 and the possibility of adding a test for the 'Processing' scenario to make it skips out. However the tests we've got already for the recurring charge jobs have a ton of set up steps and it pains me to just copy and paste 100 lines to change a few fields in a test ha
[19:24:12] <jgleeson>	 I'm guessing you looked at those too
[19:24:44] <ejegg>	 hehe, copy-paste a hundred lines of test to make 1 lil change? I would never!
[19:25:12] <ejegg>	 actually, I guess I just forgot to think about tests for that other one
[19:25:57] <ejegg>	 if it really is just a matter of status maybe I can do a dataProvider to avoid the duplication
[19:26:05] <ejegg>	 I'll take a quick look
[19:26:20] <jgleeson>	 I read a book on unit testing last month called "the art of unit testing" and the author recommends breaking test classes up into small tiny methods and avoiding using setUp methods in favour of test-specific factories 
[19:26:29] <jgleeson>	 pretty radical stuff
[19:26:38] <ejegg>	 oh hmm
[19:27:24] <ejegg>	 sounds vaguely familiar - i might have read an earlier version of that book while at my last job
[19:28:20] <ejegg>	 Roy Osherove?
[19:28:26] <wikibugs>	 (03PS5) 10Wfan: Do not check submetod metadata for gpay applepay venmo paypal amazon [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032)
[19:28:27] <jgleeson>	 yep that's it
[19:28:55] <ejegg>	 Now I'm curious how his recommendations have changed a decade later
[19:29:32] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10KHaggard)
[19:30:16] <jgleeson>	 I picked up the second edition. It was pretty good overall. 
[19:30:25] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Do not check submetod metadata for gpay applepay venmo paypal amazon [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) (owner: 10Wfan)
[19:31:53] <wikibugs>	 (03PS6) 10Wfan: Do not check submetod metadata for gpay applepay venmo paypal amazon [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032)
[19:31:59] * ejegg pages through 2009 pdf getting nostalgic about old nunit interface
[19:32:13] <jgleeson>	 ha
[19:32:46] <jgleeson>	 he used C# for the examples in the 2nd edition which was easy enough to follow
[19:35:36] <jgleeson>	 To help remember the stuff discussed, I decided to write out the techniques in PHPUnit. I kinda like the test name convention he suggests https://github.com/jackgleeson/art_of_unit_testing/blob/main/tests/StubUsingExtractAndOverrideLocalFactoryTest.php
[19:36:23] <ejegg>	 nice
[19:42:21] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "This makes sense to me! thanks for the guard." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/986521 (https://phabricator.wikimedia.org/T354085) (owner: 10Ejegg)
[19:42:45] <ejegg>	 thanks jgleeson 
[19:43:02] <jgleeson>	 np
[19:45:22] <jgleeson>	 oh this one is interesting https://phabricator.wikimedia.org/T354379
[19:58:38] <wikibugs>	 (03Merged) 10jenkins-bot: Check for 'Processing' status before charging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/986521 (https://phabricator.wikimedia.org/T354085) (owner: 10Ejegg)
[20:05:30] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10Ejegg) So these are Acoustic system fields, not anything we store in Civi or export to Acoustic, right? And since Acoustic has just one record per email address, these must be merges of two records...
[20:12:13] <wikibugs>	 (03PS2) 10Ejegg: Pull in latest extended reports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987497 (https://phabricator.wikimedia.org/T353924) (owner: 10Eileen)
[20:12:34] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] "Looks good to me." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987497 (https://phabricator.wikimedia.org/T353924) (owner: 10Eileen)
[20:14:24] <ejegg>	 jgleeson: is that how you understand the problem in that ticket? 
[20:15:08] <ejegg>	 (re https://phabricator.wikimedia.org/T354379 - i commented trying to state my understanding of what's happening)
[20:16:48] <ejegg>	 !log standalone (payments listener) SmashPig upgraded from fc74ccca to 20d6434e
[20:16:50] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:18:00] <jgleeson>	 huh i was just gonna check the silverpop export script to see if we pull any of those but looks like I haven't installed fundraising-tools locally yet
[20:18:49] <jgleeson>	 it does make sense that acoustic would have that data
[20:19:14] <jgleeson>	 you need the scary pixel tracking stuff to know last open date right?
[20:20:59] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10Ejegg) OK, so I guess we can calculate these from the raw mailing event data that we pull into Civi. So we would just want to add these dates for the few emails each night that are the 'winner' of a...
[20:21:27] <ejegg>	 jgleeson I think yeah, tracking pixel
[20:23:36] <ejegg>	 i'mma see if acoustic docs mention anything about merging records - though i imagine from their POV the email address has a specifc send/click/open history independent of an actual person it's linked to
[20:26:42] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10bsisolak) Those three fields are updated by Acoustic nightly (under Settings -> Organization Settings -> Automated Behavior Updates). You can export these fields as you can any other field.   You ca...
[20:29:05] <wikibugs>	 (03Merged) 10jenkins-bot: Pull in latest extended reports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987497 (https://phabricator.wikimedia.org/T353924) (owner: 10Eileen)
[20:34:48] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10Ejegg) @bsisolak I see there is some native merge functionality inside Acoustic. Searching help for 'merge' gives this promising-sounding article: https://help.goacoustic.com/hc/en-us/articles/22198...
[20:39:47] <ejegg>	 just got my own EOY summary email!
[20:40:28] <jgleeson>	 nice
[20:40:31] <ejegg>	 pretty stingy year, just $16 and 20k COP
[20:40:44] <ejegg>	 I guess I didn't have to do much testing on productin in 2023 :)
[20:43:17] <jgleeson>	 I noticed I had a couple in USD alongside GBP which reminded me to get better at changing the currency and avoid needlessly giving amex the conversion fees 
[20:50:57] <jgleeson>	 I'm calling it a day. catch you all tomorrow o/
[21:03:34] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10KHaggard) Thanks @Ejegg - that's an interesting link, would that replace the need for adding more custom fields? Ideally, it would be awesome if we didn't have to add more fields to the nightly expo...
[21:28:09] <ejegg>	 uh-oh, /usr/bin/env: ‘python’: No such file or directory
[21:28:21] <ejegg>	 whahappen, debian?
[21:28:33] <Jeff_Green>	 python3?
[21:29:12] <ejegg>	 should be
[21:29:27] <ejegg>	 (this is just on my local machine)
[21:30:50] <Jeff_Green>	 looks like it's the same on frpm1002/bookworm
[21:36:17] <ejegg>	 ah i see, I guess that was just an older command-line shortcut for launching my IDE
[21:36:27] <ejegg>	 I should delete that then
[21:36:50] <ejegg>	 yep, even changing that to python3 just fails because it's trying to launch it from a now-non-existent dir
[21:37:19] <ejegg>	 and the ide was just failing to launch via the gui shortcut because it had a zombie instance still running
[21:37:25] <ejegg>	 ok, all back to normal
[21:57:18] <ejegg|afk>	 bird in the house again...
[22:09:37] <wikibugs>	 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10bsisolak) In theory, yes you could do this, but it would require updating to a non-emailed keyed database. This would be a huge undertaking. Might be worth an investigation on your part, but would r...
[22:37:43] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357)
[22:47:45] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10Damilare) Thanks @EMartin and @krobinson for reporting this issue. Looks like the primary cause of this is the prenotification system of UPI recurrin...
[22:53:26] <wikibugs>	 (03PS2) 10Wfan: Use civi webhook to trigger adyen auto rescue cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984868 (https://phabricator.wikimedia.org/T351338)
[22:56:35] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal Recurring next_sched_contribution_date in the past - https://phabricator.wikimedia.org/T354327 (10AnnWF) a:03AnnWF
[22:56:40] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin)
[23:12:13] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357)
[23:13:59] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357)
[23:58:02] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: wmf_eoy_receipt send error: email is not attached (anymore?) to a valid contact - https://phabricator.wikimedia.org/T354347 (10AnnWF) just checked the log, and looking for those emails from civi contact table, seems like non of them are there even without...