[00:46:01] (03PS1) 10Wfan: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) [00:46:18] 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10KHaggard) Ok. I'll chat with Danny next week about this, but most likely I don't think we will be re-architecturing anytime soon. I'll circle back next week. [00:46:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: wmf_eoy_receipt send error: email is not attached (anymore?) to a valid contact - https://phabricator.wikimedia.org/T354347 (10AnnWF) a:03AnnWF [00:47:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Records in civicrm.civicrm_contribution_tracking with no time data. Bug or feature? - https://phabricator.wikimedia.org/T353804 (10AnnWF) a:03AnnWF [01:06:14] (03CR) 10CI reject: [V: 04-1] Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) (owner: 10Wfan) [01:59:03] (03CR) 10Ejegg: [C: 04-1] "This all looks good, except one little bit of test code we should delete before merging." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) (owner: 10Wfan) [02:03:58] (03PS6) 10Wfan: Implement Adyen Cancel Auto Rescue Api to smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) [02:04:23] (03CR) 10Wfan: Implement Adyen Cancel Auto Rescue Api to smashpig (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) (owner: 10Wfan) [02:45:51] (03PS2) 10Wfan: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) [03:02:53] (03PS7) 10Ejegg: Implement Adyen Cancel Auto Rescue Api to smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) (owner: 10Wfan) [03:03:28] (03CR) 10Ejegg: [C: 03+2] "Thanks, looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) (owner: 10Wfan) [03:04:00] (03Merged) 10jenkins-bot: Implement Adyen Cancel Auto Rescue Api to smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/982155 (https://phabricator.wikimedia.org/T351338) (owner: 10Wfan) [03:06:29] (03CR) 10Ejegg: "Looks pretty good! I'd just prefer to make a couple of those return types nullable (i.e. ?string ) since they can sometimes be unset (i.e." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) (owner: 10Wfan) [03:38:56] (03CR) 10Ejegg: "This seems to have a lot of changes unrelated to what's mentioned in the commit message. It would be ideal to have one little patch for up" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) (owner: 10Wfan) [03:44:04] (03CR) 10Ejegg: "This looks pretty good! I'll try to smoke test tomorrow." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [03:47:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10Ejegg) I'm wondering if we also need to add a check in this function (or before calling this function): {https://phabricator.wikimedia.org/diffusion/... [03:58:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10Ejegg) Going a bit further down the rabbit hole, it looks like that reactivateIfInactive function isn't actually working as advertised. It's clearing... [04:18:07] (03PS1) 10Ejegg: Specify default payment method in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/987880 [04:33:10] (03PS1) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [04:48:40] (03CR) 10CI reject: [V: 04-1] Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [05:08:47] (03PS5) 10Wfan: Save retry.rescueReference from payments result [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) [05:09:15] (03CR) 10CI reject: [V: 04-1] Save retry.rescueReference from payments result [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) (owner: 10Wfan) [05:11:18] (03PS6) 10Wfan: Save retry.rescueReference from payments result [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) [05:19:36] (03PS1) 10Wfan: for importSubscriptionCancel, updating the cancel api3 to use API4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987884 [05:33:54] (03PS1) 10Wfan: replace the deprecated function wmf_civicrm_get_recur_record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987886 [05:36:54] (03PS3) 10Wfan: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) [06:00:44] (03PS3) 10Wfan: Use civi webhook to trigger adyen auto rescue cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984868 (https://phabricator.wikimedia.org/T351338) [07:40:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10RKumar_WMF) @Damilare - After reading all notes here I am a little unsure if you still want us to reach out to dLocal for "@EMartin It would be good... [08:50:28] (03CR) 10Thiemo Kreuz (WMDE): tests: Declare class property in CampaignTest (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [13:01:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10Damilare) Hi @RKumar_WMF, yes that would still be good to check up on. [14:56:59] (03PS7) 10Ejegg: Save retry.rescueReference from payments result [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) (owner: 10Wfan) [14:57:06] (03CR) 10Ejegg: [C: 03+2] Save retry.rescueReference from payments result [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) (owner: 10Wfan) [14:57:37] (03Merged) 10jenkins-bot: Save retry.rescueReference from payments result [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983936 (https://phabricator.wikimedia.org/T353293) (owner: 10Wfan) [15:01:20] (03CR) 10Jgleeson: [C: 03+1] "Thanks for the updates. This looks good to me! I'll hold off on the +2 just for now as I can see Damilare also had a question." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) (owner: 10Wfan) [15:30:35] (03CR) 10Jgleeson: [C: 03+1] "Thanks for this. The code looks good. I've left two small update requests inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962589 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [15:49:01] (03CR) 10Umherirrender: tests: Declare class property in CampaignTest (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [15:58:04] (03PS3) 10Jgleeson: Reset the IP Velocity filter state for subsequent attempts. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962589 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [15:58:10] (03PS5) 10Jgleeson: Modify IP Velocity filter to increase count after first run. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962592 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [15:58:48] rebasing over latest ^ [16:45:04] (03PS7) 10Wfan: Do not check submetod metadata for gpay applepay venmo paypal amazon [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) [16:46:33] (03CR) 10Wfan: Do not check submetod metadata for gpay applepay venmo paypal amazon (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981431 (https://phabricator.wikimedia.org/T353032) (owner: 10Wfan) [17:10:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: wmf_eoy_receipt send error: email is not attached (anymore?) to a valid contact - https://phabricator.wikimedia.org/T354347 (10greg) p:05Triage→03High High just because we're in the middle of the send, thanks for the investigation @AnnWF ! [17:10:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Paypal Recurring next_sched_contribution_date in the past - https://phabricator.wikimedia.org/T354327 (10greg) p:05Triage→03Medium [17:11:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Add param id check for customField getFieldOptions - https://phabricator.wikimedia.org/T353924 (10greg) p:05Triage→03Medium [17:13:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10greg) p:05Triage→03High [18:29:44] (03CR) 10Ejegg: [C: 04-1] for importSubscriptionCancel, updating the cancel api3 to use API4 (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987884 (owner: 10Wfan) [18:51:33] (03PS4) 10Damilare Adedoyin: Reset the IP Velocity filter state for subsequent attempts. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962589 (https://phabricator.wikimedia.org/T323544) [19:12:54] (03CR) 10Ejegg: "just a comment on the comment. Thanks for slimming this patch down!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) (owner: 10Wfan) [19:29:11] (03CR) 10Damilare Adedoyin: "Thanks for the review jgleeson, I've made the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962589 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [19:37:15] thanks damilare [19:38:41] and thanks for reminding me about that trip. I just logged in to check the booking on the Cyprus trip and the flight has changed along with the prepaid seats we ordered for the kids!! [19:38:59] airline fun [19:39:32] currently on hold :) [19:41:38] (03CR) 10Jgleeson: [C: 03+2] "LGTM. Thanks for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962589 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [19:57:14] (03PS6) 10Jgleeson: Modify IP Velocity filter to increase count after first run. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962592 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [19:58:13] damilare: I'm close to finishing review on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/962592/6 but just a heads up that I couldn't rebase https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/962594/1 over the preceding two patches due to merge conflicts [19:59:52] ahh np [20:00:06] I'm wrapping up now so I'll check back in on monday [20:00:10] have a good weekend fr-tech! [20:00:22] sure same here [20:00:25] o/ [20:24:15] (03Merged) 10jenkins-bot: Reset the IP Velocity filter state for subsequent attempts. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962589 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:29:30] (03PS1) 10Thiemo Kreuz (WMDE): Remove misleading "protected" visibility of private code [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988078 [20:30:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] tests: Declare class property in CampaignTest (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [20:38:06] (03CR) 10CI reject: [V: 04-1] Remove misleading "protected" visibility of private code [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988078 (owner: 10Thiemo Kreuz (WMDE)) [20:54:03] (03PS4) 10Wfan: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) [20:57:28] (03CR) 10CI reject: [V: 04-1] tests: Declare class property in CampaignTest [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [21:13:17] (03Abandoned) 10Wfan: Add param check before get options from cache [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/985071 (https://phabricator.wikimedia.org/T353924) (owner: 10Wfan) [21:22:26] (03PS2) 10Wfan: Update cancelRecurContribution to unset next_sched_contribution_date and failure_retry_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987884 [22:11:10] 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10MDemosWMF) [22:13:02] 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10MDemosWMF) Here is the import summary screen as well: https://civicrm.wikimedia.org/civicrm/import/contact/summary?user_job_id=1027&reset=1 [22:44:46] 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10MDemosWMF) Another blank table when trying to view the error results: https://civicrm.wikimedia.org/civicrm/search#/display/Import_1032/Import_1032?_status=ERROR It seems to only happen when there ar... [22:49:49] 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10MDemosWMF) I just checked again and the error from import 1027 is now showing! But the others from import 1032 is not. Is it a timing issue? [23:28:35] 10Fundraising-Backlog: eoy failed due to syntax error - https://phabricator.wikimedia.org/T354462 (10AnnWF) [23:31:51] 10Fundraising-Backlog: eoy email queue failed due to syntax error - https://phabricator.wikimedia.org/T354462 (10AnnWF)