[07:40:51] (03PS2) 10Thiemo Kreuz (WMDE): tests: Declare class property in CampaignTest [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [07:43:40] (03CR) 10CI reject: [V: 04-1] tests: Declare class property in CampaignTest [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [08:13:25] (03PS1) 10Thiemo Kreuz (WMDE): Update deprecated mw.util.debounce parameter order [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988355 [08:16:05] (03CR) 10CI reject: [V: 04-1] Update deprecated mw.util.debounce parameter order [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988355 (owner: 10Thiemo Kreuz (WMDE)) [12:05:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10krobinson) @Damilare - are we good to go ahead and re-cancel this recurring donation now? Also, is there any way to check other UPI recurring cance... [14:48:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10Damilare) Hi @krobinson, we are still reviewing the patch. We'd inform you when it is deployed for the cancellations. Here's a list of similar donor... [15:13:16] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for this." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/987880 (owner: 10Ejegg) [15:14:16] (03Merged) 10jenkins-bot: Specify default payment method in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/987880 (owner: 10Ejegg) [15:15:48] thanks damilare! [15:16:05] I'll start smoke testing that dlocal cancel patch now [15:16:41] thanks [15:18:08] (03CR) 10Damilare Adedoyin: "Thanks for putting this patch up ejegg, looks like the existing tests are failing because of a missing use statement from the smashpig pat" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [15:34:34] (03CR) 10Ejegg: "Works pretty well! I just think we need to handle when a token is used for an old + a new recurring." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [15:50:00] ejegg: I thought every recurring should have a unique token unless the donor specifies a reactivation of a cancelled recurring row. [15:51:35] The reason for the multiple token rows was partly due to the recurring.inc file being unable to return an id on multiple token rows. [15:53:40] the first multiple is caused when the UPI paid IPN is received after DR cancels the payment and the consumer creates a new active recurring because of the cancelled state of the original row. [16:01:39] damilare: sometimes if someone starts a new recurring with the same card, we get an identical token back from the processor [16:02:05] which I guess makes sense, because it's the same card and the same merchant [16:02:58] i think this is the opposite problem - not multiple payment_token rows with the same token but rather multiple contribution_recur rows with the same payment_token_id [16:03:06] select id, payment_token_id, count(*) from civicrm_contribution_recur group by payment_token_id having count(*) > 1; [16:05:40] for example token with ID 518702 is connected to two recurrings, one cancelled and one in progress [16:05:49] one for 10.40 and one for 13.52 [16:06:23] yea I saw some of thos as well, so the different amount tells us its most likely deliberate [16:07:05] so if we get a payment in for that token, let's try to make sure it gets associated with the current recurring [16:07:28] though I guess we should match by amount too if those can differ, or even cycle day [16:07:56] what if there's no current active recurring? [16:09:33] on the ticket it stays associated even if cancelled? [16:12:25] sorry typo.. on the patch it stays associated even when cancelled. [16:12:33] yep, I guess associate with the most recent cancelled one if no active? [16:14:25] yep, ok thanks. [16:42:40] (03CR) 10Jgleeson: [C: 04-1] "Thanks for all the work on this Dami. The code reads really good! I've left two comments about breaking a couple of setter/indicator metho" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962592 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [16:45:42] (03CR) 10Ejegg: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988355 (owner: 10Thiemo Kreuz (WMDE)) [16:47:31] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Mobile: Mobile version of Special:CentralNotice shouldn't load complete list by default - https://phabricator.wikimedia.org/T323864 (10Ejegg) @Pcoombe now that your fix to move the archived campaigns to a separate page is live, can we close this... [16:53:15] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Mobile: Mobile version of Special:CentralNotice shouldn't load complete list by default - https://phabricator.wikimedia.org/T323864 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Oh yes, I forgot about this one! [16:53:37] (03CR) 10Jgleeson: [C: 04-1] Modify IP Velocity filter to increase count after first run. (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962592 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [18:26:50] (03PS2) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [18:36:12] (03CR) 10Ejegg: "Just a couple of questions about things we might not need" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/984273 (https://phabricator.wikimedia.org/T353293) (owner: 10Wfan) [18:43:15] (03CR) 10CI reject: [V: 04-1] Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [19:04:35] (03PS3) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [19:20:50] (03CR) 10CI reject: [V: 04-1] Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [19:23:10] (03PS1) 10Ejegg: Allow index and follow on Special:FundraiserRedirector [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/988708 (https://phabricator.wikimedia.org/T254808) [19:28:49] (03PS4) 10Damilare Adedoyin: Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) [19:32:00] wait, that index and follow patch is useless [19:34:35] (03CR) 10Jgleeson: [C: 04-1] "I've looked into the questions I had regarding how we're scoring things on prod, and I'm happy this patch doesn't break or change anything" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962592 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [19:35:00] (03Abandoned) 10Ejegg: Allow index and follow on Special:FundraiserRedirector [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/988708 (https://phabricator.wikimedia.org/T254808) (owner: 10Ejegg) [19:35:36] awesome! [19:36:24] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, and 5 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Ejegg) @Pcoombe I notice... [19:45:02] (03CR) 10CI reject: [V: 04-1] Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [19:57:17] (03CR) 10Damilare Adedoyin: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [20:09:16] (03PS2) 10Jgleeson: Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:11:16] (03CR) 10CI reject: [V: 04-1] Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:16:28] (03PS3) 10Jgleeson: Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:17:03] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, and 5 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10hashar) >>! In T254808#9... [20:18:31] (03CR) 10CI reject: [V: 04-1] Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:18:35] (03PS4) 10Jgleeson: Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:20:24] (03CR) 10CI reject: [V: 04-1] Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:20:29] (03PS5) 10Jgleeson: Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:22:13] (03CR) 10CI reject: [V: 04-1] Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:24:53] (03PS6) 10Jgleeson: Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:26:41] (03CR) 10CI reject: [V: 04-1] Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [20:28:40] damilare: I just took a pop at rebasing that last patch with conflicts over the latest chain. It was mostly test updates since your original patch accounting for the new extended return URL and a different payment description. I'm just fighting with the coding styles now [20:31:29] wow looks like a lot [20:31:51] (03PS4) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [20:31:57] I can finish the rebase so you can focus on the review. [20:32:28] and rest of the code style fixes [20:32:53] (03PS5) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [20:33:40] damilare: I think it's pretty much there. I'll see what else I missed [20:39:17] the review is pretty much there, that is [20:55:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Unplanned-Sprint-Work: Error upon event import (Stripe) - https://phabricator.wikimedia.org/T336895 (10Eileenmcnaughton) [20:55:36] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fix import date handling to deal with truncated time - https://phabricator.wikimedia.org/T342716 (10Eileenmcnaughton) 05Open→03Resolved I'm going to close this as resolved because it is merged upstream - altho... [20:57:16] 10Fundraising-Backlog: Sprint X: Priorities - WIP - https://phabricator.wikimedia.org/T352901 (10XenoRyet) [20:58:15] 10Fundraising-Backlog: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168 (10XenoRyet) [21:10:58] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: One click unsubscribe - by Feb! - https://phabricator.wikimedia.org/T354231 (10XenoRyet) [21:16:26] 10Fundraising-Backlog: Measure donation processing rate (once we decide what that is) - https://phabricator.wikimedia.org/T342013 (10Dwisehaupt) Pushing out to sprint +2 but need to review if/how we want to proceed on this. [21:22:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Keep pending message when validation action is set to "Leave in console" - https://phabricator.wikimedia.org/T353292 (10greg) p:05Triage→03Low [21:22:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Add param id check for customField getFieldOptions - https://phabricator.wikimedia.org/T353924 (10Eileenmcnaughton) 05Open→03Resolved [21:26:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: fail to import recurring donation to civi due to missing recurring token which exist - https://phabricator.wikimedia.org/T353930 (10greg) p:05Triage→03Medium [21:29:16] 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10Eileenmcnaughton) @MDemosWMF - just there is caching involved - although I thought I fixed the issue resulting in the caching not reloading [21:36:00] 10Fundraising-Backlog: Change URL in WMF Recurring Failure template - https://phabricator.wikimedia.org/T354185 (10Eileenmcnaughton) This is the message template https://civicrm.wikimedia.org/civicrm/admin/messageTemplates?reset=1#/edit?id=304&lang=en_US [21:37:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: fail to import recurring donation to civi due to missing recurring token which exist - https://phabricator.wikimedia.org/T353930 (10jgleeson) Here's a list of unique log hits for this scenario from Dec 21st to dig into: ` Dec 21 00:06:04 payments1006 ad... [21:37:24] 10Fundraising-Backlog: Change URL in WMF Recurring Failure template - https://phabricator.wikimedia.org/T354185 (10Eileenmcnaughton) Here is the list of them in various languages https://civicrm.wikimedia.org/civicrm/admin/messageTemplates?reset=1#/workflow?f=%7B%22text%22:%22fail%22%7D [21:44:03] 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10MDemosWMF) @Eileenmcnaughton Ah ok, yes seems like there is just an issue with lag. [21:45:48] (03PS7) 10Jgleeson: Add integration tests to cover the new IP Velocity behavior [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [21:47:29] (03CR) 10Jgleeson: [C: 03+1] "Changing to +1 as -1 is far too dramatic" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962592 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [21:49:33] that final patch is passing now damilare [21:49:58] so I think I can +2 that one or do you want me to wait until you can respond to the one before it tomorrow? [21:51:09] yeah I think it'd be better to wait till tomorrow [21:51:56] awesome, thank you for wrangling with the rebase and ci [21:53:00] np. thank you for all the work on that part of the code! [21:53:29] (03CR) 10Damilare Adedoyin: "thanks ejegg for the review, added some logic to be specific on the recur row." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [22:11:50] (03CR) 10Jgleeson: [C: 03+1] "I really like these tests! I left a few small asks just to sharpen things up and some food for thought around loops in unit tests." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/962594 (https://phabricator.wikimedia.org/T323544) (owner: 10Damilare Adedoyin) [22:32:45] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog: Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575 (10Jgreen) [22:45:02] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: One click unsubscribe - by Feb! - https://phabricator.wikimedia.org/T354231 (10Eileenmcnaughton) [22:52:59] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: One click unsubscribe - by Feb! - https://phabricator.wikimedia.org/T354231 (10Eileenmcnaughton) [22:54:01] ejegg: I updated the phab - https://phabricator.wikimedia.org/T354231 - could we just make https://payments.wikimedia.org/index.php/Special:FundraiserUnsubscribe work off one-click (get or post) - possibly with an extra param in the url? [22:55:56] (03PS1) 10Eileen: DO-not-merge - test finder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988738 [23:07:19] eileen: we could... that's the one in an old deprecated extension though [23:08:14] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/988740 [23:08:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: fail to import recurring donation to civi due to missing recurring token which exist - https://phabricator.wikimedia.org/T353930 (10Ejegg) Ah, a lot of those are failed auths. I will narrow the scope of that log line to only log on successful auths. [23:09:23] ejegg: ah OK - so that is what we send them to now - but ideally it would be updated - I feel like a good fix would still be the move to preference centre & a quick fix might be update in place? [23:09:28] ejegg: [23:10:05] can you check the merge to deploy - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/988740/ - it's got a lot in it [23:10:59] I think there is nothing alarming but maybe a few things we thought were already deployed.... [23:11:36] (03PS1) 10Ejegg: Don't log missing token on failed auth [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/988741 (https://phabricator.wikimedia.org/T353930) [23:11:47] looking [23:12:11] (03CR) 10CI reject: [V: 04-1] DO-not-merge - test finder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988738 (owner: 10Eileen) [23:14:17] that seems fine eileen , i will want to test a few recurrings one by one after it goes out [23:14:35] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/988740 (owner: 10Eileen) [23:15:29] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/988740 (owner: 10Eileen) [23:16:46] !log civicrm upgraded from 16b5417b to c7304245 [23:16:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:16:50] ejegg: ^^ [23:17:14] I'm just gonna shoot out for lunch [23:26:51] cool cool, testing [23:29:31] looking good