[05:30:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10RKumar_WMF) Response from dLocal: "After review and discussion with Seba and the team, unfortunately, we are unable to make changes or cancel the pa... [08:53:04] 10Fundraising Sprint Byzantine Empire Strikes Back, 10Fundraising Sprint CAPS LOCK CULTS, 10Fundraising Sprint Dampness, 10Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (10Francesca_Lissoni_WMIT) >>! In T243098#9425440, @Eileenmcnaughton wrote: > Sure - a... [09:23:42] (03CR) 10Damilare Adedoyin: [C: 03+2] Don't log missing token on failed auth [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/988741 (https://phabricator.wikimedia.org/T353930) (owner: 10Ejegg) [09:34:34] (03Merged) 10jenkins-bot: Don't log missing token on failed auth [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/988741 (https://phabricator.wikimedia.org/T353930) (owner: 10Ejegg) [11:55:53] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587 (10jgleeson) @Eileenmcnaughton, the API action that eventually processes the data sent as part of an e... [12:00:42] fr-tech today's music recommendation is a nice blend of GTA-style radio playing Synthwave with some retro radio ads thrown in. https://www.youtube.com/watch?v=4jXVd7nLlXY [13:32:10] (03PS2) 10Jgleeson: Add support for POSTabe one-click-unsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/989243 (https://phabricator.wikimedia.org/T354587) [13:35:12] (03PS3) 10Jgleeson: WIP: Add support for POSTabe one-click-unsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/989243 (https://phabricator.wikimedia.org/T354587) [14:04:36] (03CR) 10Jgleeson: [C: 04-1] "drive-by review" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [14:08:43] (03CR) 10Jgleeson: [C: 03+2] "Looks good to me! thanks for the clean up." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987886 (owner: 10Wfan) [14:12:41] (03CR) 10Jgleeson: [C: 03+2] "Tested locally and fixes the issue. Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989254 (owner: 10Eileen) [14:21:13] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, and 4 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Pcoombe) 05Open→03Res... [14:22:43] (03CR) 10Jgleeson: [C: 04-1] "This looks good. I'm wondering if we should try and marry up the param names between this and our one-click-unsubscribe POSTable endpoint," [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988749 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:26:13] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988750 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:27:45] (03CR) 10Jgleeson: [C: 03+2] "Makes sense! nice." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988751 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:29:38] (03CR) 10Jgleeson: [C: 03+2] "This looks good enough for now I'd say! Thanks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988752 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:29:40] (03Merged) 10jenkins-bot: replace the deprecated function wmf_civicrm_get_recur_record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987886 (owner: 10Wfan) [14:31:35] (03Merged) 10jenkins-bot: Fix broken preview on recurring failed message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989254 (owner: 10Eileen) [14:37:01] (03CR) 10Jgleeson: [C: 03+2] "So this has got me thinking about that recurring refactor chain and how nice it might be to start moving it instead of fighting with all t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988753 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:40:30] (03CR) 10Jgleeson: "This looks fine but I'm unsure why you didn't use the new trait after adding in the required params & setters." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988756 (owner: 10Eileen) [14:40:52] (03CR) 10Jgleeson: [C: 04-1] Calculate unsubscribe in Send class, in just the one place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988756 (owner: 10Eileen) [14:44:12] (03CR) 10Jgleeson: [C: 03+2] "Makes sense" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988757 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:44:44] (03CR) 10Jgleeson: [C: 03+2] Stop passing unsubscribe_link through from test form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988758 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [14:48:20] (03CR) 10Jgleeson: [C: 03+2] Remove last remnants of the old unsubscribe_link code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988759 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [15:01:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Disable/delete old contribution_tracking module - https://phabricator.wikimedia.org/T354708 (10JMando) Hey there. I still have one data cube that is referencing drupal.contribution_tracking. I will switch it to the new one this month and comment here when... [15:55:58] (03PS6) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [15:56:20] (03CR) 10Ejegg: Fix recurring record reactivation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [16:12:01] (03CR) 10CI reject: [V: 04-1] Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [17:02:00] (03PS6) 10Ejegg: Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [17:02:06] (03CR) 10Ejegg: [C: 03+2] Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [17:19:17] (03Merged) 10jenkins-bot: Ensure no new rows are created for UPI transaction when a payment message is received after DR had cancelled the recurring. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987846 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [17:20:02] (03CR) 10Ejegg: "jgleeson I would argue for leaving this legacy link unchanged during the refactor. We're hoping to get rid of the old FundraiserEmailUnsu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988749 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [17:24:37] (03PS7) 10Ejegg: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) [18:16:14] (03PS5) 10Wfan: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) [18:17:09] (03Abandoned) 10Wfan: Update cancelRecurContribution to unset next_sched_contribution_date and failure_retry_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987884 (owner: 10Wfan) [18:17:29] (03PS6) 10Wfan: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) [18:23:25] (03CR) 10Damilare Adedoyin: [C: 03+2] Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [18:38:51] (03CR) 10Ejegg: [C: 03+2] Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) (owner: 10Wfan) [18:39:33] (03Merged) 10jenkins-bot: Fix recurring record reactivation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987881 (https://phabricator.wikimedia.org/T354357) (owner: 10Ejegg) [18:44:22] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Add Monthly Convert to Dlocal forms - https://phabricator.wikimedia.org/T303778 (10Ejegg) a:03Ejegg [18:55:01] (03Merged) 10jenkins-bot: Update next_sched_contribution_date and cycle_day everytime when recurring_payment_profile_created [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/987875 (https://phabricator.wikimedia.org/T354327) (owner: 10Wfan) [19:15:17] (03PS1) 10Damilare Adedoyin: Update SmashPig to v0.8.9.10 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/989575 [19:17:39] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/989576 [19:19:40] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog: Adding and storing rml_source data for RML donations reporting - https://phabricator.wikimedia.org/T321163 (10KHaggard) Hi @AKanji-WMF - Circling back over to this. I had a conversation wit... [19:31:45] (03CR) 10Damilare Adedoyin: [C: 03+2] Update SmashPig to v0.8.9.10 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/989575 (owner: 10Damilare Adedoyin) [19:47:36] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.9.10 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/989575 (owner: 10Damilare Adedoyin) [19:49:00] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/989576 (owner: 10Damilare Adedoyin) [19:49:45] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/989576 (owner: 10Damilare Adedoyin) [19:56:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10Damilare) Thanks @RKumar_WMF, the changes have been deployed. This means if the donor requests to cancel the recurring and approves the prenotification, the recurring woul... [20:04:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Disable/delete old contribution_tracking module - https://phabricator.wikimedia.org/T354708 (10Eileenmcnaughton) Thanks @JMando There is no plan to change drupal.exchange_rates ... yet - although we do need to make one - good to know you use that table [20:08:02] (03CR) 10Eileen: "Just chatting with ejegg & those feature changes should be looked at - lets try them on the refactored code" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988749 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen) [20:27:50] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Determine if we need to have 1-click unsubscribes on our thank you etc emails - https://phabricator.wikimedia.org/T354586 (10Ejegg) Reviewing my own inbox, I see plenty of transactional emails from big senders tha... [20:44:21] 10Fundraising-Backlog, 10FR-Email, 10FR-email-preference-center, 10MediaWiki-extensions-DonationInterface: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10Ejegg) @AKanji-WMF @XenoRyet Since we're doing work on the unsubscribe code to handle o... [20:56:09] 10Fundraising-Backlog: email syntax error due to if - https://phabricator.wikimedia.org/T354801 (10AnnWF) [20:58:43] 10Fundraising-Backlog: email syntax error due to if condition for param directly - https://phabricator.wikimedia.org/T354801 (10AnnWF) [21:03:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DLocal recurring cancel not sticking - https://phabricator.wikimedia.org/T354357 (10MBeat33) Thanks, @Damilare for the news [21:14:51] (03PS1) 10Ejegg: Remove placeholder amounts for DLocal MC [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/989609 [21:15:14] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Remove placeholder amounts for DLocal MC [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/989609 (owner: 10Ejegg) [21:52:41] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Add Monthly Convert to Dlocal forms - https://phabricator.wikimedia.org/T303778 (10Ejegg) In local testing this seems to work for credit cards [21:53:21] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10FR-donorservices: Civi: Endowment ty email - include CNTCT - https://phabricator.wikimedia.org/T353842 (10Ejegg) a:03Ejegg [23:26:21] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587 (10Eileenmcnaughton) @jgleeson the api action you are pointing to doesn't process the data sent - it j... [23:35:57] ejegg: I'm just processing some comments from Tim over on chat.civicrm.org & thinking 'is the requirement that the 'get' url can also be POSTed to & if being posted to we provide the post params - ie for our existing url if we add post-params like "List-Unsubscribe-Post: email=elliott@example.org" - then csrf aside that would work? [23:36:18] https://chat.civicrm.org/civicrm/pl/dnetk8opjbgzbp384f8mj9r4uw