[08:07:37] 10Fundraising Sprint Byzantine Empire Strikes Back, 10Fundraising Sprint CAPS LOCK CULTS, 10Fundraising Sprint Dampness, 10Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (10Eileenmcnaughton) Looks like that is 9pm Sunday for me - I should be able to do that [08:40:00] 10Fundraising Sprint Byzantine Empire Strikes Back, 10Fundraising Sprint CAPS LOCK CULTS, 10Fundraising Sprint Dampness, 10Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (10Francesca_Lissoni_WMIT) >>! In T243098#9455382, @Eileenmcnaughton wrote: > Looks li... [11:09:19] /nick jgleeson|read [12:39:59] (03Abandoned) 10Jgleeson: WIP: start iOS App API endpoint work [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/951586 (https://phabricator.wikimedia.org/T344774) (owner: 10Jgleeson) [12:40:31] (03Abandoned) 10Jgleeson: WIP: Test for new method to resolve the rare order_id / ct_id mismatches [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919395 (https://phabricator.wikimedia.org/T334905) (owner: 10Jgleeson) [12:49:08] (03CR) 10Jgleeson: "This looks good. However, I'm curious what would happen if the refund message is processed before the donation message, as that could tech" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [13:05:55] (03CR) 10Jgleeson: [C: 03+1] "This looks good. I was thinking of a way we could confirm this behaviour with a unit test and I came up an idea inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) (owner: 10Damilare Adedoyin) [13:07:37] yh, I was thinking that too jgleeson, I was hoping it would be sequential. What do you suggest? [13:14:59] hmm that's actually a good idea re: injecting the method. [13:15:46] yeah it would be nice to confirm that new handling without having to try and melt out local machines inducing a db lock scenario lol [13:16:34] regarding the refund one: I guess my first check would be to see what happens if we try to process a refund for a donation that doesn't yet exist [13:17:17] it might work although it probably shouldn't [13:17:25] yea it throws that missing predecessor error [13:17:27] negative balance maybe [13:17:30] ah [13:42:19] (03PS1) 10Jforrester: extension.json: Drop RL targets definitions, no longer honoured [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) [13:45:24] (03CR) 10CI reject: [V: 04-1] extension.json: Drop RL targets definitions, no longer honoured [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) (owner: 10Jforrester) [14:27:01] (03CR) 10Jforrester: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) (owner: 10Jforrester) [14:48:59] (03CR) 10Jgleeson: "Thanks for the review ejegg! comments inline" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/989243 (https://phabricator.wikimedia.org/T354587) (owner: 10Jgleeson) [15:31:37] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [16:29:45] (03PS3) 10Thiemo Kreuz (WMDE): Remove misleading "protected" visibility of private code [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988078 [16:34:09] (03CR) 10CI reject: [V: 04-1] Remove misleading "protected" visibility of private code [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/988078 (owner: 10Thiemo Kreuz (WMDE)) [16:59:25] 10Fundraising-Backlog: Correcting Gift Source Coding on Benevity import - https://phabricator.wikimedia.org/T354911 (10NNichols) Adding a note about the timeline: - We are hoping this could be corrected by the end of January. I want to use it to reimport all of benevity for this fiscal year so we have a better... [17:16:10] (03PS1) 10Pcoombe: Update monthly convert amounts [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990151 (https://phabricator.wikimedia.org/T303778) [17:23:49] 10Fundraising Sprint - Yesterday (UTC), 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), 10Patch-For-Review: Add Monthly Convert to Dlocal forms - https://phabricator.wikimedia.org/T303778 (10Pcoombe) Some slight adjustments to BRL and MXN monthly convert amounts (along with some others)... [19:09:48] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990196 [19:10:36] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990208 [19:10:55] (03Abandoned) 10Jforrester: build: Update MediaWiki requirement to 1.41 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/950514 (owner: 10Jforrester) [19:11:09] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/990216 [19:11:12] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/990217 [19:12:00] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/990227 [19:14:14] (03CR) 10CI reject: [V: 04-1] build: Update MediaWiki requirement to 1.42 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990196 (owner: 10Jforrester) [19:14:33] (03CR) 10CI reject: [V: 04-1] build: Update MediaWiki requirement to 1.42 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990208 (owner: 10Jforrester) [19:20:57] (03CR) 10DannyS712: [C: 03+2] build: Update MediaWiki requirement to 1.42 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/990227 (owner: 10Jforrester) [19:23:19] (03CR) 10DannyS712: [C: 04-1] "doesn't fundraising run on a different setup? Per Iedbcf2a586e691898d8b067eff51c43281a4064b" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/990216 (owner: 10Jforrester) [19:24:30] (03CR) 10Jforrester: build: Update MediaWiki requirement to 1.42 (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/990216 (owner: 10Jforrester) [19:24:34] (03Abandoned) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/990216 (owner: 10Jforrester) [19:24:52] (03Abandoned) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990208 (owner: 10Jforrester) [19:29:19] (03CR) 10CI reject: [V: 04-1] build: Update MediaWiki requirement to 1.42 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/990217 (owner: 10Jforrester) [20:58:34] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.42 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/990227 (owner: 10Jforrester) [22:41:09] (03PS2) 10Umherirrender: extension.json: Drop RL targets definitions, no longer honoured [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) (owner: 10Jforrester) [22:43:53] (03CR) 10CI reject: [V: 04-1] extension.json: Drop RL targets definitions, no longer honoured [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) (owner: 10Jforrester) [22:46:47] (03CR) 10Jforrester: "Failure filed as T354977." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990196 (owner: 10Jforrester) [22:49:07] (03CR) 10Umherirrender: tests: Declare class property in CampaignTest (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983502 (owner: 10Umherirrender) [22:53:30] (03CR) 10Umherirrender: [C: 03+2] build: Update MediaWiki requirement to 1.42 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990196 (owner: 10Jforrester) [22:57:01] (03CR) 10Umherirrender: [C: 03+2] "Failure tracked under T354977" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) (owner: 10Jforrester) [22:57:25] (03CR) 10Umherirrender: "Failure tracked under T354977" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 (owner: 10Umherirrender) [23:12:10] (03CR) 10CI reject: [V: 04-1] build: Update MediaWiki requirement to 1.42 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990196 (owner: 10Jforrester) [23:12:12] (03CR) 10CI reject: [V: 04-1] extension.json: Drop RL targets definitions, no longer honoured [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990064 (https://phabricator.wikimedia.org/T328497) (owner: 10Jforrester) [23:18:19] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39 [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/990269 [23:19:10] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/990271 [23:23:02] (03CR) 10CI reject: [V: 04-1] build: Update MediaWiki requirement to 1.39 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/990271 (owner: 10Jforrester) [23:27:58] (03Abandoned) 10Jforrester: build: Update MediaWiki requirement to 1.42 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/990217 (owner: 10Jforrester)