[03:51:25] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Correcting Gift Source Coding on Benevity import - https://phabricator.wikimedia.org/T354911 (10AKanji-WMF) [03:51:27] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10fundraising-tech-ops: Create ipset for mws.amazonservices.com - https://phabricator.wikimedia.org/T354816 (10AKanji-WMF) [03:51:29] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Docker: Docker updates - wishlist - https://phabricator.wikimedia.org/T354705 (10AKanji-WMF) [03:51:32] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Determine if we need to have 1-click unsubscribes on our thank you etc emails - https://phabricator.wikimedia.org/T354586 (10AKanji-WMF) [03:51:35] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587 (10AKanji-WMF) [03:51:37] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: FR-ops - review google update - https://phabricator.wikimedia.org/T354584 (10AKanji-WMF) [03:51:39] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: EFT Matching Organization Import - Duplicate error override not working - https://phabricator.wikimedia.org/T353907 (10AKanji-WMF) [03:51:41] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Tidy up our subscribe-links code on the civi side to make change easy - https://phabricator.wikimedia.org/T354585 (10AKanji-WMF) [03:51:43] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457 (10AKanji-WMF) [03:51:45] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Auto-Rescue - set next_sched_contribution_date when it goes into the auto rescue flow - https://phabricator.wikimedia.org/T353294 (10AKanji-WMF) [03:51:47] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Civi: cancel recurrings for chargebacks - https://phabricator.wikimedia.org/T353549 (10AKanji-WMF) [03:51:49] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Test sending from staging with CiviMail & then on live using fr-tech as recipients - https://phabricator.wikimedia.org/T352138 (10AKanji-WMF) [03:51:51] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Have the iOS submitPayment endpoint save app version like the form front end does - https://phabricator.wikimedia.org/T351689 (10AKanji-WMF) [03:51:53] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168 (10AKanji-WMF) [03:51:55] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10AKanji-WMF) [03:51:57] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get CiviProxy API4 patch merged upstream - https://phabricator.wikimedia.org/T349762 (10AKanji-WMF) [03:51:59] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig, and 2 others: save retry.rescueReference for future cancel action - https://phabricator.wikimedia.org/T353293 (10AKanji-WMF) [03:52:01] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Confirm all Ingenico Tokens made it across to Adyen - https://phabricator.wikimedia.org/T348770 (10AKanji-WMF) [03:52:03] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Data Axle Project - Re-import to Civi - https://phabricator.wikimedia.org/T341902 (10AKanji-WMF) [03:52:05] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on demand - https://phabricator.wikimedia.org/T341299 (10AKanji-WMF) [03:52:07] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181 (10AKanji-WMF) [03:52:09] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10FR-Japan, 10MW-1.42-notes (1.42.0-wmf.12; 2024-01-02): Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10AKanji-WMF) [03:52:12] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10FR-Email, 10FR-email-preference-center, 10MediaWiki-extensions-DonationInterface: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10AKanji-WMF) [03:52:13] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: One click unsubscribe - by Feb! - https://phabricator.wikimedia.org/T354231 (10AKanji-WMF) [03:52:15] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Suppress failmail on contribution tracking constraint violations - https://phabricator.wikimedia.org/T352321 (10AKanji-WMF) [03:52:18] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), and 2 others: Standardize utm_source from app donations without a banner and clean up old data - https://phabricator.wikimedia.org/T350919 (10AKanji-WMF) [03:52:21] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig, and 2 others: Cancel auto-rescue at Adyen when donor cancels recurring donation in Civi - https://phabricator.wikimedia.org/T351338 (10AKanji-WMF) [03:58:25] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Sprint A Priorities - https://phabricator.wikimedia.org/T355197 (10AKanji-WMF) [10:22:47] Am I the only one who noticed Fundraising Sprin(g) instead of Fundraising Sprint? I feel like that might be a typo [11:45:53] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Docker: Docker updates - wishlist - https://phabricator.wikimedia.org/T354705 (10jgleeson) a:03jgleeson [11:46:10] (03CR) 10VolkerE: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/991018 (https://phabricator.wikimedia.org/T354875) (owner: 10VolkerE) [12:40:12] (03PS5) 10Damilare Adedoyin: Catch Database lock in recurring queue consume process in order to requeue message. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) [12:40:59] (03PS6) 10Damilare Adedoyin: Catch Database lock in recurring queue consume process in order to requeue message. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) [13:08:05] (03CR) 10Damilare Adedoyin: "Thanks for the suggestions jgleeson, I've made the recommended changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) (owner: 10Damilare Adedoyin) [13:09:27] looking damilare [13:12:58] thanks [13:13:40] (03PS7) 10Jgleeson: WIP: Add support for POSTabe one-click-unsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/989243 (https://phabricator.wikimedia.org/T354587) [13:15:49] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587 (10jgleeson) @Eileenmcnaughton @Ejegg, what should we show when the request is processed? I... [13:17:29] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/991324 [13:19:42] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/991324 (owner: 10Damilare Adedoyin) [13:20:53] IP velocity'ing damilare ? [13:20:55] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/991324 (owner: 10Damilare Adedoyin) [13:21:05] yh the deployment [13:21:19] lol [13:21:23] good pun [13:21:28] :D [13:21:42] I was wondering if we could tail memcache in some way [13:21:50] just to see how it behaves [13:22:20] we might not even have access [13:22:53] hmm, I was just going to check the logs. How do we currently check the behavior? [13:23:37] so to confirm it worked, I was trying to donate with failing card details, deleting my session and then retrying repeatedly [13:24:01] and then in the logs you should see your offending IP rack up risk score points [13:24:29] yep that makes sense [13:24:54] I know we went down the memcache rabbit hole last year but I've forgot how we live and being used [13:25:02] how we confirmed* [13:25:10] we should do a similar check for paypal too [13:25:21] good point [13:29:05] cool doing the deploy now [13:34:49] !log payments-wiki upgraded from 12d8ad5b to e38b24f0 [13:34:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [13:41:01] logs look ok to me damilare [13:41:39] same, I'm trying to trip the filter now [14:01:10] 突发新闻 [14:02:55] twitter.com [14:03:22] Thanks for that [14:03:58] haha [14:04:49] (03CR) 10Jgleeson: [C: 03+1] "Looks great. The tests also. I've left two small clean up comments inline and then it's ready to go! Thanks for all the work on this." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) (owner: 10Damilare Adedoyin) [14:09:04] (03PS7) 10Damilare Adedoyin: Catch Database lock in recurring queue consume process in order to requeue message. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) [14:10:04] (03CR) 10Damilare Adedoyin: "thanks jgleeson, done!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) (owner: 10Damilare Adedoyin) [14:17:19] (03CR) 10Jgleeson: [C: 03+2] "Awesome! Our failmail inboxes thank you for this patch!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) (owner: 10Damilare Adedoyin) [14:34:33] (03Merged) 10jenkins-bot: Catch Database lock in recurring queue consume process in order to requeue message. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989886 (https://phabricator.wikimedia.org/T118487) (owner: 10Damilare Adedoyin) [14:37:20] thanks jgleeson for the cr! [14:37:42] np! [16:05:02] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks wfan for working on this, looks good to me. Also confirmed we have about 41 contacts with this issue in the name. Thanks once again" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991095 (https://phabricator.wikimedia.org/T354801) (owner: 10Wfan) [16:09:01] (03PS4) 10Damilare Adedoyin: Use param isValidDonorName to check if valid donor name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991095 (https://phabricator.wikimedia.org/T354801) (owner: 10Wfan) [16:17:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: email syntax error due to if condition for param directly - https://phabricator.wikimedia.org/T354801 (10Damilare) Thanks for catching this @Wfan. The first patch looks good. I think in addition to this, we should add a function that... [16:22:19] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/991383 [16:26:31] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/991383 (owner: 10Damilare Adedoyin) [16:27:32] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/991383 (owner: 10Damilare Adedoyin) [16:29:30] !log civicrm upgraded from 5ef5362f to d8b0c977 [16:29:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:36:58] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), and 2 others: Standardize utm_source from app donations without a banner and clean up old data - https://phabricator.wikimedia.org/T350919 (10Sharvaniharan) 05O... [19:00:09] 10fundraising-tech-ops: Migrate fr-tech-ops documentation from Collab Wiki to Wikitech - https://phabricator.wikimedia.org/T342658 (10Jgreen) [19:26:28] (03CR) 10Jgleeson: "Looking good. I spotted a few small things and left a question about the $params arg of the new doRefund() method." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [19:56:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: email syntax error due to if condition for param directly - https://phabricator.wikimedia.org/T354801 (10AnnWF) >>! In T354801#9466317, @Damilare wrote: > Thanks for catching this @Wfan. The first patch looks good. I think in additio... [20:02:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: email syntax error due to if condition for param directly - https://phabricator.wikimedia.org/T354801 (10AnnWF) @Eileenmcnaughton Do you know why we would check if we have last name to render first name for donor? Also if there is no... [20:13:48] 10fundraising-tech-ops: Migrate fr-tech-ops documentation from Collab Wiki to Wikitech - https://phabricator.wikimedia.org/T342658 (10Jgreen) [20:27:49] 10Fundraising-Backlog, 10Documentation: fr-tech documentation needed for datacenter cutover procedure - https://phabricator.wikimedia.org/T266810 (10Jgreen) [20:35:53] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10FR-Email, 10FR-email-preference-center, 10MediaWiki-extensions-DonationInterface: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10AnnWF) >>! In T223330#9075239, @Ann... [21:10:21] 10fundraising-tech-ops: Migrate fr-tech-ops documentation from Collab Wiki to Wikitech - https://phabricator.wikimedia.org/T342658 (10Jgreen) [21:10:46] 10fundraising-tech-ops: Migrate fr-tech-ops documentation from Collab Wiki to Wikitech - https://phabricator.wikimedia.org/T342658 (10Jgreen) 05Open→03Resolved [22:16:43] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: email syntax error due to if condition for param directly - https://phabricator.wikimedia.org/T354801 (10Eileenmcnaughton) That business of checking first name & last name goes way back - I expect it reflected our data - if we only h... [22:20:09] wfan: I just saw the patch you did for `$isValidDonorName` - that's likely to be a good addition as other checks might get added in the future but just FYI there is also a boolean filter on tokens now - ie {contact.first_name|boolean} will return TRUE or FALSE, useful for if-not-empty checks [22:21:48] cool I saw your reply for that ticket so we could just check first_name I think, and once that deploy we need to contact email team on slack to ask them to update the email template right? [22:22:13] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587 (10Eileenmcnaughton) My instinct is that showing a formatted confirmation page makes it mult...