[00:15:41] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: email syntax error due to if condition for param directly - https://phabricator.wikimedia.org/T354801 (10AnnWF) >>! In T354801#9467302, @Eileenmcnaughton wrote: > That business of checking first name & last name goes way back - I exp... [00:58:14] (03PS1) 10Cstone: Set utm_source middle part (landing page) to app when coming from the app [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991441 (https://phabricator.wikimedia.org/T350919) [01:00:13] (03CR) 10CI reject: [V: 04-1] Set utm_source middle part (landing page) to app when coming from the app [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991441 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone) [01:01:00] (03PS2) 10Cstone: Set utm_source middle part (landing page) to app when coming from the app [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991441 (https://phabricator.wikimedia.org/T350919) [01:14:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: PayPal duplicate donations - https://phabricator.wikimedia.org/T355062 (10Cstone) [01:16:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: PayPal duplicate donations - https://phabricator.wikimedia.org/T355062 (10Cstone) I created a group and put a couple of these in it so we could compare data easier: https://civicrm.wikimedia.org/civicrm/admin/search#/edit/2057 [02:04:14] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: PayPal duplicate donations - https://phabricator.wikimedia.org/T355062 (10Cstone) @krobinson do you have any examples in the last week? We might need to email Paypal about this and they only keep logs on their end for a couple of weeks. They are all on d... [07:38:32] (03PS9) 10Wangombe: Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) [07:38:34] (03PS3) 10Wangombe: Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) [07:40:25] (03CR) 10CI reject: [V: 04-1] Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) (owner: 10Wangombe) [07:40:53] (03CR) 10CI reject: [V: 04-1] Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [07:45:39] (03PS10) 10Wangombe: Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) [07:45:41] (03PS4) 10Wangombe: Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) [07:48:29] (03CR) 10CI reject: [V: 04-1] Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) (owner: 10Wangombe) [07:48:44] (03CR) 10CI reject: [V: 04-1] Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [07:51:32] (03PS11) 10Wangombe: Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) [07:51:34] (03PS5) 10Wangombe: Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) [07:54:42] (03CR) 10CI reject: [V: 04-1] Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) (owner: 10Wangombe) [07:54:49] (03CR) 10CI reject: [V: 04-1] Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [08:06:31] (03CR) 10Nikerabbit: [C: 04-1] Update reference to namespaced MessageGroupMetadata::class (032 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [11:05:43] (03PS1) 10Damilare Adedoyin: Add interface for refund payment to dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991572 (https://phabricator.wikimedia.org/T354357) [11:28:47] (03PS2) 10Damilare Adedoyin: Add interface for refund payment to dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991572 (https://phabricator.wikimedia.org/T354357) [11:29:11] (03PS5) 10Damilare Adedoyin: Refund donation received after recurring cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) [11:31:29] (03PS6) 10Damilare Adedoyin: Refund donation received after recurring cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) [11:38:29] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the review, I left some feedback inline and also created a new smashpig patch for one of the requested changes. https:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [11:39:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: PayPal duplicate donations - https://phabricator.wikimedia.org/T355062 (10krobinson) Hey @Cstone I don't, I'm afraid. They are all from December, as it was big fundraising time, and I just didn't have time to look into them before now. If any new ones get... [11:48:49] (03CR) 10CI reject: [V: 04-1] Refund donation received after recurring cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [13:10:54] ah I didn't realise doRefund(&$params) was defined in the parent damilare [13:12:00] ohh that makes sense now, I was wondering if you meant we should change that [13:12:01] it looks like the reference parameters is a thing in civi [13:12:51] I wonder eileen added public function doRefund(&$params) {} due to a convention they have [13:13:20] probably [13:13:32] if* [13:47:29] 10Fundraising-Backlog, 10Documentation: Ensure all disaster recover documentation is in one central location - https://phabricator.wikimedia.org/T95841 (10Jgreen) Switched project tags because the documentation referenced on this task is for FR Tech not FR Tech Operations. FR Tech Ops docs has been consolidat... [14:01:33] (03PS2) 10Ejegg: build: Update 'svgo' to latest v3.2.0 and re-minify SVGs [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/991018 (https://phabricator.wikimedia.org/T354875) (owner: 10VolkerE) [14:04:17] (03CR) 10CI reject: [V: 04-1] build: Update 'svgo' to latest v3.2.0 and re-minify SVGs [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/991018 (https://phabricator.wikimedia.org/T354875) (owner: 10VolkerE) [14:06:12] argh, still failing, though there's less log noise from that EventLogging test [14:16:00] (03CR) 10Jgleeson: "Thanks for the updates. I'll take a closer look. I think we'll need to keep the reference parameter that I added a comment about if it's d" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [14:32:51] (03PS1) 10Damilare Adedoyin: Add trxn type to change contribution recur row status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991604 (https://phabricator.wikimedia.org/T355193) [14:39:16] fr-tech I'm working on the fundraising-dev docker updates in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/953984. does it make sense to draw a line in the sand and make this patch compatible with the newer docker engine / docker compose v2+ plugin commands? This will effectively force everyone to have to upgrade to a recent version of Docker and the Docker compose plugin. [14:40:29] for Mac & Windows folks, it's all the same thing, Docker Desktop... but for Linux folks it's Docker Engine and Docker Compose v2 [14:41:00] the old docker-compose syntax we use down is part of docker-compose v1 [14:41:03] I think that makes sense, keeps the floor levelled across board [14:45:27] (03PS1) 10Damilare Adedoyin: Import failed subscription rows to update contribution recur table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991607 (https://phabricator.wikimedia.org/T355193) [14:45:55] (03CR) 10CI reject: [V: 04-1] Import failed subscription rows to update contribution recur table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991607 (https://phabricator.wikimedia.org/T355193) (owner: 10Damilare Adedoyin) [14:46:44] (03PS2) 10Damilare Adedoyin: Import failed subscription rows to update contribution recur table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991607 (https://phabricator.wikimedia.org/T355193) [14:49:40] (03PS7) 10Damilare Adedoyin: Refund donation received after recurring cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) [14:50:24] (03CR) 10CI reject: [V: 04-1] Add trxn type to change contribution recur row status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991604 (https://phabricator.wikimedia.org/T355193) (owner: 10Damilare Adedoyin) [14:50:33] (03PS2) 10Damilare Adedoyin: Add trxn type to change contribution recur row status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991604 (https://phabricator.wikimedia.org/T355193) [15:03:53] jgleeson|skrun: +1 for using the newer version of docker [15:05:09] boo. I am unable to run the qunit tests under fresh-node and I can't quite figure out why [15:05:43] npm run qunit (with or without --force) always ends with this: [15:05:46] Warning: Task "karma:main" failed. Use --force to continue. [15:05:47] Warning: Task "karma:main" failed. Use --force to continue. [15:05:49] Aborted due to warnings. [15:06:09] well, only one of those karma:main failed lines, that was a paste error [15:06:38] are other folks able to run those locally? I'm following the instructions at https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#Security_consideration [15:07:06] ahhhhhh [15:07:35] i changed the port to 9011 to use the http version and forgot to change the protocol on the url [15:08:02] thanks for listening, ducks, they are running now [15:10:01] (03CR) 10CI reject: [V: 04-1] Refund donation received after recurring cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/989949 (https://phabricator.wikimedia.org/T354357) (owner: 10Damilare Adedoyin) [15:29:04] 10Fundraising-Backlog, 10Data-Engineering, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice failing in browser test on master - https://phabricator.wikimedia.org/T354977 (10Ejegg) Running the qunit tests locally in a wiki with CN and its dependencies (plus a few ext... [16:40:14] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [16:53:25] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10FR-Email, 10FR-email-preference-center, 10MediaWiki-extensions-DonationInterface: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10AnnWF) Natalie Ngu from Email team... [17:08:40] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on demand - https://phabricator.wikimedia.org/T341299 (10Ejegg) Hi @EMa... [17:26:56] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Support PIX (DIRECT) in DLocal - https://phabricator.wikimedia.org/T324303 (10greg) a:05.Toon→03None [17:27:21] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Support PIX (DIRECT) in DLocal - https://phabricator.wikimedia.org/T324303 (10greg) [17:27:38] 10Fundraising-Backlog, 10FR-dlocal: Payment type migration prioritization for Dlocal reintegration - https://phabricator.wikimedia.org/T324633 (10AKanji-WMF) Is this all done @EMartin ? [17:31:42] 10Fundraising-Backlog, 10FR-BigBundle, 10FR-LATAM: Brazil TY page in English and not Portuguese - https://phabricator.wikimedia.org/T275576 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF This seems to have been an issue with that particular round of testing, I am resolving. [17:46:21] (03CR) 10Umherirrender: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 (owner: 10Umherirrender) [18:08:04] (03PS3) 10Damilare Adedoyin: Import failed subscription rows to update contribution recur table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991607 (https://phabricator.wikimedia.org/T355193) [18:35:40] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Support PIX (DIRECT) in DLocal - https://phabricator.wikimedia.org/T324303 (10AnnWF) No QR code implemented, but able to make donation locally, on production we have pix enabled also: https://donate.wikimedia.org/w/... [18:40:31] 10Fundraising-Backlog: Civi Merges do not retain needed date fields - https://phabricator.wikimedia.org/T354379 (10DBu-WMF) @AKanji-WMF and @bsisolak The right way to do this is to retain the information from both records so that the information that carries over into the merged record in Acoustic is correct. I... [18:43:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal Recurring next_sched_contribution_date in the past - https://phabricator.wikimedia.org/T354327 (10AnnWF) >>! In T354327#9463652, @AMJohnson wrote: > Just wanted to share that this is still occurring it's just now showing February 1st as the "billin... [18:43:24] (03PS4) 10Damilare Adedoyin: Import failed subscription rows to update contribution recur table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991607 (https://phabricator.wikimedia.org/T355193) [18:56:32] 10Fundraising-Backlog, 10FR-dlocal: Payment type migration prioritization for Dlocal reintegration - https://phabricator.wikimedia.org/T324633 (10EMartin) yes @AKanji-WMF [18:58:02] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on demand - https://phabricator.wikimedia.org/T341299 (10EMartin) Hi El... [19:25:05] (03PS5) 10Damilare Adedoyin: Import failed subscription rows to update contribution recur table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/991607 (https://phabricator.wikimedia.org/T355193) [19:33:55] (03PS3) 10Damilare Adedoyin: Add trxn type to change contribution recur row status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991604 (https://phabricator.wikimedia.org/T355193) [19:35:28] (03PS1) 10Damilare Adedoyin: Add failed recurring to fundraiseup imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991639 (https://phabricator.wikimedia.org/T355193) [19:47:40] (03PS1) 10Ejegg: Send browser_info to Adyen for all CC donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991640 (https://phabricator.wikimedia.org/T341299) [19:47:45] (03CR) 10Ejegg: [C: 03+2] Send browser_info to Adyen for all CC donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991640 (https://phabricator.wikimedia.org/T341299) (owner: 10Ejegg) [19:49:50] (03CR) 10CI reject: [V: 04-1] Send browser_info to Adyen for all CC donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991640 (https://phabricator.wikimedia.org/T341299) (owner: 10Ejegg) [19:51:08] (03CR) 10CI reject: [V: 04-1] Add trxn type to change contribution recur row status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991604 (https://phabricator.wikimedia.org/T355193) (owner: 10Damilare Adedoyin) [19:52:07] (03CR) 10CI reject: [V: 04-1] Add failed recurring to fundraiseup imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991639 (https://phabricator.wikimedia.org/T355193) (owner: 10Damilare Adedoyin) [20:09:25] (03PS2) 10Ejegg: Send browser_info to Adyen for all CC donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991640 (https://phabricator.wikimedia.org/T341299) [20:11:58] (03CR) 10Ejegg: [C: 03+2] Send browser_info to Adyen for all CC donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991640 (https://phabricator.wikimedia.org/T341299) (owner: 10Ejegg) [20:48:01] (03Merged) 10jenkins-bot: Send browser_info to Adyen for all CC donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/991640 (https://phabricator.wikimedia.org/T341299) (owner: 10Ejegg) [20:59:07] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/991657 [20:59:11] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/991657 (owner: 10Ejegg) [21:04:23] !log payments-wiki upgraded from e38b24f0 to c37ddae5 [21:04:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:07:03] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), 10Patch-For-Review: Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on dem... - https://phabricator.wikimedia.org/T341299 [21:12:29] 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), 10Patch-For-Review: Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on dem... - https://phabricator.wikimedia.org/T341299 [21:14:56] woot, I found out how to unprotect the main branch on my dev-images fork [21:45:19] (03PS2) 10Umherirrender: tests: Pass UTSysop to CentralNoticeTestFixtures [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 [21:48:22] (03CR) 10CI reject: [V: 04-1] tests: Pass UTSysop to CentralNoticeTestFixtures [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 (owner: 10Umherirrender) [22:10:33] (03CR) 10Umherirrender: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 (owner: 10Umherirrender) [22:41:34] (03CR) 10Umherirrender: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 (owner: 10Umherirrender) [23:15:26] (03CR) 10Ejegg: "with the current code structure, I would expect to see a message ending a recurring contribution processed in the importSubscriptionAccoun" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991604 (https://phabricator.wikimedia.org/T355193) (owner: 10Damilare Adedoyin) [23:25:24] 10Fundraising-Backlog, 10Data-Engineering, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice failing in browser test on master - https://phabricator.wikimedia.org/T354977 (10Umherirrender) When skipping all qunit tests from CentralNotice it works, even with the Event... [23:26:22] (03PS3) 10Umherirrender: tests: Pass UTSysop to CentralNoticeTestFixtures [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 [23:29:21] (03CR) 10CI reject: [V: 04-1] tests: Pass UTSysop to CentralNoticeTestFixtures [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/983503 (owner: 10Umherirrender)