[09:52:11] <wikibugs>	 (03PS13) 10Wangombe: Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420)
[09:52:13] <wikibugs>	 (03PS7) 10Wangombe: Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724)
[09:52:15] <wikibugs>	 (03CR) 10Wangombe: Update reference to namespaced MessageGroupMetadata::class (032 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe)
[09:54:54] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Update reference to newly namesapaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) (owner: 10Wangombe)
[09:54:56] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe)
[12:49:00] <wikibugs>	 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog, 10Patch-For-Review: Set recurring status to canceled for failed fundraiseup recur contributions - https://phabricator.wikimedia.org/T355193 (10Damilare) a:03Damilare
[12:57:05] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Move subscr_id lookup to normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991874 (owner: 10Ejegg)
[13:21:07] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "Check the comments inline. I think we might be talking about different things. The question wasn't a blocker, so merging this in the inter" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988756 (owner: 10Eileen)
[13:28:55] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "*** different language setters, but both do implement getContributionID() and getEmail(), so it felt like an opportunity to combine." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988756 (owner: 10Eileen)
[13:29:08] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Normalize refund contribution status earlier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991800 (https://phabricator.wikimedia.org/T353549) (owner: 10Ejegg)
[13:31:44] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "reapplying +2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988757 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen)
[13:32:15] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Cancel recurring when we get a chargeback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991833 (https://phabricator.wikimedia.org/T353549) (owner: 10Ejegg)
[13:34:45] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991869 (owner: 10Ejegg)
[13:35:42] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991835 (https://phabricator.wikimedia.org/T355448) (owner: 10Ejegg)
[13:36:11] <jgleeson>	 damilare: looks like we're both reviewing the same chain from different ends
[13:36:31] <jgleeson>	 I was looking at the one liners
[13:36:50] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "nice catch!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991802 (owner: 10Ejegg)
[13:37:00] <damilare>	 ahh sorry I didn't know you were too... 
[13:37:19] <jgleeson>	 no it's fine we didn't clash
[13:37:31] <jgleeson>	 just in case you were wondering why the ones above were changing
[13:38:58] <wikibugs>	 (03Merged) 10jenkins-bot: Calculate unsubscribe in Send class, in just the one place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988756 (owner: 10Eileen)
[13:40:28] <damilare>	 Are you reviewing this now: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/991832/4?
[13:40:43] <jgleeson>	 nope!
[13:42:22] <jgleeson>	 I was circling back on some review for eileen with I just +2ed and then saw the other low hanging fruit but I didn't realise we were both looking at the same chain
[13:43:04] <ejegg|away>	 thanks for the review damilare and jgleeson !
[13:43:21] <damilare>	 ahh cool
[13:43:33] <damilare>	 I'd get back to that then... no p
[13:43:45] <jgleeson>	 sure thing!
[13:43:55] <jgleeson>	 x2
[13:45:34] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM thanks for all the work on this and deprecating the wmf_civicrm_get_gateway_subscription method in favour of getByGatewaySubscription" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991832 (https://phabricator.wikimedia.org/T353549) (owner: 10Ejegg)
[13:47:05] <ejegg>	 ah right damilare, thanks for reminding me what I was going to do next - I'll switch the tests to use the new method
[13:48:14] <damilare>	 awesome! we were just talking about this on one of the tech talks last week. Good to have the old methods phased out slowly
[13:48:41] <ejegg>	 ah, rather than try to do it all in one patch?
[13:48:54] <ejegg>	 Sounds about right
[13:49:16] <ejegg>	 but then we don't want to leave the deprecated one TOO long
[13:50:02] <wikibugs>	 (03Merged) 10jenkins-bot: Normalize refund contribution status earlier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991800 (https://phabricator.wikimedia.org/T353549) (owner: 10Ejegg)
[13:50:05] <wikibugs>	 (03Merged) 10jenkins-bot: Do not calculate unsubscribe_link in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988757 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen)
[13:50:07] <wikibugs>	 (03Merged) 10jenkins-bot: Stop passing unsubscribe_link through from test form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988758 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen)
[13:50:10] <wikibugs>	 (03Merged) 10jenkins-bot: Remove last remnants of the old unsubscribe_link code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/988759 (https://phabricator.wikimedia.org/T354585) (owner: 10Eileen)
[13:52:34] <damilare>	 true. 
[14:04:12] <wikibugs>	 (03Merged) 10jenkins-bot: Allow passing contribution_recur_id in subscr_cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991832 (https://phabricator.wikimedia.org/T353549) (owner: 10Ejegg)
[14:05:17] <wikibugs>	 (03Merged) 10jenkins-bot: Cancel recurring when we get a chargeback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991833 (https://phabricator.wikimedia.org/T353549) (owner: 10Ejegg)
[14:05:20] <wikibugs>	 (03Merged) 10jenkins-bot: Log PayPal edge cases [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991835 (https://phabricator.wikimedia.org/T355448) (owner: 10Ejegg)
[14:05:22] <wikibugs>	 (03Merged) 10jenkins-bot: Fix typo wasting ct_id lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991802 (owner: 10Ejegg)
[14:05:24] <wikibugs>	 (03Merged) 10jenkins-bot: Remove no-op drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991869 (owner: 10Ejegg)
[14:05:26] <wikibugs>	 (03Merged) 10jenkins-bot: Move subscr_id lookup to normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/991874 (owner: 10Ejegg)
[14:05:36] <jgleeson>	 merge wave
[14:09:42] <ejegg>	 woohoo
[14:10:18] <wikibugs>	 (03PS1) 10Ejegg: Use new subscr lookup function in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992188
[14:11:01] <ejegg>	 whoa, suddenly gerrit is darkmode?
[14:11:53] <ejegg>	 i like darkmode generally but this is somehow too jarring. back to lightmode for now
[14:12:14] <jgleeson>	 huh rly ejegg ? it looks light for me
[14:12:26] <jgleeson>	 logged out maybe?
[14:12:29] <ejegg>	 Ah mine was set to 'auto (from OS prefs)'
[14:12:38] <ejegg>	 and my OS is darkmode for the rest of the stuff
[14:12:46] <ejegg>	 so I guess maybe the auto setting is new?
[14:13:43] <jgleeson>	 when you look at the dark side, careful you must be :)
[14:14:24] <jgleeson>	 yeah mine is now auto
[14:30:52] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Review headers on payments-wiki - https://phabricator.wikimedia.org/T355545 (10Ejegg)
[14:34:38] <wikibugs>	 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168 (10Ejegg) Some thoughts (copied to etherpad): * Review x-frame options to make sure we're allowing loading from donatew...
[14:50:20] <jgleeson>	 hey damilare I'm looking at this and I can see your smashpig patch but I can't see the update on the civicrm patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/989949/comment/b2f1ca6a_703e0904/
[14:50:39] <jgleeson>	 and then as soon as I hit enter, I found it 
[14:50:53] <jgleeson>	 on ln 315
[14:50:56] <jgleeson>	 got it!
[14:51:48] <damilare>	 ahh happenes to me all the time lol
[14:51:54] <jgleeson>	 :)
[14:53:18] <jgleeson>	 will continue when I get back, thanks
[14:54:29] <damilare>	 thanks
[15:10:48] <wikibugs>	 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Have the iOS submitPayment endpoint save app version like the form front end does - https://phabricator.wikimedia.org/T351689 (10Damilare) a:03Damilare
[16:28:04] <wikibugs>	 (03CR) 10Damilare Adedoyin: "LGTM, thanks for all the work on this." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990151 (https://phabricator.wikimedia.org/T303778) (owner: 10Pcoombe)
[16:33:40] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Update monthly convert amounts [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990151 (https://phabricator.wikimedia.org/T303778) (owner: 10Pcoombe)
[16:53:10] <wikibugs>	 (03PS1) 10Ejegg: Move recurring c_t helper function to new extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992214 (https://phabricator.wikimedia.org/T270672)
[16:56:18] <wikibugs>	 (03Merged) 10jenkins-bot: Update monthly convert amounts [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/990151 (https://phabricator.wikimedia.org/T303778) (owner: 10Pcoombe)
[17:12:13] <wikibugs>	 (03PS1) 10Ejegg: Delete unreachable code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/992216 (https://phabricator.wikimedia.org/T336024)
[17:14:34] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Delete unreachable code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/992216 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg)
[17:17:13] <ejegg>	 grr, tests relying on behavior never seen in real life
[18:46:11] <wikibugs>	 10Fundraising Spring - anybodyKnowWhatThisDoes(), 10Fundraising-Backlog: Have the iOS submitPayment endpoint save app version like the form front end does - https://phabricator.wikimedia.org/T351689 (10Damilare) Hey @cstone, do we want to create new columns on the Contribution tracking table or do we reuse the...
[18:46:41] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jmoreira - https://phabricator.wikimedia.org/T355576 (10Dwisehaupt)
[18:56:24] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for afowler - https://phabricator.wikimedia.org/T355577 (10Dwisehaupt)
[18:57:07] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for tgorski - https://phabricator.wikimedia.org/T355578 (10Dwisehaupt)
[18:57:38] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for spuri - https://phabricator.wikimedia.org/T355579 (10Dwisehaupt)
[18:58:16] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jcuriel - https://phabricator.wikimedia.org/T355580 (10Dwisehaupt)
[18:58:50] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jkim - https://phabricator.wikimedia.org/T355581 (10Dwisehaupt)
[18:59:21] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dmorgan - https://phabricator.wikimedia.org/T355582 (10Dwisehaupt)
[19:00:41] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ajett - https://phabricator.wikimedia.org/T355583 (10Dwisehaupt)
[19:02:20] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sharonr - https://phabricator.wikimedia.org/T355584 (10Dwisehaupt)
[19:02:57] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jbrungs - https://phabricator.wikimedia.org/T355585 (10Dwisehaupt)
[19:04:14] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jsimmons - https://phabricator.wikimedia.org/T355586 (10Dwisehaupt)
[19:04:52] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lwadleigh - https://phabricator.wikimedia.org/T355587 (10Dwisehaupt)
[19:12:07] <cstone>	 damilare: use the ones that are already there
[19:12:38] <cstone>	 It was more of just an attempt to match up data with the form donations 
[19:34:03] <wikibugs>	 (03PS2) 10Ejegg: Delete unreachable code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/992216 (https://phabricator.wikimedia.org/T336024)
[19:34:59] <ejegg>	 ^^^ is sort-of prep for refactoring the PayPal EC adaptor to use the SmashPig library instead of making its own API calls.
[19:35:54] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Delete unreachable code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/992216 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg)
[19:49:12] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jmoreira - https://phabricator.wikimedia.org/T355576 (10Dwisehaupt) Renewed the certificate but it is failing to import into the login keychain on Keychain Access on their machine. Tested regenerating the certificate a few time...
[20:00:03] <wikibugs>	 (03CR) 10Tacsipacsi: Update reference to namespaced MessageGroupMetadata::class (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe)
[20:03:37] <wikibugs>	 (03CR) 10Eileen: "I think it's great to transfer functions to the extension." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992214 (https://phabricator.wikimedia.org/T270672) (owner: 10Ejegg)
[20:06:02] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Use new subscr lookup function in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992188 (owner: 10Ejegg)
[20:06:11] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jkim - https://phabricator.wikimedia.org/T355581 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS.
[20:08:28] <ejegg>	 thanks eileen 
[20:08:59] <eileen>	 lol - i'm trying to figure out what I was thanked for - I guess that was your patch I merged :-)
[20:14:50] <ejegg>	 Heh, that and the clear case for the message handling classes!
[20:15:24] <damilare>	 thanks cstone 
[20:19:34] <eileen>	 :-)
[20:19:54] <eileen>	 dwisehaupt: when did we last refresh data to staging? November?
[20:20:09] <dwisehaupt>	 yeah. i believe that's when we did it.
[20:20:35] <dwisehaupt>	 i'd have to look back through email to find the exact date but i'm pretty sure it was november.
[20:20:46] <dwisehaupt>	 actually, the files may still be on disk.
[20:21:13] <dwisehaupt>	 restore-20231117-001516.log
[20:21:56] <wikibugs>	 (03Merged) 10jenkins-bot: Use new subscr lookup function in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992188 (owner: 10Ejegg)
[20:23:51] <eileen>	 dwisehaupt: ok cool - thanks
[20:30:01] <wikibugs>	 10Fundraising Sprint Byzantine Empire Strikes Back, 10Fundraising Sprint CAPS LOCK CULTS, 10Fundraising Sprint Dampness, 10Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (10Eileenmcnaughton) I should be fine for any evening this week (back to normal now)
[20:44:05] <wikibugs>	 10Fundraising-Backlog: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264 (10Eileenmcnaughton) @AKanji-WMF - doing this isn't tied to maintenance week - we could just search through the UI for each segment in turn & put people into a group & if necessary export from CiviCRM via the UI...
[20:46:38] <wikibugs>	 10Fundraising-Backlog: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264 (10Eileenmcnaughton) @JMando we just chatted & felt that the above queries would be useful to have as dashboards in superset?
[20:50:55] <wikibugs>	 10Fundraising-Backlog: FY2324 Q3: Need to map new Civi fields over to Acoustic - https://phabricator.wikimedia.org/T353386 (10Eileenmcnaughton) @KHaggard so you are looking at the left & right most columns here https://civicrm.wikimedia.org/civicrm/wmf-segment
[21:05:37] <wikibugs>	 (03PS1) 10Wfan: Also update next_sched_contribution_date for paypal legacy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992237 (https://phabricator.wikimedia.org/T354327)
[21:06:00] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Issue with bank transfer payments in Brazil - https://phabricator.wikimedia.org/T355371 (10Cstone)
[21:09:35] <wikibugs>	 (03PS1) 10Wfan: set xdebug3_port as 9003 [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/992175
[21:09:37] <wikibugs>	 (03PS1) 10Wfan: clean up civi consume queue with color highlight [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/992176
[21:10:38] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate suspected Prometheus data bug - https://phabricator.wikimedia.org/T352241 (10Ejegg) Recap from December's discussion: we figured out this was because we were using stats in a way we shouldn't have.  The stat is most properly understood as 'num...
[21:14:33] <jgleeson>	 eileen: I +2ed that unsubscribe link patch holding up the remaining chain patches from merging. It was probably one we could have chatted about on a call and resolved in 2 minutes. It got me thinking if there were any async video call solutions ha
[21:14:37] <jgleeson>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/988756
[21:16:00] <eileen>	 thanks jgleeson - I get that your point is that we have 2 classes in 2 subsystems that implement similar functions so could share a trait - but my worry is that then the WorkflowMessage subsystem becomes tied to a class that is largely unrelated & when we want to do the next thing it gets us in a bind
[21:16:46] <eileen>	 on one level it is 'co-incidence' that they both implement `getContributionID()` (not that co-incidental cos I pretty much add that function everywhere I go but it's not a shared contract)
[21:19:03] <jgleeson>	 yeah that's fine eileen you know that code and it's trajectory much better than me so I'll defer to you on what's best. It was just a thought at the time. 
[21:19:59] <eileen>	 jgleeson: yeah - probably the conversation was not helped by the fact that my replies didn't 'publish' at the time :-)
[21:22:17] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Also update next_sched_contribution_date for paypal legacy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992237 (https://phabricator.wikimedia.org/T354327) (owner: 10Wfan)
[21:35:15] <jgleeson>	 ha! I guess my history with trait-like code from the old Yii PHP framework might have influenced that suggestion. Trait-like functionality used to be called behaviours in the pre 5.3 years before they became an official construct and it used to be common to write generic "behaviours" in that framework that you could attach and detatch to multiple different classes e.g. IsLoggdInCheck, ACLCheck,
[21:35:17] <jgleeson>	 LogWhenSaved and any other wide reaching things that could be pepper around. Traits came a long and pretty much made that feature redundant apart from the ability to dynamically assign them. The last I checked, you couldn't do that with vanilla traits. https://www.yiiframework.com/doc/guide/1.1/en/basics.component#component-behavior
[21:43:31] <jgleeson>	 thanks for the reply on that thread ejegg. we can probably close that one now do you think?
[21:44:50] <eileen>	 jgleeson: yeah I'm a fan of traits - but there are a bunch of workflow-message specific traits already in the workflow-message subsystem so adding another subsystem specific trait follows that pattern. If we added more handling to that trait there is no guarantee it would be the same handling we would want in the other class but it would almost certainly be consistent across workflow messages
[21:46:35] <jgleeson>	 makes sense
[21:49:45] <eileen>	 jgleeson: that is interesting to see how it allows access to properties (directly from a syntax POV) as implemented by the getters & setters
[21:55:00] <jgleeson>	 yeah it was pretty nifty back in the day. I used to read about Python with its support for multiple inheritance and Ruby's mixins enviously but then when it came to PHP in the form of traits I never really found a good reason to use them much although I do like the flexibility they offer 
[21:55:54] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jkim - https://phabricator.wikimedia.org/T355581 (10Dwisehaupt) jkim ran into the same issue with the certificate saying the password is invalid. Investigating to see if there were changes in bookworm or the latest macos versio...
[21:58:43] <eileen>	 jgleeson: yeah - I definitely have added quite a few traits to civi core - there is a new lookup trait which is kinda nifty - it allows lazy loading of entities - ie you define an entity with the details you have - which might just be the id or maybe a bit more & then you can lookup values on it & it will load from the db if not already defined
[21:59:14] <jgleeson>	 ah nice
[21:59:44] <jgleeson>	 there's something pleasing about the idea of a check called isLazyLoadable() ha
[22:00:05] <jgleeson>	 I think I have that trait :)
[22:01:32] <eileen>	 lol
[22:01:49] <ejegg>	 jgleeson: yep, I'm up for closing that ticket
[22:02:17] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate suspected Prometheus data bug - https://phabricator.wikimedia.org/T352241 (10Ejegg) 05Open→03Resolved a:03Ejegg Resolved by deleting the confusing graph
[22:02:56] <eileen>	 jgleeson: https://github.com/civicrm/civicrm-core/pull/27257
[22:03:00] <jgleeson>	 thanks ejegg !
[22:03:45] <eileen>	 - although in practice the forms implement a trait to use that trait that requires them to follow a contract
[22:05:22] <jgleeson>	 that looks good eileen 
[22:07:57] <eileen>	 yeah - implementing it in the forms what I wound up doing was wrapping those functions in (eg.) `getContributionValue()` - but that is because in the forms it's kinda confusing to track what has been defined when so `getContributionValue()` can specifically ensure the contribution has been defined using form-specific logic held in `getContributionID()` - which is the contract for using the FormContributionTrait. But 
[22:07:57] <eileen>	 that is less of an issue in our code - ie our flows are not nearly as haphazhard (see says optimistically)
[22:09:04] <jgleeson>	 lol
[22:16:30] <jgleeson>	 that PR code looks like a nice way to hide the complexity behind a nice concise API. I was listening to a podcast a few weeks ago and the guy who was being interviewed was Chris Lattner, he's the guy who created the Swift language a few others, but he said something that stuck with me about API and language design and it was that the code we offer developers is our UI, the language, code,
[22:16:32] <jgleeson>	 syntax is the UI in a strictly code-only sense. I'd never though about it like it but it made sense. I'd recommend the podcast too https://www.youtube.com/watch?v=pdJQ8iVTwj8 
[22:17:01] <jgleeson>	 I found him after watching his podcast with Jimmy Wales which was also good. 
[22:30:40] <jgleeson>	 donut wiki build is working yay! pushed that up so next is email pref ctr with civiproxy which I'll continue with tomorrow. calling it a night. bye for now o/
[22:45:16] <wikibugs>	 10Fundraising-Backlog: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264 (10Eileenmcnaughton) To get a random selection it is possible to do   ` select donor_status_id, entity_id  FROM wmf_donor d INNER JOIN civicrm_contact c O N d.entity_id = c.id AND c.is_deleted = 0 AND donor_stat...
[23:23:33] <wikibugs>	 (03PS2) 10Wfan: Also update next_sched_contribution_date and cycle_day for for paypal legacy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992237 (https://phabricator.wikimedia.org/T354327)
[23:53:08] <wikibugs>	 10fundraising-tech-ops: Update ssl_user_admin to support 'legacy' flag when generating client certificates - https://phabricator.wikimedia.org/T355623 (10Dwisehaupt)
[23:54:12] <wikibugs>	 10fundraising-tech-ops: Update ssl_user_admin to support 'legacy' flag when generating client certificates - https://phabricator.wikimedia.org/T355623 (10Dwisehaupt) p:05Triage→03High
[23:59:53] <wikibugs>	 10fundraising-tech-ops: Update ssl_user_admin to support 'legacy' flag when generating client certificates - https://phabricator.wikimedia.org/T355623 (10Dwisehaupt) 05Open→03Resolved Tested regenerating my certificate and it successfully installs in firefox on linux and the macos keychain.  Fixed: `[frack::...