[00:02:46] (03PS1) 10Jgleeson: Remove config-private from bind-mount-dirs.sh init script. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995121 [00:05:34] yay civicrm-core with --mac fixed [00:10:25] woo [00:10:49] they fully outlawed plastic bags here which sure but you cant even buy them now so therse just no bags at the grocery store checkout, not even ones you can buy hha [00:12:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for khancock - https://phabricator.wikimedia.org/T356466 (10Dwisehaupt) [00:12:35] (03PS1) 10Jgleeson: Fix --civicrm-core on --mac [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995122 [00:13:26] no paper ones either? [00:13:50] nope [00:13:58] we use the paper ones as our recycle 'bin' until they fall apart, and then they become the recycling. [00:23:08] (03PS1) 10Jgleeson: Remove --force-recreate flag from docker compose up wrapper fn [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995124 [00:25:48] gnight! [01:21:40] 10600 rows imported for DataAxle so far [01:24:48] cool. it could probably go harder. but it is what it is. [01:26:38] eileen: anything exciting for me to add in the end of day for the maintenance? aside from the data axle import rolling on. [01:29:08] dwisehaupt: only that we have started importing the custom data fields from data axle & it is progressing well [01:30:18] coolthx [01:40:49] ok. i'm headed out. see you all tomorrow. trigger alerts if you need me. :) [01:45:36] (03PS2) 10Wfan: Fix smashpig port and add more queue for opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 [01:49:02] (03PS3) 10Wfan: Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 [01:54:36] (03PS4) 10Wfan: Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 [02:27:30] (03CR) 10Ejegg: "Thanks for this! I think we can move ahead with it soon (well, maybe after the LatAm campaign). Let's move the audit test and its datafile" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [02:27:45] (03CR) 10Ejegg: [C: 04-1] Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [02:37:03] (03CR) 10Ejegg: [C: 04-1] "Let's not run ALL of the jobs in the consume-queues script please. I'm on board with adding the banner history, the unsubscribe, and the o" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 (owner: 10Wfan) [02:39:23] (03PS5) 10Wfan: Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 [02:41:07] (03CR) 10Ejegg: "Looks pretty good! Just that one test folder should be updated to match." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [02:42:37] (03CR) 10Ejegg: Rename WMFHelpers to WMFHelper (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [02:42:39] (03CR) 10Wfan: Remove astropay from smashpig (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [02:45:25] (03PS1) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995132 (https://phabricator.wikimedia.org/T326218) [02:47:18] (03Abandoned) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995132 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [02:48:07] (03PS5) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) [02:55:25] (03PS1) 10Ejegg: Set no_thank_you if configured [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/995133 (https://phabricator.wikimedia.org/T349539) [03:03:24] (03PS1) 10Ejegg: Remove unused token migration action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995134 [03:25:53] 10Fundraising-Backlog: Upgrading project Landing pages code - https://phabricator.wikimedia.org/T356370 (10Ejegg) Let's keep them as a single page. On the email preferences pages we accept a 'variant' parameter which can load a different template. We could do something similar here. We can definitely add an 'ot... [03:39:00] (03PS6) 10Wfan: Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 [03:39:44] (03PS7) 10Wfan: Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 [04:14:51] (03PS2) 10Damilare Adedoyin: WIP: Move successful autorescue to recurring queue without reading from Pending db table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995038 (https://phabricator.wikimedia.org/T356224) [04:15:16] (03CR) 10CI reject: [V: 04-1] WIP: Move successful autorescue to recurring queue without reading from Pending db table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995038 (https://phabricator.wikimedia.org/T356224) (owner: 10Damilare Adedoyin) [04:17:48] (03PS1) 10Damilare Adedoyin: WIP: Check additional contribution details from Contribution Recur using rescue reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995136 (https://phabricator.wikimedia.org/T356224) [05:35:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Tech-Analytics: Some Recent Email Send have No Clicks Or Donations - https://phabricator.wikimedia.org/T355974 (10MSuijkerbuijk_WMF) Thanks, noted [07:42:43] (03CR) 10Jgleeson: "@cstone - one for you" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995121 (owner: 10Jgleeson) [07:44:16] (03PS2) 10Jgleeson: Fix --civicrm-core on --mac [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995122 [07:44:21] (03PS2) 10Jgleeson: Remove --force-recreate flag from docker compose up wrapper fn [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995124 [07:50:13] morning giggles https://phabricator.wikimedia.org/F41749233 [07:59:10] 10Fundraising-Backlog: Add 'other' amount field to the upgrading page - https://phabricator.wikimedia.org/T356478 (10MSuijkerbuijk_WMF) [08:01:19] 10Fundraising-Backlog: Show total amount once donor chooses amount - upgrading landing page - https://phabricator.wikimedia.org/T356479 (10MSuijkerbuijk_WMF) [08:02:16] 10Fundraising-Backlog: Upgrading project Landing pages code - https://phabricator.wikimedia.org/T356370 (10MSuijkerbuijk_WMF) Thanks Elliott, the variant parameter sounds smart. Here's the request for the 'Other amount' https://phabricator.wikimedia.org/T356478 Here's the reques to show total amount https://p... [12:55:28] (03Abandoned) 10Jgleeson: Remove --force-recreate flag from docker compose up wrapper fn [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995124 (owner: 10Jgleeson) [13:11:07] (03PS1) 10Jgleeson: Add ./setup.sh --config-private build option [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995203 [13:14:37] (03PS1) 10Jgleeson: Update email-pref-ctr service to depend on donorprefsqueues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995205 [13:53:17] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 7908 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:55:57] 10Fundraising-Backlog: Upgrading project Confirmation email - https://phabricator.wikimedia.org/T356373 (10AKanji-WMF) [13:55:59] 10Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations, 10Epic: How can we enable upgrading of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317 (10AKanji-WMF) [13:58:17] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 2494016 Threads: 4 Questions: 275310418 Slow queries: 1213 Opens: 3394 Open tables: 1215 Queries per second avg: 110.388 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:40:35] (03PS2) 10Ejegg: Add ./setup.sh destroy command [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995113 (owner: 10Jgleeson) [14:40:43] ty [14:40:44] ! [14:40:44] (03CR) 10Ejegg: [C: 03+2] Add ./setup.sh destroy command [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995113 (owner: 10Jgleeson) [14:41:00] (03PS2) 10Ejegg: Remove config-private from bind-mount-dirs.sh init script. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995121 (owner: 10Jgleeson) [14:41:06] (03CR) 10Ejegg: [C: 03+2] Remove config-private from bind-mount-dirs.sh init script. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995121 (owner: 10Jgleeson) [14:43:14] ejegg: does donut wiki load properly for you? [14:43:46] I get some weird JS error [14:43:48] Refused to execute script from 'https://localhost:9010/w/load.php?lang=en-gb&modules=startup&only=scripts&raw=1&skin=vector' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled. [14:44:15] I recently updated chrome so I don't know if it's a bug of a coincidence [14:45:42] ejegg: I'm just looking at https://docs.docker.com/compose/environment-variables/envvars/#compose_project_name [14:45:43] 10Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677 (10AKanji-WMF) FR-Tech - please note this thread: https://wikimedia.slack.com/archives/C5MAUGA72/p1706691364498959 [14:46:02] I think we can add it to the init prompts [14:47:18] jgleeson: let me check on donut [14:47:34] oh it didn't even install [14:47:46] is the container up? [14:47:47] maybe I didn't say y to all the right prompts [14:47:54] yeah, just the db doesn't exist [14:47:59] will run --donut [14:47:59] oh interesting [14:50:31] yeah, it loads fine for me, no errors in console [14:50:40] oh great [14:50:43] I'll reinstall [14:50:47] maybe I missed something too [14:51:52] gonna grab the kids. back soon [15:08:01] morning/afternoon team - I'm going to take the rest of the day off for sick child management and some pre-weekend travel - so you all Monday! [15:58:46] (03PS1) 10Ejegg: Make Case link on Relationship search conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995246 [15:58:56] good luck anilk ! [15:59:26] (03PS2) 10Ejegg: Make Case link on Relationship search conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995246 [15:59:39] fr-tech that patch should fix the relationship tab not showing active ones ^^^ [15:59:48] can anyone give it a quick look? [15:59:58] I can also pull it onto staging [16:20:20] OK, works locally and on staging [16:43:54] (03CR) 10Ejegg: "Could you please restore the audit test (moving it over to the dlocal folder)?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [16:48:57] (03CR) 10Ejegg: "I think we need to review the requirements here - let's see if we should really require that CID and checksum." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [16:54:23] hm, expired email prefs links just load a form with no email/name and defaults for other stuff now [16:59:18] ejegg: how do you get to an example locally of the cases? [17:00:00] cstone locally we have no cases [17:00:07] because we've never had civicase active [17:00:09] oh i see thers a cid at the top of the thread [17:00:17] if you go to dmaster there might be some with cases [17:00:38] (if you want to make sure the patch doesn't break case links for ppl with CiviCase enabled) [17:18:52] (03PS6) 10Wfan: Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) [17:20:04] (03CR) 10Cstone: [C: 03+2] "yep this got it showing back up for me!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995246 (owner: 10Ejegg) [17:20:29] (03PS3) 10Jgleeson: Fix --civicrm-core on --mac [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995122 [17:21:02] (03CR) 10Jgleeson: [V: 03+2] Add ./setup.sh destroy command [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995113 (owner: 10Jgleeson) [17:21:12] (03CR) 10Jgleeson: [V: 03+2] Remove config-private from bind-mount-dirs.sh init script. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995121 (owner: 10Jgleeson) [17:21:35] (03PS2) 10Jgleeson: Add ./setup.sh --config-private build option [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995203 [17:21:40] (03PS1) 10Wfan: remove contribution check from email unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995269 (https://phabricator.wikimedia.org/T223330) [17:21:42] (03PS2) 10Jgleeson: Update email-pref-ctr service to depend on donorprefsqueues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995205 [17:36:26] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/995273 [17:36:29] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/995273 (owner: 10Ejegg) [17:38:09] (03Merged) 10jenkins-bot: Make Case link on Relationship search conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995246 (owner: 10Ejegg) [17:38:11] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/995273 (owner: 10Ejegg) [17:39:34] (03CR) 10CI reject: [V: 04-1] remove contribution check from email unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995269 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [17:40:26] (03PS7) 10Wfan: Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) [17:42:25] (03CR) 10CI reject: [V: 04-1] Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [18:02:24] !log fundraising civicrm upgraded from f89f3a58 to 427c40f5 [18:02:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:24:16] (03PS2) 10Wfan: remove contribution check from email unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995269 (https://phabricator.wikimedia.org/T223330) [18:44:06] (03PS3) 10Wfan: remove contribution check from email unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995269 (https://phabricator.wikimedia.org/T223330) [18:55:39] sorry wfan I think we should have done more requirements gathering before working on that ticket [18:55:43] 10Fundraising Sprint: brb(), 10Fundraising-Backlog, 10FR-Email, 10FR-email-preference-center, and 2 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10Ejegg) @AKanji-WMF, @XenoRyet , @DBu-WMF Can you help us determine the current requir... [18:56:21] (03PS8) 10Wfan: Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) [18:56:58] 10fundraising-tech-ops: Upgrade Fundraising Superset to 3.0.2 - https://phabricator.wikimedia.org/T356531 (10Jgreen) [18:57:17] (03PS9) 10Wfan: Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) [18:58:29] ejegg|food: like adding checksum check for the email address that we want? I think it's fine that we can wait for the confirmation see if they still want to have the donors manually write their email address, if so we do need the check of checksum and contact id to verify that [18:58:34] 10fundraising-tech-ops: Upgrade Fundraising Superset to 3.0.2 - https://phabricator.wikimedia.org/T356531 (10Jgreen) I got the software install, schema fixes, and basic database upgrade to work in testing. Next step is to try upgrading the live instance and make sure various charts and reports work properly. [18:59:12] (03CR) 10CI reject: [V: 04-1] Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [19:00:22] (03PS10) 10Wfan: Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) [19:06:41] ejegg: do you want to move the checksum check from di level to civi queue, like we did for the email and contribution-id before? [19:07:08] wfan i'm not sure [19:07:35] let's get some more input about what's legally required [19:08:24] I figure that's why our unsubscribe queue needs contribution-id before ... Sure :) [19:16:16] dwisehaupt / Jeff_Green process-control logs more than 1 year old are just completely purged, right? [19:16:39] was seeing if I could find info about something from March 2022 for https://phabricator.wikimedia.org/T326770 [19:16:41] ejegg: I can't remember offhand, checking [19:16:52] but I might just have to close it as a cold case [19:17:39] yeah they're purged at 1Y [19:18:46] k, cool [19:20:32] ejegg: we have the central logs stored for longer for forensics though, is it possible there would be something useful logged that way [19:23:44] (03PS8) 10Cstone: Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 (owner: 10Wfan) [19:24:21] (03CR) 10Cstone: [V: 03+2 C: 03+2] Update smashpig port and add more queue like epf opt-in and unsubscribe [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995017 (owner: 10Wfan) [19:30:00] ejegg: I think I looked into that one before trying to see what was up trying to remember [19:32:44] (03PS4) 10Eileen: Rename WMFHelpers to WMFHelper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) [19:34:32] (03PS1) 10Eileen: Also move FinanceInstrumentTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995320 [19:35:09] (03CR) 10Eileen: "I think those are addressed" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [19:38:18] ejegg: just looking at fixing up https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/994353 & I wondered if we should remove the wmf in wmfQueueConsumer - since it's in the WMFQueue name space and the others don't have wmf [19:39:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10Ejegg) Hi @MBeat33 this case is now maybe too cold to figure out exactly why the message wasn't sent in this donor's case (the logs that woul... [19:44:35] (03PS5) 10Eileen: Rename WMFHelpers to WMFHelper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) [19:44:37] (03PS2) 10Eileen: Also move FinanceInstrumentTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995320 [19:44:39] (03PS4) 10Eileen: Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 [19:46:00] (03CR) 10Eileen: "I'm wondering about dropping the Wmf instead? Seems like all the WMFQueue contents are WMF...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (owner: 10Eileen) [19:54:25] (03PS1) 10Eileen: Apply IDE formattng, to avoid it getting into later patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995323 [19:54:27] (03PS1) 10Eileen: Apply IDE level formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995324 [19:54:29] (03PS1) 10Eileen: Apply IDE formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995325 [19:54:31] (03PS1) 10Eileen: Apply IDE level formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995326 [19:55:02] it might be able to mve the Queue classes if the IDE reformatting is done first ^^ - otherwise it keep sneaking in [20:02:47] (03CR) 10CI reject: [V: 04-1] Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (owner: 10Eileen) [20:05:20] 10Fundraising Sprint: brb(), 10Fundraising-Backlog, 10Patch-For-Review, 10Unplanned-Sprint-Work: FY2324 Q3: Need to map new Civi fields over to Acoustic - https://phabricator.wikimedia.org/T353386 (10KHaggard) Ok, great. @Eileenmcnaughton the data jobs for today completed and all 4 of them look good to me.... [20:08:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10Ejegg) Aha, there is ONE reason we wouldn't send it - if they already have another recurring donation active (via any processor, including Pa... [20:10:26] cstone: so it looks like maybe on_hold is the culprit here [20:11:59] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10Ejegg) For devs looking for more missing activities, here's some SQL: `lang=sql select cr.contact_id, cr.id, cr.cancel_date, aa.activity_date... [20:14:27] 10Fundraising Sprint: brb(), 10Fundraising-Backlog, 10FR-Email, 10FR-email-preference-center, and 2 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10AnnWF) @Ejegg are we deleting https://www.mediawiki.org/wiki/Extension:FundraisingEmai... [20:15:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10Ejegg) Aha, yeah, it is the on_hold status, we're just applying that filter in a different place than I would have expected (the 'Render' ste... [20:15:16] (03PS1) 10Eileen: Move normalize function to our new DonationMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995327 (https://phabricator.wikimedia.org/T356115) [20:15:18] (03PS1) 10Eileen: Move more normalize to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995328 (https://phabricator.wikimedia.org/T356115) [20:15:20] (03PS1) 10Eileen: More normalize functions moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995329 (https://phabricator.wikimedia.org/T356115) [20:16:00] cstone: found it: https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/Civi/Api4/Action/FailureEmail/Render.php$65 [20:16:31] eileen: sure, we don't need redundant Wmf in the class name if it's already in the namespace [20:17:40] (03CR) 10Ejegg: [C: 03+2] Rename WMFHelpers to WMFHelper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [20:18:00] (03CR) 10Ejegg: [C: 03+2] Also move FinanceInstrumentTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995320 (owner: 10Eileen) [20:19:46] ejegg: if you merge some of those ID format ones I can simplify the commit a bit when I re-fix the WMFQueue move one [20:20:10] (03PS1) 10Eileen: Move endowment gift check to normalize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995331 (https://phabricator.wikimedia.org/T356115) [20:24:05] (03PS2) 10Damilare Adedoyin: WIP: Check additional contribution details from Contribution Recur using rescue reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995136 (https://phabricator.wikimedia.org/T356224) [20:24:33] (03PS3) 10Damilare Adedoyin: Check additional contribution details from Contribution Recur using rescue reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995136 (https://phabricator.wikimedia.org/T356224) [20:28:01] (03PS2) 10Ejegg: Apply IDE formattng, to avoid it getting into later patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995323 (owner: 10Eileen) [20:28:20] (03CR) 10Ejegg: [C: 03+2] Apply IDE formattng, to avoid it getting into later patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995323 (owner: 10Eileen) [20:28:55] (03CR) 10Ejegg: [C: 03+2] Apply IDE level formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995324 (owner: 10Eileen) [20:29:43] (03CR) 10Ejegg: [C: 03+2] Apply IDE formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995325 (owner: 10Eileen) [20:30:12] (03CR) 10Ejegg: [C: 03+2] Apply IDE level formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995326 (owner: 10Eileen) [20:30:22] (03PS2) 10Ejegg: Apply IDE level formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995324 (owner: 10Eileen) [20:31:23] oh darn, there's a conflict with the WMFHelper patch in RecurringQueueConsumer [20:31:42] (03PS2) 10Ejegg: Apply IDE level formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995326 (owner: 10Eileen) [20:35:38] (03Merged) 10jenkins-bot: Rename WMFHelpers to WMFHelper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994876 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [20:41:32] (03Merged) 10jenkins-bot: Also move FinanceInstrumentTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995320 (owner: 10Eileen) [20:46:09] (03PS1) 10Eileen: Move date determination to DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995332 (https://phabricator.wikimedia.org/T356115) [20:46:11] (03PS1) 10Eileen: Standardise thank you date determination in DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995333 (https://phabricator.wikimedia.org/T356115) [20:46:30] (03Merged) 10jenkins-bot: Apply IDE formattng, to avoid it getting into later patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995323 (owner: 10Eileen) [20:46:48] (03CR) 10CI reject: [V: 04-1] Move date determination to DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995332 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [20:46:59] (03CR) 10CI reject: [V: 04-1] Standardise thank you date determination in DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995333 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [20:52:33] (03PS1) 10Eileen: Make campaigns module do it's own dirty work [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995334 (https://phabricator.wikimedia.org/T356115) [20:56:01] hmm eileen lots of merge conflicts now :( [20:56:28] (03PS2) 10Eileen: Apply IDE formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995325 [20:57:01] ejegg: yeah - I expected that - I have to re-fix that naming & figured I'd do it over the IDE cleanup to reduce the noise [20:57:26] k [20:57:37] (03CR) 10Ejegg: [C: 03+2] Apply IDE formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995325 (owner: 10Eileen) [21:02:21] (03PS5) 10Eileen: Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) [21:03:43] ejegg: hopefully I got it this time - I was just trying to make it so the commit wasn't full of stuff like https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/994353/5/drupal/sites/all/modules/queue2civicrm/opt_in/OptInQueueConsumer.php with toooo much git add -p work [21:06:46] (03PS2) 10Eileen: Move normalize function to our new DonationMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995327 (https://phabricator.wikimedia.org/T356115) [21:08:47] (03PS2) 10Eileen: Move more normalize to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995328 (https://phabricator.wikimedia.org/T356115) [21:11:35] (03PS3) 10Damilare Adedoyin: Move successful autorescue to recurring queue without reading from Pending db table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995038 (https://phabricator.wikimedia.org/T356224) [21:12:01] (03CR) 10CI reject: [V: 04-1] Move successful autorescue to recurring queue without reading from Pending db table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995038 (https://phabricator.wikimedia.org/T356224) (owner: 10Damilare Adedoyin) [21:12:08] (03PS2) 10Eileen: More normalize functions moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995329 (https://phabricator.wikimedia.org/T356115) [21:12:10] (03PS2) 10Eileen: Move endowment gift check to normalize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995331 (https://phabricator.wikimedia.org/T356115) [21:12:12] (03PS2) 10Eileen: Move date determination to DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995332 (https://phabricator.wikimedia.org/T356115) [21:12:15] (03PS2) 10Eileen: Standardise thank you date determination in DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995333 (https://phabricator.wikimedia.org/T356115) [21:12:40] 10Fundraising Sprint: brb(), 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q3 maintenance window - https://phabricator.wikimedia.org/T337581 (10AKanji-WMF) [21:12:42] 10Fundraising Sprint: brb(), 10Fundraising-Backlog, 10fundraising-tech-ops: Remove disabled custom fields - https://phabricator.wikimedia.org/T356443 (10AKanji-WMF) [21:13:25] 10Fundraising Sprint: brb(), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Tidy up our subscribe-links code on the civi side to make change easy - https://phabricator.wikimedia.org/T354585 (10AKanji-WMF) [21:13:40] 10Fundraising Sprint: brb(), 10Wikimedia-Fundraising-CiviCRM: add venmo username to TY email var and add to the end of it - https://phabricator.wikimedia.org/T350624 (10AKanji-WMF) [21:15:15] (03Merged) 10jenkins-bot: Apply IDE formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995325 (owner: 10Eileen) [21:17:18] (03PS4) 10Damilare Adedoyin: Move successful autorescue to recurring queue without reading from Pending db table [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/995038 (https://phabricator.wikimedia.org/T356224) [21:18:06] ejegg: do we still run that banner history queue consumer [21:19:06] yep eileen [21:19:14] we should move that table into Civi, huh? [21:19:51] (03CR) 10CI reject: [V: 04-1] Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:22:24] (03CR) 10CI reject: [V: 04-1] Move normalize function to our new DonationMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995327 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:24:45] (03CR) 10CI reject: [V: 04-1] Move more normalize to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995328 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:28:15] (03CR) 10CI reject: [V: 04-1] More normalize functions moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995329 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:28:56] (03CR) 10CI reject: [V: 04-1] Move endowment gift check to normalize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995331 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:28:58] (03CR) 10CI reject: [V: 04-1] Move date determination to DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995332 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:29:00] (03CR) 10CI reject: [V: 04-1] Standardise thank you date determination in DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995333 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:39:55] (03PS3) 10Ejegg: Remove auto rescue message from pending queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995034 (https://phabricator.wikimedia.org/T356224) (owner: 10Damilare Adedoyin) [21:40:01] (03CR) 10Ejegg: [C: 03+2] Remove auto rescue message from pending queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995034 (https://phabricator.wikimedia.org/T356224) (owner: 10Damilare Adedoyin) [21:44:36] (03PS6) 10Eileen: Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) [21:45:12] -ok cross fingers that ^^ is back on track [21:48:32] (03PS7) 10Ejegg: Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [21:48:44] just rebasing it on top of the one I just +2ed [21:48:49] cool [21:50:53] (03PS3) 10Eileen: Move normalize function to our new DonationMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995327 (https://phabricator.wikimedia.org/T356115) [21:51:16] (03PS3) 10Eileen: Move more normalize to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995328 (https://phabricator.wikimedia.org/T356115) [21:51:18] (03PS3) 10Eileen: More normalize functions moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995329 (https://phabricator.wikimedia.org/T356115) [21:51:20] (03PS3) 10Eileen: Move endowment gift check to normalize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995331 (https://phabricator.wikimedia.org/T356115) [21:51:22] (03PS3) 10Eileen: Move date determination to DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995332 (https://phabricator.wikimedia.org/T356115) [21:51:24] (03PS3) 10Eileen: Standardise thank you date determination in DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995333 (https://phabricator.wikimedia.org/T356115) [21:53:12] eileen: just one doubt - should the QueueHelper actually go into the WMFQueue namespace? [21:53:27] yeah that crossed my mind too [21:53:30] That's helping with core-civi-queue stuff, not WMF queue stuff [21:53:33] let's see what is in it [21:53:49] oh right - yeah [21:55:22] I'd lean towards Civi\Queue or maybe even WMFHelper\QueueHelper [21:56:07] though i guess it's likely to be upstreamed sometime? So maybe no need to worry much where it is right now [21:56:43] yeah - there is a class in WMFHelper but I guess we were seeing that as upstreamable [21:57:25] Well, I'm fine leaving it as is in the patch [21:57:31] the rest looks fine [21:57:43] lemme just pull it down and run the queue consume script [21:58:01] (03Merged) 10jenkins-bot: Remove auto rescue message from pending queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995034 (https://phabricator.wikimedia.org/T356224) (owner: 10Damilare Adedoyin) [21:58:21] (03PS8) 10Eileen: Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) [21:58:30] ejegg: I moved it up one - seems clearer to me [21:59:15] I'm inclined to move the other queue consumers into that folder - even though some of them still have drupal specific code in them [22:00:08] yep, sounds good. we'll get it out [22:02:35] (03PS4) 10Damilare Adedoyin: Check additional contribution details from Contribution Recur using rescue reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995136 (https://phabricator.wikimedia.org/T356224) [22:18:03] (03CR) 10CI reject: [V: 04-1] Move date determination to DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995332 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [22:18:40] (03CR) 10CI reject: [V: 04-1] Standardise thank you date determination in DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995333 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [22:19:52] (03CR) 10CI reject: [V: 04-1] Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [22:47:19] (03PS9) 10Eileen: Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) [22:48:05] ejegg: cross fingers that works - looks like at least the first few move patches are passing now too https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/995327/3 [22:48:43] the last couple I need to fix from the looks [23:04:29] (03CR) 10CI reject: [V: 04-1] Move Top queue objects to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/994353 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [23:42:52] 10Fundraising Sprint: brb(), 10Fundraising-Backlog: Investigation: Migrating historical SurveyMonkey data - https://phabricator.wikimedia.org/T337880 (10HNordeenWMF) Documenting our requirements if we are planning to retain the last 5 years of email address data: - Download and store response data for around...