[00:07:13] nice i have both too [00:07:29] woo! [00:08:01] (03CR) 10Cstone: [V: 03+2 C: 03+2] "yay getting both to load!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995122 (owner: 10Jgleeson) [00:08:35] (03CR) 10Cstone: [V: 03+2 C: 03+2] Add ./setup.sh --config-private build option [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995203 (owner: 10Jgleeson) [00:08:46] awesome [00:09:03] (03CR) 10Cstone: [V: 03+2] Update email-pref-ctr service to depend on donorprefsqueues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/995205 (owner: 10Jgleeson) [00:09:19] (03CR) 10Cstone: [V: 03+2 C: 03+2] "works well!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/997528 (owner: 10Jgleeson) [00:09:25] I was trying out damilare's suggestion to use the bind mounts so we don't have to run the sync between restarts and it works great [00:09:30] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rstearns - https://phabricator.wikimedia.org/T356942 (10Dwisehaupt) [00:09:34] I'm gonna push this up now before I drop off [00:10:04] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ayounsi - https://phabricator.wikimedia.org/T356943 (10Dwisehaupt) [00:10:28] hmm, after docker finish, wmff not loading for me haha will try again [00:10:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for wfan - https://phabricator.wikimedia.org/T356944 (10Dwisehaupt) [00:10:57] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dadedoyin - https://phabricator.wikimedia.org/T356945 (10Dwisehaupt) [00:11:22] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sxu - https://phabricator.wikimedia.org/T356946 (10Dwisehaupt) [00:11:31] (03PS1) 10Jgleeson: Detect Mac OS earlier in the setup [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998595 [00:25:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: PHP notices in Import Parser - https://phabricator.wikimedia.org/T356947 (10Ejegg) [00:27:02] (03PS6) 10Eileen: Add Queue Settings + navigation entries [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/997760 (https://phabricator.wikimedia.org/T356115) [00:27:16] (03PS1) 10Jgleeson: Mac improvements: use volume mounts instead of bind mounts. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998598 [00:27:26] (03PS7) 10Eileen: Add Queue Settings + navigation entries [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/997760 (https://phabricator.wikimedia.org/T356115) [00:28:11] cstone: wfan ^ I think that's all you will need now. I just tested a full install and then did docker compose down / docker compose up and both civis were fine along with everything else [00:28:27] cool will test now [00:28:44] if you hit any issues try deleting the old src files [00:28:51] or reclone/overwrite [00:28:58] catch you all tomorrow o/ [00:29:11] 10Fundraising-Backlog: Incorrect Gift Source - https://phabricator.wikimedia.org/T356894 (10Eileenmcnaughton) The spinning part might be this issue https://phabricator.wikimedia.org/T356930 [00:29:17] whoa Jack only just went to bed! [00:34:53] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for wfan - https://phabricator.wikimedia.org/T356944 (10Dwisehaupt) Renewed certificate and sent via email. Certificate and password files are in their home directory on frpm1002. [00:40:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: De-duplicate %context% in Civi log lines - https://phabricator.wikimedia.org/T356950 (10Ejegg) [00:41:44] ok, I need to sign off too [00:42:06] argh i was going to push up a civi update first [00:43:13] ah the tutorial extension needs a civix update too [00:43:51] !log fundraising civicrm upgraded from 98d35c79 to c66b04bd [00:43:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:52:39] here is my menu now.... https://usercontent.irccloud-cdn.com/file/RGihfrtS/image.png [00:53:05] niceeee eileen !!!! [00:53:13] :-) [00:53:15] nice! I see that damage table~ [00:53:30] Damaged messages doesn't work locally - but that is the url from prod I think [00:56:30] (03PS8) 10Eileen: Add Queue Settings + navigation entries [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/997760 (https://phabricator.wikimedia.org/T356115) [00:56:42] (03PS1) 10Ejegg: Civix updates for tutorial [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998600 [00:58:52] ejegg: are those civix updates done upstream? I wondered that on system tools too [00:59:20] eileen: ah we have an upstream repo for systemtools? [00:59:27] I think so [00:59:27] I did submit the tutorial one upstream [00:59:31] cool [01:00:21] hmm, all the urls for systemtools are still http://FIXME [01:00:26] (not even https!!!) [01:00:40] so I'm not sure where else we would be hosting it [01:00:44] your github perhaps? [01:01:21] oh, https://lab.civicrm.org/extensions/systemtools.git [01:01:35] forking [01:03:35] oh, there were other upstream updates [01:06:45] hmm eileen or maybe there was more updated locally than you had in gitlab [01:07:00] oh well, I'll try to sort that out tomorrow [01:07:06] so long! [01:19:23] jgleeson|away looks great, works fine locally with --full [01:19:41] (03CR) 10Wfan: [C: 03+2] Detect Mac OS earlier in the setup [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998595 (owner: 10Jgleeson) [01:20:36] (03PS2) 10Wfan: Detect Mac OS earlier in the setup [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998595 (owner: 10Jgleeson) [01:20:56] (03PS2) 10Wfan: Mac improvements: use volume mounts instead of bind mounts. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998598 (owner: 10Jgleeson) [01:25:52] (03CR) 10Wfan: [V: 03+2 C: 03+2] Detect Mac OS earlier in the setup [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998595 (owner: 10Jgleeson) [01:26:07] (03CR) 10Wfan: [C: 03+2] Mac improvements: use volume mounts instead of bind mounts. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998598 (owner: 10Jgleeson) [01:26:10] (03CR) 10Wfan: [V: 03+2 C: 03+2] Mac improvements: use volume mounts instead of bind mounts. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998598 (owner: 10Jgleeson) [01:33:21] (03PS8) 10Wfan: Automatically detect MacOS. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/997528 (owner: 10Jgleeson) [01:34:18] (03CR) 10Wfan: [C: 03+2] Automatically detect MacOS. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/997528 (owner: 10Jgleeson) [01:34:20] (03CR) 10Wfan: [V: 03+2 C: 03+2] Automatically detect MacOS. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/997528 (owner: 10Jgleeson) [01:57:44] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for wfan - https://phabricator.wikimedia.org/T356944 (10AnnWF) 05Openโ†’03Resolved [01:57:58] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for wfan - https://phabricator.wikimedia.org/T356944 (10AnnWF) Done, thanks Dallas [02:29:42] (03CR) 10Eileen: [C: 03+2] Civix updates for tutorial [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998600 (owner: 10Ejegg) [02:34:07] eileen: looks like systemtools upstream was a ways behind gerrit [02:34:22] ah [02:34:31] i just made an omnibus merge request cause i was too lazy to do each patch separately [02:34:37] do I have one upstream repo or 2... sometimes I have github & gitlab.... [02:34:40] what with the different path roots [02:34:43] oh hah [02:34:53] well now there's a MR against gitlab [02:35:18] oh dear ..... https://github.com/eileenmcnaughton/org.wikimedia.systemtools [02:35:23] I'll sort it anyway [02:49:58] (03Merged) 10jenkins-bot: Civix updates for tutorial [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998600 (owner: 10Ejegg) [02:55:52] (03Abandoned) 10Ejegg: Move recurring c_t helper function to new extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/992214 (https://phabricator.wikimedia.org/T270672) (owner: 10Ejegg) [03:01:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10Ejegg) OK @krobinson and @MBeat33 we have updated the logic to attempt sending the recurring failure email including to contacts whose email... [07:09:43] 10Fundraising-Backlog: New country South Korea via Adyen - https://phabricator.wikimedia.org/T356962 (10RKumar_WMF) [07:19:36] 10Fundraising-Backlog: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963 (10RKumar_WMF) [08:04:23] 10Fundraising-Backlog: Civi Summary Page Edit Issue - https://phabricator.wikimedia.org/T356930 (10Peachey88) [08:17:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10krobinson) Awesome - thank you! [12:53:37] uhh wonder why the damage table isn't working [12:55:12] attempting a reinstall of the extension [12:55:53] ok that fixed it [12:56:21] and the detail pop up is now rendering without errors [12:57:04] ohh but the drupal one is still broken [13:03:56] seems to be caused by a missing import, I'd push up a patch for that [13:05:59] ahh that import isn't missing [13:30:58] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM thanks for this." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995092 (https://phabricator.wikimedia.org/T356433) (owner: 10Eileen) [13:48:49] (03Merged) 10jenkins-bot: Remove legacy engage role code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995092 (https://phabricator.wikimedia.org/T356433) (owner: 10Eileen) [13:58:17] damilare|brb: something missing on fundraising-dev? [14:03:16] jgleeson: nah this was on production after ejegg deployed the extension updates lat night [14:03:20] is* [14:03:36] oh right [14:03:41] lemme know if you need any review [14:04:02] I'm here but just on the other comp, my mac [14:04:21] sure no p, nothing yet at the moment [14:07:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Ensure new ContributionRecur rows have a financial_type_id - https://phabricator.wikimedia.org/T356999 (10Ejegg) [14:19:43] damilare|brb: so the drupal one needs us to add a civicrm_initialize() a bit earlier in that function I think [14:22:53] anilk: I added some more info to the 'internal referrers' doc here: https://docs.google.com/document/d/1qlDgWvOdlCIp-EFwVUm9Ns8B67gCzRclG0_-Z4hFs-k/edit [14:23:09] I almost asked you where to find that doc - should we put it on wiki someplace? [14:24:57] damilare|brb: and for the drupal damaged link to work on dev we need to add the smashpig connection string to the drupal databse config [14:25:35] interestingly, the individual damaged message links from failmail DO still work on prod, it's just the search display that's broken [14:31:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig: Standardize message and time limit options for all scripts - https://phabricator.wikimedia.org/T357001 (10Ejegg) [14:32:10] ahh okk, that makes sense. Just remember you said that yesterday. I'd add that [14:33:18] I think we are looking to deprecate the UI, but I want to run a comparison with the new UI first [14:33:43] so would be good to have it working for a bit [14:36:18] ok, I'll make a lil patch [14:36:36] oh sorry you said you would [14:36:41] go for it, i'll review [14:36:53] get in line ha [14:37:08] :) [14:40:12] (03PS1) 10Damilare Adedoyin: Fix Drupal Damaged UI [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998935 [14:40:21] (03PS1) 10Ejegg: Change --max-messages to --message-limit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/998936 (https://phabricator.wikimedia.org/T357001) [14:41:19] (03PS2) 10Ejegg: Fix Drupal Damaged UI [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998935 (owner: 10Damilare Adedoyin) [14:41:27] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998935 (owner: 10Damilare Adedoyin) [14:41:31] looks easy enough! [14:42:05] fr-tech I've got a lil chain of SmashPig patches to review if anyone has some time: https://gerrit.wikimedia.org/r/998936 [14:43:40] :) thanks for the speedy review๐Ÿ˜‚ [14:58:36] (03Merged) 10jenkins-bot: Fix Drupal Damaged UI [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998935 (owner: 10Damilare Adedoyin) [14:59:23] (03PS1) 10Ejegg: Add drupal connection string for smashpig db [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998943 [14:59:42] fr-tech ^^^ should make the drupal damaged message UI work locally [14:59:53] (https://wmff.localhost:32353/damaged) [15:02:57] (03PS2) 10Ejegg: Add drupal connection string for smashpig db [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998943 [15:03:42] (03PS2) 10Ejegg: Suppress project name prompt once set [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998436 [15:03:44] (03PS2) 10Ejegg: Skip proxy forward prompt when set, validate [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998439 [15:04:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig, 10Patch-For-Review: Standardize message and time limit options for all scripts - https://phabricator.wikimedia.org/T357001 (10Ejegg) [15:05:33] oops those suppress prompt ones were already C+2ed [15:05:38] will just merge em [15:05:49] (03PS3) 10Ejegg: Suppress project name prompt once set [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998436 [15:05:59] (03CR) 10Ejegg: [V: 03+2] Suppress project name prompt once set [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998436 (owner: 10Ejegg) [15:06:08] (03PS3) 10Ejegg: Skip proxy forward prompt when set, validate [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998439 [15:06:12] (03CR) 10Ejegg: [V: 03+2] Skip proxy forward prompt when set, validate [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/998439 (owner: 10Ejegg) [15:31:35] (03PS1) 10Ejegg: Fix default financial_type_id for recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998952 (https://phabricator.wikimedia.org/T356999) [15:31:37] (03PS1) 10Ejegg: Backfill ContributionRecur financial type id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998953 (https://phabricator.wikimedia.org/T356999) [15:47:41] (03PS1) 10Ejegg: Update Contact Layout Editor to 2.2.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998990 [15:50:08] (03CR) 10CI reject: [V: 04-1] Fix default financial_type_id for recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998952 (https://phabricator.wikimedia.org/T356999) (owner: 10Ejegg) [15:50:46] (03CR) 10CI reject: [V: 04-1] Backfill ContributionRecur financial type id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998953 (https://phabricator.wikimedia.org/T356999) (owner: 10Ejegg) [15:54:27] hmm [16:00:58] (03PS1) 10Ejegg: Install Import Extensions on new WMFF build [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998995 [16:07:50] (03PS4) 10Ejegg: Move decode to construct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995389 (owner: 10Eileen) [16:07:52] (03CR) 10Ejegg: [C: 03+2] Move decode to construct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995389 (owner: 10Eileen) [16:28:55] (03Merged) 10jenkins-bot: Move decode to construct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995389 (owner: 10Eileen) [16:29:55] (03CR) 10Damilare Adedoyin: [C: 03+1] "LGTM, +1'ing to make space for anyone else currently reviewing." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/998936 (https://phabricator.wikimedia.org/T357001) (owner: 10Ejegg) [16:39:10] (03CR) 10Cstone: [C: 03+2] Remove unused token migration action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995134 (owner: 10Ejegg) [16:41:13] (03CR) 10Cstone: [C: 03+2] "This is really helpful to just have in general, we should do something like this for other implementations we do!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997969 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [16:50:54] (03CR) 10Damilare Adedoyin: [C: 03+2] Install Import Extensions on new WMFF build [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998995 (owner: 10Ejegg) [16:53:15] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rstearns - https://phabricator.wikimedia.org/T356942 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [16:59:49] (03Merged) 10jenkins-bot: Remove unused token migration action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995134 (owner: 10Ejegg) [16:59:51] (03Merged) 10jenkins-bot: Test data for Adyen JSON IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997969 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [17:22:39] (03CR) 10Damilare Adedoyin: [C: 03+2] Change --max-messages to --message-limit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/998936 (https://phabricator.wikimedia.org/T357001) (owner: 10Ejegg) [17:28:16] 10Fundraising-Backlog: Enable Post-Payment Monthly Convert for CL, CO, MX, PE, UY, BR - https://phabricator.wikimedia.org/T356277 (10Dwisehaupt) [17:29:51] 10Fundraising-Backlog: Investigate whether we can use mysql EXPLAIN checks to prevent runaway dedupe queries - https://phabricator.wikimedia.org/T355807 (10Dwisehaupt) Changing to spike after discussion in standup. [17:30:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448 (10Dwisehaupt) [17:35:42] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dadedoyin - https://phabricator.wikimedia.org/T356945 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [17:39:09] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jmando - https://phabricator.wikimedia.org/T356126 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [17:47:39] (03PS2) 10Ejegg: Change --max-messages to --message-limit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/998936 (https://phabricator.wikimedia.org/T357001) [17:49:08] (03PS2) 10Ejegg: Install Import Extensions on new WMFF build [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/998995 [17:57:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Miss update venmo username for existing customers - https://phabricator.wikimedia.org/T357034 (10AnnWF) [18:24:07] I'm going to deploy that SmashPig message-limit patch [18:41:25] !log jobs disabled for option change [18:41:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:45:26] fr-tech I've just pushed a change to process-control. Want to see if that's right? All the SmashPig scripts should be changed to use message-limit rather than max-messages [18:45:35] oh I should update the other server config too [18:49:52] !log standalone SmashPig upgraded from 20d6434e to 669a9fe3 [18:49:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:51:59] sure ejegg [18:52:15] thanks cstone ! [18:52:24] it's actually the last two commits now [18:55:35] looks good ejegg [18:56:25] thanks cstone [18:58:00] !log re-enabled fundraising scheduled jobs [18:58:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:06:53] fr-tech this should help get donut-wiki loading (and more importantly keep donatewiki from failing as soon as it's updated!) [20:07:18] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/999067?usp=dashboard [20:08:01] dwisehaupt: I think I removed some points by mistake on a thing I was editing while we were estimating [20:08:05] lemme try to find it [20:08:17] (this was yesterday) [20:10:35] found it T356373 [20:10:36] T356373: Send thank you email confirming recurring donation upgrade - https://phabricator.wikimedia.org/T356373 [20:12:02] thank you stashbot. Not slacking on the job like wikibugs, I see! [20:18:48] oh. ok. i can look in poinz and find out what we rated it as. [20:19:03] how do we get wikibugs to love us again [20:19:42] looks like it was a 4. i'll update. [20:20:06] oh, it's already a 4. so we're ok. [20:20:27] yeah, i just read it from the history on the page [20:21:19] fr-tech we probably should get this out ASAP: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/999067 [20:21:26] also, almost at gerrit one million [20:21:44] * ejegg furiously spams patches [20:22:23] gogo ejegg just 900 more! [20:23:50] ejegg: I +2d ^ since wikibugs has forsaken us :P [20:29:11] thanks cstone! [20:41:01] eileen: any thoughts on whether the financial_type_id should be 'Recurring Gift' for the contribution_recur row? [20:41:45] Looks like that's what it'll use if we go with the ID passed in via the message from the 'normal' (not monthly conver) flow [20:43:05] seems redundant [20:43:21] I think I'll have it ignore the passed-in id and just hard-code cash [20:49:28] yep, confirmed, that'll match processSubscriptionSignup [20:52:15] ah was it monthly convert that had it missing? [20:52:34] no, MC had it, it was organic recurring that was missing [20:52:45] so most of the recurrings in the DB have null there [20:52:55] ahh [20:52:58] but I've got a patch to backfill [20:53:11] using that snazzy new queueSql to do it in batches with coworker [20:53:36] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/998952 Fix default financial_type_id for recurring [20:53:39] i think we could just do it in search kit [20:53:43] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/998953 Backfill ContributionRecur financial type id [20:53:43] if you dont want a patch [20:53:47] it's like a million rows [20:53:50] now you have to be wikibugs [20:53:55] haha yeah [20:54:02] ahh million hah! [20:54:27] my wiki bugs of renaming one thing for emailpreferences [20:54:27] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/999074 [20:54:31] * ejegg puts pinky to side of mouth [20:54:36] ONE MILLION ROWS [20:55:22] ahh it was hardcoded!! [20:55:35] it was in the part that worked! [20:55:41] haha [20:55:45] so I'mma hardcode it in the other part too [20:56:00] since we don't do recurring stock gifts [20:56:12] or at least not in a way that they get a contribution_recur row [20:57:03] oh lemme run those tests that failed on PS1 locally [20:58:05] k, worked locally [20:58:58] oh i C+2ed your rename patch [20:59:07] i was about to do a deploy [20:59:26] i'll do that too so we change the var while it's fresh on our minds [21:00:02] i dont think that wg exists [21:00:08] i couldnt find it at least [21:00:28] ah yeah, we're just using the default then [21:02:41] sorry ejegg is there something you wanted me to +2 no wikibugs is really difficult I was trying to find documentation on it haha [21:03:35] lol if you want to review the financial_type_id ones that would be great [21:03:41] ok [21:03:58] just make a 'normal' recurring (non-mc) consume queues and look at the record [21:04:07] should get 'Cash' as the financial type [21:04:35] then for the backfill one you need at least one null row (i.e. a regular recurring imported before the first patch) [21:04:59] and click the extension upgrade button ,then go into the drush container and run 'coworker run' [21:11:28] do we want the recur financial type ot be different than the contribution financial type ejegg ? [21:12:07] cstone: so the contribution financial type is different between installment 1 and installment 2 [21:12:26] 'Recurring Gift' vs 'Recurring Gift - Cash' [21:12:35] I was never clear on why they needed that [21:12:36] ok and i did not ever understand that [21:12:38] haha ok [21:12:39] me too! [21:13:30] https://phabricator.wikimedia.org/T341370 [21:14:07] That was the old discussion of the different codes [21:14:33] so instead of trying to choose one of those I just figured we could hard-code the same thing as we're hardcoding in the other place [21:14:41] hmm yeah i still dont understnd the distinction between first and second though [21:14:46] yeah ejegg I +2d [21:14:51] something with reporting I guess? [21:31:06] hmm actually ejegg i ran that extension upgrade but it didnt update [21:31:13] lemme check waht im on though [21:31:41] 4450 [21:31:43] you need coworker rum after that [21:31:47] ah haaa [21:31:57] you made it fancy i already forgot! [21:32:05] :) [21:32:18] just glad that fancy is easy now [21:32:44] cool [21:33:17] btw, I asked in -cloud about wikibugs, hopefully someone can kick it [21:33:32] ahh is that what we needed to do greg-g ? [21:34:12] yeah, I think so, they generally have access to all of the tools on toolhub. I used to have access to wikibugs but I think it was dropped at some point [21:34:33] and it's running in other channels, so I wasn't sure if I would need to do more than a restart [21:34:40] more/less [22:00:46] maybe i'll wait till tomorrow to deploy that / run the upgrade since it'll be hitting contribution_recur rows [22:07:54] oh weird, i can only request review from one person at a time in gitlab [22:09:08] ooh darn, (wmf-civicrm) has a missing dependency on "import_extensions" [22:09:39] ah right it wasn't installed [22:10:24] i could not figure out how to merge it ejegg because I was not logged in ๐Ÿ™ƒ [22:23:39] lol [22:24:16] ah yeah, we spam ppl's email when we assign them in gitlab [22:24:47] * ejegg feels creaky after a day working at the dining room table [22:25:01] let's see how standing up goes [22:25:20] standing up desk that is [22:25:28] i'm not so creaky as all that [22:26:25] ooh, dish drainer is a good height when using the external kayboard [22:26:34] but this kitchen counter is not a good mousing surface [22:27:39] yeah my old aparmtnet i had a good kitchen laptop height but here nothing is setup nicely [22:30:51] belated thanks ejegg -yeah - documentation for in progress things is a thing - we sometimes use phab to talk things out, sometimes etherpads - I know other teams do use wikis for every feature (like the growth team) - and that makes sense from a transparency perspective. I can at least keep things in our shared folder...open to thoughts! [22:31:52] alright, if someone wants to make an update to a phab task, hopefully wikibugs is fixed (it doesn't join until it needs to, afair) [22:33:44] hmmm, I just set the priority of a chaos crew task and it didn't announce here [22:36:39] just submitted a new patch set to the CRM repo [22:37:05] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/999100 Rename donation queue consumer params [22:39:33] and not a peep greg-g [22:39:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: PHP notices in Import Parser - https://phabricator.wikimedia.org/T356947 (10greg) p:05Triageโ†’03Medium [22:39:43] wahoo [22:39:44] oh hi! [22:39:55] the big hammer fixed it :) [22:39:59] (03PS2) 10Ejegg: Rename donation queue consumer params [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999100 (https://phabricator.wikimedia.org/T357001) [22:40:24] thanks for weilding it bd808 [22:40:45] percussive maintenance is one of my specialties [22:41:01] wiki bugsssss!!! [22:41:14] thanks bd808 !! [22:52:03] (03PS1) 10Cstone: Standardize emailpreferences naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/999116 [22:52:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: De-duplicate %context% in Civi log lines - https://phabricator.wikimedia.org/T356950 (10Ejegg) [22:52:35] eileen: any thoughts on how we can de-duplicate the log context when we're NOT logging an exception? https://phabricator.wikimedia.org/T356950 [22:53:43] ejegg: there is a Monolog Syslog extension - not sure if that helps? [22:54:35] eileen: see the ticket, the SyslogFormatter is in 3.0 which needs php 8.1 [22:54:46] ah [22:55:06] ah right, i should make a pull request for php-queue to work with 3.0 too [22:55:43] just in case the maintainer isn't as quick on the response as he was oh 3 years ago when I added 2.x [22:55:44] I wonder what it actually does differently [22:56:02] I never checked - just assumed it would be better [22:57:28] thanks for the merge cstone! [22:58:57] (03PS1) 10Cstone: Lost an e [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/999121 [22:59:00] bah ejegg I had a typo in that first rename ^ [23:00:49] or anyone really haha [23:02:10] oooops [23:02:33] (03CR) 10Ejegg: [C: 03+2] Lost an e [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/999121 (owner: 10Cstone) [23:02:54] thanks ejegg [23:04:23] (03Merged) 10jenkins-bot: Lost an e [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/999121 (owner: 10Cstone) [23:05:29] (03PS2) 10Cstone: Standardize emailpreferences naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/999116 [23:12:46] oh no one of our variables in named emailprefs haha [23:15:30] (03PS1) 10Cstone: Standarize emailpreferences naming for opt in [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/999123 [23:21:22] (03PS1) 10Cstone: Standardize emailPreferences name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999125 [23:23:01] (03PS1) 10Ejegg: Update parameter names for ty drush job [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999130 (https://phabricator.wikimedia.org/T357001) [23:28:18] TY is not a queue consumer but the double meaning of 'message' makes that make sense ^^^ [23:28:42] however the dedupe job uses --batch and there's really no way --message-limit fits there [23:29:12] omnimail_load uses just 'limit' [23:29:36] as do the major_gifts_addresses jobs [23:30:04] seems fine to leave that as 'limit' i guess [23:30:43] eileen: does that update_language.yaml still need to exist? [23:30:55] seems to be changing da_** to da_DK [23:31:29] ah i see, it's disabled [23:31:32] that feels like a very early version of message clean up efforts - I think we got it 'done' when wfan went through? [23:31:40] cool cool [23:31:43] i'll clean it up [23:33:34] eileen are you OK with these two patches as preliminaries to changing / deleting the drupal vars ? https://gerrit.wikimedia.org/r/999130https://gerrit.wikimedia.org/r/999130 and parent [23:34:45] ejegg: looks OK - is there some juggling on deployment? [23:34:54] yep, gotta update yamls [23:35:08] I just did that for the SmashPig-based process-control scripts and it went fine [23:35:29] (03CR) 10Eileen: [C: 03+2] Update parameter names for ty drush job [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999130 (https://phabricator.wikimedia.org/T357001) (owner: 10Ejegg) [23:36:11] (03CR) 10Eileen: [C: 03+2] Rename donation queue consumer params [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999100 (https://phabricator.wikimedia.org/T357001) (owner: 10Ejegg) [23:41:04] thanks eileen ! [23:41:35] I'll deploy those tomorrow, as there is another patch in deploy that will queue up a million contribution_recur updates [23:41:48] and right before the charge jobs start seems like a bad time for that [23:44:52] feeling pretty beat, gonna call it a day [23:44:55] see you later! [23:53:29] (03Merged) 10jenkins-bot: Rename donation queue consumer params [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999100 (https://phabricator.wikimedia.org/T357001) (owner: 10Ejegg) [23:54:23] (03Merged) 10jenkins-bot: Update parameter names for ty drush job [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/999130 (https://phabricator.wikimedia.org/T357001) (owner: 10Ejegg)