[01:44:35] !log civicrm upgraded from 497e0899 to 3ee91f59 [01:44:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:44:57] (03PS4) 10Eileen: Schema updates on newly defined fredge api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003102 (https://phabricator.wikimedia.org/T357469) [06:24:31] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1003170 (owner: 10L10n-bot) [06:37:16] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ppenloglou - https://phabricator.wikimedia.org/T357359 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [08:26:01] (03CR) 10Wangombe: Update reference to namespaced MessageGroupMetadata::class (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [12:51:52] 10Fundraising-Backlog, 10Domains, 10SRE, 10serviceops: Request donatewiki redirect - https://phabricator.wikimedia.org/T357436 (10AKanji-WMF) Thank you @RLazarus ! The fundraising team would like the redirect to be active for two years - considering the life cycle of the podcast and surrounding marketing c... [12:59:07] 10Fundraising-Backlog: Add scripts to backup and restore civicrm db to fundraising-dev - https://phabricator.wikimedia.org/T357315 (10jgleeson) [13:02:52] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10Damilare) [13:04:55] (03CR) 10Jgleeson: [V: 03+2] Update civicrm-core build to copy ~/.gitconfig to container. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1002669 (owner: 10Jgleeson) [13:05:46] (03PS3) 10Damilare Adedoyin: Switch AntifraudQueueConsumer from drupal insert to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003105 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [13:06:50] (03PS1) 10Jgleeson: Add restore db scripts for civicrm and civicrm-core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003412 (https://phabricator.wikimedia.org/T357315) [13:07:27] damilare: that's something similar to what we spoke about when reviewing those patches on Monday ^^ [13:08:04] ahh for the tests [13:08:19] yeah and just general restorability [13:08:34] we should only really need when something unexpected happens [13:09:06] lookingyep [13:09:20] noticed you added the .backup directory to the gitignore [13:09:29] but the file still made it to the commit [13:09:41] was that that intentional? [13:10:09] the ignore line should be targeting the sql files only [13:10:13] ahh [13:10:15] I see [13:10:25] the gitkeep retains the directory [13:10:25] we don't wanna commit those as they could be large [13:10:29] ya [13:10:57] testing it out [13:11:39] I was just gonna test it out on mac before moving on but I'll let you do that if you already are :) saves me getting it back out [13:13:36] I was testing the restore by installing from fresh and then editing a demo contact record visible in the contributions dashboard and then running the restore to confirm it was changed back [13:14:44] ahh I was just going to add/delete some new rows and do the restore [13:14:46] I also did the broken test use-case. I forced stopped the tests half way through and then rerun them to confirm it leaves the broken fixture data. After restoring the db tests worked [13:19:04] (03CR) 10Damilare Adedoyin: [C: 03+2] Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [13:21:06] jgleeson: do I need a fresh install of civi for this to work [13:32:27] (03Merged) 10jenkins-bot: Update reference to namespaced MessageGroupMetadata::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/980983 (https://phabricator.wikimedia.org/T353420) (owner: 10Wangombe) [13:48:54] yeah damilare checks the commit message [13:49:02] either --civicrm or --civi-core [14:02:09] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Add scripts to backup and restore civicrm db to fundraising-dev - https://phabricator.wikimedia.org/T357315 (10jgleeson) [14:02:27] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Add scripts to backup and restore civicrm db to fundraising-dev - https://phabricator.wikimedia.org/T357315 (10jgleeson) a:03jgleeson [14:11:52] (03PS1) 10Jgleeson: Remove duplicated '**** MacOS Detected:' announcement [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003422 [14:12:59] Ok that wirjs [14:13:02] works* [14:13:10] awesome [14:13:22] really handy to have that around [14:13:49] can we extend it to smashpig as well [14:15:24] yeah anytime we run into issues and we'd like back restore the db we could use that approach [14:15:38] at least we know after a fresh install it should be good [14:16:52] yep [14:17:11] (03CR) 10Damilare Adedoyin: [C: 03+2] Add restore db scripts for civicrm and civicrm-core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003412 (https://phabricator.wikimedia.org/T357315) (owner: 10Jgleeson) [14:17:18] (03CR) 10Damilare Adedoyin: [V: 03+2 C: 03+2] Add restore db scripts for civicrm and civicrm-core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003412 (https://phabricator.wikimedia.org/T357315) (owner: 10Jgleeson) [14:17:47] (03CR) 10Damilare Adedoyin: [C: 03+2] Fix `./setup down` command for MacOS [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003421 (owner: 10Jgleeson) [14:17:51] (03CR) 10Damilare Adedoyin: [V: 03+2 C: 03+2] Fix `./setup down` command for MacOS [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003421 (owner: 10Jgleeson) [14:18:16] damilare: just a heads up. if you ever need to clear out the mac-specific volume mounts in the event something in buildkit or civi code isn't updating as you expect, you can use `./setup drop` . It's the same as using docker compose down -v (-v clears volumes) but it will automatically select the docker-compose-mac.yml config too [14:18:41] ahh that makes sense [14:18:48] thanks for the review! [14:19:05] np [14:26:21] jgleeson: is there a documentation for the new fundraising dev process. I want to update this restore process and also checkout one of eileen's patch. [14:26:49] I'm updating the README at the moment so we can paste that to the docs once done I think [14:26:52] or summarise [14:26:56] or even just link to [14:30:13] yep, thanks! [14:59:47] 10Fundraising-Backlog, 10Domains, 10SRE, 10serviceops: Request donatewiki redirect - https://phabricator.wikimedia.org/T357436 (10AKanji-WMF) Tagging you @Dwisehaupt as Jeff is out this AM. [15:07:27] damilare: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1003443 [15:08:01] probably best reading that in your IDE [15:08:22] or https://gerrit.wikimedia.org/g/wikimedia/fundraising/dev/+/refs/changes/43/1003443/2/README.md [15:09:13] https://gerrit.wikimedia.org/g/wikimedia/fundraising/dev/+/refs/changes/43/1003443/3/README.md * [15:12:02] damilare: I remembered ejegg|afk made a start on this https://wikitech.wikimedia.org/wiki/Fundraising/Development_tools/Fundraising-dev so it might be worth updating that in case you were thinking about adding new docs for the stack [15:12:35] I think a lot of those errors mentioned will have gone away [15:13:00] the "Install docker-compose" ones [15:14:42] jgleeson, cool. this looks good, only part missing are the mac script instructionsls. [15:14:52] nevermind seen them [15:15:05] good point though [15:15:37] if we get that merged we could add a follow on patch with mac-specific instructions on why/how the sync thingy works [15:15:41] do you also see this error during the sync: chown: changing ownership of '/srv/civi-sites/wmff/vendor/wikimedia/civicrm-data-table-provider/.git/objects/pack/pack-31b8accb60972e3b2c183eb01cbce95198b821ce.idx': Permission denied [15:15:51] ok sure... [15:16:10] oh I haven't tried the sync lately. lemme check [15:20:35] spotted a few typos [15:20:50] will push up corrections now [15:21:05] awesome! [15:21:28] wait do you mean in this patch? [15:21:49] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1003443 [15:21:55] yeah in the README updates [15:22:03] just fixed 'em [15:27:49] hi fr-tech! [15:28:01] civi prod is saying 'extension updates should be run as soon as possible' [15:28:05] is it ok to run those now? [15:28:12] or are we deferring them for some reason? [15:28:56] not that I'm aware of ejegg [15:29:04] well, here goes! [15:29:56] ah i see it was just copying a few drupal vars to civi settings [15:34:21] ah looks like that add github remotes script doesn't work on the mac [15:40:45] hmm no Jeff or Dallas yet to turn off that icinga failmail that we've had all day [15:41:51] ah let me see if I can ack it jgleeson [15:42:10] oh what is that alarm triggered by? [15:42:35] recurring_contrib_processing=6 [15:42:50] I think that means there are 5 contribution recur rows in processing status [15:42:51] adyen has been having intermittent failures [15:43:08] ok, i will ack for now [15:43:12] then look at the recur rows [15:43:21] and see which have been charged and which not [15:43:30] then try to put them in the right status [15:43:37] when I try to ack I get permission denied [15:44:18] d'oh, me too [15:44:27] ok, I'll just start looking at the rows then [15:46:51] oh man. macOS is running bash 3.2 by default which is from 2006. Linux distros run bash 4.0 released 2009. That script uses associative bash arrays that aren't available until bash 4. it's 2024 Apple.... [15:47:39] damilare|brb: wfan what version do you see when you run `bash --version` on the cli? [15:47:54] maybe I'm on an old mac OS [15:48:44] I'm on Sonoma [15:48:54] GNU bash, version 3.2.57(1)-release (arm64-apple-darwin23) [15:48:55] Copyright (C) 2007 Free Software Foundation, Inc. [15:49:06] ah ok I guess it is the default [15:49:08] thanks wfan [15:49:12] that's my M1, np [15:49:15] ok I need to fix that [15:52:53] is that cause they what switched shells a while ago [15:56:41] not sure [15:56:45] maybe [15:57:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), 10Patch-For-Review: Issue with bank transfer payments in Brazil - https://phabricator.wikimedia.org/T355371 (10AnnWF) [ { "id": "I", "type": "BANK_TRANSFER", "name": "Itau",... [16:05:19] thanks damilare|brb for the review! [16:06:56] MacOS folks I just pushed up a fix to the add-github-remotes script that fixes things on mac. To test, run ./scripts/add-github-mirror-remotes.sh and if it doesn't blow up it worked :) [16:08:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Deduper causing deadlocks - https://phabricator.wikimedia.org/T355677 (10jgleeson) a:03jgleeson [16:10:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Deduper causing deadlocks - https://phabricator.wikimedia.org/T355677 (10jgleeson) This feels related to {T355807}, so I'll take a look at that whilst on this. [16:47:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ehughes - https://phabricator.wikimedia.org/T357362 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [16:51:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10AnnWF) [16:57:44] (03Merged) 10jenkins-bot: Add function visibily, type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002642 (owner: 10Eileen) [16:59:11] (03Merged) 10jenkins-bot: Move Optin Queue Consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002643 (owner: 10Eileen) [17:00:56] (03CR) 10Jgleeson: [C: 03+2] "LGTM! Working locally for me" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002644 (owner: 10Eileen) [17:03:04] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002675 (owner: 10Eileen) [17:23:39] (03Merged) 10jenkins-bot: Move refundQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002644 (owner: 10Eileen) [17:23:41] (03Merged) 10jenkins-bot: IDE formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002675 (owner: 10Eileen) [17:24:02] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for expediting work on this wfan. Looks good to me" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1003113 (https://phabricator.wikimedia.org/T355371) (owner: 10Wfan) [17:25:36] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for all the work on this. LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003102 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [17:34:32] (03Merged) 10jenkins-bot: Based on dlocal payment_method api get the enalbed bt for brazil [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1003113 (https://phabricator.wikimedia.org/T355371) (owner: 10Wfan) [17:35:04] thanks dami!! [17:44:38] (03Merged) 10jenkins-bot: Schema updates on newly defined fredge api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003102 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [18:01:11] PROBLEM - check_mysql on payments1006 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1006&service=check_mysql [18:06:11] PROBLEM - check_mysql on payments1006 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1006&service=check_mysql [18:11:11] PROBLEM - check_mysql on payments1006 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1006&service=check_mysql [18:13:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for pcoombe - https://phabricator.wikimedia.org/T357361 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [18:16:11] RECOVERY - check_mysql on payments1006 is OK: Uptime: 157 Threads: 7 Questions: 11309 Slow queries: 0 Opens: 103 Open tables: 97 Queries per second avg: 72.031 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1006&service=check_mysql [18:20:59] (03CR) 10Damilare Adedoyin: [C: 03+2] Switch AntifraudQueueConsumer from drupal insert to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003105 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [18:34:50] 10Fundraising-Backlog, 10Domains, 10SRE, 10serviceops: Request donatewiki redirect - https://phabricator.wikimedia.org/T357436 (10Dwisehaupt) @RLazarus Does this really need an apache config patch or just an update to the redirect rules in `hieradata/common/mediawiki.yaml`? [18:39:37] (03Merged) 10jenkins-bot: Switch AntifraudQueueConsumer from drupal insert to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003105 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [18:51:34] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1003503 [18:51:36] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1003504 [18:51:52] hrm? [18:53:57] (03PS2) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1003504 [18:54:08] (03Abandoned) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1003503 (owner: 10Ejegg) [18:54:13] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1003504 (owner: 10Ejegg) [18:55:25] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1003504 (owner: 10Ejegg) [19:12:04] 10Fundraising-Backlog, 10Domains, 10SRE, 10serviceops: Request donatewiki redirect - https://phabricator.wikimedia.org/T357436 (10RLazarus) Sorry yeah, I was using the term broadly. The goal is to edit the Apache config, but that hieradata file is how you'd do it. :) [19:16:24] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for krobinson - https://phabricator.wikimedia.org/T356307 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [19:25:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10AnnWF) Cleaned up BR: ` [{"id":"I","type":"BANK_TRANSFER","name":"Itau","logo":"https://static.dlocal.com/images/providers/I.png","allo... [19:31:01] (03PS3) 10Wfan: seperate codi with code_qr otherwise alwasy just get CJ as code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1003114 (https://phabricator.wikimedia.org/T346814) [19:32:51] 10Fundraising-Backlog, 10SRE, 10Wikimedia-Apache-configuration, 10serviceops: Request donatewiki redirect - https://phabricator.wikimedia.org/T357436 (10RLazarus) [19:34:29] (03PS1) 10Wfan: Clean up dlocal supported submethods based on the get payment method api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1003036 (https://phabricator.wikimedia.org/T346814) [19:35:42] Dami, here is the follow up clean up https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1003036 & https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1003114 [19:35:54] Thanks :) [19:36:32] Oh probably too late for UK timezone, if anyone else is open to check them, then I will deploy after those been reviewed, thanks :) [19:47:07] (03PS3) 10Eileen: Move recurring Queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002677 [19:47:16] thanks for the review damilare|away [19:51:43] !log payments-wiki upgraded from b699e513 to 29eb0fff [19:51:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:52:29] (03PS1) 10Wfan: ARS min 366 so update amount from 200 to 400 [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003037 (https://phabricator.wikimedia.org/T346814) [19:54:33] (03PS1) 10Wfan: Mexico Bancomer is actually a bank transfer method instead of ticket [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003517 (https://phabricator.wikimedia.org/T346814) [19:56:41] Ah thanks ejegg for update the payments, brazil now have valid bank transfer and pix, can test with document 030.809.377-16 [20:04:46] (03CR) 10Cstone: [C: 03+2] Clean up dlocal supported submethods based on the get payment method api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1003036 (https://phabricator.wikimedia.org/T346814) (owner: 10Wfan) [20:07:09] (03PS4) 10Wfan: seperate codi with code_qr otherwise alwasy just get CJ as code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1003114 (https://phabricator.wikimedia.org/T346814) [20:07:32] (03PS3) 10Eileen: Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) [20:07:34] (03PS1) 10Eileen: Use type hints, simplify check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003519 (https://phabricator.wikimedia.org/T357469) [20:07:36] (03PS1) 10Eileen: IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003520 [20:07:38] (03PS1) 10Eileen: Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) [20:07:40] (03PS1) 10Eileen: wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003522 [20:08:49] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1003114 needs to go first haha, thanks cstone: [20:12:53] (03CR) 10Cstone: [C: 03+2] seperate codi with code_qr otherwise alwasy just get CJ as code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1003114 (https://phabricator.wikimedia.org/T346814) (owner: 10Wfan) [20:13:29] (03Merged) 10jenkins-bot: seperate codi with code_qr otherwise alwasy just get CJ as code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1003114 (https://phabricator.wikimedia.org/T346814) (owner: 10Wfan) [20:17:46] is someone able to +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1003520 - having some formatting fights [20:17:52] (03PS2) 10Eileen: IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003520 [20:22:48] (03CR) 10Cstone: [C: 03+2] IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003520 (owner: 10Eileen) [20:26:45] (03CR) 10CI reject: [V: 04-1] Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:26:58] (03CR) 10CI reject: [V: 04-1] wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003522 (owner: 10Eileen) [20:27:12] PROBLEM - check_disk on frdb1003 is CRITICAL: DISK CRITICAL - free space: /dev 257195 MB (100% inode=99%): /run 51442 MB (99% inode=99%): / 4986 MB (71% inode=89%): /dev/shm 257218 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12350 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25591 MB (96% inode=99%): /boot 577 MB (84% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23620 MB (88% inode=99%): /srv 284033 M [20:27:12] e=99%): /var/log/audit 422 MB (99% inode=99%): /run/user/571 51443 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_disk [20:27:21] (03CR) 10CI reject: [V: 04-1] Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:41:27] (03CR) 10Wfan: [C: 03+2] Add some type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002660 (owner: 10Eileen) [20:58:54] 10Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: New Donors Donating On Email - https://phabricator.wikimedia.org/T356911 (10Cstone) [21:00:29] (03Merged) 10jenkins-bot: Add some type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002660 (owner: 10Eileen) [21:04:20] (03PS1) 10Eileen: IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003533 [21:11:13] (03PS1) 10Eileen: Use wmf_failmail_recipient setting instead of wmf_common_failmail setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003536 [21:11:15] (03PS1) 10Eileen: Setting to var - wmf_common_no_failmail to wmf_failmail_exclude_list [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003537 [21:11:17] (03PS1) 10Eileen: Use setting wmf_failmail_from rather than drupal setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003538 [21:18:49] (03PS1) 10Eileen: Stop validating field length in fredge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003541 (https://phabricator.wikimedia.org/T357469) [21:22:09] RECOVERY - check_disk on frdb1003 is OK: DISK OK - free space: /dev 257195 MB (100% inode=99%): /run 51442 MB (99% inode=99%): / 4986 MB (71% inode=89%): /dev/shm 257218 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12350 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25591 MB (96% inode=99%): /boot 577 MB (84% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23619 MB (88% inode=99%): /srv 1094121 MB (23% ino [21:22:09] var/log/audit 422 MB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_disk [21:47:05] 10Fundraising-Backlog: Support for transaction level reconciliation - https://phabricator.wikimedia.org/T357588 (10EMartin) [21:50:24] ok so this just removes that extraneous length validation that we discussed [21:51:56] (03PS1) 10Jforrester: FundraiserSubscriptionPage::getTemplateParams: Don't pass null to str_replace [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 [21:52:14] (03CR) 10Jforrester: "check php" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (owner: 10Jforrester) [21:55:19] (03PS2) 10Jforrester: FundraiserSubscriptionPage::getTemplateParams: Don't pass null to str_replace [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 [21:56:43] (03CR) 10Jforrester: "check php" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (owner: 10Jforrester) [21:57:21] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1003550 [21:57:33] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1003550 (owner: 10Eileen) [21:58:24] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1003550 (owner: 10Eileen) [22:00:55] ejegg: I've hit something in the antifraud convert - the API expects a non-empty value for required fields - our code defines fields like 'payment_submethod' as required but accepts an empty string - - I'm inclined to think we should just set the fields that require data to required.... [22:01:55] cstone: this should be an easy merge (it's pretty limited but that is what should make it easy to merge :-) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1002720 [22:09:07] looking eileen [22:30:09] (03CR) 10Cstone: [C: 03+2] Replace some CiviCRM_API3_Exception annotations with \CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002720 (owner: 10Eileen) [22:30:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Incorrect Financial Types - https://phabricator.wikimedia.org/T356886 (10Ejegg) a:03Ejegg [22:31:18] (03PS1) 10Eileen: Update normalizeMessage test to instantiate message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003552 (https://phabricator.wikimedia.org/T357471) [22:31:20] (03PS1) 10Eileen: Update recurringTest to instantiate message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003553 (https://phabricator.wikimedia.org/T357471) [22:31:22] (03PS1) 10Eileen: Update recurring Queue consumer to instantiate recurring message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003554 (https://phabricator.wikimedia.org/T357471) [22:31:24] (03PS1) 10Eileen: Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) [22:36:17] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Enable Post-Payment Monthly Convert for CL, CO, MX, PE, UY, BR - https://phabricator.wikimedia.org/T356277 (10Cstone) a:03Cstone [22:37:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Incorrect Financial Types - https://phabricator.wikimedia.org/T356886 (10Ejegg) We're still checking for financial_type=Endowment Gift to decide * which TY template to send * who to notify on large donations * how to list donations in the EOY email * whi... [22:40:06] 10Fundraising Tech Chaos Holding Pen, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: DB Error 'No such field' when sorting Civi advanced search results by country - https://phabricator.wikimedia.org/T324288 (10Ejegg) moving to holding pen based on Eileen's last comment [22:42:21] fr-tech I added countries to the monthlyconvert list on localsettings if someone could check my change [22:43:11] sure cstone [22:45:14] looks fine to me cstone ! [22:45:27] thanks ejegg ! [22:48:39] 10Fundraising-Backlog, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub: Archive the FundraisingEmailUnsubscribe extension - https://phabricator.wikimedia.org/T224764 (10Jdforrester-WMF) [22:48:45] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10FR-Email, 10FR-email-preferences, and 2 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10Jdforrester-WMF) [22:51:34] (03PS2) 10Eileen: Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) [22:51:36] (03PS1) 10Eileen: Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) [22:52:03] (03CR) 10CI reject: [V: 04-1] Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:52:50] (03Merged) 10jenkins-bot: Replace some CiviCRM_API3_Exception annotations with \CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002720 (owner: 10Eileen) [22:56:23] (03PS3) 10Eileen: Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) [22:56:42] (03PS3) 10Jforrester: FundraiserSubscriptionPage::getTemplateParams: Fix errors on PHP 8.1 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) [22:56:45] (03PS2) 10Eileen: Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) [22:57:16] (03PS4) 10Jforrester: FundraiserSubscriptionPage::getTemplateParams: Fix errors on PHP 8.1 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) [22:57:29] (03CR) 10Jforrester: "check php" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) (owner: 10Jforrester) [22:57:53] (03PS2) 10Jforrester: build: Updating npm dependencies [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1002695 (owner: 10Libraryupgrader) [23:04:23] 10Fundraising-Backlog, 10fundraising-tech-ops, 10SRE, 10Wikimedia-Apache-configuration, and 2 others: Request donatewiki redirect - https://phabricator.wikimedia.org/T357436 (10Dwisehaupt) [23:09:03] ejegg: this question probably got lost in the scroll above - I've hit something in the antifraud convert - the API expects a non-empty value for required fields - our code defines fields like 'payment_submethod' as required but accepts an empty string - - I'm inclined to think we should just set the fields that require data to required.... [23:10:06] !log civicrm upgraded from 3ee91f59 to 84ba0ccf [23:10:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:12:30] (03CR) 10CI reject: [V: 04-1] Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:16:28] (03CR) 10CI reject: [V: 04-1] Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:17:29] (03CR) 10CI reject: [V: 04-1] Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:18:00] hi eileen sorry, i saw it but i wasn't sure what to say [23:18:09] i guess we were just worried about malformed messages? [23:18:38] but yeah, I think the payment_method is generally there and non-empty, right? [23:19:00] i've gotta head out for now but I'd look at the actual data to decide what to do [23:23:35] 10Fundraising-Backlog, 10fundraising-tech-ops: Campaign URL Request - https://phabricator.wikimedia.org/T357433 (10Dwisehaupt) a:03Dwisehaupt This fallback has been put in place. The main redirect should be rolling out in tomorrow's prod puppet deploy. [23:36:30] (03PS2) 10Eileen: Try to set SmashPig recur fields to hidden [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003006 (owner: 10Ejegg) [23:37:47] (03CR) 10Eileen: [C: 03+1] "turns out the word you wanted was unmodified ejegg - so ahead & up this to +2 if you are happy with my change" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003006 (owner: 10Ejegg) [23:46:14] (03PS4) 10Eileen: Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) [23:47:11] (03PS3) 10Eileen: Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) [23:51:38] (03PS1) 10Eileen: Move trimming to construct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003567 (https://phabricator.wikimedia.org/T357471) [23:57:27] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Enable Post-Payment Monthly Convert for CL, CO, MX, PE, UY, BR - https://phabricator.wikimedia.org/T356277 (10Cstone) These have been enabled