[01:56:39] (03PS2) 10Eileen: Update recurring Queue consumer to instantiate recurring message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003554 (https://phabricator.wikimedia.org/T357471) [02:55:03] (03CR) 10Ejegg: [C: 03+2] "Thanks for the cleanup!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1003575 (https://phabricator.wikimedia.org/T317837) (owner: 10Cstone) [02:55:38] (03Merged) 10jenkins-bot: Remove the WSDL directdebit method iDEAL and newer bank transfers are using the new methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1003575 (https://phabricator.wikimedia.org/T317837) (owner: 10Cstone) [03:14:07] (03PS2) 10Ejegg: Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) [03:14:33] (03CR) 10CI reject: [V: 04-1] Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [03:15:16] (03PS3) 10Ejegg: Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) [03:20:04] (03PS1) 10Ejegg: Fix proxy-forward script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003980 [03:31:04] (03PS4) 10Ejegg: Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) [12:43:59] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Enable Post-Payment Monthly Convert for CL, CO, MX, PE, UY, BR - https://phabricator.wikimedia.org/T356277 (10Pcoombe) Tested and looks good, thanks! [13:35:16] (03CR) 10Jgleeson: [C: 03+2] "thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003774 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [13:50:59] fr-tech I'm still puzzled by the apache2 non-root launch [13:51:12] so I'mma leave that PHP8 dev patch another day and work on other stuff [13:52:06] (03PS5) 10Ejegg: Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) [13:53:02] (03CR) 10Jgleeson: [C: 03+2] "LGTM. I went down a rabbit hole looking for some unit tests that pass through this but couldn't easily, so I ended up testing on the UI ar" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003775 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [13:53:54] (03Merged) 10jenkins-bot: Update some variable names for clarity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003774 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [13:56:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal Recurring trnx does not have payment_token_id for future charge - https://phabricator.wikimedia.org/T334902 (10Ejegg) So it looks like this is one of those errant annual paypal payments that someone managed to make. We have a job to cancel old subs... [14:02:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal Recurring trnx does not have payment_token_id for future charge - https://phabricator.wikimedia.org/T334902 (10Ejegg) a:03Ejegg [14:03:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal annual Recurring trnx was cancelled for inactivity - https://phabricator.wikimedia.org/T334902 (10Ejegg) [14:08:21] (03CR) 10Jgleeson: [C: 04-1] "Works great, thanks. Just two small asks on the new method name and signature." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003776 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [14:11:37] (03Merged) 10jenkins-bot: Remove deprecated $_subscriptionDetails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003775 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [14:13:26] I've not looked at the apache thing yet ejegg but will do [14:14:21] all the image building puts me off :P [14:15:07] I much prefer `Docker build` to the crazy docker-package stuff we use [14:15:27] but I can see why it's useful integrating with the repo [14:17:03] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.17; 2024-02-06): Add 'other' amount field to the upgrading page - https://phabricator.wikimedia.org/T356478 (10Damilare) a:03Damilare [14:17:28] (03PS1) 10Ejegg: Don't cancel annual subscriptions for inactivity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004120 (https://phabricator.wikimedia.org/T334902) [14:17:48] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.17; 2024-02-06): Add 'other' amount field to the upgrading page - https://phabricator.wikimedia.org/T356478 (10Damilare) a:05Damilare→03Ejegg [14:20:04] (03PS2) 10Ejegg: Add extra details to the recurring edit activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003776 (https://phabricator.wikimedia.org/T357454) [14:24:42] ok, fn name updated jgleeson ^^ [14:25:27] (03CR) 10Jgleeson: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003776 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [14:25:34] thank you! [14:25:46] i fixed it in the upstream PR too [14:26:19] nice [14:27:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Incorrect Financial Types - https://phabricator.wikimedia.org/T356886 (10Ejegg) @NNichols can you point to some discussion about removing the 'Endowment Gift' financial type? We're using that in a bunch of places to decide how to treat endowment donations. [14:29:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: amazon pay from gateway chooser return invalid - https://phabricator.wikimedia.org/T344450 (10Ejegg) 05Open→03Invalid "We were unable to find a donation form matching your parameters. Please contact our help team for more information. " This is the c... [14:30:02] fr-tech should we have a team meeting for the Adyen auto-rescue deployment on Monday? I think most of the code is there right, we just need to make time to go through the checklist, deploy and test. It would make Evelyn's day :) [14:33:23] or maybe tuesday since Monday is a holiday in the US [14:34:08] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10FR-Adyen, 10Patch-For-Review: Remove Adyen WSDL classes and related code in Api.php and PaymentProvider classes - https://phabricator.wikimedia.org/T317837 (10Ejegg) OK, there is a JSON IPN listener ready for some smoke testing [14:42:19] (03Merged) 10jenkins-bot: Add extra details to the recurring edit activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003776 (https://phabricator.wikimedia.org/T357454) (owner: 10Ejegg) [14:50:00] I've moved that suggestion to slack [14:55:32] (03PS1) 10Ejegg: Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) [14:56:08] (03CR) 10CI reject: [V: 04-1] Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [14:58:22] thanks jgleeson that's great [14:59:45] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for avargas - https://phabricator.wikimedia.org/T356129 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via WhatsApp. [15:06:10] np! [15:09:24] (03CR) 10Jgleeson: [C: 03+2] "thanks for this" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003905 (owner: 10Ejegg) [15:12:59] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] Add bookworm override sample [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003905 (owner: 10Ejegg) [15:17:07] ejegg: I had some late feedback that patch [15:18:01] hmm [15:18:09] I guess it doesn't matter for testing [15:18:29] but because that override updates the image of each service directly, it's bypassing the x-common-settings [15:18:42] which I think is how the image is currently set for 4-5 generic ones [15:21:25] (03PS2) 10Ejegg: Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) [15:21:54] (03CR) 10CI reject: [V: 04-1] Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [15:27:21] (03PS3) 10Ejegg: Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) [15:27:23] (03PS1) 10Ejegg: Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 [15:27:53] (03CR) 10CI reject: [V: 04-1] Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (owner: 10Ejegg) [15:28:12] jgleeson: right, since x-common-settings is just a yaml backreference, i can't manipulate it from a different yaml file [15:34:26] (03PS2) 10Ejegg: Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 [15:39:22] (03CR) 10Jgleeson: [C: 04-1] "This is great and works well. Just one small rename request. Can we change $DOCKER_COMMAND_BASE to $DOCKER_COMPOSE_COMMAND_BASE or even ju" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003906 (owner: 10Ejegg) [15:39:54] (03PS3) 10Ejegg: Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (https://phabricator.wikimedia.org/T317837) [15:42:04] (03CR) 10Jgleeson: [C: 04-1] "I also test this on a mac and it works well there too." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003906 (owner: 10Ejegg) [15:42:19] ok, i'll make that update [15:48:50] 10fundraising-tech-ops: Upgrade Fundraising Superset to 3.1.0 - https://phabricator.wikimedia.org/T356531 (10Jgreen) [15:51:10] oh fun, forgetme jobs need kicking again [15:52:21] yay failmail zoo has instructions [15:52:26] thanks, past us [15:57:52] ok, dealt with [16:00:12] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1004165 [16:00:16] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1004165 (owner: 10Ejegg) [16:01:17] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1004165 (owner: 10Ejegg) [16:04:58] !log fundraising civicrm upgraded from 84ba0ccf to 45a0138c [16:05:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:06:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: CiviCRM - Activity log for changes made to recurring contributions need more details - https://phabricator.wikimedia.org/T357454 (10Ejegg) OK @AMJohnson and @krobinson I just deployed a patch to add details about changes to next sche... [16:07:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: CiviCRM - Activity log for changes made to recurring contributions need more details - https://phabricator.wikimedia.org/T357454 (10Ejegg) We never made a ticket for it, but those custom 'Smashpig' field should be collapsed by defaul... [16:27:01] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: CiviCRM - Activity log for changes made to recurring contributions need more details - https://phabricator.wikimedia.org/T357454 (10AMJohnson) Perfect! Thank you so much, @Ejegg! [16:38:18] 10Fundraising-Backlog: Testing New Civi User Role - Major Gifts - https://phabricator.wikimedia.org/T357139 (10NNichols) 05Open→03Resolved a:03NNichols [16:40:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Incorrect Financial Types - https://phabricator.wikimedia.org/T356886 (10NNichols) https://phabricator.wikimedia.org/T343756 Endowment Gift was to be removed and that would be indicated in the Restrictions field on a gift [16:48:32] multilistener sounds fancy [16:51:12] i'm going to make some coffee. should be done in time for standup [16:52:35] lol jgleeson yeah, REST & WSDL capable! [16:52:53] but actually just instantiates one of two child classes based on the first char of the IPN [16:54:51] (03CR) 10Jgleeson: Clean up WSDL stuff from Api.php (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [16:55:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Incorrect Financial Types - https://phabricator.wikimedia.org/T356886 (10Ejegg) Hi @NNichols on that ticket it looks like after some back and forth you came around to the idea of keeping the financial type ID: https://phabricator.wikimedia.org/T343756#912... [16:55:51] :) [16:56:57] anilk: I'm at the point in the day that due to my addiction to coffee I want more but if I have more I'll crash and burn [16:57:51] I'm on my 2.5th [16:58:20] (03PS2) 10Ejegg: Explicitly include docker override file in all commands [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003906 [16:58:32] ok jgleeson ^^^ has the var updated [16:58:34] I had (what I would call a cappuccino but they call an) "extra-small latte" today because OMG_FRIDAY_BEFORE_WEEK_OFF [16:59:00] lol [16:59:05] ooh [17:00:41] okta, we meet again [17:25:10] 10Fundraising-Backlog, 10FR-Amazon, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Upgrade Amazon integration by April 1st - https://phabricator.wikimedia.org/T357798 (10Ejegg) [18:47:03] 10Fundraising-Backlog, 10MediaWiki-extensions-Translate, 10ci-test-error: phpunit test failure for extension FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T357804 (10Umherirrender) [18:47:17] (03CR) 10Umherirrender: "(Reported as T357804)" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1002696 (owner: 10Libraryupgrader) [19:21:59] (03PS3) 10Ejegg: Remove old backfil sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002689 (owner: 10Eileen) [19:22:03] (03CR) 10Ejegg: [C: 03+2] Remove old backfil sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002689 (owner: 10Eileen) [19:30:01] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for anil - https://phabricator.wikimedia.org/T357195 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [19:38:54] (03PS2) 10Ejegg: Fix update of dedupe listing after merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003585 (owner: 10Eileen) [19:39:00] (03CR) 10Ejegg: [C: 03+2] Fix update of dedupe listing after merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003585 (owner: 10Eileen) [19:39:55] (03PS3) 10Ejegg: Fix update of dedupe listing after merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003585 (owner: 10Eileen) [19:40:31] (03CR) 10Ejegg: [C: 03+2] Fix update of dedupe listing after merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003585 (owner: 10Eileen) [19:41:20] (03Merged) 10jenkins-bot: Remove old backfil sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002689 (owner: 10Eileen) [19:58:36] (03Merged) 10jenkins-bot: Fix update of dedupe listing after merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003585 (owner: 10Eileen) [20:09:08] (03PS3) 10Ejegg: Update recurring Queue consumer to instantiate recurring message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003554 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:09:29] (03CR) 10Ejegg: [C: 03+2] Update recurring Queue consumer to instantiate recurring message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003554 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:21:19] (03CR) 10Wfan: [C: 03+2] Check Civi contribution tracking not drupal from wmfImportTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002717 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [20:28:43] (03Merged) 10jenkins-bot: Update recurring Queue consumer to instantiate recurring message directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003554 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:32:06] (03PS5) 10Ejegg: Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:32:15] (03CR) 10Ejegg: [C: 03+2] Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:32:19] 10fundraising-tech-ops: Fundraising access request for jroberson - https://phabricator.wikimedia.org/T357817 (10Dwisehaupt) [20:32:33] 10fundraising-tech-ops: Fundraising access request for jroberson - https://phabricator.wikimedia.org/T357817 (10Dwisehaupt) [20:33:11] 10fundraising-tech-ops: Fundraising access request for jroberson - https://phabricator.wikimedia.org/T357817 (10Dwisehaupt) a:03Dwisehaupt [20:36:23] (03CR) 10Ejegg: [C: 04-1] "should be 'subscription ID', not subscriber" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:39:20] (03Merged) 10jenkins-bot: Check Civi contribution tracking not drupal from wmfImportTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002717 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [20:40:02] (03PS2) 10Ejegg: Use type hints, simplify check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003519 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:40:09] (03CR) 10Ejegg: [C: 03+2] Use type hints, simplify check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003519 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:40:20] (03PS3) 10Ejegg: Use type hints, simplify check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003519 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:40:32] (03CR) 10Ejegg: [C: 03+2] Use type hints, simplify check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003519 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:44:49] (03PS2) 10Ejegg: IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003533 (owner: 10Eileen) [20:46:20] (03CR) 10Ejegg: [C: 03+2] IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003533 (owner: 10Eileen) [20:51:18] (03Merged) 10jenkins-bot: Extract getFinancialTypeID() in message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003555 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:52:19] (03PS2) 10Ejegg: Use wmf_failmail_recipient setting instead of wmf_common_failmail setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003536 (owner: 10Eileen) [20:52:25] (03CR) 10Ejegg: [C: 03+2] Use wmf_failmail_recipient setting instead of wmf_common_failmail setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003536 (owner: 10Eileen) [20:54:33] (03PS2) 10Ejegg: Setting to var - wmf_common_no_failmail to wmf_failmail_exclude_list [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003537 (owner: 10Eileen) [20:54:42] (03CR) 10Ejegg: [C: 03+2] Setting to var - wmf_common_no_failmail to wmf_failmail_exclude_list [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003537 (owner: 10Eileen) [20:55:16] (03PS2) 10Ejegg: Use setting wmf_failmail_from rather than drupal setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003538 (owner: 10Eileen) [20:55:21] (03CR) 10Ejegg: [C: 03+2] Use setting wmf_failmail_from rather than drupal setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003538 (owner: 10Eileen) [20:59:09] (03Merged) 10jenkins-bot: Use type hints, simplify check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003519 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:05:01] (03Merged) 10jenkins-bot: IDE reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003533 (owner: 10Eileen) [21:10:06] (03Merged) 10jenkins-bot: Use wmf_failmail_recipient setting instead of wmf_common_failmail setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003536 (owner: 10Eileen) [21:10:51] (03Merged) 10jenkins-bot: Setting to var - wmf_common_no_failmail to wmf_failmail_exclude_list [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003537 (owner: 10Eileen) [21:13:31] (03Merged) 10jenkins-bot: Use setting wmf_failmail_from rather than drupal setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003538 (owner: 10Eileen) [21:52:34] (03PS1) 10Ejegg: WIP Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [21:55:56] (03CR) 10CI reject: [V: 04-1] WIP Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [22:27:43] (03PS1) 10Ejegg: Use standard 'language' and 'recurring' params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004260 (https://phabricator.wikimedia.org/T336449) [22:38:21] (03CR) 10Ejegg: [C: 04-1] "Looking really good, just one last thing in the audit to clean up" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [22:40:34] I just worry if we hardcode dlocal as gateway for all trxn in audit file, all of the old astropay donations will fail to charge again right? [22:42:43] Thanks ejegg for the review and if that’s not a case I can remove that get gateway function which depends on cutoverdate 4/13/2023 [22:45:30] wfan are we still parsing any audit files from before April 13 2023? [22:45:41] I think we should have cleared all those out by now [22:46:11] also elsewhere in your patch you removed the config value, right? [22:47:06] (03PS4) 10Ejegg: Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (https://phabricator.wikimedia.org/T317837) [22:48:01] seems like the oldest is wikimedia_staging_report_2023-05-24.csv [22:48:12] ok, then I will remove that, thanks :) [22:48:39] wikimedia_report_2023-04-28.csv is the earliest still later than 4/13 [22:51:04] (03PS12) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) [22:54:07] (03CR) 10CI reject: [V: 04-1] Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [23:04:33] (03PS13) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) [23:13:36] (03CR) 10Wfan: [C: 03+2] "make sense and looks good to me :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004120 (https://phabricator.wikimedia.org/T334902) (owner: 10Ejegg) [23:17:04] (03PS14) 10Ejegg: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [23:17:20] (03CR) 10Ejegg: [C: 03+2] "Thanks for the cleanup!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [23:17:29] Thx ☺️ elliott [23:17:41] :) [23:18:10] gonna head out. have a good weekend! [23:21:05] toodaloo [23:36:21] (03Merged) 10jenkins-bot: Don't cancel annual subscriptions for inactivity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004120 (https://phabricator.wikimedia.org/T334902) (owner: 10Ejegg) [23:36:23] (03Merged) 10jenkins-bot: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan)