[06:32:52] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1004399 (owner: 10L10n-bot) [12:40:41] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1004399 (owner: 10L10n-bot) [13:20:25] (03CR) 10Damilare Adedoyin: [C: 03+1] "LGTM, added a comment about some lines we no longer need since globalcollect has been removed from the stack." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [13:21:26] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM. Thanks for the work on this." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002718 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [13:22:44] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002719 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [13:31:25] (03CR) 10Damilare Adedoyin: [C: 03+2] Stop writing to contribution tracking table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002670 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [13:40:52] (03Merged) 10jenkins-bot: Update TestDonation to test civicrm contribution tracking, not drupal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002718 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [13:40:58] (03Merged) 10jenkins-bot: Update testCreateDistinctContributions to test civicrm_contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002719 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [13:49:25] (03Merged) 10jenkins-bot: Stop writing to contribution tracking table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002670 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [19:15:24] (03CR) 10Jgleeson: [C: 03+1] "The code looks fine. The '<' check does feel slightly risky in case of stray whitespace, but it tests fine. I sent JSON and SOAP requests " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [19:17:53] (03CR) 10Jgleeson: [C: 03+2] "thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [19:26:29] (03CR) 10Jgleeson: [C: 03+2] "Awesome. So good to get rid of those global test suite errors too." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [19:48:57] (03CR) 10Jgleeson: [C: 03+2] "Thanks for picking this up. I don't use this script so completely missed it." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003980 (owner: 10Ejegg) [19:56:37] (03CR) 10Jgleeson: [C: 03+2] "Works great. thanks" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003906 (owner: 10Ejegg) [20:01:55] (03PS2) 10Jgleeson: Fix scripts/add-github-mirror-remotes.sh on MacOS [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003453 [20:01:57] (03PS1) 10Jgleeson: Add xdebug config for smashpig to .run [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1004776 [20:14:07] hey damilare so that handling of subscription ID for global collect is definitely done with now? [20:15:08] (03PS1) 10Jgleeson: Update repo for docker-pkg to anon http. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1004780 [20:22:56] (03PS6) 10Eileen: Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) [20:23:24] (03CR) 10Eileen: "Well I always like REMOVING code!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:23:43] (03CR) 10Eileen: Move get subscriber ID to child message class (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:25:09] if anyone is able to check this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1002677 - it seems a bit prone to getting into fights (conflicts) [20:26:13] checking eileen [20:26:22] thanks! [20:33:34] (03CR) 10Jgleeson: [C: 03+2] "Works fine locally. Thanks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002677 (owner: 10Eileen) [20:33:41] thanks jgleeson [20:34:33] np [20:40:27] (03PS3) 10Eileen: Stop validating field length in fredge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003541 (https://phabricator.wikimedia.org/T357469) [20:40:29] (03PS5) 10Eileen: Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) [20:41:57] (03PS3) 10Eileen: Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) [20:43:51] (03PS3) 10Eileen: Generic WMFQueue:consume() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002753 (https://phabricator.wikimedia.org/T356115) [20:46:34] I think so eileen, haven't seen that come up in a while and we've removed the code in DI. We can confirm on tomorrow's call too [20:47:02] damilare: ok - I removed it from the patch - [20:50:41] (03PS1) 10Eileen: Move ContributionTracking Queue Consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004782 (https://phabricator.wikimedia.org/T357469) [20:52:10] (03Merged) 10jenkins-bot: Move recurring Queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002677 (owner: 10Eileen) [20:56:36] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM thanks for all the work on this!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:56:55] thanks damilare [20:57:09] np [20:59:08] (03CR) 10CI reject: [V: 04-1] Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:00:27] (03PS1) 10Eileen: Move BannerHistoryQueueConsumer to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004784 (https://phabricator.wikimedia.org/T357471) [21:00:41] (03CR) 10CI reject: [V: 04-1] Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:09:05] (03CR) 10CI reject: [V: 04-1] Move ContributionTracking Queue Consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004782 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:14:33] (03Merged) 10jenkins-bot: Move get subscriber ID to child message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003560 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [21:22:26] (03CR) 10CI reject: [V: 04-1] Move BannerHistoryQueueConsumer to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004784 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [21:23:32] (03PS6) 10Eileen: Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) [21:25:09] (03PS4) 10Eileen: Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) [21:30:20] (03PS2) 10Eileen: Move ContributionTracking Queue Consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004782 (https://phabricator.wikimedia.org/T357469) [21:30:33] (03PS2) 10Eileen: Move BannerHistoryQueueConsumer to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004784 (https://phabricator.wikimedia.org/T357471) [21:40:13] (03PS1) 10Eileen: Superficial cleanup in OptIn Test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004787 [21:41:49] (03CR) 10CI reject: [V: 04-1] Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:42:27] (03CR) 10CI reject: [V: 04-1] Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:52:49] (03CR) 10CI reject: [V: 04-1] Move ContributionTracking Queue Consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004782 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:58:03] (03CR) 10CI reject: [V: 04-1] Superficial cleanup in OptIn Test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004787 (owner: 10Eileen) [22:08:15] (03PS4) 10Eileen: Stop validating field length in fredge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003541 (https://phabricator.wikimedia.org/T357469) [22:08:17] (03PS7) 10Eileen: Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) [22:11:06] (03PS9) 10Eileen: Move Test to right directory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/997573 (https://phabricator.wikimedia.org/T356115) [22:13:30] (03PS3) 10Eileen: Move ContributionTracking Queue Consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004782 (https://phabricator.wikimedia.org/T357469) [22:23:15] (03PS2) 10Eileen: Superficial cleanup in OptIn Test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004787 [22:25:45] (03PS1) 10Eileen: Update deduper version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004789 [22:31:37] (03CR) 10CI reject: [V: 04-1] Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:32:59] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Consolidate rest of normalize into WMFMessage class - https://phabricator.wikimedia.org/T357471#9556300 (10Eileenmcnaughton) a:03Eileenmcnaughton [22:33:12] (03PS1) 10Eileen: Move validation to RecurMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004790 (https://phabricator.wikimedia.org/T357471) [22:41:02] (03PS1) 10Eileen: Move getContributionRecurID to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004791 (https://phabricator.wikimedia.org/T357471) [23:01:01] (03CR) 10CI reject: [V: 04-1] Move getContributionRecurID to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004791 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen)