[00:11:03] (03PS2) 10Eileen: Move getContributionRecurID to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004791 (https://phabricator.wikimedia.org/T357471) [00:12:00] (03PS1) 10Eileen: Switch test to use api rather than overloaded function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004795 (https://phabricator.wikimedia.org/T357471) [00:12:02] (03PS1) 10Eileen: Move contribution_tracking_id lookup to Recurring Message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004796 (https://phabricator.wikimedia.org/T357471) [00:20:44] (03PS1) 10Eileen: Move 2 line function back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004797 (https://phabricator.wikimedia.org/T357471) [00:30:06] (03CR) 10CI reject: [V: 04-1] Move getContributionRecurID to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004791 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [00:30:18] (03CR) 10CI reject: [V: 04-1] Switch test to use api rather than overloaded function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004795 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [00:30:37] (03CR) 10CI reject: [V: 04-1] Move contribution_tracking_id lookup to Recurring Message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004796 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [00:30:51] (03PS8) 10Eileen: Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) [00:31:25] (03PS5) 10Eileen: Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) [00:49:12] (03CR) 10CI reject: [V: 04-1] Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [00:49:56] (03CR) 10CI reject: [V: 04-1] Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:12:32] (03PS9) 10Eileen: Switch PaymentsInitQueueConsumer from drupal insert to Apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003111 (https://phabricator.wikimedia.org/T357469) [01:47:26] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Follow up on coworker - do some testing with queue_pause & busy on prod - https://phabricator.wikimedia.org/T348704#9556533 (10Eileenmcnaughton) [01:47:42] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Follow up on coworker - do some testing with queue_pause & busy on prod - https://phabricator.wikimedia.org/T348704#9244928 (10Eileenmcnaughton) [01:57:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Do we need sleeping pills? - https://phabricator.wikimedia.org/T357945#9556547 (10Eileenmcnaughton) [02:25:49] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Follow up on coworker - do some testing with queue_pause & busy on prod - https://phabricator.wikimedia.org/T348704#9556598 (10Eileenmcnaughton) @Dwisehaupt I confirmed that this DOES work on prod - ie after running... [02:56:12] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Dedupe Oddity - https://phabricator.wikimedia.org/T339288#9556611 (10Eileenmcnaughton) a:03Eileenmcnaughton @SHust I pushed out a fix [02:56:54] (03PS6) 10Eileen: Code simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003521 (https://phabricator.wikimedia.org/T357469) [03:01:10] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: replace our drush scripts with WMFQueue.consume api - https://phabricator.wikimedia.org/T357470#9556613 (10Eileenmcnaughton) [12:18:50] (03PS12) 10Nikerabbit: Update reference to newly namespaced MessageGroupStates::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/990793 (https://phabricator.wikimedia.org/T340724) (owner: 10Wangombe) [13:54:57] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] Explicitly include docker override file in all commands [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003906 (owner: 10Ejegg) [14:05:54] hi jgleeson. Thanks for all the CR! [14:06:15] np. just digging into the apache perms one now [14:13:41] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Incorrect Financial Types - https://phabricator.wikimedia.org/T356886#9559169 (10NNichols) I see! Reading is truly fundamental :) Thank you Elliot. All of those fun conversations about custom fields and tables are coming back to me. My apologies; we... [14:29:33] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003541 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:48:21] ejegg: I noticed that when I run apache directly from the new payments container, it's creating /tmp/apache2 with the uid of the host and not the apache run user which is probably preventing apache creating that socks file. It should be creating /tmp/apache2 as www-data to my understanding but it's not. will dig in more when I get back. [14:49:12] (03Merged) 10jenkins-bot: Stop validating field length in fredge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003541 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:52:13] jgleeson|skrun: hmm, i wonder if we could just create that file as www-data in the image setup [15:14:07] (03PS2) 10Ejegg: Use standard 'language' and 'recurring' params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004260 (https://phabricator.wikimedia.org/T336449) [15:14:39] fr-tech minor fix to get ready to use SmashPig to make PayPal payments from the front-end ^^^ [15:15:05] that call is currently not used by anthing else [15:16:14] (03PS6) 10Ejegg: Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) [15:16:16] (03PS4) 10Ejegg: Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) [15:16:18] (03PS5) 10Ejegg: Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (https://phabricator.wikimedia.org/T317837) [15:43:29] checking ejegg [15:46:10] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004260 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:46:57] (03Merged) 10jenkins-bot: Use standard 'language' and 'recurring' params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004260 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:47:44] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for this! LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/997573 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [15:50:15] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004790 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [15:55:33] (03PS2) 10Ejegg: WIP Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [15:55:51] thanks jgleeson ! [15:57:24] (03CR) 10CI reject: [V: 04-1] WIP Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:57:44] right, let's update those tests [15:58:52] np! [16:00:02] ejegg: I did start testing out setting perms on that dir, although it shouldn't be needed, but then the image wasn't pulling in the new entrypoint script after rebuilding so gonna revisit that [16:01:54] I deleted the docker image locally, rebuilt the image with docker-pkg after updating the entrypoint.sh file but then a new docker compose up launched a container with the old entrypoint script so i was scratching my head on that one [16:05:20] usually with Docker it's a simple as docker compose --build to rebuild the image but our dependency on docker-pkg means we have to delete local images which sometimes isn't as straightforward as it sounds and then rebuild in that tool in a different place, down the stack and pull in the news stuff. It's a lot of overhead. [16:06:13] (03Merged) 10jenkins-bot: Move Test to right directory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/997573 (https://phabricator.wikimedia.org/T356115) (owner: 10Eileen) [16:10:00] oh weird, the entrypoint script was laggy? [16:10:13] possibly a cache issue [16:10:21] yeah, it's definitely been time consuming to rebuild often [16:13:17] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004797 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [16:13:26] part me is wondering if it would be worth exploring a `docker-pkg export fundraising-image...` command which just exports the files we store in dev-images to vanilla docker format to aid quick testing like this. We could even do `docker-pkg import path/to/dockerfile` to convert both ways [16:13:39] (03CR) 10Damilare Adedoyin: [C: 03+2] Update deduper version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004789 (owner: 10Eileen) [16:13:50] those Dockerfile.template files are 95% Dockerfiles [16:14:40] right, if we can get it working with a regular dockerfile I guess we can easily apply the lesson to the template [16:32:13] (03Merged) 10jenkins-bot: Move 2 line function back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004797 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [16:32:39] (03Merged) 10jenkins-bot: Update deduper version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004789 (owner: 10Eileen) [16:32:41] (03Merged) 10jenkins-bot: Move validation to RecurMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004790 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [17:10:56] fr-tech today's album/song recommendation is Massive Attack - Teardrop [17:11:12] from the album Mezzanine [17:13:11] ejegg: so that permission issue isn't specific to Apache. it's a general failure of the Docker user running the container (and any other user including www-data) to change permissions of directories in /tmp [17:13:38] not sure why that's suddenly a problem but it reduces the layers involved [17:14:31] yeah, it's perplexing why it would have changed from bullseye to bookworm [17:17:44] I think we can fix it easily enough [17:18:04] but yeah it's odd why it's now a problem [17:18:24] to fix it we can just create the dir and set perms to www-data in the Dockerfile.template [17:18:29] I'll try that now [17:26:28] (03CR) 10Jgleeson: [C: 03+2] "Thanks for the update! LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [17:26:55] (03Merged) 10jenkins-bot: Add Adyen multilistener and REST listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/997998 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [17:27:01] (03Merged) 10jenkins-bot: Remove old WSDL recurring authorize method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004133 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [17:27:04] woohoo [17:27:10] (03Merged) 10jenkins-bot: Clean up WSDL stuff from Api.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1004145 (https://phabricator.wikimedia.org/T317837) (owner: 10Ejegg) [17:46:26] jgleeson|food: speaking of songs, i don't know if you have been subjected to Hey Duggee on cbeebies. but this one may send you over the edge: https://www.youtube.com/watch?v=1Y2esjMTZ40 [18:07:49] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ejegg - https://phabricator.wikimedia.org/T356720#9560678 (10Dwisehaupt) Renewed certificate and sent via email. Certificate and password files place in the homedir on frpm1002. [18:29:04] omg dwisehaupt [18:29:10] LOL [18:29:21] vengaboys are classic [18:29:43] Oscar did have a hey duggee period [18:30:05] or maybe it was Tilly [19:10:27] 10fundraising-tech-ops: Fundraising access request for Ramon Lopez - https://phabricator.wikimedia.org/T356116#9561050 (10RLopez-WMF) 05Open→03Resolved a:03RLopez-WMF [19:13:51] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ejohnston - https://phabricator.wikimedia.org/T357369#9561061 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [19:14:26] 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9561063 (10RLopez-WMF) [19:26:58] 10Fundraising-Backlog, 10fundraising-tech-ops: Update fr-tech maxmind config to pull databases from new url. - https://phabricator.wikimedia.org/T358043#9561098 (10Dwisehaupt) [20:14:09] (03PS3) 10Eileen: Superficial cleanup in OptIn Test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1004787 [20:30:44] 10Fundraising-Backlog, 10FR-Amazon, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Upgrade Amazon integration by April 1st - https://phabricator.wikimedia.org/T357798#9561300 (10AnnWF) [20:45:00] (03PS4) 10Eileen: Generic WMFQueue:consume() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1002753 (https://phabricator.wikimedia.org/T356115) [20:49:29] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Migrate Ingenico API URLs to new Worldline addresses - https://phabricator.wikimedia.org/T352197#9561345 (10jgleeson) a:05jgleeson→03None [20:50:09] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Migrate Ingenico API URLs to new Worldline addresses - https://phabricator.wikimedia.org/T352197#9561346 (10XenoRyet) p:05Triage→03Low [20:51:56] 10Fundraising Sprint: canOfWorms(🪱): 2024 Sprint C - Priorities - https://phabricator.wikimedia.org/T357728#9561348 (10AnnWF) [21:07:31] 10Fundraising-Backlog: Gift not importing, but error reason is not showing - https://phabricator.wikimedia.org/T355827#9561439 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [21:08:50] 10Fundraising-Backlog: Update old AstroPay audit to Dlocal from the civi wmf_audit module - https://phabricator.wikimedia.org/T358055#9561447 (10AnnWF) [21:10:36] 10Fundraising-Backlog: Update old AstroPay audit to Dlocal from the civi wmf_audit module - https://phabricator.wikimedia.org/T358055#9561462 (10AnnWF) [21:12:52] 10Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: New Donors Donating On Email - https://phabricator.wikimedia.org/T356911#9561464 (10AKanji-WMF) @JMando @Ejegg has some theories about why this might be happening - have added to chaos [21:16:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Add banner history log id to contribution_tracking table - https://phabricator.wikimedia.org/T356918#9561477 (10AKanji-WMF) Ideally slot in during next maintenance window [21:17:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: PHP notices in Import Parser - https://phabricator.wikimedia.org/T356947#9561482 (10AKanji-WMF) 05Open→03Resolved [21:19:08] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker log issues - https://phabricator.wikimedia.org/T355736#9561484 (10Eileenmcnaughton) [21:19:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: De-duplicate %context% in Civi log lines - https://phabricator.wikimedia.org/T356950#9561485 (10Eileenmcnaughton) [21:21:41] 10Fundraising-Backlog: New country South Korea via Adyen - https://phabricator.wikimedia.org/T356962#9561488 (10AKanji-WMF) Thanks @RKumar_WMF - can we please create a shared doc/table listing out our requested/required payments/types for this market - and is there a campaign launch we need to work towards (i.e... [21:27:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Do we need sleeping pills? - https://phabricator.wikimedia.org/T357945#9561501 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [21:31:06] 10Fundraising-Backlog: Support for transaction level reconciliation - https://phabricator.wikimedia.org/T357588#9561517 (10AKanji-WMF) Hi @EMartin - let's have a scoping conversation with members of FR-Tech, Finance and FR-Operations when ready, and we can better scope the investigation phase. [21:37:18] hey ejegg, adding that socks dir and giving www-data ownership fixes the apache start issue. I just updated the docker image locally and it worked as expected. Do you want me to paste the changes somewhere so you can push them up to avoiding messing with your merge request [21:37:26] 10Fundraising-Backlog: Matching gift company search changes required - https://phabricator.wikimedia.org/T357727#9561538 (10AKanji-WMF) Hi @EMartin @RKumar_WMF - there's a question as to whether we will require a security review for the CSP update [h/t @Pcoombe @Ejegg ] - how do we determine whether this does in... [21:38:49] (03PS1) 10Eileen: Step one of moving currency handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005170 (https://phabricator.wikimedia.org/T357471) [21:48:32] ejegg: https://phabricator.wikimedia.org/P57425 [21:49:23] I'm wrapping up for today. have a good evening all! [21:55:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Add banner history log id to contribution_tracking table - https://phabricator.wikimedia.org/T356918#9561613 (10AKanji-WMF) 05Open→03Invalid closing as duplicate of {T357375} [21:58:11] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9561621 (10AKanji-WMF) @Ejegg - continuing our triage convo here: * Because this represents a high drop off (~10K) recurring donors, we'd like... [22:13:29] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Dedupe Oddity - https://phabricator.wikimedia.org/T339288#9561650 (10SHust) Thanks, @Eileenmcnaughton, I'll share the good news with the admin team! [22:20:02] thanks jgleeson|away ! [22:22:53] (03PS1) 10Eileen: Extract getConversionRate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005181 (https://phabricator.wikimedia.org/T357471) [22:22:55] (03PS1) 10Eileen: Move converstion rate handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005182 (https://phabricator.wikimedia.org/T357471) [22:22:57] (03PS1) 10Eileen: Simplify setting of amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005183 (https://phabricator.wikimedia.org/T357471) [22:22:59] (03PS1) 10Eileen: Simplify early return check on money [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005184 (https://phabricator.wikimedia.org/T357471) [22:23:01] (03PS1) 10Eileen: Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) [22:26:30] (03PS2) 10Eileen: Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) [22:32:00] (03CR) 10CI reject: [V: 04-1] Simplify early return check on money [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005184 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:32:44] (03CR) 10CI reject: [V: 04-1] Simplify setting of amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005183 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:32:58] (03CR) 10CI reject: [V: 04-1] Move converstion rate handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005182 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:33:11] (03CR) 10CI reject: [V: 04-1] Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:35:31] (03CR) 10CI reject: [V: 04-1] Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:48:35] (03PS1) 10Ejegg: Fix PHP8.2 notices [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005187 [22:48:37] (03PS1) 10Ejegg: Fix PHP8.2 notice [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005188 [22:48:39] (03PS2) 10Eileen: Move converstion rate handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005182 (https://phabricator.wikimedia.org/T357471) [22:48:41] (03PS2) 10Eileen: Simplify setting of amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005183 (https://phabricator.wikimedia.org/T357471) [22:48:43] (03PS2) 10Eileen: Simplify early return check on money [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005184 (https://phabricator.wikimedia.org/T357471) [22:48:45] (03PS3) 10Eileen: Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) [22:57:11] (03PS1) 10Eileen: Update verify_message & stage to accept a message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005191 (https://phabricator.wikimedia.org/T357471) [23:05:54] (03PS1) 10Eileen: Move exception on insufficient recurring info to the message validate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005192 (https://phabricator.wikimedia.org/T357471) [23:07:03] (03CR) 10CI reject: [V: 04-1] Simplify early return check on money [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005184 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:07:15] (03CR) 10CI reject: [V: 04-1] Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:08:53] (03CR) 10CI reject: [V: 04-1] Move converstion rate handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005182 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:08:55] (03CR) 10CI reject: [V: 04-1] Simplify setting of amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005183 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:13:32] (03PS1) 10Eileen: Move function called from one class to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005198 (https://phabricator.wikimedia.org/T357471) [23:21:57] (03CR) 10CI reject: [V: 04-1] Move exception on insufficient recurring info to the message validate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005192 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:28:31] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sxu - https://phabricator.wikimedia.org/T356946#9561797 (10Dwisehaupt) Renewed certificate and sent via email. Password sent via SMS. [23:29:30] (03PS3) 10Eileen: Move converstion rate handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005182 (https://phabricator.wikimedia.org/T357471) [23:30:56] (03PS3) 10Eileen: Simplify setting of amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005183 (https://phabricator.wikimedia.org/T357471) [23:30:58] (03PS3) 10Eileen: Simplify early return check on money [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005184 (https://phabricator.wikimedia.org/T357471) [23:31:00] (03PS4) 10Eileen: Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) [23:32:49] (03PS2) 10Eileen: Move exception on insufficient recurring info to the message validate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005192 (https://phabricator.wikimedia.org/T357471) [23:32:56] (03CR) 10CI reject: [V: 04-1] Move function called from one class to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005198 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:33:42] (03PS2) 10Eileen: Move function called from one class to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005198 (https://phabricator.wikimedia.org/T357471) [23:51:27] (03CR) 10CI reject: [V: 04-1] Simplify early return check on money [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005184 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:51:46] (03CR) 10CI reject: [V: 04-1] Fold the amount wrangling back into the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005185 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:52:26] (03CR) 10CI reject: [V: 04-1] Simplify setting of amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005183 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:52:52] (03CR) 10CI reject: [V: 04-1] Move function called from one class to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005198 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:52:54] (03CR) 10CI reject: [V: 04-1] Move converstion rate handling to getters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005182 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [23:53:13] (03CR) 10CI reject: [V: 04-1] Move exception on insufficient recurring info to the message validate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005192 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen)