[00:02:55] (03CR) 10CI reject: [V: 04-1] Fix Drupal contribution tracking lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005620 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [00:03:08] dang [00:03:52] (03CR) 10CI reject: [V: 04-1] Update AdyenResolveTest to not interact with drupal contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005630 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [00:04:22] i need to help with kid / dinner / bed stuff for a bit but I think I can be back on later [00:07:19] (03Merged) 10jenkins-bot: Consolidate WMFAudit into wmf-civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005624 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [00:08:50] eileen: you are worried about the pending test? [00:08:58] no the one after it [00:09:57] (03CR) 10CI reject: [V: 04-1] Fix wmf_audit to use a Civi::statics not a global [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005625 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [00:10:39] (03PS1) 10Eileen: Fix IngenicoResolveTest to not use fake contribution IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005633 (https://phabricator.wikimedia.org/T354708) [00:10:57] cstone: well - I'm worried that the pending test is failing because of a real bug.... [00:11:29] Civi\Api4\Action\PendingTransaction\Adyen\AdyenResolveTest::testContributionIdSetAndPendingPokeDuplicateInPendingDatabase [00:11:29] 13:03:23 Failed asserting that two strings are equal. [00:11:29] 13:03:23 --- Expected [00:11:29] 13:03:23 +++ Actual [00:11:29] 13:03:23 @@ @@ [00:11:29] 13:03:23 -'cancelled' [00:11:29] 13:03:23 +'failed' [00:11:39] yeah was just looking at that [00:12:02] fails because the live code is looking in the drupal table that we no longer write to - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1005620/3/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php [00:12:26] i was just scanning through that its just the ct id so should behave but why is it confused [00:12:36] once that is fixed then https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1005633/1 bubbles up - I have just copied & pasted fixes from the other test [00:12:53] so the issue is the CiviCRM table has an FK on contribution ID - so you can't use a fake one [00:13:24] but it didn't care cos it was writing to the drupal table & per ^^ above the live code is looking in the drupal table [00:13:49] but earlier today we stopped writing to the drupal table on prod... [00:14:56] unfortunately I have to go into town for ameeting - I'm gonna drive in & then in 20 mins check on the test - if it passes I think we can merge all 3 patches (the children may need to be force v+2?) & deploy & re-enable queues [00:15:21] hah okay cause I have independaent autorescue test Im supposed to run right now too :P [00:15:26] but we can hold off on that [00:15:34] so we are just waiting for jenkins? [00:17:01] well - yeah - if it passes & it looks OK to you we can merge them all [00:17:21] ok ill mess around with it locally too [00:29:42] (03CR) 10CI reject: [V: 04-1] Fix IngenicoResolveTest to not use fake contribution IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005633 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [00:40:27] phpunit too strong freezing laptop [00:40:28] (03PS2) 10Eileen: Fix IngenicoResolveTest to not use fake contribution IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005633 (https://phabricator.wikimedia.org/T354708) [00:40:42] eileen: im trying to step through the test its missing data coming back somehow [00:41:02] that fail ^^ was because there was cleanup missing - I just fixed the tearDown [00:42:06] you got the first test to pass ? [00:42:34] yeah - but only with the whole chain up to https://gerrit.wikimedia.org/r/1005633 [00:42:40] ahhh i see [00:45:01] ok yep passing locally for me too [00:45:24] yay [00:46:18] all the pending group ones passing [01:02:50] cstone: it passed!!! [01:03:06] woooo~~ [01:03:28] do we have to force the misbehaving one? [01:05:28] force the 2 under the ingenico one [01:11:41] eileen: i think its ok to turn the jobs back on too then? or are we still worried [01:12:06] yep if you + 2 them & force em out & deploy then jobs can go on [01:12:16] ok [01:12:27] (03CR) 10Cstone: [C: 03+2] Fix IngenicoResolveTest to not use fake contribution IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005633 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [01:12:37] lets see how this chain is [01:13:00] (03CR) 10Cstone: [V: 03+2 C: 03+2] Update AdyenResolveTest to not interact with drupal contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005630 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [01:13:07] (03CR) 10Cstone: [V: 03+2 C: 03+2] Fix Drupal contribution tracking lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005620 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [01:13:13] i think thats what we need [01:18:05] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1005638 [01:18:23] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1005638 (owner: 10Eileen) [01:18:24] ah eileen I missed forcing that ingenico one [01:18:43] (03CR) 10Cstone: [V: 03+2 C: 03+2] Fix IngenicoResolveTest to not use fake contribution IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005633 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [01:19:38] but its the middle one thats doing the logic [01:26:24] yeah [01:27:22] !log civicrm upgraded from cd839468 to c50fcae3 [01:27:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:28:58] !log config revision changed from 5bdfab7a to b221a95a [01:29:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:29:31] !log config revision changed from 5bdfab7a to b221a95a [01:29:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:29:48] re-enabled queues cstone [01:30:36] thanks eileen [01:30:48] i was checking if the pending transaction resolver even had any today [01:30:50] it probably didnt [01:31:04] oh a couple [01:31:11] (03PS3) 10Eileen: Fix test to look in CiviCRM table for contribution_tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005622 [01:31:27] (03PS3) 10Eileen: Stop cleaning up drupal contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005623 [01:31:49] (03PS5) 10Eileen: Remove contribution tracking dependenciy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005588 [01:32:02] ok im going to do the autorescue testing [01:43:06] finally got one [01:43:34] :-) [01:44:51] but card expired we continue [01:45:38] :-) [01:57:25] (03CR) 10CI reject: [V: 04-1] Remove contribution tracking dependenciy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005588 (owner: 10Eileen) [02:05:12] merchantAdviceCode is that new hmm [02:09:49] looks like these couple passed https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1005623 [02:32:00] eileen: working through this test data how hard would it be to trim whitespace when pasting on the civi search box or maybe there is a use case for whitespace? [02:32:08] also once i get to ten ill go back to looking at yours [02:58:26] (03CR) 10Cstone: [C: 03+2] Fix test to look in CiviCRM table for contribution_tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005622 (owner: 10Eileen) [03:01:41] cstone: hmm - so when you create an sk you want it to trim? I guess I'd have to see what Coleman thinks [03:02:07] - it's not finding stuff cos of leading whitespace? [03:02:22] yeah im copying emails from adyen and searching and theres a leading whitespace a lot [03:03:48] not a sk just in the like tiny search box [03:03:52] at the top left [03:04:18] - as in from a form attached to a search? [03:04:28] oh - you mean the contact search? [03:04:54] what if you use an sk- with a form? [03:04:58] maybe? the one that lets you pick different things [03:05:10] i guess i was just being lazy and wanted the fastest result [03:05:46] since i can get to that one from any page [03:05:51] :-) [03:06:09] its fine i can just delete the whitespace when it cant find anything i was just curious [03:09:29] (03PS1) 10Eileen: Remove test code to delete drupal contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005640 (https://phabricator.wikimedia.org/T354708) [03:10:36] (03PS1) 10Eileen: Remove BaseTestCase code to delete drupal contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005641 (https://phabricator.wikimedia.org/T354708) [03:11:22] (03PS2) 10Eileen: Remove BaseTestCase code to delete drupal contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005641 (https://phabricator.wikimedia.org/T354708) [03:13:12] hmm - I feel like Coleman wants to replace that search box with something that feeds into SK - it might be already in the search extension [03:13:58] I feel like jenkins could hussle a bit - my current test fail looks like it's covered by the one you just gave +2 to [03:14:56] can you +2 this & the one below it ? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1005641 that will save me a jenkins cycle if you do it before it finished :-) [03:15:56] (03Merged) 10jenkins-bot: Fix test to look in CiviCRM table for contribution_tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005622 (owner: 10Eileen) [03:16:44] (03CR) 10Cstone: [C: 03+2] Remove test code to delete drupal contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005640 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [03:16:53] (03CR) 10Cstone: [C: 03+2] Remove BaseTestCase code to delete drupal contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005641 (https://phabricator.wikimedia.org/T354708) (owner: 10Eileen) [03:17:06] hope i got it in time there [03:17:15] :-) [03:17:22] have three computers going at once hah [03:17:29] was reading wiki on the third :P [03:17:32] it's not usually too much of a race to beat jenkins :-) [03:28:33] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import birth dates - https://phabricator.wikimedia.org/T357344#9566225 (10Eileenmcnaughton) There were a similar number in the first table - which was the one with munted formatting - however, most already... [03:35:33] (03CR) 10Cstone: [C: 03+2] Stop cleaning up drupal contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005623 (owner: 10Eileen) [03:36:51] (03PS6) 10Eileen: Remove contribution tracking dependenciy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005588 [03:42:13] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import birth dates - https://phabricator.wikimedia.org/T357344#9566233 (10Eileenmcnaughton) I the second set there were literally only 3 birth dates that were not already in CiviCRM - I manually updated th... [03:42:59] so out of 500k rows from Data Axle only 90 had birth dates that we did not already have [03:44:40] hah [03:47:45] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove disabled custom fields - https://phabricator.wikimedia.org/T356443#9566236 (10Eileenmcnaughton) @AKanji-WMF @Dwisehaupt I think we should maybe pull this out of the sprint & do it in the next maintenance windo... [03:56:48] (03CR) 10CI reject: [V: 04-1] Remove contribution tracking dependenciy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005588 (owner: 10Eileen) [03:59:05] ok auto rescue turned off for now and charge job back on [04:06:02] I think that's a good thing... [04:06:30] cstone: this might be the most aptly named sprint ever... [04:06:41] hah just end of my test [04:06:46] the worms have been freed? [04:07:18] also - do we even need to discuss what sprint f will be - doesn't fixMe() win hands down? [04:10:11] we might be able to workshop it to be wrose [04:10:13] worse even [04:11:51] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Test Adyen Auto-Rescue - https://phabricator.wikimedia.org/T357458#9566277 (10Cstone) We turned on auto rescue today and manually ran the recurring charge job to collect some data, I ran it in chunks until we got 20 failures. Data on it so far is here... [04:11:57] (03PS1) 10Eileen: Can the worm (remove more contribution tracking refs) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005642 (https://phabricator.wikimedia.org/T354708) [04:12:11] haha eileen [04:12:20] i personally like worms a lot [04:13:17] (03PS7) 10Eileen: Remove contribution tracking dependenciy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005588 [04:13:32] worms are good for soil [04:15:52] im gona head out eileen after I make sure this job starts in 5 minutes [04:21:30] ok have a good rest of your day eileen I'll look at your review again tomo [04:22:00] (03Merged) 10jenkins-bot: Stop cleaning up drupal contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005623 (owner: 10Eileen) [05:11:06] (03CR) 10Eileen: [C: 03+2] Fix PHP8.2 notice [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005188 (owner: 10Ejegg) [05:12:04] (03PS2) 10Eileen: Fix PHP8.2 notice [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005188 (owner: 10Ejegg) [05:13:49] (03CR) 10Eileen: [C: 03+2] Fix PHP8.2 notices [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005187 (owner: 10Ejegg) [05:37:43] (03Merged) 10jenkins-bot: Fix PHP8.2 notices [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1005187 (owner: 10Ejegg) [11:00:04] 10Fundraising-Backlog: New country South Korea via Adyen - https://phabricator.wikimedia.org/T356962#9567002 (10RKumar_WMF) Update the sheet but this still needs to be reviewed with service provider [16:43:04] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Remove disabled custom fields - https://phabricator.wikimedia.org/T356443#9568659 (10Dwisehaupt) That sounds ok to me. Next maintenance window is the week of Aug 19. {T337582} [16:43:53] 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2425Q1 maintenance window - https://phabricator.wikimedia.org/T337582#8883935 (10Dwisehaupt) [17:09:32] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: for next maintenance window - Remove disabled custom fields - https://phabricator.wikimedia.org/T356443#9568828 (10AKanji-WMF) [17:31:08] 10Fundraising-Backlog, 10FR-donorservices: Civi Snooze feature stopped working! - https://phabricator.wikimedia.org/T358259#9569007 (10SHust) [18:17:55] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: payments.wikimedia.org SSL certificate expires on Feb 29, 2024 - https://phabricator.wikimedia.org/T356652#9569318 (10Jgreen) We've received the new certificate and deployed it to the backup servers at codfw. So far things look good, it's showing up h... [18:36:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import deceased date - https://phabricator.wikimedia.org/T357346#9569396 (10ERoden-WMF) I agree @MDemosWMF. If we're not confident with the data we shouldn't import. Could you reach out the DA with some examples and ask them to look into it for... [18:49:27] 10Fundraising-Backlog: Auto Rescue - Not actually cancelling when retry.rescueScheduled:false - https://phabricator.wikimedia.org/T358264#9569429 (10Cstone) [18:50:39] 10Fundraising Sprint: canOfWorms(🪱), 10Fundraising-Backlog: Test Adyen Auto-Rescue - https://phabricator.wikimedia.org/T357458#9569444 (10Cstone) [18:50:41] 10Fundraising-Backlog: Auto Rescue - Not actually cancelling when retry.rescueScheduled:false - https://phabricator.wikimedia.org/T358264#9569445 (10Cstone) [19:09:39] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for cstone - https://phabricator.wikimedia.org/T357192#9569519 (10Dwisehaupt) Renewed certificate and sent via email. Certificate and password files placed in home directory on frpm1002 [19:12:48] 10Fundraising-Backlog, 10FR-Docker: Create convenience script for fundraising-dev to set contributon-tracking sequence ID - https://phabricator.wikimedia.org/T358267#9569532 (10jgleeson) [19:18:31] 10fundraising-tech-ops: Upgrade Fundraising Superset to 3.1.0 - https://phabricator.wikimedia.org/T356531#9569552 (10Dwisehaupt) Post install we also needed these sequences added since we were getting failures adding users. ` CREATE SEQUENCE ab_register_user_id_seq START WITH 1 MINVALUE 1 MAXVALUE 9223372036854... [19:22:26] 10fundraising-tech-ops: Upgrade Fundraising Superset to 3.1.0 - https://phabricator.wikimedia.org/T356531#9569572 (10Jgreen) [20:32:09] 10Fundraising-Backlog, 10FR-donorservices: Civi Snooze feature stopped working! - https://phabricator.wikimedia.org/T358259#9569936 (10SHust) [21:00:41] 10Fundraising-Backlog, 10FR-donorservices: Civi Feature Request - Display transaction fee separate from donation amount - https://phabricator.wikimedia.org/T358291#9570067 (10AMJohnson) [22:24:09] (03PS3) 10Jgleeson: Fix scripts/add-github-mirror-remotes.sh on MacOS [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003453 [22:24:11] (03PS2) 10Jgleeson: Add xdebug config for smashpig to .run [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1004776 [22:24:13] (03PS2) 10Jgleeson: Update repo for docker-pkg to anon http. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1004780 [22:24:15] (03PS1) 10Jgleeson: Add scripts for managing contributon-tracking sequence ID [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1005849 (https://phabricator.wikimedia.org/T358267) [22:24:33] cstone: ^^^ that last one is what we talked about on the call [22:27:53] bye for now o/