[00:11:46] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009362 [00:11:58] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009362 (owner: 10Eileen) [00:12:44] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009362 (owner: 10Eileen) [00:18:05] (03PS1) 10Eileen: Move last 2 queue consumer tasks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009364 (https://phabricator.wikimedia.org/T357469) [00:28:39] (03PS1) 10Eileen: Move last 2 queue consumer tasks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009365 (https://phabricator.wikimedia.org/T357469) [00:28:41] (03PS1) 10Eileen: Remove last reference to db_switcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) [00:42:12] (03CR) 10CI reject: [V: 04-1] Move last 2 queue consumer tasks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009364 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [00:57:47] (03Abandoned) 10Eileen: Move last 2 queue consumer tasks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009364 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:08:29] (03PS4) 10Ejegg: New variant for recurring upgrade landing pages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008974 (https://phabricator.wikimedia.org/T356370) [01:08:31] (03PS1) 10Ejegg: Show new total before submitting recur upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009367 (https://phabricator.wikimedia.org/T356479) [01:10:20] (03CR) 10CI reject: [V: 04-1] Show new total before submitting recur upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009367 (https://phabricator.wikimedia.org/T356479) (owner: 10Ejegg) [01:15:00] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: replace our drush scripts with WMFQueue.consume api - https://phabricator.wikimedia.org/T357470#9609763 (10Dwisehaupt) Ok. This is now in place on both civi and frdev roles. frdev will... [01:26:55] (03PS2) 10Ejegg: Show new total before submitting recur upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009367 (https://phabricator.wikimedia.org/T356479) [02:02:12] (03CR) 10Cstone: [C: 03+2] "glad it was straightforward!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008923 (https://phabricator.wikimedia.org/T359441) (owner: 10Wfan) [02:07:49] (03CR) 10Cstone: [C: 03+2] "looks good! thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1009355 (https://phabricator.wikimedia.org/T359441) (owner: 10Wfan) [02:08:34] (03Merged) 10jenkins-bot: Enable Recurring for ACH [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1009355 (https://phabricator.wikimedia.org/T359441) (owner: 10Wfan) [02:09:17] wow thanks a lot cstone! [02:09:35] im glad it wasnt super complicated [02:10:03] Small one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1008922 for local test link [02:10:14] oh right i was goign to do that too [02:10:21] (03CR) 10Cstone: [V: 03+2 C: 03+2] Add ACH recurring test link [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1008922 (https://phabricator.wikimedia.org/T359441) (owner: 10Wfan) [02:10:27] 😎 many thanks [02:12:53] i can deploy it wfan [02:31:32] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: replace our drush scripts with WMFQueue.consume api - https://phabricator.wikimedia.org/T357470#9609838 (10Eileenmcnaughton) I just tested the upiQueue consumer & this ran a treat ` wm... [02:33:44] Oh sure or we can wait until tmr morning? I have no objection to deploy tonight haha [02:34:15] Since Rakhi is using different time zone [02:48:57] (03PS1) 10Cstone: Update Smash Pig to v0.8.9.19 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009374 [03:12:58] (03CR) 10Cstone: [C: 03+2] Update Smash Pig to v0.8.9.19 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009374 (owner: 10Cstone) [03:36:01] (03Merged) 10jenkins-bot: Update Smash Pig to v0.8.9.19 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009374 (owner: 10Cstone) [03:36:51] (03CR) 10Cstone: [C: 03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008923 (https://phabricator.wikimedia.org/T359441) (owner: 10Wfan) [03:38:54] (03Merged) 10jenkins-bot: Enable ACH recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008923 (https://phabricator.wikimedia.org/T359441) (owner: 10Wfan) [03:42:24] (03PS1) 10Cstone: Update SmashPig to v0.8.9.19 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1009376 [03:43:55] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.9.19 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1009376 (owner: 10Cstone) [04:01:05] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9609852 (10EMartin) @AKanji-WMF I'm of the view that we don't need to email but simply retry a 4th attempt. I believe @krobinson may have... [04:01:58] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.9.19 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1009376 (owner: 10Cstone) [04:07:23] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009377 [04:07:55] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009377 (owner: 10Cstone) [04:08:42] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009377 (owner: 10Cstone) [04:09:46] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1009378 [04:11:04] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1009378 (owner: 10Cstone) [04:12:20] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1009378 (owner: 10Cstone) [04:13:33] !log payments-wiki upgraded from 99d8e9f6 to 6a3ff7e5 [04:13:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:15:56] !log civicrm upgraded from 2dd94b1e to ef6ebc35 [04:15:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:23:28] hmmm that staged to deploy fredge change broke something [04:24:18] eileen: are you still around? [04:24:42] or hmm [04:30:47] not the civi deploy! ook what in that di one did it then hah [04:32:40] what neither of them did it?? haha [04:42:54] hah minfraud has betrayed me [06:30:37] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.21; 2024-03-05): Add ACH payment type for US donation processing - https://phabricator.wikimedia.org/T324517#9609952 (10RKumar_WMF) Also, do we have re-try logic in place for ACH? [06:32:38] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.21; 2024-03-05): Add ACH payment type for US donation processing - https://phabricator.wikimedia.org/T324517#9609954 (10AnnWF) >>! In T324517#9609952, @RKumar_WMF wrote: > Also, do we have re-try logic in place for A... [06:46:15] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9609967 (10MSuijkerbuijk_WMF) Thanks all, yes we want to also inform them after the 4th attempt that we are restarting. Here is the [[ http... [07:31:42] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9610032 (10MSuijkerbuijk_WMF) @Ejegg the text chan... [07:50:52] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009425 (owner: 10L10n-bot) [08:00:43] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.21; 2024-03-05): Add ACH payment type for US donation processing - https://phabricator.wikimedia.org/T324517#9610048 (10RKumar_WMF) Got it. Thanks. [08:10:43] (03PS2) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009425 (owner: 10L10n-bot) [08:12:18] (03CR) 10Raimond Spekking: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009425 (owner: 10L10n-bot) [14:19:28] (03PS3) 10Ejegg: Show new total before submitting recur upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009367 (https://phabricator.wikimedia.org/T356479) [14:19:56] ha I was just about to say I was getting a js error testing that [14:22:18] ok that works now [14:23:01] originally I wasn't seeing the updated amount I was getting https://phabricator.wikimedia.org/F42443874 [14:24:21] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9611578 (10ppenloglou) Hey @Ejegg @MSuijkerbuijk_W... [14:25:10] (03CR) 10Jgleeson: [C: 03+2] "PS3 fixes some bugs I was seeing when testing earlier https://phabricator.wikimedia.org/F42443874. It LGTM now." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009367 (https://phabricator.wikimedia.org/T356479) (owner: 10Ejegg) [14:27:35] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:35:43] (03CR) 10Jgleeson: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008974 (https://phabricator.wikimedia.org/T356370) (owner: 10Ejegg) [14:37:01] ejegg|away: did you come up with the font-family? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1008974/4/email_forms/templates/recurUpgrade_v01.css#5 [14:48:18] (03PS1) 10Jgleeson: Upgrade queues-redis-monitor.sh to watch both queue servers [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009546 [14:49:32] fr-tech ^ that patch makes it possible to now monitor both redis queues from a single script. makes our lives easier working with email-pref-center [14:50:19] (03Merged) 10jenkins-bot: New variant for recurring upgrade landing pages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008974 (https://phabricator.wikimedia.org/T356370) (owner: 10Ejegg) [14:50:24] (03Merged) 10jenkins-bot: Show new total before submitting recur upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009367 (https://phabricator.wikimedia.org/T356479) (owner: 10Ejegg) [15:04:19] jgleeson|skrun: how would you feel about having a both script and a separate script for each? I was thinking about the big queue consume too its nice to have everything but everything is a lot when you are just trying to do one specific thing [15:19:55] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9611843 (10MSuijkerbuijk_WMF) @Ejegg you mention a... [15:31:46] (03CR) 10Damilare Adedoyin: [C: 03+1] "Tested and can see the string in the console. Quick question, didn't we add a phone number in the description also?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008936 (https://phabricator.wikimedia.org/T356963) (owner: 10Wfan) [15:42:30] cstone were you just testing an adyen recurring? [15:50:57] damilare: not actively but I was attempting things last night [15:51:02] michael just settled one of my tests [15:51:55] okk just got a failmail that got sent tot he damaged message table from one of your tests [15:51:59] I guess [15:52:37] https://civicrm.wikimedia.org/civicrm/damaged/edit?action=update&id=618324&reset=1 [15:52:39] cstone: we could do that. I'll add separate scripts too. In theory we should only see traffic for one queue at a time so it should mean the visible output isn't overloaded in the combined one but I guess you might also just want to see one [15:52:40] I tried to make a recurring ACH last night but minfraud returned a score of 80 for me haha [15:52:43] which blocked everything [15:52:52] jgleeson: I think i added one just for the other redis? [15:52:55] or was it never merged [15:53:14] we usually get this kind of error so I was hoping you'd be able to describe what led to this one. [15:53:17] jgleeson: i was thnking more too the redis one probably does make sense to combine its not quite the same sitaution as the queue [15:53:23] ooh nice damilare lemme see what one it was [15:53:39] they are both redis cstone [15:53:58] I'm confused now [15:54:15] sorry jgleeson I am taking back what I said haha about separate [15:54:26] ah ok sorry lol [15:56:09] I was trying to say I had made a separate email prefs redis script but maybe it was never merged? but then also thinking about it a combined one makes sense there, but then was thinking about a less combined queue consume one [15:56:26] ahh [15:56:47] yes I agree on breaking out of queue consume script [15:57:15] something like smashpig-queue-consume.sh [15:57:21] with the smashpig ones in there [15:57:22] yeah damilare on that one it got stopped at auth which I think doesnt return the token? [15:57:47] jgleeson: i was thinking more like use case too like one for just getting a test donation in [15:58:07] hmmm [15:58:14] that could work too [15:58:31] looking at the logs last night damilare i saw the token was not returned which I thought was a bug from the depoy I just did [15:58:42] but did not see the fraud score 117 line [15:58:51] deploy [15:59:25] payments-adyen:Mar 7 05:03:56 payments1006 adyen_gateway: 204399819:204399819.1 Created payment rejected by our fraud filters [15:59:25] payments-adyen:Mar 7 05:03:56 payments1006 adyen_gateway: 204399819:204399819.1 No token found on successful recurring payment authorization response. [15:59:33] haha it was right there! i guess i saw succesfful first [16:00:06] ahh so no token was generated because it got rejected by us from the filters [16:01:06] im guessing? i did not look into it more [16:01:20] some good lighthearted news fr-tech. The kangaroos are migrating :) https://www.bbc.co.uk/news/av/world-australia-68501403 [16:01:37] always nice when golf courses are taken back :P [16:01:41] :D [16:02:45] It would be great if one of the kangaroos stopped picked up his golf ball and carried on [16:02:53] "thanks for that" [16:04:38] and now I'm laughing that video just reminded of this gem and I liked the first comment as it's very true https://www.youtube.com/watch?v=3GRSbr0EYYU [16:15:33] wikibugs didn't announce it, so: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1009562 Fix validation for amount [16:15:39] (03PS1) 10Ejegg: Fix validation for amount [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009562 (https://phabricator.wikimedia.org/T356370) [16:15:48] oh hah, sorry wikibugs [16:32:09] (03PS1) 10Jgleeson: Split out consume-queues.sh script by service. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009564 [16:32:30] cstone: damilare I know y'all have mentioned that once or twice ^ [16:40:25] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9612138 (10Ejegg) @MSuijkerbuijk_WMF and @ppenlogl... [16:49:56] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9612202 (10MSuijkerbuijk_WMF) @Ejegg do you have a... [16:54:20] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9612238 (10Ejegg) @MSuijkerbuijk_WMF I'm waiting f... [16:55:26] fr-tech folks are hoping to start QAing the recur upgrade landing page by next Wednesday [16:55:41] given that I'm out Mon-Wed next week, I'd have to deploy... today [16:56:05] (03PS1) 10Ejegg: Add new amount and next date to upgrade success page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009569 (https://phabricator.wikimedia.org/T356370) [16:56:16] so if anyone has a minute to review ^^^ and its parent patches, I'd be grateful! [16:58:32] ejegg: I reviewed two earlier [16:58:58] will look at the last one soon if no one else gets to it [16:59:36] fr-tech can we do the autopsy now? [16:59:54] There's some monthly donations meeting in half an hour overlapping when the autopsy got bumped to [17:00:07] thanks jgleeson ! Lemme just look at that CR [17:00:33] ejegg: ah, same question I had in our private channel [17:00:41] Oh rockin, you merged 'em! [17:00:44] Let's try to have standup now. [17:02:25] (03PS2) 10Ejegg: Fix validation for amount [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009562 (https://phabricator.wikimedia.org/T356370) [17:02:27] (03PS2) 10Ejegg: Add new amount and next date to upgrade success page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009569 (https://phabricator.wikimedia.org/T356370) [17:02:33] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9612292 (10MSuijkerbuijk_WMF) Sounds good, thanks! [17:19:17] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9612419 (10Ejegg) Oops, sorry for the mixup @ppenl... [17:28:33] (03PS6) 10D3r1ck01: IPVelocityTest: Avoid use of global state `ObjectCache::$instances` [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009514 (https://phabricator.wikimedia.org/T358346) [17:29:16] damilare: is Wikimedia +1 877 600 9454 (Recurring) looks good to you? I do not want to make it too long [17:31:02] wfan: I think there's a string passed from civi by default: smashpig_recurring_charge_descriptor [17:31:20] it has value Wikimedia 877 600 9454 [17:31:36] so we can check for that string and append "recurring" to the end of it [17:31:54] I see that, ok, also confirm with Rakhi see if that works for her [17:32:12] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9612500 (10AnnWF) Is Wikimedia +1 877 600 9454 (Recurring) as the recurring description looks ok for you? @RKumar_WMF [17:32:18] sounds good [17:34:13] (03PS1) 10Wfan: If recurring, add (recurring) after description for dlocal console [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009579 (https://phabricator.wikimedia.org/T356963) [17:34:39] (03PS4) 10Wfan: If recurring, add (recurring) after description for dlocal console [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008936 (https://phabricator.wikimedia.org/T356963) [17:45:10] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: replace our drush scripts with WMFQueue.consume api - https://phabricator.wikimedia.org/T357470#9612601 (10Dwisehaupt) @Eileenmcnaughton The way process control is designed right now is... [18:13:26] ejegg: so I tried some of the jobs using the new pc-option here https://phabricator.wikimedia.org/T357470#9609838 [18:13:26] which looked good. Just wondering about the process for switching them over. It's worth noting that if we do want to run them under their own users then it would be easy enough to create a bunch of new users through the UI & specify them as we update the jobs. Once updated we can delete whole modules from the queue2civicrm. One gotcha is some of them do some extra things - mostly stats - but optin (the first one I [18:13:26] looked at doesn't seem to do anything the WMFQueue.consume doesn't [18:14:10] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: replace our drush scripts with WMFQueue.consume api - https://phabricator.wikimedia.org/T357470#9612776 (10Eileenmcnaughton) @Dwisehaupt probably doesn't make sense to do if it is a big... [18:16:47] (03PS2) 10Eileen: Remove last reference to db_switcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) [18:26:57] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9612848 (10Ejegg) @ehughes I was just in a meeting... [18:29:32] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences: Redirect to ThankYou wiki after completing upgrade - https://phabricator.wikimedia.org/T359578 (10Ejegg) 03NEW [18:32:53] 06Fundraising-Backlog: Belgium currency formatting issue - https://phabricator.wikimedia.org/T359579 (10nisrael) 03NEW [18:50:53] (03PS1) 10Eileen: Use more efficient loading in import extensions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009586 (https://phabricator.wikimedia.org/T341902) [18:51:08] maybe it's bI have a new fix on the import slowness issue ^^ [18:53:38] (03PS2) 10Eileen: More import mappings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1006599 (https://phabricator.wikimedia.org/T354911) [18:54:32] (03CR) 10Eileen: "ejegg - I met with Nora & confirmed what's going on - basically she confirmed it's Ok to map the source field only & ignore reason - https" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1006599 (https://phabricator.wikimedia.org/T354911) (owner: 10Eileen) [18:59:52] (03PS1) 10Eileen: Add mid-value prospect back into the Acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1009587 (https://phabricator.wikimedia.org/T353264) [19:01:26] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264#9613019 (10Eileenmcnaughton) The option is back & the triggers are updated for mid-value prospect. I also put a patch up to add it into the Acous... [19:13:50] 06Fundraising-Backlog: Belgium currency formatting issue - https://phabricator.wikimedia.org/T359579#9613073 (10Ejegg) Perhaps the number formatting is better done in the Acoustic UI? Or is that very difficult? Our acoustic export is sending both_funds_latest_native_amount as a number, currency code as a 3 lett... [19:14:06] (03PS3) 10Ejegg: More import mappings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1006599 (https://phabricator.wikimedia.org/T354911) (owner: 10Eileen) [19:14:09] (03CR) 10Ejegg: [C: 03+2] More import mappings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1006599 (https://phabricator.wikimedia.org/T354911) (owner: 10Eileen) [19:15:45] gonna look at those recurring upgrade patches now [19:16:44] thanks! [19:21:19] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264#9613139 (10Eileenmcnaughton) I've tried updating like this ` echo '{"values":{"donor_segment_id":"","donor_status_id":""},"where":[["id","BETWEE... [19:26:32] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264#9613161 (10Eileenmcnaughton) Note I've done a handful - up to echo '{"values":{"donor_segment_id":"","donor_status_id":""},"where":[["id","BETWE... [19:32:20] (03PS2) 10Eileen: Use more efficient loading in import extensions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009586 (https://phabricator.wikimedia.org/T341902) [19:32:32] (03Merged) 10jenkins-bot: More import mappings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1006599 (https://phabricator.wikimedia.org/T354911) (owner: 10Eileen) [19:36:24] 06Fundraising-Backlog, 07Epic: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9613195 (10Pcoombe) @AKanji-WMF I'm out of office next week, but feel free to put something on my calendar for when I'm back [19:36:45] 06Fundraising-Backlog: Belgium currency formatting issue - https://phabricator.wikimedia.org/T359579#9613197 (10nisrael) I don't believe we're able to format the currency in Acoustic UI. We're simply pulling the latest donation amount via the **both_funds_latest_native_amount** provided by Civi. [19:48:46] eileen: did we want to move any of the p-c jobs to using the cv based path? like maybe email_preferences_queue_consume or upi_donations_queue_consume [19:49:19] dwisehaupt: yeah - I think so - just hoping to bring ejegg in on the change too [19:49:42] ah, cool. just wasn't sure how close we were to ready. no issues from this side. [19:50:39] yeah I think it's all OK - at least to start on it [19:51:21] cool. pretty interested to make the switch and see how it goes for the future. :) [20:01:37] 06Fundraising-Backlog: Belgium currency formatting issue - https://phabricator.wikimedia.org/T359579#9613266 (10nisrael) @Ejegg you are right. And actually now that I'm digging deeper I see that this issue is actually just specific to Belgium because we do format our code to not include the decimal points for ou... [20:02:29] (03PS1) 10Eileen: Was it just a good idea at the time? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009596 (https://phabricator.wikimedia.org/T357471) [20:05:02] not good when eileen is mentioning dark magic must be extra complicated :P [20:05:15] :-) [20:05:50] (03PS2) 10Eileen: Was it just a good idea at the time? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009596 (https://phabricator.wikimedia.org/T357471) [20:07:11] (03PS3) 10Ejegg: Was it just a good idea at the time? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009596 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:07:28] (03CR) 10Ejegg: [C: 03+2] "Radical simplification! I'm for it." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009596 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:12:03] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:12:05] I feel like I recall us hitting that max field length issues a few years back [20:12:55] jgleeson: yeah possibly - it hasn't always been handled so centrally in core - it's now in the DAO::writeRecord() function [20:13:45] https://phabricator.wikimedia.org/T332991 [20:14:16] oh ha that was actually to do with a mb_string causing it to trip [20:24:24] If anyone has headspace I'm looking at decommisioning `wmf_civicrm_verify_message_and_stage` (which would mean moving a cut down version back into each of the 2 callers) [20:24:24] It is called from 2 places [20:24:24] - wmf_civicrm_contribution_message_import [20:24:25] - UPIQueueConsumer::insertContributionRecur() [20:26:18] (03Merged) 10jenkins-bot: Was it just a good idea at the time? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009596 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:29:39] hah not what i was expected the adyen audit to fail for [20:30:59] hah our csv is html [20:33:17] ill move that to completed so it wont break it again [20:43:51] ok adyen thing isnt as complicated as I thought just a lot of email to get through [20:46:02] lol planned maintenance [20:50:03] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009562 (https://phabricator.wikimedia.org/T356370) (owner: 10Ejegg) [20:50:12] thanks jgleeson ! [20:52:02] (03Merged) 10jenkins-bot: Fix validation for amount [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009562 (https://phabricator.wikimedia.org/T356370) (owner: 10Ejegg) [20:54:30] i made a new account on our adyen sandbox for the amazon testing [20:54:36] it just needed a separate account from our live one [21:08:27] I think this will sort out the import taking forever issue -https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1009586 [21:09:52] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Email: Update Acoustic Unsubscribe landing page domain to be served by a secure wikimedia.org domain - https://phabricator.wikimedia.org/T336000#9613466 (10EWilfong_WMF) Hi all, I have an update from Acoustic on the landing page domain. In order to provi... [21:21:18] nice cstone. that's moving quickly [21:30:48] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 07Spike: Figure out what to do with Amazon Integration - https://phabricator.wikimedia.org/T358624#9613546 (10Cstone) Adyen got back they need to enable it in test and production at the same time but will disable the production until we need it... [21:37:16] (03CR) 10Jgleeson: [C: 03+2] "Nice job on this and the other patches. The code is clean, and it all looks and works well for me. Thanks! Big improvement overall to the " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009569 (https://phabricator.wikimedia.org/T356370) (owner: 10Ejegg) [21:39:23] (03Merged) 10jenkins-bot: Add new amount and next date to upgrade success page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009569 (https://phabricator.wikimedia.org/T356370) (owner: 10Ejegg) [22:26:17] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1009615 [22:27:12] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1009615 (owner: 10Ejegg) [22:28:25] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1009615 (owner: 10Ejegg) [22:28:40] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1009616 [22:34:18] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1009616 (owner: 10Ejegg) [22:42:38] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1009616 (owner: 10Ejegg) [22:49:03] !log donorwiki upgraded from bc49e5a6 to 9b31d4fe [22:49:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:54:43] Where is the donor wiki [22:55:05] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, 10Recurring-Donations: Send thank you email confirming recurring donation upgrade - https://phabricator.wikimedia.org/T356373#9613643 (10Ejegg) a:03Ejegg [22:55:06] Same frpm? [23:01:52] wfan it's deployed from there, yep [23:02:02] but it's the one with email preferences and the recurring upgrade page [23:02:48] eileen: do the workflow entries get automatically created when you add a messageTemplate with a new workflow name in the mgd file? [23:03:10] I'm not seeing where e.g. recurring_failed_message gets created [23:03:43] hmm so by workflow entries you mean? [23:04:07] oh derp [23:04:08] when you create via the mgd file you get a row in civicrm_msg_template (well 2 probably) + possibly some in civicrm_translation [23:04:13] it's just a string [23:04:18] i thought it was a FK [23:04:51] yeah that workflow_name field is tied to the relevant WorkFlowMessage class & Example file by virtue of them specifying it [23:05:27] yep yep, ok, i can proceed [23:05:34] ah, found a tiny cleanup too [23:07:09] (03PS1) 10Ejegg: Clean up some message template stuff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009619 [23:07:21] trivial cleanup eileen ^^ [23:08:04] (03PS3) 10Ejegg: Remove last reference to db_switcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:11:02] (03CR) 10Eileen: [C: 03+2] Clean up some message template stuff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009619 (owner: 10Ejegg) [23:11:07] yep - makes sense [23:11:11] Understand~ thanks ejegg ：） [23:13:04] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate rest of normalize into WMFMessage class - https://phabricator.wikimedia.org/T357471#9613657 (10Eileenmcnaughton) If anyone has headspace I'm looking at decommisioning `wmf_civic... [23:29:56] (03Merged) 10jenkins-bot: Clean up some message template stuff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009619 (owner: 10Ejegg) [23:32:10] ejegg: I do have some things I want to catch up with you on but suspecting it might be next week now? [23:33:09] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen)