[00:02:20] shoot eileen, probably. I'm working tomorrow, but that's your Saturday [00:02:46] yeah - it just seems to have been a hectic week huh [00:02:54] (03PS4) 10Ejegg: Remove last reference to db_switcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [00:02:58] (03CR) 10Ejegg: [V: 03+2] Remove last reference to db_switcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009366 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [00:03:24] one thing tho is this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1009586 I think that might get us through that import! [00:04:04] Really eileen? The CSV reading is the slow part at this point? [00:04:09] I guess they are honking huge files [00:04:50] ejegg: yeah - I think it's having to find the line row by row - current theory [00:05:11] (03PS1) 10Ejegg: Delete a couple of unused functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009625 [00:05:12] so 50 * find line 280000 to get 50 rows [00:06:22] (03CR) 10Eileen: [C: 03+2] "deleting functions makes me happy" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009625 (owner: 10Ejegg) [00:12:25] (03PS3) 10Ejegg: Use more efficient loading in import extensions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009586 (https://phabricator.wikimedia.org/T341902) (owner: 10Eileen) [00:12:53] (03CR) 10Ejegg: [C: 03+2] Use more efficient loading in import extensions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009586 (https://phabricator.wikimedia.org/T341902) (owner: 10Eileen) [00:13:06] yeah, definitely a better way to do it! [00:17:34] eileen: Can you check some sql for me quick? [00:17:35] https://phabricator.wikimedia.org/P58662 [00:18:08] So I've got a bunch of rows in contribution_recur_copy for all the donors with Ingenico recurrings cancelled from october to december [00:18:31] and I'm just trying to find the subset of those who have an active recurring attached to their email address [00:18:39] but that query is giving me zero [00:18:45] which is definitely possible [00:19:03] but there are like 5k donors in that table, so I'm a little surprised [00:19:11] Am I missing something dumb on the joins there? [00:21:36] looking [00:23:52] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009627 [00:24:10] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009627 (owner: 10Eileen) [00:25:04] (03Merged) 10jenkins-bot: Delete a couple of unused functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009625 (owner: 10Ejegg) [00:32:17] eg.g I tried another way to get to the same date & found no rows [00:32:25] (03Merged) 10jenkins-bot: Use more efficient loading in import extensions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009586 (https://phabricator.wikimedia.org/T341902) (owner: 10Eileen) [00:32:27] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009627 (owner: 10Eileen) [00:35:08] ejegg: sorry mis-ping above [00:35:10] !log config revision changed from 77ff8877 to 58829954 [00:35:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:47:20] thanks eileen ! [00:48:31] looks like that last deploy didn't quite get the CSV efficiency [00:48:55] well it has just started it's first new pick up since the deploy [00:49:13] & is 6 mins into that [00:51:23] hang on - not sure I see the change in the deployed list [00:52:14] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009629 [00:52:26] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009629 (owner: 10Eileen) [00:53:32] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1009629 (owner: 10Eileen) [00:55:04] !log civicrm upgraded from 867fc977 to 50278dbc [00:55:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:11:17] ahhh derp i mean NOT IN (1,3,4) [01:11:56] that gets a few [01:16:49] err, ok, doing it piecewise gets way more [01:26:59] oh fudge [01:27:04] argh [01:27:22] I need to restore some things from log tables [01:27:41] I just deleted from the real live civicrm_contribution_recur table [01:27:56] fortunately just the ones that were already canceled [01:28:01] but... OOOPS [01:28:35] i think the API undo will work [01:31:15] oh dear - might be time to call it! [01:31:52] ejegg: the queue has sped up now [01:32:30] halelujah, the recurs are back [01:33:09] hah, no, $kid has just gone up to bed, I can actually concentrate now [01:36:39] yay for recurs [01:50:15] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9613990 (10Ejegg) a:03Ejegg OK, there were 4196 Ingenico recurrings that * failed in Oct-Dec * were possible to migrate from the Ingenico... [01:54:08] hmm might have made a long running search kit query lets see if it finishes [01:55:49] it did finish! [01:57:35] 06Fundraising-Backlog: Belgium currency formatting issue - https://phabricator.wikimedia.org/T359579#9614001 (10Ejegg) 05Open→03Resolved a:03Ejegg [02:07:53] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations, 10Thank-You-Page: Create thank you pages for recurring upgrade - https://phabricator.wikimedia.org/T335881#9614007 (10Ejegg) Looks like @ehughes is going to make these on thank-you-wiki. The task to make our form redirect to this page is her... [02:15:50] (03CR) 10Ejegg: "clever!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009546 (owner: 10Jgleeson) [02:24:42] oh nice we got a live example of cancelled the recurring while in the auto rescue state...i think [02:26:19] oho, canceled in the CIvi UI then? [02:26:35] yeah [02:26:45] it has an autorescue reference in the smashpig table [02:27:05] cid=16687552 [02:27:42] i dont remember that flow we sent a call to adyen do they send back a ipn saying they stopped? [02:32:25] (03CR) 10Cstone: "Hah we actually removed that phone number everywhere else looks like we missed this spot? https://phabricator.wikimedia.org/T336779" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008936 (https://phabricator.wikimedia.org/T356963) (owner: 10Wfan) [02:32:27] oh hmm, i don't know about an ipn [02:32:38] got distracted trying to find the code [02:32:42] our phone number lives on [02:33:19] I already at Rakhi, see if she want phone or not [02:33:40] are we putting it back wfan ? [02:33:48] https://phabricator.wikimedia.org/T336779 [02:34:43] We will see, not ready to review until rakhi confirmed the final descriptions they want [02:35:02] I think that other patch too wfan would put (Recurring) after all the recurrings which we should make sure DR is okay with too if we do that [02:35:03] But those places would get update together https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1009579 [02:35:10] I was just going to comment that [02:35:26] Yeah already let her knows [02:35:42] ok cool [02:36:15] just looks otherwise like an easy patch to merge [02:36:29] so going to add the comment [02:36:34] (03CR) 10Cstone: "I think this will update the descriptor for everyone right? We should make sure DR is okay with (Recurring) showing up" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009579 (https://phabricator.wikimedia.org/T356963) (owner: 10Wfan) [02:36:50] Sure 👍 [02:45:21] nice we do get an ipn [03:10:02] no [03:10:07] er [03:10:10] those were different ipns [03:11:39] 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9614044 (10RLopez-WMF) Thanks Dallas! I have access now. Is there a way to test/simulate a system workflow message sent? Do you have documentation about how to do that? I coded a new email proposal for the WMF Than... [03:29:08] 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9614050 (10RLopez-WMF) Thanks Christine for jumping in! Here is the list of emails i will need to send the tests to: rlopez@wikimedia.org wikimedia.4b69@litmusemail.com [05:30:11] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9614191 (10RKumar_WMF) Yes, looks good. The phone number appearing is something you have added or is it from dLocal? [06:38:47] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9614243 (10RKumar_WMF) Let us use “Wikimedia foundation (recurring)”. TY. [07:10:29] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9614258 (10AnnWF) >>! In T356963#9614243, @RKumar_WMF wrote: > Let us use “Wikimedia foundation (recurring)”. TY. Thanks 😊 wi... [07:47:30] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9614292 (10MSuijkerbuijk_WMF) Thanks Elliott. @krobinson @shust and @AKanji-WMF tagging you three as per recent conversation. How do you s... [13:50:18] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences: Redirect to ThankYou wiki after completing upgrade - https://phabricator.wikimedia.org/T359578#9614965 (10ehughes) Hey @Ejegg , I spoke to @Pcoombe and we think the best way to do this is just to use the regular TY page... [13:51:18] 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Adyen: Better handle terse Adyen idempotency result - https://phabricator.wikimedia.org/T331319#9614974 (10jgleeson) I'm not sure of the best way to implement this. Did you have any thoughts when writing the ticket? [13:51:34] 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Investigate whether we can use mysql EXPLAIN checks to prevent runaway dedupe queries - https://phabricator.wikimedia.org/T355807#9614976 (10jgleeson) 05Declined→03Stalled [13:51:42] 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Deduper causing deadlocks - https://phabricator.wikimedia.org/T355677#9614977 (10jgleeson) [13:51:50] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Revisit deduper interface with a view to making it possible to do a search in search kit to dedupe - https://phabricator.wikimedia.org/T327728#9614978 (10jgleeson) [13:52:54] (03CR) 10Jgleeson: [C: 03+2] "LGTM! Builds locally without issue." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1009587 (https://phabricator.wikimedia.org/T353264) (owner: 10Eileen) [13:53:02] (03Merged) 10jenkins-bot: Add mid-value prospect back into the Acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1009587 (https://phabricator.wikimedia.org/T353264) (owner: 10Eileen) [13:55:33] better late than never wikibugs [13:58:04] (03PS1) 10Jgleeson: Add setup of silverpop_export.yaml config during --tools build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009751 [14:07:25] (03CR) 10Jgleeson: [C: 03+2] "Tested locally and works as expected for me" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009365 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:09:08] (03CR) 10Jgleeson: [C: 03+2] "Makes sense. LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008946 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [14:13:11] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008525 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [14:13:19] (03Merged) 10jenkins-bot: Move last 2 queue consumer tasks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009365 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:26:39] (03CR) 10Jgleeson: [C: 04-1] "Everything looks good. Just one suggestion and a small typo. Other than that it's ready to go." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008869 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [14:32:22] (03Merged) 10jenkins-bot: Move function back to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008946 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [14:32:24] (03Merged) 10jenkins-bot: Add Address object for DonorDetails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008525 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [14:46:52] thanks for the CR jgleeson ! [14:47:01] looking at that suggestion now [14:49:02] np! [14:49:04] back soon [16:16:38] (03CR) 10Daniel Kinzler: [C: 03+2] IPVelocityTest: Avoid use of global state `ObjectCache::$instances` [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009514 (https://phabricator.wikimedia.org/T358346) (owner: 10D3r1ck01) [16:22:02] (03Merged) 10jenkins-bot: IPVelocityTest: Avoid use of global state `ObjectCache::$instances` [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009514 (https://phabricator.wikimedia.org/T358346) (owner: 10D3r1ck01) [16:53:23] (03PS1) 10Jgleeson: Change how we reclone projects to fix bind mount bug. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009777 [16:54:06] wfan: remember that issue you had where you couldn't install one of the apps? this patch should fix it https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1009777 [17:06:55] Cool! I destroyed the image and reinstall to make it right. And will test this with my other laptop haha thanks 😊 Jack [17:36:59] thanks! [17:37:03] have a good weekend all [18:09:11] (03PS5) 10Wfan: If recurring, add (recurring) after description for dlocal console [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008936 (https://phabricator.wikimedia.org/T356963) [18:10:51] (03PS2) 10Wfan: Update description for following recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009579 (https://phabricator.wikimedia.org/T356963) [18:56:30] (03PS4) 10Ejegg: Add address info to normalized PayPal responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008869 (https://phabricator.wikimedia.org/T336449) [18:56:47] (03CR) 10Ejegg: "Thanks for the review jgleeson. I fixed the things you pointed out." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008869 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [19:10:56] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9616138 (10Ejegg) @MSuijkerbuijk_WMF, I have some problems with that copy - the 'due to a technical error that affected a small number of d... [20:01:27] (03PS1) 10Ejegg: Factor out base class for recurring message previews [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009791 (https://phabricator.wikimedia.org/T356373) [20:01:31] (03PS1) 10Ejegg: Add template for Recurring Upgrade thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009792 (https://phabricator.wikimedia.org/T356373) [20:19:36] (03PS1) 10Ejegg: Send recurring upgrade thank you emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009796 (https://phabricator.wikimedia.org/T356373) [20:20:02] ^^^ some copypasta from the FailureEmail, and still needs smoke testing, but that might be enough to get us ready for QA [20:24:50] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Reattempt failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9616381 (10EMartin) @MSuijkerbuijk_WMF Hi Mariana, are we clear here that this wasn't a technical error to this message is not accurate. W... [20:26:16] (03CR) 10Umherirrender: [V: 03+2] build: Updating dependencies [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1002696 (owner: 10Libraryupgrader) [20:26:30] (03CR) 10Wfan: [C: 03+2] "LTGM~" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009777 (owner: 10Jgleeson) [20:29:34] (03CR) 10Wfan: [C: 03+2] "Cool to have the donorprefsqueue moniter" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009546 (owner: 10Jgleeson) [21:18:21] ejegg: do you need those reviewed today then? I am back at my computer [21:19:04] if you have time that would be great! [21:19:15] i will be working till late i think [21:19:28] ok i will be too its cold rain outside [21:19:36] dont miss this weather at all [22:30:57] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences: Redirect to ThankYou wiki after completing upgrade - https://phabricator.wikimedia.org/T359578#9616681 (10Ejegg) OK @ehughes, I'll pass in e.g. recurUpgrade=1&recurDate=2024-03-24&recurAmount=3.75&recurCurrency=USD&cou... [22:49:34] (03PS1) 10Ejegg: Slight refactor for recurUpgrade declines [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009807 (https://phabricator.wikimedia.org/T359578) [23:08:58] hmm ejegg when you were testing the email does it actually go to mailcatcher or I guess the failed one isnt either and its the same kind [23:10:17] argh, yeah, that's annoying [23:11:28] well it failed when I didnt have the mgd files there so I believe that it would send :P [23:12:21] (03CR) 10Cstone: [C: 03+2] Factor out base class for recurring message previews [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009791 (https://phabricator.wikimedia.org/T356373) (owner: 10Ejegg) [23:14:21] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009792 (https://phabricator.wikimedia.org/T356373) (owner: 10Ejegg) [23:14:32] woo, thanks! [23:16:19] ejegg: should this be in the same place code structure wise as the failure email or this another case of things just in differnt places as they were written at different times? [23:16:52] theres that monthly convert email too where is that one [23:20:23] ok thats some chaos old way that I apparently wrote haha [23:21:32] ok and failure email lives in smashpig instead [23:22:57] ejegg: what do you think about changing the name of UpgradeEmail to RecurringUpgradeEmail? [23:25:44] (03PS1) 10Ejegg: Redirect to Thank You page on recur upgrade (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009809 (https://phabricator.wikimedia.org/T359578) [23:27:40] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 13Patch-For-Review: Redirect to ThankYou wiki after completing upgrade - https://phabricator.wikimedia.org/T359578#9616774 (10Ejegg) @ehughes, when they decline to upgrade, we just send recurUpgrade=0, right (and maybe... [23:30:31] (03Merged) 10jenkins-bot: Factor out base class for recurring message previews [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009791 (https://phabricator.wikimedia.org/T356373) (owner: 10Ejegg) [23:33:04] (03Merged) 10jenkins-bot: Add template for Recurring Upgrade thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009792 (https://phabricator.wikimedia.org/T356373) (owner: 10Ejegg) [23:42:06] cstone: yeah, that could be a good rename, I guess I was just trying to be consistent with 'FailureEmail' [23:42:17] though we could easily rename them both! [23:44:24] and yeah, I was a bit flustered by the code being scattered all around [23:44:35] some of it in the wmf-thankyou module [23:44:39] some in wmf-civicrm [23:44:44] and then the other bit in SmashPig [23:45:19] hah, that SmashPig thing is supposed to be standalone, but I guess with FailureEmail it has a dependency on the templates in wmf-civicrm [23:45:39] we should have it fire a hook on failure instead and subscribe to that hook in wmf-civicrm [23:46:21] ejegg: I just could see a non recurring upgrade email show up somehow too [23:46:42] the thank you emails seem to work! [23:46:55] I think that's because the ty emails call sendmail directly [23:47:02] and the others use Civi's built-in mailer [23:47:17] maybe we're just missing some config for the built-in mailer in dev? [23:48:07] yeah i cant remember what we did to get the tys to work [23:55:06] ooh, getUpgradeableRecur seems to not be returning country