[00:08:37] ejegg: I think making it RecurringUpgradeEmail just because its not completely in recurring space like the failureEmail is, but i also agree with moving that one out [01:15:49] cstone also: we have a discrepancy between RecurUpgrade and RecurringUpgrade :( [01:16:12] we can still change the page name now, no emails have gone out! [01:17:21] Haha can never win with names [01:18:19] Id be ok with RecurUpgradeEmail cause at least that naming doesn't break search [01:19:23] (03PS1) 10Ejegg: Add TY page to email preferences center LocalSettings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009816 [01:19:51] dev settings patch for testing the redirect changes ^^^ [01:23:41] (03PS1) 10Ejegg: Redirect to Thank You page on recurring upgrade decline [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009817 (https://phabricator.wikimedia.org/T359578) [01:25:47] hmm, I guess we don't need to pass the whole time part of the date string across to the TY page [01:25:53] lemme truncate that to 10 chars [01:26:50] (03CR) 10Cstone: [V: 03+2 C: 03+2] Add TY page to email preferences center LocalSettings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009816 (owner: 10Ejegg) [01:28:01] ooh i didnt realize recurUpgrade is the special page ugh if only the civi table wasnt named recur :P [01:31:56] ok, I'll rename UpgradeEmail to RecurUpgradeEmail in that not-merged-yet CRM patch [01:32:59] ejegg: unrelated but is the integer only upgrade amount a request or just how we implemented it? [01:35:09] ohh? I thought I fixed that to allow non-ints [01:35:17] its not letting me [01:35:28] hmm, with variant=v01 or without? [01:36:03] also, I am thinking maybe we don't need a variant [01:36:29] ooh whatevre one is default from civi [01:38:17] i was able to upgrade to 10 million :) [01:38:50] lolol [01:39:19] oh from civi i think the default is the v01 [01:39:31] ok, let's put a max on that [01:40:16] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1009796/1/drupal/sites/default/civicrm/extensions/wmf-thankyou/Civi/Api4/Action/UpgradeEmail/Send.php#93 [01:40:24] not sure if brain not working but what is this line doing [01:40:52] or is result being magic passed somewhere [01:41:24] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: More amount validation for recurring upgrade - https://phabricator.wikimedia.org/T359694 (10Ejegg) 03NEW [01:41:28] or would we have multiple ids in one send? [01:41:58] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: More amount validation for recurring upgrade - https://phabricator.wikimedia.org/T359694#9617092 (10Ejegg) [01:42:00] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations, 07Epic: How can we enable upgrading of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317#9617093 (10Ejegg) [01:43:48] ah handleChains [01:46:38] ah yeah, $result is passed in to the _run function of any API4 action [01:46:50] and you just add things to $result like it was an array for them to be output [01:52:20] (03PS2) 10Ejegg: Send recurring upgrade thank you emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009796 (https://phabricator.wikimedia.org/T356373) [01:52:48] ok cstone that's renamed it [01:53:01] thanks ejegg [01:53:06] if you had the other version checkout out before you'll need to do a system.flush with that ptach [01:53:21] as the API4 caches some metadata [01:53:28] (03PS1) 10Ejegg: Add country to getUpgradeableRecur output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009820 (https://phabricator.wikimedia.org/T359578) [01:53:51] ok, and THAT patch gets getUpgradeableRecur to output the donor's country [01:54:00] but... I'm still not seeing it pass all the way through [01:54:29] I don't think we're sanitizing in civiproxy on the way out much... [01:54:35] just on the way in [01:54:44] in the url ejegg ? [01:55:33] ignore thta lemme read the patch hah [01:55:37] so we want to pass country to the TY page [01:55:43] but we weren't even getting it from civi [01:55:53] ahhh the ty page [01:56:27] so that last Civi patch adds it to the output of the API call we make from the upgrade form [01:57:52] oh gross, why is it wrapped an extra level deep? [01:58:02] OK, I wanna make a breaking change now before it's too late [02:00:56] (03CR) 10Cstone: [C: 03+2] "thanks! looks good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009796 (https://phabricator.wikimedia.org/T356373) (owner: 10Ejegg) [02:01:10] ohhhhhhh we were expecting country on the recurring form params??? [02:01:20] hah i didn't have that [02:01:23] should I look at the DI ones now ejegg or is what you are wokring on now on both sides? [02:02:42] sure, if you want to look at the DI ones that would be great [02:02:46] okie [02:04:02] ok, so I'm going to get rid of this country param on the incoming email link, i think [02:04:25] or... we make it optional, and use the one from the address as backup [02:11:49] ejegg: the integer thing is fixed I had the wrong branch checked out [02:18:27] (03Merged) 10jenkins-bot: Send recurring upgrade thank you emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009796 (https://phabricator.wikimedia.org/T356373) (owner: 10Ejegg) [02:18:28] oh i see [02:18:34] woohoo [02:19:18] (03CR) 10Cstone: [C: 03+2] Slight refactor for recurUpgrade declines [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009807 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [02:19:36] should we just add that variable now on the deploy note one? [02:19:43] its not going to break in advance right? [02:19:46] sure, might as well! [02:19:48] ok [02:19:50] i can do [02:20:21] ok, i'm logged in too so i can give it the verbal +2 whenever [02:20:25] okie [02:21:03] (03Merged) 10jenkins-bot: Slight refactor for recurUpgrade declines [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009807 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [02:21:30] wait where are the settings hah [02:21:39] donorwiki! [02:21:46] so not in local settings? [02:21:49] ohhh wait [02:21:58] d'oh, is it all puppetized? [02:22:00] lemme see [02:22:09] theres only donorwiki-data [02:22:20] arrr, ok, yeah, then it's just puppet [02:22:55] wanna hop on a call and make a puppet patch to send to Jeff_Green or dwisehaupt on monday? [02:23:05] sure [02:23:20] today's autopsy link? [02:23:35] okie [02:33:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23380MiB (88% inode=99%): /var/tmp 422MiB (99% i [02:33:13] : /var/log/audit 422MiB (99% inode=99%): /run/user/3649 6392MiB (100% inode=99%): /run/user/16765 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [02:38:15] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23380MiB (88% inode=99%): /var/tmp 422MiB (99% i [02:38:15] : /var/log/audit 422MiB (99% inode=99%): /run/user/3649 6392MiB (100% inode=99%): /run/user/16765 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [02:43:15] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23380MiB (88% inode=99%): /var/tmp 422MiB (99% i [02:43:15] : /var/log/audit 422MiB (99% inode=99%): /run/user/3649 6392MiB (100% inode=99%): /run/user/16765 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [02:45:21] (03PS1) 10Ejegg: Unbreak recur upgrade rancel button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009822 [02:45:54] (03PS2) 10Ejegg: Unbreak recur upgrade cancel button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009822 [02:48:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23372MiB (88% inode=99%): /var/tmp 422MiB (99% i [02:48:13] : /var/log/audit 422MiB (99% inode=99%): /run/user/16765 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [02:52:32] (03PS1) 10Ejegg: Recur Upgrade: use donor country when none on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009823 (https://phabricator.wikimedia.org/T359578) [02:53:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6391MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23372MiB (88% inode=99%): /var/tmp 422MiB (99% i [02:53:13] : /var/log/audit 422MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [02:58:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6391MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23371MiB (88% inode=99%): /var/tmp 422MiB (99% i [02:58:13] : /var/log/audit 422MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:00:53] (03CR) 10Cstone: [C: 03+2] "we have a puppet patch out to handle the deploy note" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009809 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:01:55] (03CR) 10Cstone: [C: 03+2] Add country to getUpgradeableRecur output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009820 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:02:40] (03Merged) 10jenkins-bot: Redirect to Thank You page on recur upgrade (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009809 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:02:42] (03CR) 10Cstone: [C: 03+2] Redirect to Thank You page on recurring upgrade decline [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009817 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:02:46] (03CR) 10Cstone: [C: 03+2] Unbreak recur upgrade cancel button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009822 (owner: 10Ejegg) [03:02:56] (03CR) 10Cstone: [C: 03+2] "looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009823 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:03:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23355MiB (87% inode=99%): /var/tmp 422MiB (99% i [03:03:13] : /var/log/audit 422MiB (99% inode=99%): /run/user/212 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:04:34] (03Merged) 10jenkins-bot: Redirect to Thank You page on recurring upgrade decline [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009817 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:04:49] (03Merged) 10jenkins-bot: Unbreak recur upgrade cancel button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009822 (owner: 10Ejegg) [03:04:53] (03Merged) 10jenkins-bot: Recur Upgrade: use donor country when none on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009823 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:08:15] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23338MiB (87% inode=99%): /var/tmp 422MiB (99% i [03:08:15] : /var/log/audit 422MiB (99% inode=99%): /run/user/212 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:13:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6391MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23383MiB (88% inode=99%): /var/tmp 422MiB (99% i [03:13:13] : /var/log/audit 422MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:16:39] thanks for all the CR cstone! [03:16:49] np ejegg ! [03:18:15] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6391MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23375MiB (88% inode=99%): /var/tmp 422MiB (99% i [03:18:15] : /var/log/audit 422MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:18:29] hmmmm audit [03:20:40] (03Merged) 10jenkins-bot: Add country to getUpgradeableRecur output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1009820 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [03:21:30] audit files eating up the whole disk? [03:21:36] or other failmails? [03:23:13] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31936MiB (100% inode=99%): /run 6391MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 584MiB (4% inode=90%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23375MiB (88% inode=99%): /var/tmp 422MiB (99% i [03:23:13] : /var/log/audit 422MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:24:09] im bad at actually reading what these mean [03:25:43] ohhh /home is full on frpm [03:25:53] lemme see how much i have in mine [03:26:02] could it be that puppet repo is really big? [03:26:11] and that your cloning it justt tipped /home over the line? [03:26:11] ah hah [03:26:21] yeah that or that tiny file? [03:26:25] i can delete that puppet repo [03:26:33] hang on [03:26:49] ooh my homedir is 2.4 gig [03:27:12] oh wow and 1.8G of that is my puppet repo [03:27:18] ok its gone [03:27:18] I wonder how to slim that down [03:27:25] mine at least so should make it happy again [03:28:13] RECOVERY - check_disk on frpm1002 is OK: DISK OK - free space: /dev 31936MiB (100% inode=99%): /run 6390MiB (99% inode=99%): / 3344MiB (47% inode=83%): /dev/shm 31960MiB (99% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 314MiB (74% inode=99%): /home 2873MiB (23% inode=91%): /tmp 12350MiB (99% inode=99%): /srv 218627MiB (75% inode=48%): /var 21587MiB (81% inode=98%): /var/log 23375MiB (88% inode=99%): /var/tmp 422MiB (99% inode=99%) [03:28:13] g/audit 422MiB (99% inode=99%): /run/user/3649 6392MiB (100% inode=99%): /run/user/16765 6392MiB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [03:28:31] there we go [03:29:15] wow mine shrunk by 1GB when i just ran git gc [03:29:22] gc for garbage collect [03:29:30] whole lot of garbage piled up [03:42:04] (03PS2) 10Ejegg: Fix proxy-forward script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003980 [03:42:06] (03CR) 10Ejegg: [V: 03+2] Fix proxy-forward script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1003980 (owner: 10Ejegg) [14:45:15] (03PS1) 10Umherirrender: Fix casing of dropdown-related methods [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1009832 [21:30:50] (03CR) 10Krinkle: [C: 03+2] Fix casing of dropdown-related methods [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1009832 (owner: 10Umherirrender) [21:54:55] (03Merged) 10jenkins-bot: Fix casing of dropdown-related methods [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1009832 (owner: 10Umherirrender)