[00:09:00] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sbaruchel - https://phabricator.wikimedia.org/T355901#9622205 (10Dwisehaupt) 05Open→03Resolved Verified as working. [03:23:56] (03CR) 10Ejegg: [C: 03+2] Migrate OptIn to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1010329 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [03:23:59] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Migrate OptIn to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1010329 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [04:18:25] (03PS2) 10Eileen: Move RefundQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008586 (https://phabricator.wikimedia.org/T357469) [05:33:06] 06Fundraising-Backlog: Turn on post MC for rtbt and ACH? - https://phabricator.wikimedia.org/T359877#9622431 (10MSuijkerbuijk_WMF) Yes from my perspective good to activate for post MC for now (until I work with Sam and team on how to roll out ACH in the donation form = organic and pre MC) [05:39:45] (03PS1) 10Eileen: Ensure all values in row are strings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010352 [06:56:29] (03CR) 10Eileen: [C: 03+2] "Actually I'm gonna self +2 this since the import's stalled anyway...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010352 (owner: 10Eileen) [07:15:06] (03Merged) 10jenkins-bot: Ensure all values in row are strings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010352 (owner: 10Eileen) [07:16:53] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1010452 [07:17:54] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1010452 (owner: 10Eileen) [07:18:53] !log civicrm upgraded from 1cc73ba9 to 3cab2177 [07:18:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:13:20] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9623598 (10MSuijkerbuijk_WMF) @Ejegg could you share the link with me fo... [14:39:05] 06Fundraising-Backlog, 10FR-donorservices: Investigation Needed for Cancellation Error on Recurring Donation - https://phabricator.wikimedia.org/T359942 (10SHust) 03NEW [15:31:50] (03PS1) 10Reedy: Fix casing of MediaWiki [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 [15:56:10] (03CR) 10Jforrester: [C: 03+2] Fix casing of MediaWiki [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 (owner: 10Reedy) [16:37:59] (03PS1) 10Ejegg: Better amount validation for RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010560 (https://phabricator.wikimedia.org/T359694) [16:48:04] (03CR) 10CI reject: [V: 04-1] Fix casing of MediaWiki [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 (owner: 10Reedy) [17:17:05] hmm, that validation isn't quite working [17:49:24] (03PS2) 10Ejegg: Better amount validation for RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010560 (https://phabricator.wikimedia.org/T359694) [17:51:23] (03CR) 10CI reject: [V: 04-1] Better amount validation for RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010560 (https://phabricator.wikimedia.org/T359694) (owner: 10Ejegg) [18:40:07] (03PS3) 10Ejegg: Better amount validation for RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010560 (https://phabricator.wikimedia.org/T359694) [19:05:31] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): Redirect to ThankYou wiki after completing upgrade - https://phabricator.wikimedia.org/T359578#9624767 (10Ejegg) OK, the redirect part of this is done - either outcome on th... [19:06:06] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): Create variant version of Recurring Upgrade landing page - https://phabricator.wikimedia.org/T356370#9624771 (10Ejegg) [19:06:31] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): Redirect to ThankYou wiki after completing upgrade - https://phabricator.wikimedia.org/T359578#9624768 (10Ejegg) 05Open→03Resolved [19:06:35] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations, 07Epic: How can we enable upgrading of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317#9624774 (10Ejegg) [19:06:37] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, 10Recurring-Donations: Send thank you email confirming recurring donation upgrade - https://phabricator.wikimedia.org/T356373#9624772 (10Ejegg) 05Open→03Resolved [19:12:51] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Correcting Gift Source Coding on Benevity import - https://phabricator.wikimedia.org/T354911#9624794 (10Eileenmcnaughton) this should be done @NNichols [19:19:02] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Create new Benevity import - https://phabricator.wikimedia.org/T359219#9624820 (10XenoRyet) [19:19:06] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Recurring charge job: what happens to a donation that gets skipped by the 2 within 23 days rule - https://phabricator.wikimedia.org/T357350#9624821 (10XenoRyet) [19:19:08] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import deceased date - https://phabricator.wikimedia.org/T357346#9624822 (10XenoRyet) [19:19:11] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9624823 (10XenoRyet) [19:19:19] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448#9624824 (10XenoRyet) [19:19:27] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9624825 (10XenoRyet) [19:19:35] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert Queue2civicrm to civicrm extension - https://phabricator.wikimedia.org/T270672#9624826 (10XenoRyet) [19:19:43] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Epic: drupal upgrade - https://phabricator.wikimedia.org/T261779#9624827 (10XenoRyet) [19:25:47] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 2 others: More amount validation for recurring upgrade - https://phabricator.wikimedia.org/T359694#9624833 (10XenoRyet) [19:26:10] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Create new Benevity import - https://phabricator.wikimedia.org/T359219#9624837 (10XenoRyet) [19:26:19] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: 2024 Sprint D - Priorities - https://phabricator.wikimedia.org/T358916#9624838 (10XenoRyet) [19:26:26] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), 07Spike: PayTM In India: What do we do - https://phabricator.wikimedia.org/T358625#9624839 (10XenoRyet) [19:26:35] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 07Spike: Figure out what to do with Amazon Integration - https://phabricator.wikimedia.org/T358624#9624840 (10XenoRyet) [19:26:47] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-Amazon, and 2 others: Upgrade Amazon integration by April 1st - https://phabricator.wikimedia.org/T357798#9624841 (10XenoRyet) [19:26:55] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate rest of normalize into WMFMessage class - https://phabricator.wikimedia.org/T357471#9624842 (10XenoRyet) [19:27:03] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: replace our drush scripts with WMFQueue.consume api - https://phabricator.wikimedia.org/T357470#9624843 (10XenoRyet) [19:27:11] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Move all our queue consumers into the extension space - https://phabricator.wikimedia.org/T357469#9624844 (10XenoRyet) [19:27:19] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Recurring charge job: what happens to a donation that gets skipped by the 2 within 23 days rule - https://phabricator.wikimedia.org/T357350#9624845 (10XenoRyet) [19:27:27] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import deceased date - https://phabricator.wikimedia.org/T357346#9624846 (10XenoRyet) [19:27:35] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9624847 (10XenoRyet) [19:27:43] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Payment Orchestration Technical Investigation and Scoping - https://phabricator.wikimedia.org/T357334#9624848 (10XenoRyet) [19:27:51] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9624849 (10XenoRyet) [19:27:59] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker log issues - https://phabricator.wikimedia.org/T355736#9624850 (10XenoRyet) [19:28:07] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448#9624851 (10XenoRyet) [19:28:17] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Correcting Gift Source Coding on Benevity import - https://phabricator.wikimedia.org/T354911#9624852 (10XenoRyet) [19:28:25] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587#9624853 (10XenoRyet) [19:28:33] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457#9624854 (10XenoRyet) [19:28:41] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#9624855 (10XenoRyet) [19:28:49] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Email donors with failed Ingencio transactions from Oct, Nov, Dec 2023 - https://phabricator.wikimedia.org/T353677#9624856 (10XenoRyet) [19:28:57] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Segmentation - Sample data request - https://phabricator.wikimedia.org/T353264#9624857 (10XenoRyet) [19:29:05] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168#9624858 (10XenoRyet) [19:29:13] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501#9624859 (10XenoRyet) [19:29:21] 03Fundraising Sprint E, 14Fundraising Sprint Uptown cURL, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get CiviProxy API4 patch merged upstream - https://phabricator.wikimedia.org/T349762#9624860 (10XenoRyet) [19:29:29] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Follow up on coworker - do some testing with queue_pause & busy on prod - https://phabricator.wikimedia.org/T348704#9624861 (10XenoRyet) [19:29:37] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Changing User Permissions in Civi - https://phabricator.wikimedia.org/T347058#9624862 (10XenoRyet) [19:29:46] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9624863 (10XenoRyet) [19:29:54] 03Fundraising Sprint E, 14Fundraising Sprint Uptown cURL, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: Data Axle Project - Re-import to Civi - https://phabricator.wikimedia.org/T341902#9624864 (10XenoRyet) [19:30:02] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181#9624865 (10XenoRyet) [19:30:10] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Investigation: Migrating historical SurveyMonkey data - https://phabricator.wikimedia.org/T337880#9624866 (10XenoRyet) [19:30:18] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 13Patch-For-Review: SEPA direct debit as mainstream payment method in EU campaigns - https://phabricator.wikimedia.org/T324520#9624867 (10XenoRyet) [19:30:26] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert Queue2civicrm to civicrm extension - https://phabricator.wikimedia.org/T270672#9624869 (10XenoRyet) [19:30:34] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Epic: drupal upgrade - https://phabricator.wikimedia.org/T261779#9624870 (10XenoRyet) [19:30:42] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Migrate Ingenico API URLs to new Worldline addresses - https://phabricator.wikimedia.org/T352197#9624873 (10XenoRyet) [19:30:54] 03Fundraising Sprint E, 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-Email, and 3 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#9624872 (10XenoRyet) [20:04:41] (03PS1) 10Damilare Adedoyin: Skip normalize message in autorescue recur consume [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010631 [20:07:09] (03PS1) 10Eileen: Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 [20:13:05] (03PS2) 10Eileen: Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 [20:17:19] eileen: we are working on the mail from coworker/cv issue and have a question. how does coworker/cv decide to send the email? does it use the smtp settings that civi would use? [20:18:12] (03PS2) 10Damilare Adedoyin: Skip normalize message in autorescue recur consume [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010631 [20:32:20] (03CR) 10CI reject: [V: 04-1] Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 (owner: 10Eileen) [20:59:26] hmm damilare it looks like normalize actually gets called again [21:14:46] 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9625074 (10RLopez-WMF) Thanks @Dwisehaupt I can start testing with my account but It will be really helpful to also add the litmus account, since the main purpose of this test is to make sure the email will render... [21:28:54] hah Failed asserting that 'Anonymous' is not equal to 'Anonymous'. ok cool [21:31:11] wasn't one of the sprint name ideas everyone is anonymous? [21:33:45] yeah cause we had just been looking at that bug for an hour :P [21:36:06] (03PS3) 10Eileen: Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 [21:36:17] ah. makes sense. [21:40:06] eileen: quick fix is not quick its normalizing it more than that one place [21:40:32] cstone: as in you can't just not call normalize? [21:41:00] yeah it calls it again in importMessage [21:42:22] cstone: so this will stop it messing with the name fields I think https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1010632 - but it's also touching language? comms prefs? [21:42:38] yeah it NULLd the language [21:42:53] well I could extend ^^ to skip that too? [21:43:26] dwisehaupt: https://civicrm.wikimedia.org/civicrm/admin/setting/smtp?reset=1 is the civi settings dunno how they work but it would also use the ones that failmail normally uses [21:44:33] eileen: idono how much we want to change that without thinking about paypal as a bigger piece, like if we move the donation import part into the donations queue would we even need to keep this? [21:46:00] well that part is kinda what I had intended anyway - ie move to getters & it's in the parent part - we might stop calling the parent if we separate but even then I think the rule that IF contact ID is set then we should not put defaults for fields makes sense [21:46:09] eileen: cool thanks. it's still a little confusing. but after much digging, i think we found an option that works. jeff is testing and hopefully we'll have a fix soonish. [21:46:28] yeah eileen [21:47:14] lemme switch to testing yours then its either fix it there or add back in all the data in the if autorescue part so its there in the $message [21:50:54] 06Fundraising-Backlog: Autorescue: successful donations are losing their names and becoming Anonymous - https://phabricator.wikimedia.org/T359985 (10Cstone) 03NEW [21:51:13] (03PS1) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [21:51:15] eileen: ^ i made that if you want to put patches against it [21:51:26] (03PS1) 10Cstone: Add a new autorescue type and break the test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010689 (https://phabricator.wikimedia.org/T359985) [21:51:50] cstone: yeah - I'm not 100% sure where language default is filled after digging [21:52:53] hah - I killed off this class when moving the refund test https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1010689/1/drupal/sites/all/modules/queue2civicrm/tests/includes/Message.php [21:53:13] haha i was just breaking the test localling to match prod [21:53:47] yeah - it's fine - I'm just keen to get them moved over but didn't want to proceed until the RefundQueue one was merged [21:54:12] locally * that patch wont pass CI [21:59:55] cstone: I'm having a fight getting your test to run - around that dang AutoRescue Message class [22:01:16] so locally your test is passing on top of my 2 but some hackery so not sure [22:02:42] you can also hack the recurring json for the test to not have name [22:05:02] the donor it makes in the database though STILL has a name hah (the test) [22:06:08] so it seems the test will run fine if I run the whole class but not just the test - ok for now [22:06:55] so cstone with your test + my first patch it DOES pass for me locally - only fail in the class is on the failure email but that is because of mailcatcher config [22:07:11] okay I was trying to break perfrerred language locally now and failing at that [22:07:59] (03CR) 10CI reject: [V: 04-1] Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 (owner: 10Eileen) [22:09:33] yeah that test failed ^^ [22:10:00] eileen: just in your first patch the getFirstName got one last_name copied over [22:10:39] ohh cstone, but the test passed on CI [22:10:49] what my broken test??? [22:11:22] nah the test I added to the patch [22:11:35] hah yeah cause its dumb and it runs normalize again [22:11:56] although i see waht you mean that test [22:11:57] hmm [22:12:10] ohh that's strange, let me runit again and debug through [22:12:25] oh wait I think I removed dat [22:12:26] a [22:12:34] cause the recurring example had the name on it [22:12:50] why I made that separate patch damilare [22:13:22] yh but the recurring example should have a name shouldn't it [22:13:38] and then the import should be without any PII [22:13:46] let me see your patch [22:14:10] but the example data has a name [22:14:18] my patch just broke off the example data to not have a name [22:14:25] ohh ok [22:14:32] to match what we were seeing [22:15:34] if you want to hop into tech talk i can explain also its late for you so also that [22:16:36] (03PS4) 10Eileen: Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 [22:26:08] (03PS1) 10Ejegg: Handle failure looking up recurring token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1010699 [22:26:23] (03PS2) 10Ejegg: Handle failure looking up recurring token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1010699 [22:28:51] (03PS2) 10Ejegg: More detailed context [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010328 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:28:52] (03CR) 10Ejegg: [C: 03+2] More detailed context [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010328 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:29:04] (03PS2) 10Ejegg: Stop enabling opt in queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010331 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:29:06] (03CR) 10Ejegg: [C: 03+2] Stop enabling opt in queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010331 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:29:15] (03PS2) 10Ejegg: Remove OptIn module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010332 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:29:32] (03CR) 10Ejegg: [C: 03+2] "Woohoo, another little monster slain" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010332 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:31:17] (03PS2) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [22:39:00] (03PS3) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [22:45:22] (03PS4) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [22:46:22] (03Merged) 10jenkins-bot: More detailed context [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010328 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:47:01] (03Merged) 10jenkins-bot: Stop enabling opt in queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010331 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:47:48] (03PS5) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [22:48:26] (03Merged) 10jenkins-bot: Remove OptIn module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010332 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [22:49:26] (03PS6) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [22:50:15] (03PS7) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [22:52:35] (03PS1) 10Ejegg: Don't add time to date on redirect URL [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010700 (https://phabricator.wikimedia.org/T359578) [22:55:17] (03CR) 10Ejegg: "Generally a big improvement! Exchange rate setter in base queue test is a bit confusing (e.g. makes it seem like "*" is part of the exchan" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008586 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:08:51] (03CR) 10CI reject: [V: 04-1] Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 (owner: 10Eileen) [23:12:39] (03PS8) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [23:21:36] ejegg: did you mean to +2 that refund test one so the exchange rate can be a follow up [23:33:48] sure, I'll +2 it [23:34:01] (03PS3) 10Ejegg: Move RefundQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008586 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:34:07] (03CR) 10Ejegg: [C: 03+2] Move RefundQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008586 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:35:24] cstone: if you want a break from that stuff I have the extra validation for the recur upgrade ready to review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1010560 [23:35:44] also fr-tech I'm thinking of increasing the timeout for dlocal since we're getting a bunch of timeouts [23:35:51] How about 30 sec? It's 12 now [23:52:03] (03Merged) 10jenkins-bot: Move RefundQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008586 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:56:49] !log increased timeout for dlocal API calls to 30 sec [23:56:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log