[00:03:50] (03PS7) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [00:03:51] (03PS2) 10Ejegg: WIP use SmashPig to get PayPal details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [00:04:59] (03PS3) 10Ejegg: WIP use SmashPig to get PayPal details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [00:05:41] (03CR) 10CI reject: [V: 04-1] WIP use SmashPig to get PayPal details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [00:07:13] (03CR) 10CI reject: [V: 04-1] WIP use SmashPig to get PayPal details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [00:34:51] (03PS5) 10Ejegg: Leverage apiv4 more in test to reduce calls to drupal module code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008553 (owner: 10Eileen) [00:35:06] (03CR) 10Ejegg: "PS5: manual rebase" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008553 (owner: 10Eileen) [00:35:44] (03CR) 10Ejegg: [C: 03+2] Leverage apiv4 more in test to reduce calls to drupal module code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008553 (owner: 10Eileen) [00:52:58] (03Merged) 10jenkins-bot: Leverage apiv4 more in test to reduce calls to drupal module code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1008553 (owner: 10Eileen) [02:25:20] (03PS5) 10Ejegg: Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 (owner: 10Eileen) [02:25:33] (03CR) 10Ejegg: [C: 03+2] "Looks safe enough!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 (owner: 10Eileen) [02:44:31] (03Merged) 10jenkins-bot: Improve normalize to not add name defaults when there is a contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010632 (owner: 10Eileen) [02:57:46] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9625470 (10Ejegg) 14You can get links from a donor's CiviCRM co... [03:23:36] (03PS1) 10Eileen: Move Fredge Queue Consumer tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010709 (https://phabricator.wikimedia.org/T357469) [03:27:07] 03Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: 142024 Sprint D - Priorities - 14https://phabricator.wikimedia.org/T358916#9625504 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [05:35:48] (03PS9) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [06:05:03] (03PS2) 10Eileen: Move Fredge Queue Consumer tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010709 (https://phabricator.wikimedia.org/T357469) [06:05:04] (03PS1) 10Eileen: Move ContributionTrackingQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010809 (https://phabricator.wikimedia.org/T357469) [06:05:58] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1010739 (owner: 10L10n-bot) [06:13:37] (03PS1) 10Eileen: Move first RecurringQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) [06:21:40] (03PS2) 10Eileen: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) [06:24:25] (03CR) 10CI reject: [V: 04-1] Move ContributionTrackingQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010809 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [06:25:27] (03PS3) 10Eileen: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) [06:29:28] (03PS4) 10Eileen: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) [06:34:58] (03PS5) 10Eileen: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) [06:38:45] (03PS2) 10Eileen: Move ContributionTrackingQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010809 (https://phabricator.wikimedia.org/T357469) [06:54:31] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9625605 (10MSuijkerbuijk_WMF) 14Hi @Ejegg Flagging a couple o... [07:51:59] (03PS1) 10Eileen: Move some more RecurringQueueTests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010845 (https://phabricator.wikimedia.org/T357469) [11:32:44] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1010739 (owner: 10L10n-bot) [12:52:47] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: 14Redirect to ThankYou wiki after completing upgrade - 14https://phabricator.wikimedia.org/T359578#9626352 (10ehughes) 14Hey @Ejegg thanks for all... [14:29:06] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 03Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Correcting Gift Source Coding on Benevity import - https://phabricator.wikimedia.org/T354911#9626788 (10NNichols) Working! Thank you Eileen [14:52:53] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9626888 (10Ejegg) 14@MSuijkerbuijk_WMF we don't have any compan... [16:15:44] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), 13Patch-For-Review: 14Redirect to ThankYou wiki after completing upgrade - 14https://phabricator.wikimedia.org/T359578#9627122 (10Ejegg) 14Hi @ehughes, I've got a pat... [16:21:59] 03Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9627153 (10Cstone) a:05AnnWF→03Cstone Taking this over from wfan! :) [16:27:05] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations, 07Epic: Track which email people clicked to upgrade their recurring donation - https://phabricator.wikimedia.org/T360047 (10Ejegg) 03NEW [16:48:48] (03CR) 10Cstone: [C:03+2] "Looks good, wasn't able to break it :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010560 (https://phabricator.wikimedia.org/T359694) (owner: 10Ejegg) [16:48:56] (03CR) 10Cstone: [C:03+2] "the time is gone!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010700 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [16:52:03] thanks cstone! [16:52:12] np ejegg [16:53:11] (03PS1) 10Wfan: Add rtbt and ach to adyen supported MC payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010682 (https://phabricator.wikimedia.org/T359877) [16:53:59] (03CR) 10Cstone: [C:04-1] "looks like normalize was still being called further on, looking at fixing the base issue now in https://gerrit.wikimedia.org/r/c/wikimedia" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010631 (owner: 10Damilare Adedoyin) [16:55:44] 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 13Patch-For-Review: Turn on post MC for rtbt and ACH? - https://phabricator.wikimedia.org/T359877#9627287 (10AnnWF) [17:15:42] (03Merged) 10jenkins-bot: Better amount validation for RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010560 (https://phabricator.wikimedia.org/T359694) (owner: 10Ejegg) [17:15:45] (03Merged) 10jenkins-bot: Don't add time to date on redirect URL [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010700 (https://phabricator.wikimedia.org/T359578) (owner: 10Ejegg) [17:22:28] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1010916 [17:22:34] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1010916 (owner: 10Ejegg) [17:38:35] 06Fundraising-Backlog, 10Recurring-Donations, 07recurring upgrade: RecurUpgrade: error message for donors with no upgradable recur - https://phabricator.wikimedia.org/T360052 (10Ejegg) 03NEW [17:38:43] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1010916 (owner: 10Ejegg) [17:39:02] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-email-preferences, 07recurring upgrade: Add favicon for donorwiki - https://phabricator.wikimedia.org/T360054 (10Ejegg) 03NEW [17:41:28] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07recurring upgrade: Move donor prefs links up on DR view - https://phabricator.wikimedia.org/T360055 (10Ejegg) 03NEW [17:52:53] !log donorwiki upgraded from 5755ea82 to 32789f89 [17:52:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:53:55] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Track which email people clicked to upgrade their recurring donation - https://phabricator.wikimedia.org/T360047#9627640 (10Ejegg) [17:57:54] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): 14Redirect to ThankYou wiki after completing upgrade - 14https://phabricator.wikimedia.org/T359578#9627653 (10Ejegg) 14OK @ehughes , that change is live on the recurrin... [18:02:41] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9627665 (10ppenloglou) 14Hey @Ejegg! After our meeting, I've up... [18:03:47] weird how some tasks have white color for the titles, but others have grey (here, on IRC) [18:04:28] just the ones with comments (vs eg task creation) are grey it seems [18:05:34] 06Fundraising-Backlog, 10Recurring-Donations, 07recurring upgrade: RecurUpgrade: error message for donors with no upgradable recur - https://phabricator.wikimedia.org/T360052#9627671 (10MSuijkerbuijk_WMF) @Ejegg wording looks good to me, I'll leave @AMJohnson to chime in too! [18:05:57] nevermind, that one is white [18:06:00] what is happening?! [18:06:02] 03Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.22; 2024-03-12): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9627672 (10ppenloglou) 14Hey @Ejegg, just updated the email tem... [18:06:22] greg-g: grey title + url is T140881 [18:06:23] T140881: Print events in closed tasks in grey - https://phabricator.wikimedia.org/T140881 [18:06:31] ahhh, ones with the MW-X-notes [18:07:31] bd808: huh! closed! that's the variable I wasn't noticing [18:07:55] which kind of is the MW-X-notes one, ish [18:08:13] its new as of yesterday and you are not the first to WTF about it :) [18:08:25] nerds and our ocd [18:08:39] "ocd" aka "notice changes" [18:09:03] (quotes because I don't actually have real ocd, but folks use that as shorthand for "I notice things") [18:09:23] my client eats the grey for #reasons, so it's not jumped out at me [18:10:00] "who moved my cheese?" is real :) [18:10:09] weechat+glowingbear here and it looks nice other than just it being different :) [18:16:25] 06Fundraising-Backlog, 10Recurring-Donations, 07recurring upgrade: RecurUpgrade: error message for donors with no upgradable recur - https://phabricator.wikimedia.org/T360052#9627694 (10AMJohnson) Thanks @Ejegg! Good idea. :) So I have two thoughts: 1. Would it be better to have them just email donate@ if... [18:25:52] ejegg|food: can we remove the code around wmf_civicrm_update_legacy_paypal_subscription - am I right in thinking will have aged out of relevance? I got the test working in it's new home but then had thoughts about whether it just go up in a poof of smoke [18:44:29] (03CR) 10Reedy: [C:03+2] "resubmit" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 (owner: 10Reedy) [18:47:15] (03CR) 10CI reject: [V:04-1] Fix casing of MediaWiki [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 (owner: 10Reedy) [19:03:56] 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 13Patch-For-Review: Turn on post MC for rtbt and ACH? - https://phabricator.wikimedia.org/T359877#9627878 (10AnnWF) >>! In T359877#9622431, @MSuijkerbuijk_WMF wrote: > Yes from my perspective good to activate for post MC for now (until I work... [19:08:15] eileen: there's a task for that in sprint [19:08:21] we do still have legacy subscriptions active [19:08:47] but we should be able to look for log lines and find out if they're still sending IPNs in that weird state [19:09:12] T355448 [19:09:13] T355448: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448 [19:15:49] (03PS10) 10Eileen: Use a getter for language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010688 [19:23:08] (03PS6) 10Eileen: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) [19:23:09] (03PS2) 10Eileen: Move some more RecurringQueueTests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010845 (https://phabricator.wikimedia.org/T357469) [19:23:11] (03PS1) 10Eileen: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) [19:42:11] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1010948 [19:44:07] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1010948 (owner: 10Cstone) [19:45:07] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1010948 (owner: 10Cstone) [19:48:43] (03PS2) 10Eileen: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) [19:49:01] !log civicrm upgraded from 3cab2177 to ee785ecd [19:49:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:51:36] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Track which email people clicked to upgrade their recurring donation - https://phabricator.wikimedia.org/T360047#9628358 (10Ejegg) In Tech Talk we just decided it's OK to add these as activity custom fields. @JMando This is related to the thi... [19:53:35] https://usercontent.irccloud-cdn.com/file/WhIrxMGc/image.png [19:53:53] https://usercontent.irccloud-cdn.com/file/XtSgwE8j/image.png [19:57:04] 14Fundraising Sprint Uptight Piano, 14Fundraising Sprint Vaporwerewolf, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: 14Epic: Don't duplicate contact for email donations - 14https://phabricator.wikimedia.org/T177663#9628371 (10Ejegg) 05Open→03Resolved a:03Ejegg [19:57:46] ok, I can't find the task I thought I wrote about moving those emails out of the queue consumer cstone [19:58:22] There's this one.... https://phabricator.wikimedia.org/T172300 [19:59:21] (03CR) 10CI reject: [V:04-1] Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:01:52] cause where was the other weird spot ejegg ? [20:02:27] oh failure email [20:02:31] monthly convert and failure [20:06:34] oh right [20:40:29] 03Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9628575 (10NNichols) Custom field ideas for addresses 1. Source: - NOCA update - Staff suppl... [20:52:35] (03CR) 10Jforrester: [C:03+2] "Failure is real: T357593" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 (owner: 10Reedy) [21:04:56] interesting subscription https://lab.civicrm.org/extensions/searchkitmaps [21:05:42] ooh [21:06:25] (03CR) 10CI reject: [V:04-1] Fix casing of MediaWiki [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1010543 (owner: 10Reedy) [21:57:53] 06Fundraising-Backlog, 10FR-donorservices: Investigation Needed for Cancellation Error on Recurring Donation - https://phabricator.wikimedia.org/T359942#9628780 (10Cstone) Looks like something happened when making the activity, the donation is fully cancelled though. Still looking into this. [22:02:16] 06Fundraising-Backlog, 13Patch-For-Review: Autorescue: successful donations are losing their names and becoming Anonymous - https://phabricator.wikimedia.org/T359985#9628799 (10Cstone) Eileens patch fixed the test, waiting for a new one to come in to check that the name issue is fixed. Still need to fix the la... [22:05:09] ug - now I am fighting tests again - I guess on the bright side some of the early ones (https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1010709/2) are still passing [22:05:51] i was just about to merge that one [22:08:20] (03PS3) 10Eileen: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) [22:15:39] now i did something to break it locally im pretty sure bad db data [22:21:39] (03CR) 10Cstone: [C:03+2] "thanks!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010709 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:28:59] (03CR) 10CI reject: [V:04-1] Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:35:41] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unsubscribe + email prefs consumers should create Civi Activities - https://phabricator.wikimedia.org/T297143#9628856 (10Ejegg) [22:39:32] (03Merged) 10jenkins-bot: Move Fredge Queue Consumer tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010709 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:46:50] (03PS4) 10Eileen: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) [23:09:08] wooo auto rescue just name in and they have a name!!!! [23:10:41] came in even [23:10:43] hah [23:26:03] (03CR) 10Cstone: [C:03+2] "yay!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010809 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:31:23] yay! [23:45:24] (03Merged) 10jenkins-bot: Move ContributionTrackingQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010809 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:46:06] (03PS1) 10Eileen: Move test covering ContributionTracking api to api folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) [23:46:50] (03PS2) 10Eileen: Move test covering ContributionTracking api to api folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) [23:51:26] cstone: so looking at breaking out these recurring tests a bit more - it seems like there should be a separate queue for recurringModify or recurringUpgradeDowngrade to cover the trxn types 'recurring_upgrade', 'recurring_upgrade_decline', 'recurring_downgrade' [23:51:53] which actually have no code in common with the rest of that consumer [23:53:41] - what I don't understand is say I created a new consumer [23:53:41] RecurringModifySubscriptionAmountQueue [23:53:41] - what would push the transactions into that queue instead [23:54:29] for the recurring upgrade stuff i think its in in donation infterface code lemme see [23:55:38] (03CR) 10CI reject: [V:04-1] Move test covering ContributionTracking api to api folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:56:05] ok now that says it goes to the recurring-upgrade queue haha [23:56:14] i guess is that just the one to get it back into civi what does that do [23:59:01] do things on the recurring-upgrade queue just get funneled back into the recurring queue consumer then? [23:59:37] cstone: yep, it's only a different queue because it has to go to a different redis server [23:59:53] ejegg: eileen ^ was thinking about making it its own