[00:28:24] (03PS4) 10Eileen: Return handling for tags & groups to import classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011181 (https://phabricator.wikimedia.org/T357471) [00:29:02] (03PS5) 10Eileen: Return handling for tags & groups to import classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011181 (https://phabricator.wikimedia.org/T357471) [05:41:43] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9633265 (10MSuijkerbuijk_WMF) 14Thanks both, cross-posting from... [08:07:50] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9633340 (10ehughes) 14Hi @MSuijkerbuijk_WMF thanks for this. It... [14:23:13] (03PS7) 10Ejegg: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:23:18] (03CR) 10Ejegg: [C:03+2] Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [14:25:40] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9633988 (10Ejegg) 14It'll probably be an improvement for the Em... [14:38:33] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9634048 (10ehughes) 14Thanks, @Ejegg ! If the email preferences... [14:42:40] 06Fundraising-Backlog: Further permission restrictions - https://phabricator.wikimedia.org/T360198 (10NNichols) 03NEW [14:45:08] (03Merged) 10jenkins-bot: Move first RecurringQueueTest tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010814 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:51:25] damilare: confirmed that the double ipn issue is fixed too [15:51:55] awesome!! [15:53:07] 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: AutoRescue message causing duplicates in Civi contact contribution record - https://phabricator.wikimedia.org/T360140#9634221 (10Cstone) both of these are fixed, need to clean up the data, they are all in a group called autorescue [15:54:19] 06Fundraising-Backlog: Issue with using Address Proximity in a Searchkit - https://phabricator.wikimedia.org/T360205 (10NNichols) 03NEW [15:58:05] hi fr-tech I had a apoointment that got delayed this morning so i don't think i'll make it to standup [15:59:37] kk. thanks! [16:08:14] 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Investigation Needed for Cancellation Error on Recurring Donation - https://phabricator.wikimedia.org/T359942#9634305 (10Damilare) [16:29:23] 06Fundraising-Backlog, 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9634360 (10greg) Update on this request: * We can change Christine's record in Civi Staging (CID 165749) to use the listmus email ** We'll update that contact to something like Test User i... [16:35:28] (03PS1) 10Damilare Adedoyin: Fix Damaged row details error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011312 (https://phabricator.wikimedia.org/T359437) [16:36:39] 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Investigation Needed for Cancellation Error on Recurring Donation - https://phabricator.wikimedia.org/T359942#9634410 (10Damilare) a:03Damilare [16:38:25] 06Fundraising-Backlog: Paypal recurring not appearing in Mexico form - https://phabricator.wikimedia.org/T360214 (10EMartin) 03NEW [16:48:42] (03PS1) 10Ejegg: Send tracking param to TY page + to queue on cancel [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011313 [16:48:43] (03PS1) 10Ejegg: RecurUpgrade: fix viewport, set title differently [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011314 [16:49:23] OK fr-tech, I have two patches up for review, starting here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1011313 [16:50:46] 06Fundraising-Backlog: Paypal recurring not appearing in Mexico form - https://phabricator.wikimedia.org/T360214#9634438 (10Danielyepezgarces) In most countries in America, recourse by this method is not available, it is only available with amounts in USD [16:54:24] 06Fundraising-Backlog: Paypal recurring not appearing in Mexico form - https://phabricator.wikimedia.org/T360214#9634446 (10EMartin) For Paypal, we settle everything into USD. [17:11:57] (03PS1) 10Ejegg: Be consistent with next_sched_contribution_date [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011316 [17:39:16] (03PS2) 10Ejegg: RecurUpgrade: fix viewport [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011314 [17:39:24] (03PS2) 10Ejegg: Be consistent with next_sched_contribution_date [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011316 [17:39:32] (03PS1) 10Ejegg: Set RecurUpgrade title with less code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011321 [17:39:32] ok, got a whole string of 'em ready for review if anyone has time fr-tech ^^^ [17:39:40] (03PS1) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [17:39:46] I tried to make them as small and self-contained as possible [17:42:57] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [18:35:06] (03PS2) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [18:37:36] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [18:56:53] ejegg|food: I'm omw to airport right now but will look when I get there [19:05:28] thanks! [19:06:28] I wonder what I need to do to make Phan happy with the validation patch [19:22:06] (03PS3) 10Eileen: Move some more RecurringQueueTests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010845 (https://phabricator.wikimedia.org/T357469) [19:22:17] (03PS5) 10Eileen: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) [19:22:28] (03PS4) 10Eileen: Move test covering ContributionTracking api to api folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) [19:24:40] (03PS3) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [19:26:49] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [19:26:56] (03CR) 10Ejegg: [C:03+2] Move some more RecurringQueueTests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010845 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:28:16] seems the adyen autorescue error is a config issue [19:28:53] the cancel request on prod is going to a test link [19:28:59] https://pal-test.adyen.com/pal/servlet/Payment/v68/cancel [19:29:36] I suspect this is due to the initialisation of the smashpig context before making the request that prevents the library from using the global config [19:29:55] oh shoot! [19:29:57] but I'm unable to reproduce this in a test [19:30:11] are we just missing some config on prod? [19:30:53] no we aren't, we are using the payment-base-url for the rest url [19:31:02] which is the same for the recurring charge [19:31:32] oh? I see recurring-base-url in adyen/main.yaml on prod, but no payment-base-url [19:31:33] and that works fine, just the cancel autorescue that uses the local config in the smashpig library [19:32:45] ohh I see [19:33:13] I just pushed a change to settings up on frpm - want to see if that looks right? [19:33:25] Thanks for figuring it out! [19:33:27] (03PS1) 10Jforrester: CentralNotice: Use UnlistedSpecialPage rather than defining isListed() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 [19:33:28] (03PS1) 10Jforrester: Rename CentralNotice to CentralNoticeSpecialPage for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 [19:33:50] sure [19:35:38] (03CR) 10CI reject: [V:04-1] CentralNotice: Use UnlistedSpecialPage rather than defining isListed() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [19:35:42] (03CR) 10CI reject: [V:04-1] Rename CentralNotice to CentralNoticeSpecialPage for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester) [19:35:51] Ok that looks correct [19:36:02] can I do the deploy? [19:37:19] sure, go ahead! [19:38:08] (03PS2) 10Jforrester: Rename CentralNotice to CentralNoticeSpecialPage for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 [19:38:11] (03PS4) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [19:38:51] (03PS2) 10Jforrester: CentralNotice: Use UnlistedSpecialPage rather than defining isListed() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 [19:38:52] (03PS3) 10Jforrester: Rename CentralNotice to CentralNoticeSpecialPage for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 [19:40:24] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [19:40:45] (03CR) 10CI reject: [V:04-1] Rename CentralNotice to CentralNoticeSpecialPage for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester) [19:41:37] (03CR) 10CI reject: [V:04-1] Rename CentralNotice to CentralNoticeSpecialPage for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester) [19:42:56] !log localsettings revision changed from 07e3839c to b3dbab1d [19:42:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:43:16] (03PS5) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [19:43:27] (03PS3) 10Eileen: Separate out modify amount queue tests to new class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011007 (https://phabricator.wikimedia.org/T357469) [19:43:43] (03PS4) 10Eileen: Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) [19:52:19] (03CR) 10CI reject: [V:04-1] Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:58:43] (03CR) 10Ejegg: "Not sure about those test fails, but would it be better to have all the special pages named consistently? I.e. either rename CentralNotice" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester) [20:02:22] (03CR) 10Ejegg: "We really don't want the main admin page showing up on https://meta.wikimedia.org/wiki/Special:SpecialPages ?" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [20:08:07] (03CR) 10Jforrester: [C:04-1] "Oh, meh, CentralNotice.php is both a super-class and an actual page, what a complete mess. Will re-do differently then." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester) [20:08:40] (03CR) 10Jforrester: "Eh, fair point, but it's extremely rarely used in that way, surely?" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [20:27:48] 06Fundraising-Backlog, 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9634913 (10Dwisehaupt) I have updated the data entries for CID 165749 to replace instances of the name with "Test User" and the address to the office address. Additionally updated some exte... [20:28:44] (03CR) 10Ejegg: "I guess when the cabal grants you CN admin rights they can send you the link :)" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [20:35:30] (03CR) 10Jforrester: "Yes, ish. :-)" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [20:36:02] 06Fundraising-Backlog, 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9634922 (10Dwisehaupt) wikimedia.4b69@litmusemail.com has been added as a valid address for sending mail off of the frdev host. It should be only be used with CID 165749 as stated above. ht... [20:52:12] (03CR) 10Cstone: [C:03+2] "looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011313 (owner: 10Ejegg) [20:53:57] (03Merged) 10jenkins-bot: Send tracking param to TY page + to queue on cancel [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011313 (owner: 10Ejegg) [21:17:44] (03PS1) 10Umherirrender: Use array for empty arguments on Title::getFullURL and Html::element [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011350 [21:35:25] thanks, cstone! [21:38:00] (03CR) 10Ejegg: [C:03+2] CentralNotice: Use UnlistedSpecialPage rather than defining isListed() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [21:51:31] (03PS1) 10Ejegg: Round off native amounts in RecurUpgrade activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011353 [21:58:18] (03Merged) 10jenkins-bot: CentralNotice: Use UnlistedSpecialPage rather than defining isListed() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011338 (owner: 10Jforrester) [22:10:05] (03CR) 10CI reject: [V:04-1] Round off native amounts in RecurUpgrade activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011353 (owner: 10Ejegg)