[12:34:48] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "LGTM! thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008869 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg)
[12:35:21] <wikibugs>	 (03Merged) 10jenkins-bot: Add address info to normalized PayPal responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1008869 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg)
[12:39:23] <wikibugs>	 (03PS2) 10Jgleeson: Split out consume-queues.sh script by service. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009564
[12:39:24] <wikibugs>	 (03PS2) 10Jgleeson: Add setup of silverpop_export.yaml config during --tools build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009751
[12:39:26] <wikibugs>	 (03PS2) 10Jgleeson: Change how we reclone projects to fix bind mount bug. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009777
[12:39:34] <jgleeson>	 rebased over latest ^ 
[12:57:21] <jgleeson>	 fr-tech I've just pushed up a change to localsettings disabling the amazon audit job as it's giving us two failmails a night. As we're looking at Adyen as an alternative route for Amazon, it looks like that job might be done. 
[13:00:47] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Investigation Needed for Cancellation Error on Recurring Donation - https://phabricator.wikimedia.org/T359942#9637732 (10Damilare) This was due to a configuration issue, the problem was identified and solution deployed last Friday.
[13:05:25] <wikibugs>	 (03PS3) 10Jgleeson: Change how we reclone projects to fix bind mount bug. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009777
[13:10:32] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10FR-Amazon, and 2 others: Upgrade Amazon integration by April 1st - https://phabricator.wikimedia.org/T357798#9637771 (10jgleeson) I guess we need to rename this from upgrading to migrating based o...
[13:11:27] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Payment Orchestration Technical Investigation and Scoping - https://phabricator.wikimedia.org/T357334#9637776 (10jgleeson) a:03jgleeson
[13:29:39] <wikibugs>	 (03CR) 10Jforrester: [C:03+2] Update wikimedia/remex-html to 4.1.0 (dev dependency) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011401 (owner: 10C. Scott Ananian)
[13:50:51] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "Looks fine to me! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011401 (owner: 10C. Scott Ananian)
[13:53:03] <wikibugs>	 (03Merged) 10jenkins-bot: Update wikimedia/remex-html to 4.1.0 (dev dependency) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011401 (owner: 10C. Scott Ananian)
[13:54:03] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fix Adyen failmail that is due to missing property in the response - https://phabricator.wikimedia.org/T360322 (10Damilare) 03NEW
[13:54:05] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fix Adyen failmail that is due to missing property in the response - https://phabricator.wikimedia.org/T360322#9637996 (10Damilare) a:03Damilare
[13:54:41] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Add checks for getPaymentDetails function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012377 (https://phabricator.wikimedia.org/T360322)
[13:55:08] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add checks for getPaymentDetails function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012377 (https://phabricator.wikimedia.org/T360322) (owner: 10Damilare Adedoyin)
[13:58:17] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Add checks for getPaymentDetails function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012377 (https://phabricator.wikimedia.org/T360322)
[14:01:07] <ejegg>	 morning fr-tech!
[14:01:31] <ejegg>	 thanks for merging that address patch jgleeson !
[14:06:40] <jgleeson>	 morning ejegg. np!
[14:10:38] <wikibugs>	 (03PS4) 10Jforrester: Rename CentralNotice to SpecialCentralNotice for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339
[14:13:22] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Rename CentralNotice to SpecialCentralNotice for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester)
[14:16:43] <wikibugs>	 (03PS5) 10Jforrester: Rename CentralNotice to SpecialCentralNotice for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339
[14:19:08] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Rename CentralNotice to SpecialCentralNotice for clarity [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011339 (owner: 10Jforrester)
[14:28:28] <ejegg>	 fr-tech, the recurring upgrade gang (Mariana in particular) are eager to see a few little fixes deployed which are currently in review. If anyone has a moment to take a look at this chain I'd be grateful: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1011314
[14:28:43] <ejegg>	 Oh and this one: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1011353?usp=search
[14:30:12] <jgleeson>	 looking at that first one 
[14:30:19] <ejegg>	 thanks jgleeson 
[14:36:02] <jgleeson>	 hmm
[14:36:04] <jgleeson>	 docker@civicrm:/srv/civi-sites/wmff/drupal$ drush @wmff -vv qc
[14:36:06] <jgleeson>	 bash: drush: command not found
[14:38:11] <jgleeson>	 I'll rebuild
[14:41:23] <ejegg>	 heh, sounds like it's needed if drush is gone!
[14:45:40] <jgleeson>	 fixed
[14:45:50] <jgleeson>	 not sure what I did before I went away lol
[14:46:25] <ejegg>	 rockstar exit, trashed the place
[14:46:34] <jgleeson>	 probably
[14:49:39] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "Looks good! I can see the change in the src and the code tidy up is nice too. Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011314 (owner: 10Ejegg)
[14:50:05] <jgleeson>	 will check the others when I get back from school run, if they are still waiting
[14:50:57] <ejegg>	 thanks jgleeson|skrun ! That was the most visible one. I'll deploy it for a start
[15:01:57] <wikibugs>	 (03Merged) 10jenkins-bot: RecurUpgrade: fix viewport [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011314 (owner: 10Ejegg)
[15:07:13] <icinga-wm>	 PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/usr/local/bin/package_update_check] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun
[15:12:13] <icinga-wm>	 PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/usr/local/bin/package_update_check] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun
[15:17:13] <icinga-wm>	 RECOVERY - check_puppetrun on frpm2001 is OK: OK: Puppet is currently enabled, last run 3 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun
[15:36:34] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1012399
[15:36:38] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1012399 (owner: 10Ejegg)
[15:37:58] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1012399 (owner: 10Ejegg)
[15:41:06] <ejegg>	 ack, i totally missed standup
[15:58:10] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07recurring upgrade: Move donor prefs links up on DR view - https://phabricator.wikimedia.org/T360055#9638502 (10SHust) @Ejegg feel free to solve/close this phab since I was able to move the box on the DR Layout.
[16:10:51] <wikibugs>	 (03CR) 10Cstone: [C:03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011321 (owner: 10Ejegg)
[16:12:44] <wikibugs>	 (03Merged) 10jenkins-bot: Set RecurUpgrade title with less code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011321 (owner: 10Ejegg)
[16:15:23] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Be consistent with next_sched_contribution_date [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011316 (owner: 10Ejegg)
[16:17:32] <wikibugs>	 (03Merged) 10jenkins-bot: Be consistent with next_sched_contribution_date [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011316 (owner: 10Ejegg)
[16:25:35] <ejegg>	 !log donorwiki upgraded from 6ea55e72 to 27d326b7
[16:25:38] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[16:37:55] <ejegg>	 thanks cstone!
[16:39:06] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07recurring upgrade: 14Move donor prefs links up on DR view - 14https://phabricator.wikimedia.org/T360055#9638738 (10Ejegg) 05Open→03Resolved a:03Ejegg 14Nice @SHust, glad to hear you were able to fix i!
[17:14:39] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "Thanks for the type tidy-up! looks good to me." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011350 (owner: 10Umherirrender)
[17:16:36] <jgleeson>	 ejegg: I take it we're ok with phan skipping the vendor/smash-pig and special folders 
[17:17:03] <ejegg>	 jgleeson: yep, anything in vendor makes sense to skip (in fact, maybe I should just list /vendor)
[17:17:24] <ejegg>	 and then the special folder skip is just so it will not trigger lots of other phan failures that I'd have to fix in that same patch
[17:17:45] <ejegg>	 it's not actually been phan-testing much in DI as yet
[17:17:56] <ejegg>	 I guess it only tests the things that follow the namespacing
[17:17:59] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1012412
[17:18:06] <ejegg>	 er, PSR4 namespacing that is
[17:22:59] <wikibugs>	 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations, 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): Track which email people clicked to upgrade their recurring donation - https://phabricator.wikimedia.org/T360047#9639109 (10Ejegg) OK, I have deployed...
[17:25:14] <wikibugs>	 (03Merged) 10jenkins-bot: Use array for empty arguments on Title::getFullURL and Html::element [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011350 (owner: 10Umherirrender)
[17:28:01] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1012412 (owner: 10Damilare Adedoyin)
[17:28:48] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1012412 (owner: 10Damilare Adedoyin)
[17:31:49] <jgleeson>	 ejegg: some food for thought. The Validator class looks good. As it's newly minted and a fairly discrete class, it felt like we could also drop in some tests for it. I can see the shared public entrypoint validate() means there would be a lil bit of shared set up required across different tests. I looked at the two validation methods called by validate(),token and amount, and an as they're not
[17:31:51] <jgleeson>	 relying on instance data directly, you could potentially change the API making those methods public and easier to write a quick test for, and still call them via the wrapper method or refactor it slightly to call them directly. 
[17:32:31] <jgleeson>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1011322/5/includes/RecurUpgrade/Validator.php
[17:33:03] <damilare>	 !log civicrm upgraded from 87d72bd7 to b8a84b22
[17:33:06] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[17:38:14] <jgleeson>	 I imagine the validate token scenario is already well tested as it's a core thing
[17:43:50] <wikibugs>	 (03CR) 10Jgleeson: [C:03+1] "This looks good! I left a comment on IRC about potentially changing the API to add in a test or two." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg)
[17:58:53] <ejegg>	 ah thanks! Yep, definitely should be testable
[17:59:07] <ejegg>	 I was thinking of testability when I put the dependencies in the constructor
[17:59:21] <ejegg>	 sorry, just got out of a meeting
[18:03:03] <jgleeson>	 yeah that makes sense
[18:08:56] <ejegg>	 ok, I'll add a test or two to the patch
[18:09:20] <ejegg>	 it's not urgent to get that out before the send, as it's just a code refactor
[18:09:34] <ejegg>	 but I guess I'd want to merge it before any other fixes that might emerge from QA
[18:14:03] <jgleeson>	 thanks. if adding tests is distracting you from other stuff we could capture that bit in a ticket 
[19:08:18] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Payment Orchestration Technical Investigation and Scoping - https://phabricator.wikimedia.org/T357334#9639470 (10jgleeson) This looks potentially useful https://github.com/gr4vy/gr4vy-php
[19:17:04] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Payment Orchestration Technical Investigation and Scoping - https://phabricator.wikimedia.org/T357334#9639498 (10jgleeson) It looks like we're going to need to request individual sandbox accounts [[ h...
[19:37:19] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Segmentation - QA response - https://phabricator.wikimedia.org/T353264#9639568 (10Eileenmcnaughton)
[19:38:41] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Segmentation - QA response - https://phabricator.wikimedia.org/T353264#9639586 (10Eileenmcnaughton) a:03Eileenmcnaughton @JMando as I mentioned on slack the Mid tier prospects are now updated so thi...
[19:41:00] <wikibugs>	 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: 2024 Sprint E - Priorities - https://phabricator.wikimedia.org/T359434#9639614 (10AKanji-WMF)
[19:55:29] <wikibugs>	 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-Amazon, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Upgrade Amazon integration by April 1st - https://phabricator.wikimedia.org/T357798#9639700 (10Dwisehaupt) Pulling out of sprint in favor of a task to implement via adyen...
[19:55:33] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9639703 (10Damilare)
[20:03:02] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Fix Adyen failmail that is due to missing property in the response - https://phabricator.wikimedia.org/T360322#9639733 (10AKanji-WMF) p:05Triage→03Medium
[20:05:47] <wikibugs>	 06Fundraising-Backlog: Paypal recurring not appearing in Mexico form - https://phabricator.wikimedia.org/T360214#9639756 (10AKanji-WMF) @Pcoombe Is this something done on your end?
[20:07:16] <wikibugs>	 (03CR) 10Damilare Adedoyin: "LGTM thanks for working on this!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1010699 (owner: 10Ejegg)
[20:07:22] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Handle failure looking up recurring token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1010699 (owner: 10Ejegg)
[20:07:37] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1010699 (owner: 10Ejegg)
[20:08:07] <wikibugs>	 (03Merged) 10jenkins-bot: Handle failure looking up recurring token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1010699 (owner: 10Ejegg)
[20:08:14] <wikibugs>	 (03Abandoned) 10Damilare Adedoyin: Add checks for getPaymentDetails function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012377 (https://phabricator.wikimedia.org/T360322) (owner: 10Damilare Adedoyin)
[20:09:29] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Fix Adyen failmail that is due to missing property in the response - https://phabricator.wikimedia.org/T360322#9639776 (10Damilare) Actual patch here: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1010699
[20:09:51] <wikibugs>	 06Fundraising-Backlog: Explore whether we can activate Acoustic web tracking on our donation forms and thank you pages - https://phabricator.wikimedia.org/T360151#9639788 (10AKanji-WMF) @DBu-WMF flagging this may require legal review - have you explored this yet?
[20:17:16] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: AutoRescue message causing duplicates in Civi contact contribution record - https://phabricator.wikimedia.org/T360140#9639828 (10AKanji-WMF) p:05Triage→03High
[20:21:23] <wikibugs>	 06Fundraising-Backlog: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9639865 (10Eileenmcnaughton) @MDemosWMF We can make the expiry time editable so you can set it what you want
[20:21:39] <wikibugs>	 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-email-preferences, 07recurring upgrade: Add favicon for donorwiki - https://phabricator.wikimedia.org/T360054#9639870 (10Dwisehaupt) This was pushed on 13 Mar 2024 ` [frack::puppet] 12c170a84 Add localsettings...
[20:22:42] <wikibugs>	 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-email-preferences, 07recurring upgrade: Add favicon for donorwiki - https://phabricator.wikimedia.org/T360054#9639894 (10Dwisehaupt) @Ejegg Let us know if there are any issues here. If none, it's closable at t...
[20:23:05] <wikibugs>	 06Fundraising-Backlog: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9639897 (10MDemosWMF) That sounds great!
[20:24:41] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9639909 (10AKanji-WMF) p:05Triage→03High
[20:26:07] <wikibugs>	 06Fundraising-Backlog: New recurring donation that gets stopped at auth makes INVALID_RECURRING Recurring donation, but no subscription ID or recurring payment token found. - https://phabricator.wikimedia.org/T360122#9639912 (10AKanji-WMF) p:05Triage→03Medium
[20:27:31] <wikibugs>	 (03PS1) 10Umherirrender: Pass $knownData to AdyenCheckoutAdapter::getFieldsToRemove [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012443
[20:29:03] <wikibugs>	 06Fundraising-Backlog, 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9639929 (10AKanji-WMF) @Cstone has offered to talk to you about this @RLopez-WMF
[20:32:47] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Autorescue: successful donations are losing their names and becoming Anonymous - https://phabricator.wikimedia.org/T359985#9639954 (10AKanji-WMF) p:05Triage→03High
[20:33:52] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Autorescue: successful donations are losing their names and becoming Anonymous - https://phabricator.wikimedia.org/T359985#9639957 (10Eileenmcnaughton) If we can merge this we can finish the test https://gerrit.wikimedia.org/r/c/wiki...
[20:36:50] <wikibugs>	 06Fundraising-Backlog: Placeholder - Research Task - Implementing GPay on Android - https://phabricator.wikimedia.org/T360377 (10AKanji-WMF) 03NEW
[20:41:03] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] "Looks good to me, thank you." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011020 (owner: 10Eileen)
[20:58:58] <wikibugs>	 (03Merged) 10jenkins-bot: Remove one place where we call our outgoing helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011020 (owner: 10Eileen)
[21:13:49] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1012448
[21:15:28] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1012448 (owner: 10Damilare Adedoyin)
[21:15:59] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1012448 (owner: 10Damilare Adedoyin)
[21:17:10] <damilare>	 !log SmashPig upgraded from cc80c042 to 47cd65d9
[21:17:13] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:39:57] <wikibugs>	 (03PS6) 10Ejegg: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen)
[21:40:00] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen)
[21:41:30] <wikibugs>	 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-email-preferences, 07recurring upgrade: Add favicon for donorwiki - https://phabricator.wikimedia.org/T360054#9640125 (10Ejegg) a:03Dwisehaupt No issues, this looks fine
[21:58:03] <wikibugs>	 (03Merged) 10jenkins-bot: Move a couple more tests, including AutoRescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen)
[22:29:32] <wikibugs>	 06Fundraising-Backlog: Explore whether we can activate Acoustic web tracking on our donation forms and thank you pages - https://phabricator.wikimedia.org/T360151#9640230 (10greg) For FR-Tech / @XenoRyet : we should look probably use integrity checks/hashs for this (eg: https://content-security-policy.com/exampl...
[22:34:05] <damilare>	 cstone: looks like this phabs are all related: T360123, T360322, and the one on invalid recurring
[22:34:05] <stashbot>	 T360123: ACH recurring link not working - https://phabricator.wikimedia.org/T360123
[22:34:06] <stashbot>	 T360322: Fix Adyen failmail that is due to missing property in the response - https://phabricator.wikimedia.org/T360322
[22:34:25] <damilare>	 I can't find the ticket on the invalid recurring failmail you created
[22:34:52] <damilare>	 Anyway looks like Adyen isn't returning the recurring payment token for ACH payments
[22:34:56] <damilare>	 on production
[22:35:06] <damilare>	 but they're returning it on sandbox...
[22:35:55] <damilare>	 This causes the invalid subscription failmail during the donation import process due to recurring being set to true and no recurring payment token
[22:36:21] <damilare>	 therefore contribution isn't imported into Civi
[22:37:14] <cstone>	 Ahhhh damilare nice detective work 
[22:37:32] <damilare>	 Then another attempt is made to import the contribution through the audit, but it seems the TokenizeRecurJob also doesn't find the required details and fails leading to the missing property failmail
[22:37:58] <damilare>	 I see the trxns are settled on Adyen console, but not marked as recurring
[22:39:20] <damilare>	 thanks cstone, I think we need to skip the recur checks so we can import a successful contribution even if the recurring token is missing
[22:40:52] <damilare>	 I'd drop a message on the phab for visibility
[22:46:46] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9640264 (10Damilare) Thanks @Cstone for sharing the IDs, I was able to locate the trxns on the Adyen console. One thing I noticed about the records is that they weren't flagged as...
[23:00:20] <greg-g>	 damilare: huh, annoying difference between sandbox and prod :/ thanks for that
[23:08:54] <damilare>	 exactly greg, hard to keep it all together. 
[23:10:39] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9640359 (10EMartin) Just noting here @Cstone that Adyen confirmed to me that we are setup for recurring on ACH on their systems when I asked their support team. LMK if I should res...