[00:22:41] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import deceased date - https://phabricator.wikimedia.org/T357346#9640621 (10Eileenmcnaughton) @MDemosWMF @NNichols we talked about getting some more infor... [00:39:28] 14Fundraising Sprint Uptown cURL, 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 13Patch-For-Review: Data Axle Project - Re-import to Civi - https://phabricator.wikimedia.org/T341902#9640689 (10Eileenmcnaughton) @MDemosWMF these are imported n... [00:48:34] (03PS5) 10Eileen: Move test covering ContributionTracking api to api folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) [00:49:01] (03PS4) 10Eileen: Separate out modify amount queue tests to new class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011007 (https://phabricator.wikimedia.org/T357469) [01:18:37] (03PS1) 10Eileen: Add new address custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012457 (https://phabricator.wikimedia.org/T357345) [01:20:23] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9640778 (10Eileenmcnaughton) Patch to add the new custom fields is ready... [01:45:50] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: 14Correcting Gift Source Coding on Benevity import - 14https://phabricator.wikimedia.org/T354911#9640789 (10Eileenmcnaughton) 05Open→03Resolv... [01:50:44] (03PS6) 10Eileen: Return handling for tags & groups to import classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011181 (https://phabricator.wikimedia.org/T357471) [01:50:45] (03PS1) 10Eileen: Stop setting unnecessary defaults [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012459 (https://phabricator.wikimedia.org/T357471) [01:50:48] (03PS1) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [02:06:25] (03PS2) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [02:07:33] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate rest of normalize into WMFMessage class - https://phabricator.wikimedia.org/T357471#9640811 (10Eileenmcnaughton) I think we might h... [02:09:47] (03CR) 10CI reject: [V:04-1] Return handling for tags & groups to import classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011181 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:11:09] (03CR) 10CI reject: [V:04-1] Stop setting unnecessary defaults [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012459 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:11:33] (03CR) 10CI reject: [V:04-1] Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:20:53] (03CR) 10Ejegg: [C:03+2] "Looks like good shared functionality, but I wonder if the setUp and tearDown from the trait will need overriding for many tests." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:29:56] (03CR) 10CI reject: [V:04-1] Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:39:20] (03Merged) 10jenkins-bot: Move test covering ContributionTracking api to api folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011002 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:24:32] (03CR) 10Ejegg: [C:03+2] "Looks good, good catch deleting that extra create function." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011007 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:25:33] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10FR-email-preferences, 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): 14Create variant version of Recurring Upgrade landing page - 14https://phabricator.wikimedia.org/T356370#9640831 (10Ejegg) 14Just to follow up, we were able to change t... [03:28:35] alright, now I can make tests pass on the rounding patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1011353 [03:42:34] (03Merged) 10jenkins-bot: Separate out modify amount queue tests to new class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011007 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:47:46] (03PS2) 10Ejegg: Round off native amounts in RecurUpgrade activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011353 [03:48:05] oh dang, that ended up with a lot of formattingg noise [03:48:17] well, I guess I could re-do it as two patches [03:55:11] (03PS1) 10Ejegg: Slight cleanup ahead of rounding fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012463 [03:59:04] (03PS2) 10Ejegg: Slight cleanup ahead of rounding fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012463 [04:02:01] (03PS3) 10Ejegg: Round off native amounts in RecurUpgrade activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011353 [04:02:45] fr-tech if anyone's around to review those, they should be quick [04:06:41] eh, it'll wait [04:36:29] oh hey, recurring charge fail [04:37:22] {"status":503,"errorCode":"703","message":"required resource temporarily unavailable","errorType":"internal"} [04:37:31] and we crash with 'unknown error code 703' [04:37:54] eh, should work next time, i hope [04:38:03] though I could file a bug for better error handling [04:42:39] 06Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Adyen error code 703 crashes recurring charge job - https://phabricator.wikimedia.org/T360399#9640861 (10Ejegg) [04:55:18] 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07recurring upgrade: WorkflowMessage ignores set ContributionRecurID, picks first recur from contact - https://phabricator.wikimedia.org/T360245#9640880 (10Ejegg) Oho, our RecurUpgradeMessage is not the culp... [09:09:14] (03CR) 10Eileen: [C:03+2] Slight cleanup ahead of rounding fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012463 (owner: 10Ejegg) [09:10:02] (03CR) 10Eileen: [C:03+2] Round off native amounts in RecurUpgrade activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011353 (owner: 10Ejegg) [09:10:19] (03PS3) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [09:11:11] (03Merged) 10jenkins-bot: Slight cleanup ahead of rounding fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012463 (owner: 10Ejegg) [09:11:47] (03PS4) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [09:11:55] (03PS1) 10Eileen: not for merge" " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012586 [09:12:44] (03Merged) 10jenkins-bot: Round off native amounts in RecurUpgrade activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011353 (owner: 10Ejegg) [09:13:08] (03CR) 10CI reject: [V:04-1] Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [09:13:16] (03CR) 10CI reject: [V:04-1] not for merge" " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012586 (owner: 10Eileen) [09:15:04] (03Abandoned) 10Eileen: Stop setting unnecessary defaults [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012459 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [09:15:24] (03PS7) 10Eileen: Return handling for tags & groups to import classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011181 (https://phabricator.wikimedia.org/T357471) [09:18:33] (03PS5) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [09:22:50] (03CR) 10CI reject: [V:04-1] Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [09:25:07] (03PS6) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [09:25:17] (03PS1) 10Eileen: Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) [09:27:27] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457#9641062 (10Eileenmcnaughton) [09:33:33] (03CR) 10CI reject: [V:04-1] Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [09:55:21] (03CR) 10Ladsgroup: [C:03+2] Replace usage of wfGetDB() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011390 (https://phabricator.wikimedia.org/T357635) (owner: 10沈澄心) [10:06:58] (03Merged) 10jenkins-bot: Replace usage of wfGetDB() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1011390 (https://phabricator.wikimedia.org/T357635) (owner: 10沈澄心) [13:00:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9641753 (10Damilare) Hi @EMartin, I think it's a good idea to resurrect the thread as it seems recurring only works on Sandbox. Evidence: Sandbox ACH transaction with a recurring... [13:20:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Message validation function prevents contribution import when recurring is set - https://phabricator.wikimedia.org/T360429 (10Damilare) 03NEW [14:08:48] mornin fr-tech! [14:12:34] afternoon! [14:12:53] for us UK folks [14:13:09] maggie used to say TZAG [15:20:44] tzag! [15:20:54] and tzaf (farewell) when the time comes :) [15:22:02] 06Fundraising-Backlog: Explore whether we can activate Acoustic web tracking on our donation forms and thank you pages - https://phabricator.wikimedia.org/T360151#9642649 (10greg) Another thought I had was if we could conditionally load the js for only email send donate urls? [16:00:55] (03PS6) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [16:01:42] (03PS1) 10Ejegg: RecurUpgrade: handle new API response format [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012704 [16:02:59] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [16:03:31] TIL tzaf greg-g. nice [16:03:47] (03CR) 10CI reject: [V:04-1] RecurUpgrade: handle new API response format [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012704 (owner: 10Ejegg) [17:00:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Message validation function prevents contribution import when recurring is set - https://phabricator.wikimedia.org/T360429#9643117 (10EMartin) I have reached out to Adyen @Damilare @Cstone and copied you both in. [17:13:28] 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Recurring-Donations, 07recurring upgrade: RecurUpgrade: error message for donors with no upgradable recur - https://phabricator.wikimedia.org/T360052#9643181 (10AKanji-WMF) [17:23:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9643250 (10EMartin) @Damilare Thanks Dami, I have sent an email to Adyen and copied you in. @RKumar_WMF fyi [17:32:16] (03PS2) 10Eileen: Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) [17:36:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH recurring link not working - https://phabricator.wikimedia.org/T360123#9643288 (10Damilare) Thanks @EMartin [18:31:59] (03PS7) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [18:31:59] (03PS2) 10Ejegg: RecurUpgrade: handle new API response format [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012704 [18:33:50] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [18:34:04] (03CR) 10CI reject: [V:04-1] RecurUpgrade: handle new API response format [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012704 (owner: 10Ejegg) [18:47:23] 10fundraising-tech-ops: Fundraising access request for ncreasy - https://phabricator.wikimedia.org/T346174#9643571 (10NCreasy) SSH key pair generated. Public key: ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJDucOKBClXZYVB2WTw410o020Q78aFGOHGVpz5BthBk ncreasy-ctr@wikimedia.org Yubikey public side: Cccccbknuhce Thanks! [18:52:15] (03PS8) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [18:53:34] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Access to rua-dmarc@wikimedia.org - https://phabricator.wikimedia.org/T360462 (10DBu-WMF) 03NEW [18:53:55] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [18:56:02] (03PS9) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [18:57:54] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [19:47:34] 06Fundraising-Backlog, 10FR-email-preferences, 10Recurring-Donations: For donor prefs pages, offer to send a new link when checksum is expired - https://phabricator.wikimedia.org/T352337#9643863 (10AKanji-WMF) @Ejegg is this relevant to the current recurring upgrade work? - let me know if we should bring thi... [20:12:03] 06Fundraising-Backlog, 10FR-email-preferences, 10Recurring-Donations: For donor prefs pages, offer to send a new link when checksum is expired - https://phabricator.wikimedia.org/T352337#9643955 (10Ejegg) @AKanji-WMF it would be nice, but maybe next sprint. The checksums shouldn't expire for 30 days, so this... [20:16:59] (03PS1) 10Damilare Adedoyin: Silence autorescue cancel notifications [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012745 [20:21:23] (03PS10) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [20:23:37] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [20:27:01] (03PS11) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [20:29:01] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [21:05:56] ejegg: switching amount to upgrade_amount should get to you past that failure although it runs into another one [21:12:31] ok the next error is due to the mock call expecting an array but it receives a string as the param [21:13:29] i.e $session->method( 'get' )->with( [ \RecurUpgrade::DONOR_DATA ] ) should be $session->method( 'get' )->with( \RecurUpgrade::DONOR_DATA ) [21:13:43] and the same on line 30 [21:16:42] and then finally on line 130 you just to to swap out amount and other_amount for upgrade_amount and upgrade_amount_other and then those tests pass for me [21:37:14] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/apparmor.d/local/usr.bin.freshclam] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun [21:42:12] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/apparmor.d/local/usr.bin.freshclam] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun [21:44:13] 06Fundraising-Backlog: Autorescue JPY getting reduced from 335.00 to 3.35 - https://phabricator.wikimedia.org/T360480 (10Cstone) 03NEW [21:45:48] jgleeson: ahhh thank you! [21:47:14] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 15 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/apparmor.d/local/usr.bin.freshclam] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun [21:48:57] (03PS12) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [21:49:14] jgleeson: were you able to make the test run locally? [21:49:26] yeah it worked for me [21:49:57] so odd, I wonder what's wrong with my setup [21:50:10] I can't seem to run them under payments or email-pref-ctr [21:50:18] are you running it via phpstorm? [21:50:23] all the other tests run fine, it just ignores the others [21:50:24] in the fun-dev config [21:50:28] or do you have your own setup [21:50:31] no, via scripts/ [21:50:42] ejegg: in our thank you email the first para is a div with nbsp & similar -is that for that hack to affect how google previews it? [21:50:58] (03CR) 10CI reject: [V:04-1] Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [21:51:03] i copy-paste-replaced the payments-phpunit one to get one for email-pref-ctr [21:51:07] eileen: yep, I think so [21:51:14] yes eileen [21:51:35] ok cool - it might not be needed for this ingenico email? [21:51:43] (we could tokenise it in future) [21:52:12] RECOVERY - check_puppetrun on frpm2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun [21:52:16] maybe eileen [21:52:38] (03PS13) 10Ejegg: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 [21:52:49] ejegg: https://phabricator.wikimedia.org/F42772965 [21:53:21] looks like we've got a few ValidatorTests [22:07:02] oho, it ignores the namespace? [22:07:20] I even tried specifying the file and no dice [22:07:36] weirdest thing is it would happily list the tests with --list-tests and the filename [22:07:43] just didn't want to run any of em [22:08:01] but it's passing in CI now, thanks to your help! [22:09:44] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog: Recurring charge job: what happens to a donation that gets skipped by the 2 within 23 days rule - https://phabricator.wikimedia.org/T357350#9644233 (10Cstone) a:03Cstone [22:13:21] np! thanks for the tests [22:13:26] will review 'em first thing [22:13:28] bye for now [22:27:04] (03PS1) 10Cstone: Create new autorescue data and update test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012758 [22:33:08] is there any other currency like JPY that doesnt have decimals [22:33:17] INR? [22:34:39] but through adyen [22:37:06] 06Fundraising-Backlog: Autorescue JPY getting reduced from 335.00 to 3.35 - https://phabricator.wikimedia.org/T360480#9644291 (10Cstone) [22:41:13] 06Fundraising-Backlog: Autorescue JPY getting reduced from 335.00 to 3.35 - https://phabricator.wikimedia.org/T360480#9644294 (10Cstone) [22:48:34] (03PS2) 10Cstone: Create new autorescue data and update test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012758 [23:05:01] well this article wasn't helpful here: https://en.wikipedia.org/wiki/Non-decimal_currency [23:06:23] https://docs.adyen.com/development-resources/currency-codes/ has a list [23:23:45] ah thanks greg-g looks like just JPY [23:37:03] well, I think the recurring upgrade page is mostly ready for the test [23:37:10] I've gotta sign off and get ready for the trip [23:47:09] (03PS3) 10Ejegg: RecurUpgrade: handle new API response format [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012704