[01:30:08] (03PS1) 10Cstone: Add JPY test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012800 [01:30:46] 06Fundraising-Backlog: Enable 90 day snooze: Comms Preferences Centre update - https://phabricator.wikimedia.org/T358878#9644603 (10AKanji-WMF) Noting that the confirmation page copy (after a subscriber submits their preferences) should be as follows: **Header: **Email Preferences Updated **Main Copy:** Your em... [02:48:09] (03CR) 10Eileen: [C:03+1] "this looks good - one thing I hit which you have too is the question of whether the functions like `getAutoRescueMessage()` belong on the " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012758 (owner: 10Cstone) [02:48:43] hah eileen I made that because theres another bug and I wanted to break it https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1012800 [02:49:28] cstone: but those are both called from the same child test classes? [02:49:50] yeah im ambivalent to where everything lives I just needed different data to break it for the current bug [02:50:38] i think test class makes sense so you can see the data right there? [02:52:08] yeah I guess I tend to think that narrower scope (ie child class not parent) means there is less chance of things getting called in all sorts of crazy ways from crazy places :-) But then some of those functions are legit used from lots of places (e.g the one that processes the signup - cos that is used to set up for other things) [02:52:22] which could be a case for putting them all on the parent. [05:42:37] 10fundraising-tech-ops: Fundraising access request for ncreasy - https://phabricator.wikimedia.org/T346174#9644760 (10Dwisehaupt) [05:56:41] 10fundraising-tech-ops: Fundraising access request for ncreasy - https://phabricator.wikimedia.org/T346174#9644762 (10Dwisehaupt) [09:25:24] 06Fundraising-Backlog, 10FR-donorservices: Card type not shown on Civi for French donations - https://phabricator.wikimedia.org/T360503 (10SBorriello) 03NEW [11:19:30] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Access to rua-dmarc@wikimedia.org - https://phabricator.wikimedia.org/T360462#9645333 (10Fabfur) a:03Fabfur [11:29:19] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), 07Spike: PayTM In India: What do we do - https://phabricator.wikimedia.org/T358625#9645360 (10RKumar_WMF) Attached is the list of donors in PayTM walle... [12:01:24] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: 14Access to rua-dmarc@wikimedia.org - 14https://phabricator.wikimedia.org/T360462#9645440 (10Fabfur) 05Open→03Resolved 14Sent information about dmarc address privately (mail) to the ticket author [12:18:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Autorescue JPY getting reduced from 335.00 to 3.35 - https://phabricator.wikimedia.org/T360480#9645467 (10Damilare) [12:18:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Autorescue JPY getting reduced from 335.00 to 3.35 - https://phabricator.wikimedia.org/T360480#9645469 (10Damilare) a:03Damilare [14:20:54] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: explain($LikeImFive), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle -import deceased date - https://phabricator.wikimedia.org/T357346#9645847 (10NNichols) Yeah I think so as well. We can break this list down further and ha... [16:15:00] (03CR) 10Cstone: [C:03+2] "thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012745 (owner: 10Damilare Adedoyin) [16:15:35] (03Merged) 10jenkins-bot: Silence autorescue cancel notifications [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1012745 (owner: 10Damilare Adedoyin) [16:42:30] 14Fundraising Sprint Go Your Own Pay, 14Fundraising Sprint Istanbool (not Constantidouble), 06Fundraising-Backlog: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236#9646465 (10XenoRyet) 05Invalid→03Open [16:42:32] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021) - https://phabricator.wikimedia.org/T291697#9646466 (10XenoRyet) [16:54:08] frvngrudjcjujd [16:55:00] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the work on this and all the tests!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [16:56:59] (03Merged) 10jenkins-bot: Move RecurUpgrade validation into its own class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1011322 (owner: 10Ejegg) [16:58:02] catch you all tomorrow o/ [17:00:37] toodles [17:07:24] 06Fundraising-Backlog: Validation checks for ACH in donor checkout - https://phabricator.wikimedia.org/T360549 (10EMartin) 03NEW [17:08:32] 06Fundraising-Backlog: Explore whether we can activate Acoustic web tracking on our donation forms and thank you pages - https://phabricator.wikimedia.org/T360151#9646594 (10DBu-WMF) I am checking with Chuck Roslof to see if this is feasible. [17:30:55] thanks for the review cstone [17:32:10] I found the reason behind the JPY bug [17:33:14] its not exactly because of the autorescue feature, just the way we extract data from WSDL and make the approve payment request [17:34:41] i was thinking it was that normalizing class that caused the other issues was it in there damilare ? [17:35:19] nah its in smashpig [17:35:34] interesting! [17:35:40] the smashpig code sent the value/100 to the queue [17:35:45] ah haa [17:36:21] I'm trying to wrangle together a test from the WSDL stage but seems to be a waste of time [17:37:08] is this flow different how did other JPY escape this? [17:37:55] yea its because of a currency formatting we are doing in the approvePayment API call [17:38:13] I could show you on a call [17:39:06] I can in 20 mins, sorry to ask so many questions i was trying hard to not dig into it last night :P [17:40:22] no problems, lemme know whenever you're ready or we could discuss on tech talk too [18:08:17] damilare: i can now if you want also we can in tech talk too [18:11:19] ahh sorry please lets do tech talk, want to go make dinner [18:12:25] yeah no worries have a good dinner! [18:44:57] so just wondering if anyone got the email from me in the last few days with a partial of a longer email that I was wondering if people got... (about the recurring restructure) [18:50:14] I saw it eileen [18:50:25] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: 14Access to rua-dmarc@wikimedia.org - 14https://phabricator.wikimedia.org/T360462#9647060 (10Jgreen) [18:51:10] 10fundraising-tech-ops, 10Mail: DMarc Email Address for Wikimedia.org - https://phabricator.wikimedia.org/T316899#9647067 (10Jgreen) [19:32:24] 06Fundraising-Backlog, 10donate.wikimedia.org: 14Paypal recurring not appearing in Mexico form - 14https://phabricator.wikimedia.org/T360214#9647187 (10Pcoombe) 05Open→03Resolved a:03Pcoombe 14I have enabled monthly paypal in Mexico on donatewiki ([diff](https://donate.wikimedia.org/w/index.php?titl... [19:47:40] (03PS1) 10Damilare Adedoyin: Multiply JPY currency amount by 100 in autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013133 (https://phabricator.wikimedia.org/T360480) [19:48:08] (03PS2) 10Damilare Adedoyin: Multiply JPY currency amount by 100 in autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013133 (https://phabricator.wikimedia.org/T360480) [20:06:58] (03PS3) 10Damilare Adedoyin: Multiply JPY currency amount by 100 in autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013133 (https://phabricator.wikimedia.org/T360480) [20:07:23] (03CR) 10CI reject: [V:04-1] Multiply JPY currency amount by 100 in autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013133 (https://phabricator.wikimedia.org/T360480) (owner: 10Damilare Adedoyin) [20:07:24] (03PS4) 10Damilare Adedoyin: Multiply JPY currency amount by 100 in autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013133 (https://phabricator.wikimedia.org/T360480) [20:09:27] (03PS1) 10Damilare Adedoyin: Use authorization reference as gateway txn id in autorescue capture recurring message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013137 [20:09:57] (03CR) 10CI reject: [V:04-1] Use authorization reference as gateway txn id in autorescue capture recurring message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013137 (owner: 10Damilare Adedoyin) [20:11:01] (03PS2) 10Damilare Adedoyin: Use authorization reference as gateway txn id in autorescue capture recurring message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1013137 [20:28:03] damilare: thanks - did you get the first one or just the resent partial [20:29:27] got the recent one you sent on the 19th with the Recurring Queue classes [20:39:18] damilare: that's a shame - that means that the real one never went - which I spent about an hour writing - my fautl for 'documenting' via email