[00:21:04] (03PS2) 10Eileen: Consolidation on function names, centralization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014629 (https://phabricator.wikimedia.org/T357469) [00:30:51] (03PS1) 10Eileen: Introduce new Message class to be the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014643 (https://phabricator.wikimedia.org/T357469) [00:30:52] (03PS1) 10Eileen: Add round function to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014644 (https://phabricator.wikimedia.org/T357469) [00:39:38] (03CR) 10CI reject: [V:04-1] Consolidation on function names, centralization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014629 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [00:45:41] (03PS1) 10Eileen: Add exchangeConvert function to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) [00:45:42] (03PS1) 10Eileen: Move getContributionRecurValue to chared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) [00:45:43] (03PS1) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [01:04:02] (03CR) 10CI reject: [V:04-1] Move getContributionRecurValue to chared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:05:19] (03CR) 10CI reject: [V:04-1] Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:09:56] (03PS2) 10Eileen: Move getContributionRecurValue to chared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) [01:09:56] (03PS2) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [01:09:57] (03PS1) 10Eileen: Introduce RecurringModifyAmountMessage & use it for basic validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014669 (https://phabricator.wikimedia.org/T357469) [01:11:19] (03Abandoned) 10Eileen: Split RecurringModifiyAmount into own queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014624 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:12:03] (03Abandoned) 10Eileen: Add getContributionRecurID() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014627 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:40:16] eileen: i lied im back [03:42:06] cstone: hi [03:42:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Adyen error code 703 crashes recurring charge job - https://phabricator.wikimedia.org/T360399#9664259 (10Cstone) [03:42:46] going to make some spam sorry [03:43:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Card type not shown on Civi for French donations - https://phabricator.wikimedia.org/T360503#9664260 (10Cstone) [03:43:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9664261 (10Cstone) [03:43:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Something going on with Banner Status Codes in Brazil campaign? - https://phabricator.wikimedia.org/T360821#9664262 (10Cstone) [03:43:38] cstone: I split up the patch a bit [03:44:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice selenium tests failing - https://phabricator.wikimedia.org/T360899#9664263 (10Cstone) [03:44:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9664266 (10Cstone) [03:44:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Issue mapping Adyen error code leads to bad payments-init message - https://phabricator.wikimedia.org/T360901#9664267 (10Cstone) [03:45:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: New recurring donation that gets stopped at auth makes INVALID_RECURRING Recurring donation, but no subscription ID or recurring payment token found. - https://phabricator.wikimedia.org/T360122#9664268 (10Cstone) [03:45:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-Translate, 07ci-test-error: phpunit test failure for extension FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T357804#9664269 (10Cstone) [03:45:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: New Donors Donating On Email - https://phabricator.wikimedia.org/T356911#9664270 (10Cstone) [03:46:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Matching gift import - https://phabricator.wikimedia.org/T356445#9664271 (10Cstone) [03:49:30] eileen: were you thinking for message that it would spread to all the donation like queues then? and just be like getters? [03:49:53] er non donation like * [03:50:03] cstone: yeah - it is intended to be a generic Message that they can extend [03:50:09] so shared helper functionality [03:50:17] ok cool [03:51:43] unrelated question what does the validate do on the import errors searchkit [03:51:58] or does it save this so i can get back to it? [03:53:46] this is really nice eileen appreciate the smaller chunks [03:53:47] when you do an import it runs validate first & then import - validate does the cheap validation - e.g is the date a date so if you had a invalid date & fixed it they validate would 'pass' [03:54:59] import = validate + try to import & on try-to-import thats when contact look ups happen [03:57:02] what would it do from the error page? [03:57:17] eileen: i just read that slack too [03:58:49] im guessing paypal recurring import gone wrong? [03:59:13] or right and its getting into that flow somehow [04:00:37] start date of 0th is suspicious [04:04:21] cstone: is that re the recur message? [04:04:59] i think its the only one like that [04:05:10] well the only one with 0th [04:05:11] I just jumped back into tech talk in case it's easier to chat [04:05:15] ok sure [04:28:08] (03PS1) 10Eileen: Quick & dirty to make sure we don't upgrade paypal, amazon [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014699 (https://phabricator.wikimedia.org/T361063) [04:31:07] (03PS2) 10Eileen: Quick & dirty to make sure we don't upgrade paypal, amazon [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014699 (https://phabricator.wikimedia.org/T361063) [04:33:50] (03CR) 10Cstone: [C:03+2] Quick & dirty to make sure we don't upgrade paypal, amazon [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014699 (https://phabricator.wikimedia.org/T361063) (owner: 10Eileen) [04:44:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Received TY for recurring upgrade that did not occur? - https://phabricator.wikimedia.org/T361063#9664327 (10Cstone) [04:45:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Received TY for recurring upgrade that did not occur? - https://phabricator.wikimedia.org/T361063#9664329 (10Eileenmcnaughton) Just noting cstone & I looked into this & the message had gone into the fundraise up... [04:50:01] (03CR) 10Cstone: [C:03+2] Introduce new Message class to be the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014643 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:50:35] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1014701 [04:51:08] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1014701 (owner: 10Eileen) [04:54:49] thanks both for the quick response [04:55:10] !log civicrm upgraded from 143aa0bf to 2e0ac12f [04:55:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:59:01] (03PS2) 10Eileen: Introduce new Message class to be the parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014643 (https://phabricator.wikimedia.org/T357469) [04:59:01] (03PS2) 10Eileen: Add round function to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014644 (https://phabricator.wikimedia.org/T357469) [04:59:02] (03PS2) 10Eileen: Add exchangeConvert function to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) [04:59:02] (03PS3) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [04:59:03] (03PS2) 10Eileen: Introduce RecurringModifyAmountMessage & use it for basic validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014669 (https://phabricator.wikimedia.org/T357469) [04:59:04] (03PS1) 10Eileen: Move getContributionRecurValue to chared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014703 (https://phabricator.wikimedia.org/T357469) [04:59:09] (03PS1) 10Eileen: Move some validation to the validate() function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014704 (https://phabricator.wikimedia.org/T357469) [04:59:13] (03PS1) 10Eileen: Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 [04:59:17] (03PS1) 10Eileen: Remove moved constants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014726 [04:59:21] (03PS1) 10Eileen: Move gateway functions to base class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014727 (https://phabricator.wikimedia.org/T357469) [04:59:25] (03PS1) 10Eileen: Do not send upgrade message to fundraise up donors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014728 (https://phabricator.wikimedia.org/T357469) [05:21:12] (03CR) 10CI reject: [V:04-1] Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 (owner: 10Eileen) [05:22:17] (03CR) 10CI reject: [V:04-1] Move gateway functions to base class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014727 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:22:33] (03CR) 10CI reject: [V:04-1] Remove moved constants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014726 (owner: 10Eileen) [05:22:41] (03CR) 10CI reject: [V:04-1] Do not send upgrade message to fundraise up donors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014728 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:36:05] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014643 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [06:28:11] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1014786 (owner: 10L10n-bot) [06:39:40] (03PS3) 10Eileen: Add round function to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014644 (https://phabricator.wikimedia.org/T357469) [06:39:40] (03PS3) 10Eileen: Add exchangeConvert function to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) [06:39:40] (03PS3) 10Eileen: Move getContributionRecurValue to shared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) [06:39:40] (03PS2) 10Eileen: Move gateway functions to base class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014727 (https://phabricator.wikimedia.org/T357469) [06:39:41] (03PS4) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [06:39:43] (03PS3) 10Eileen: Introduce RecurringModifyAmountQueueConsumer & also add RecurringModifyAmountMessage & use it for basic validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014669 (https://phabricator.wikimedia.org/T357469) [06:39:47] (03PS2) 10Eileen: Move some validation to the validate() function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014704 (https://phabricator.wikimedia.org/T357469) [06:39:51] (03PS1) 10Eileen: Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) [07:00:38] (03CR) 10CI reject: [V:04-1] Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [10:05:50] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Can we please add our vendor to Google Postmaster Tools - https://phabricator.wikimedia.org/T360907#9664538 (10jcrespo) @DBu-WMF Hi, we are discussing how to proceed, as handling postmaster access is a new process for us. The first question is **what dom... [14:54:17] (03PS1) 10Jgleeson: Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 [14:55:10] (03PS2) 10Jgleeson: Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 [15:36:14] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9665944 (10ppenloglou) For donor 397205, I was able to retrieve their email address from Civi and try testing it within Acoustic. Their address... [16:00:30] (03PS1) 10Ejegg: Extract base client-side error logging API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) [16:02:41] (03CR) 10CI reject: [V:04-1] Extract base client-side error logging API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) (owner: 10Ejegg) [16:07:58] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Can we please add our vendor to Google Postmaster Tools - https://phabricator.wikimedia.org/T360907#9666103 (10Jgreen) >>! In T360907#9664537, @jcrespo wrote: > @DBu-WMF Hi, we are discussing how to proceed, as handling postmaster access is a new process f... [16:11:58] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, and 2 others: Move all our queue consumers into the extension space - https://phabricator.wikimedia.org/T357469#9666111 (10Cstone) [16:17:26] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Can we please add our vendor to Google Postmaster Tools - https://phabricator.wikimedia.org/T360907#9666137 (10DBu-WMF) Trilogy is not an unknown vendor to us. They have been assisting us with Banners and Emails for several years. They also manage our co... [16:18:00] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236#9666139 (10jgleeson) a:03jgleeson [16:25:47] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Can we please add our vendor to Google Postmaster Tools - https://phabricator.wikimedia.org/T360907#9666211 (10bsisolak) We have access to Google Postmaster Tools, this is just with a new account that will allow us to send automated alerts based on a Spam... [16:47:32] (03CR) 10Ejegg: [C:03+2] Add round function to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014644 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [16:52:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9666322 (10Ejegg) Thanks for checking @ppenloglou! So I wonder how that full real URL gets translated to the long gibberi... [17:00:24] (03PS2) 10Ejegg: Extract base client-side error logging API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) [17:04:10] (03Merged) 10jenkins-bot: Add round function to the Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014644 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [17:05:34] oh hmm, I should namespace that API [17:14:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Received TY for recurring upgrade that did not occur? - https://phabricator.wikimedia.org/T361063#9666375 (10greg) For posterity, the slack thread discussing this: https://wikimedia.slack.com/archives/C057U5C7HB... [17:42:22] (03PS1) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [17:44:15] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [17:45:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9666504 (10ppenloglou) Sure thing @Ejegg! Indeed you're right, Acoustic generates these //links.email.wikimedia.org// hyp... [17:45:07] Hmm, class not found. Let's see what we need to do there [17:54:18] oh derp I need to specify the full namespaced class name in extension.json [17:55:14] (03PS2) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [17:57:10] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [17:58:09] ah it would help to spell the namespace right too [17:58:31] (03PS3) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [17:59:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9666560 (10bsisolak) No humans ever see the text version, so it's not that. If if they seeing the text version they are u... [18:00:21] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [18:01:38] hmm, is it the casing of Api vs folder /api ? [18:05:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Received TY for recurring upgrade that did not occur? - https://phabricator.wikimedia.org/T361063#9666590 (10Cstone) What happened, three edge cases combined: There was an older fundraise up specific flow for i... [18:08:03] let's see if any bundled extensions have namespaced their API endpoints [18:10:05] oh interesting, they seem to like to START the class name with Api, not end it with that [18:30:16] (03PS3) 10Jgleeson: Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 [18:37:58] just tested that on a mac ^ [18:43:17] (03PS1) 10Umherirrender: Various changes to @param documentation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015093 [19:21:02] (03PS2) 10Eileen: Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) [19:21:22] (03PS3) 10Eileen: Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) [19:35:31] (03PS1) 10Eileen: Update Geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015100 (https://phabricator.wikimedia.org/T358259) [19:36:59] (03PS1) 10Eileen: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) [19:49:23] (03PS1) 10Eileen: Vendor update, guzzle 7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015105 (https://phabricator.wikimedia.org/T358259) [19:49:31] (03CR) 10CI reject: [V:04-1] Vendor update, guzzle 7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015105 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [19:51:32] (03PS2) 10Eileen: Vendor update, guzzle 7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015105 (https://phabricator.wikimedia.org/T358259) [19:56:45] (03CR) 10CI reject: [V:04-1] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [19:57:39] (03CR) 10CI reject: [V:04-1] Update Geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015100 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:12:36] (03CR) 10Ejegg: [C:03+2] Update Geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015100 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:12:46] (03PS2) 10Ejegg: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:15:03] (03PS3) 10Ejegg: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:15:05] (03CR) 10Ejegg: [C:03+2] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:32:39] (03CR) 10CI reject: [V:04-1] Update Geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015100 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:32:40] (03CR) 10CI reject: [V:04-1] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [20:35:03] hmm geocoder needs some test fix - on cleanup I think [20:37:19] (03PS4) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [20:39:31] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [20:42:13] woohoo, ok, now I just have to make Phan happy [20:57:16] (03PS5) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [20:59:33] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [21:10:03] (03PS6) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [21:11:53] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [21:14:32] (03PS7) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [21:16:29] (03CR) 10CI reject: [V:04-1] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [21:18:41] (03PS8) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [21:18:47] flailing with this phan config [21:19:10] i've got it including dirs for dependencies but not scrutinizing them [21:19:18] but I can't seem to do that with a single file [21:22:41] oho, that did it! [21:27:49] (03PS2) 10Eileen: Update Geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015100 (https://phabricator.wikimedia.org/T358259) [21:27:50] (03PS4) 10Eileen: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) [21:27:50] (03PS1) 10Eileen: Switch Omnimail to use core GuzzleTestTrait [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015117 [21:46:31] (03CR) 10CI reject: [V:04-1] Switch Omnimail to use core GuzzleTestTrait [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015117 (owner: 10Eileen) [21:47:25] wow - I didn't think I was gonna spend today locked in a mortal battle with composer [21:48:02] I hope you persevere [21:56:28] (03PS1) 10Eileen: Update wikimedia/civicrm-data-table-provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015124 (https://phabricator.wikimedia.org/T358259) [21:56:32] lol [21:56:49] I don't need to persevere - I need to WIN [23:08:40] (03CR) 10Krinkle: Various changes to @param documentation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015093 (owner: 10Umherirrender) [23:11:11] (03CR) 10Krinkle: "If I understand correctly, this patch is repairing a function that has been broken for a long time. It's not clear what the side-effects o" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014616 (owner: 10Umherirrender) [23:44:14] (03CR) 10Ejegg: [C:03+2] Update wikimedia/civicrm-data-table-provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015124 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [23:46:21] did we see this? https://phabricator.wikimedia.org/T360596 [23:52:11] oh boy cstone, replacing redis would be annoying [23:52:44] looks like some forks are coming out though [23:56:08] i saw that. we've probably got a while. [23:58:06] y'all should add your redis usage to the description on that task so nobody forgets to keep you in the loop/invite you to any working group that might arise [23:58:54] Both KeyDB and redict look like they will be reasonable for the use cases I know about