[00:00:11] I'd have a bias for redict because of the license Drew picked, but he's going to need co-maintainers to link up with him too [00:05:02] (03PS1) 10Cstone: Add id to log line [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015159 [00:05:37] (03Merged) 10jenkins-bot: Update wikimedia/civicrm-data-table-provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015124 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [00:05:50] fr-tech if someone could look at this ^ im pretty sure I was the cause of the adyen audit fail but I need to track down what id did it [00:07:26] oh spoke too soon maybe i did find it [00:07:47] nope nevermind [00:09:59] oh i did find it! [00:10:59] such a rollercoaster. :) [00:11:09] i shouldnt announce anything haha [00:11:47] i feel the same way a lot of days. i consider irc to be my rubber duck. [00:12:04] i still dont know if the weird one i found is the cause of the fail hah well see there [00:12:34] (03PS1) 10Ejegg: Add new API action to log recurring upgrade errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015161 (https://phabricator.wikimedia.org/T360785) [00:12:40] ok. i'm off to get the family where they need to go tonight. see you later. [00:14:34] (03CR) 10CI reject: [V:04-1] Add new API action to log recurring upgrade errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015161 (https://phabricator.wikimedia.org/T360785) (owner: 10Ejegg) [00:15:25] (03PS2) 10Ejegg: Add id to log line [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015159 (owner: 10Cstone) [00:15:27] (03CR) 10Ejegg: [C:03+2] Add id to log line [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015159 (owner: 10Cstone) [00:17:49] thanks ejegg [00:19:57] (03PS1) 10Eileen: Upgrade geocoder to latest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015163 (https://phabricator.wikimedia.org/T358259) [00:20:34] just flagging this for review - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1012457 [00:21:14] what does the payment details UI in civi actually update? [00:21:26] financial_trxn table [00:21:42] (also linked by financial_item , entity_financial_trxn) [00:22:15] yeah i have a situaton where the contribution has a bad trxn_id [00:22:22] which looks like i cant update via ui/searchkit [00:22:29] but then its not acutally showing up anywhere in the UI [00:22:41] cause it shows the one in the financial_trxn table [00:22:54] hmm - so trxn_id is in civicrm_contribution but that is a single value where as there can be many payments on one contribution [00:23:00] so financial_trxn has that [00:23:30] ooooh [00:23:45] thats what these commans mean! [00:23:49] commas even [00:24:09] yeah [00:24:37] only records with is_payment=true should be considered [00:25:08] hmm how do i clean this up [00:27:04] what record? [00:27:06] ie id [00:28:04] cid=45906826 [00:28:12] i made it worse trying to understand what it does [00:28:23] so this whole thing is because it didn't have a payment somehow [00:28:47] and it needed one for the refund so I added it, but then pasted the wrong id, and then tried to fix it, which is where commas came from [00:34:26] (03Merged) 10jenkins-bot: Add id to log line [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015159 (owner: 10Cstone) [00:36:51] (03CR) 10Cstone: [C:03+2] "I see them!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012457 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [00:40:18] (03CR) 10CI reject: [V:04-1] Upgrade geocoder to latest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015163 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [00:41:29] cstone: ok - I see 103583245 | RECURRING ADYEN P5TZ9VRS87MDP672,P8RTQ2FJQ7C97F32,RECURRING ADYEN P8RTQ2FJQ7C97F32,test,more - & you are saying sk treats that field as read only? [00:43:34] i guess what do i do to make it just say RECURRING ADYEN P8RTQ2FJQ7C97F32 [00:44:32] yeah i cant update transacton id from sk but i think because it is glueing together those multiples? [00:50:19] eileen: im tagging you in a slack thread [00:51:27] " mistakenly selected "Add new contacts and update existing field values in the contact source" in Acoustic instead of "Update field values in the contact source" when uploading a contact list that I downloaded from Acoustic." natalie wants to know if we need to do something to fix that [00:53:44] cstone: yeah I'm not quite sure what she means [00:55:49] to my other question we have code that explodes trxn_id that on spaces and validates and its causing the audit to fail because ive created the monstrosity [00:56:31] (03Merged) 10jenkins-bot: Add new address custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012457 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [01:15:43] ok, so are all of those dlocal invalid recurrings from the recon auditor? [01:16:09] idono ejegg im like 3 failmails back [01:16:19] they might be if they happen at whatever time that runs [01:17:40] 00:20 UTC [01:18:24] the timing doesnt line up i don think? [01:19:46] ah well the last one has Recon Auditor as the source_name [01:20:05] was going to try to do a db query for the percentage that have that source_name [01:20:18] but I guess smashpig db isn't replicated to frdev [01:20:18] maybe they are though [01:20:42] gonna query from civi1002 [01:21:48] ejegg: do you see any issue with me just updating a cursed trxn_id i have with a transaction on the civicrm_contribution table its causing the audit to fail [01:23:12] oh wow fun [01:23:26] what CID? just curious [01:23:37] cid=45906826 i made a mess hah [01:23:48] if you have backscroll there is more info too [01:24:09] its on the 3 yen one it never had a payment so i added one and then things went downhill from there [01:24:18] ah ha 'more' ??? [01:24:33] Sure, go ahead and fix it! [01:24:44] it confirmed that it just concats any change to the trxn id haha [01:24:47] i did not expect it to do that [01:26:19] (03PS8) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [01:27:02] (03PS2) 10Eileen: Upgrade geocoder to latest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015163 (https://phabricator.wikimedia.org/T358259) [01:28:16] ooh vector 2022 on our docs too [01:28:16] yeah - we should actually query civicrm_financial_trxn I guess but.... [01:28:53] but that doesnt have it in there, is it just a feature that it concats them like that? [01:29:44] cstone the space-concatenated thing I think is our invention [01:29:58] since trxn_id has to be unique across the whole Civi db [01:30:16] but different payment processors could have the same ID [01:31:02] it may have been overkill to add the 'RECURRING' prefix, but I'm sure awight or k4 had a good reason for it at the time [01:32:14] yeah thats fine but just that when you change like RECURRING 1 to RECURRING 2 i just didnt expect it to make it be RECURRING 1, RECURRING 2 [01:33:25] I *think* I've won the battle to get geocoder updated.... [01:36:37] ok that did the complete opposite of what I thought [01:37:00] why did it send a ty email :( [01:37:33] cause its still more bah [01:38:06] ok i think i finally understand [01:44:05] hm how long does adyen keep sending a message for like a week? [01:46:37] ejegg: dlocal ones are all audit [01:46:57] aha, thank you [01:47:06] they are all at 00:23 in the damaged queue [01:47:09] i totally got distracted while i was writing thta query [01:47:22] I did it I did it - latest geocode update passed [01:47:22] and started slogging through paypal refactor [01:47:42] and its the same ones over and over [01:47:49] no worries i can look into the dlocal thing [01:47:52] woo eileen [01:52:41] ejegg: I tink you need to transfer you +2 to https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1015163 [01:53:21] sure eileen ! [01:53:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9667837 (10Cstone) [01:57:17] (03PS1) 10Eileen: Update guzzle to match CiviCRM version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015167 (https://phabricator.wikimedia.org/T358259) [02:03:41] (03CR) 10Ejegg: [C:03+2] Upgrade geocoder to latest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015163 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [02:12:28] ejegg: just looking at composer & the state of our packages & [02:12:28] 1) we install drush 8.x but 9.x would in theory work for d7 and [02:12:29] 2) I note locally we don't use this instance of drush anyway.. [02:13:08] hmm, and drush will be a moot point within a year [02:13:25] any reason to change the version in the composer folder? [02:14:45] yeah- the only reason is that there are other older packages in composer because of it - but I guess I should move along [02:17:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9667846 (10Cstone) [02:17:09] ok - now I'm not sure if the post geocoder patch is ok - sigh [02:17:36] dang, i think I need to change something in SmashPig that will leave the CreatePaymentResponse identical to the PaymentDetailResponse [02:18:02] turns out that PayPal can tell us to send the user back to them again when we query for the latest payment details [02:18:24] and the only thing the Create response had that the Detail response didn't were those redirect properties [02:18:29] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015167 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [02:19:18] I have a question - I was thinking about documenting our different types of messages - where they come from, where they go & what fields they have - do we have something that does that already? [02:19:54] there was a page for that once eileen but it's pretty old [02:20:06] (03CR) 10CI reject: [V:04-1] Update guzzle to match CiviCRM version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015167 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [02:20:31] https://wikitech.wikimedia.org/wiki/Fundraising/Normalized_donation_messages <-eileen [02:21:16] oh yeah - explain a message, any type, as long as it is a donation [02:21:24] hmm, 'message roadmap' is a redlink [02:21:57] yeah thats very old docs i think theres another one somewhere too but also old [02:21:58] I kinda feel like it should be 'in code' documentation - maybe even dynamic like the api explorer [02:23:47] i wonder if we can fully expand the side bar as a setting in vector 2022 [02:26:03] ah that page has opinions about currency field names [02:26:31] currency (required) Original currency of transaction. Do not use the deprecated original_currency or original_gross fields, these are too confusing. We'll introduce "settled_currency", etc., when it becomes necessary to track FOREX across processor accounts. [02:27:42] (03PS2) 10Eileen: Update Guzzle to match CiviCRM version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015167 (https://phabricator.wikimedia.org/T358259) [02:28:05] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015163 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [02:28:06] names are hard [02:28:21] hah [02:28:41] & now we are like 'settled ==== usd' let's say usd [02:29:22] cause don't we settle some accounts in the original (lol) currency [02:29:49] i think maybe [02:30:02] my argument for just naming it usd [02:30:07] lol [02:31:23] (03Merged) 10jenkins-bot: Upgrade geocoder to latest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015163 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [02:36:02] i think this dlocal issue is something weird with debit cards they are all visa debit or mastercard debit (all 7) [02:37:03] ok - I think guzzle is gonna work this time - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1015167/2 - it got past it's last fail [02:39:37] by the way - smashpig composer is not on the latest? [02:40:21] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015168 [02:40:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9667858 (10Cstone) suspicious they are all debit, asking payments if they have any more information [02:41:14] (03CR) 10CI reject: [V:04-1] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015168 (owner: 10Eileen) [02:43:36] eileen: im going to head out good luck in the battle [02:43:45] lol [02:46:08] eileen: apologies, what was the action around the PDFs appended to old email sends that are eating up space in the database (https://phabricator.wikimedia.org/T297308)? Am I asking MG&E if we can strip those attachments of all those emails OR delete the comms history and purge from the record? [02:46:58] yeah - just the attachments - the assumption is they are sending a mail with a brochure & don't need a copy of the brochure attached to each mail.... [02:50:01] (03PS5) 10Eileen: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) [02:51:11] cstone: if you are still about can you + 2 this cos this one is different to the one ejegg|afk +2d but kinda the same https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1015167 [02:57:28] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [02:58:38] (03CR) 10CI reject: [V:04-1] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [03:07:44] (03PS1) 10Eileen: Update vendor, removes old guzzle 6 adapter [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015170 [03:07:44] (03PS2) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015168 [03:07:51] (03CR) 10CI reject: [V:04-1] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015168 (owner: 10Eileen) [03:12:01] (03PS6) 10Eileen: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) [03:13:15] (03CR) 10CI reject: [V:04-1] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [03:13:22] (03CR) 10Eileen: [C:03+2] "I'm putting back the +2 because the change was just to include a .lock file tweak in the extension - which is not material to the change" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [03:14:37] (03CR) 10CI reject: [V:04-1] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [03:14:51] (03CR) 10Eileen: [C:03+2] Update vendor, removes old guzzle 6 adapter [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015170 (owner: 10Eileen) [03:33:23] (03Merged) 10jenkins-bot: Update vendor, removes old guzzle 6 adapter [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015170 (owner: 10Eileen) [03:58:45] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015168 (owner: 10Eileen) [04:03:37] (03Abandoned) 10Eileen: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015104 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [04:05:25] (03Abandoned) 10Eileen: Update Geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015100 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [04:05:59] (03Abandoned) 10Eileen: Vendor update, guzzle 7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015105 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [04:06:52] (03Abandoned) 10Eileen: Consolidation on function names, centralization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014629 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:09:26] (03Abandoned) 10Eileen: Move getContributionRecurValue to chared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014703 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:09:44] (03Abandoned) 10Eileen: Remove moved constants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014726 (owner: 10Eileen) [04:13:20] (03PS7) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [04:13:20] (03PS4) 10Eileen: Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) [04:29:08] (03PS5) 10Eileen: Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) [04:29:19] (03CR) 10CI reject: [V:04-1] Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:39:04] (03PS6) 10Eileen: Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) [07:01:05] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1014786 (owner: 10L10n-bot) [13:18:41] (03CR) 10Damilare Adedoyin: [C:03+2] Update Guzzle to match CiviCRM version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015167 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [13:19:08] cheers to snoozing through Easter [13:25:15] (03CR) 10Jgleeson: Add exchangeConvert function to Message class (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [13:27:21] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [13:28:14] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014727 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [13:38:31] (03Merged) 10jenkins-bot: Update Guzzle to match CiviCRM version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015167 (https://phabricator.wikimedia.org/T358259) (owner: 10Eileen) [13:40:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9669212 (10AMJohnson) I'm not sure if this will be helpful to you all so please disregard if not! :) @Ejegg @PPenloglou-W... [13:49:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9669283 (10Ejegg) Thanks @AMJohnson, that is good information. [14:24:24] (03PS1) 10Damilare Adedoyin: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015336 (https://phabricator.wikimedia.org/T358259) [15:02:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9669710 (10Ejegg) Hi @AMJohnson I can't seem to sign in to Zendesk either via Okta or with my old password, and the reset... [15:03:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9669711 (10ppenloglou) Thanks @AMJohnson for the extra info! @Ejegg , I went to Zendesk myself and had a look at the orig... [15:07:46] (03PS1) 10Ejegg: Pull redirect members up to PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015345 (https://phabricator.wikimedia.org/T317245) [15:08:52] (03CR) 10Damilare Adedoyin: [C:03+2] Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015336 (https://phabricator.wikimedia.org/T358259) (owner: 10Damilare Adedoyin) [15:09:33] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015346 [15:10:00] (03CR) 10CI reject: [V:04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015346 (owner: 10Damilare Adedoyin) [15:10:01] 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when canceling recurrings due to chargebacks - https://phabricator.wikimedia.org/T361243 (10MBeat33) 03NEW [15:23:03] (03CR) 10Jgleeson: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:26:31] (03Merged) 10jenkins-bot: Update guzzle to 7.6.1 per core [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015336 (https://phabricator.wikimedia.org/T358259) (owner: 10Damilare Adedoyin) [15:27:20] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015346 (owner: 10Damilare Adedoyin) [15:59:11] 06Fundraising-Backlog, 07Epic: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9670012 (10Ejegg) @Pcoombe brought up in a meeting that we need to update the parameters we pass through to the Thank You pages. To avoid really long URLs, he suggests we do... [16:05:40] (03PS1) 10Ejegg: Use wmf_ params for redirect to TY pages (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) [16:06:24] (03CR) 10Ejegg: [C:04-1] "Do not merge till @pcoombe says he's ready on the https://phabricator.wikimedia.org/T351325" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) (owner: 10Ejegg) [16:07:34] (03CR) 10CI reject: [V:04-1] Use wmf_ params for redirect to TY pages (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) (owner: 10Ejegg) [16:07:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-Translate, 07ci-test-error: phpunit test failure for extension FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T357804#9670047 (10greg) p:05Triage→03Medium [16:09:15] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 13Patch-For-Review: Update contact on CiviCRM when FRUP donor updates their email through donor portal - https://phabricator.wikimedia.org/T349663#9670050 (10Damilare) [16:16:30] (03PS2) 10Ejegg: Use wmf_ params for redirect to TY pages (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) [16:28:09] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Discard duplicate RecurUpgrade messages - https://phabricator.wikimedia.org/T361255 (10Ejegg) 03NEW [16:31:52] 06Fundraising-Backlog: Add activity when recurring donation starts autorescue flow - https://phabricator.wikimedia.org/T361256 (10Cstone) 03NEW [16:36:12] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9670175 (10AMJohnson) @Ejegg Sorry you had trouble, Elliott! I just went and looked in Zendesk admin and it doesn't look... [16:48:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9670273 (10AMJohnson) @Ejegg Ignore my previous comment if you saw it. I re-activated your Zendesk access and resent a pa... [17:06:09] (03CR) 10Ejegg: [C:04-1] "Plz do not merge till Peter gets the javascript updated" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) (owner: 10Ejegg) [17:10:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9670393 (10bsisolak) So suspect I know what happened, it struck me you said the email is not in Acoustic anymore. My gues... [17:11:14] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 13Patch-For-Review: SEPA direct debit as mainstream payment method in EU campaigns - https://phabricator.wikimedia.org/T324520#9670396 (10AKanji-WMF) Flagging this form e... [17:42:46] oh shoot that last recurUpgrade patch needs i18n changes [17:58:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9670588 (10ppenloglou) @bsisolak Very interesting insight into how Acoustic handles URLs. So you're saying that without c... [17:59:03] (03PS3) 10Ejegg: Extract base client-side error logging API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) [17:59:03] (03PS9) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [17:59:03] (03PS2) 10Ejegg: Add new API action to log recurring upgrade errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015161 (https://phabricator.wikimedia.org/T360785) [18:01:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Trouble upgrading via Recurring Upgrade email - https://phabricator.wikimedia.org/T360785#9670599 (10Ejegg) > - How is the checksum column populated for contacts? Could something have gone wrong there? Every... [18:05:50] (03PS4) 10Eileen: Add exchangeConvert function to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) [18:06:11] (03CR) 10Eileen: "I agree jgleeson - I prefer currencyConvert - updated" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [18:15:01] (03PS1) 10Eileen: Update guzzle [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015364 [18:15:10] (03CR) 10CI reject: [V:04-1] Update guzzle [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015364 (owner: 10Eileen) [18:19:44] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015366 [18:19:59] (03Abandoned) 10Eileen: Update guzzle [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015364 (owner: 10Eileen) [18:20:13] (03CR) 10CI reject: [V:04-1] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015366 (owner: 10Eileen) [18:20:19] looks like you merged the guzzle patch to vendor damilare but not deployment? [18:20:52] yh I was trying to do the deployment own but it keeps failing CI [18:21:12] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015366 (owner: 10Eileen) [18:21:22] with this error: 15:09:55 fatal: No url found for submodule path 'vendor/drupal/coder' in .gitmodules [18:21:23] 15:09:55 Failed to recurse into submodule path 'vendor' [18:21:25] y [18:22:01] here's the patch where I tried doing the deployment merge: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1015346 [18:22:58] hmm - is coder dev only & it accidentally got committed? [18:24:26] looks like it might have been me [18:24:42] that's possible, seems yours is making some progress now [18:24:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Something going on with Banner Status Codes in Brazil campaign? - https://phabricator.wikimedia.org/T360821#9670706 (10spatton) Hey @Cstone, thanks for working on this; we are definitely observing a year over year drop in impression counts in our Brazil c... [18:27:10] (03PS1) 10Damilare Adedoyin: Remove coder [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015369 [18:29:07] ohh missed your second message, but yh I just ran composer install --no-dev and it removed coder [18:30:23] (03PS1) 10Damilare Adedoyin: Remove dev dependencies for vendor [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015370 [18:30:37] (03PS1) 10Eileen: Remove incorrectly added coder file [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015371 [18:30:51] (03CR) 10Eileen: [C:03+2] Remove incorrectly added coder file [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015371 (owner: 10Eileen) [18:31:31] ok - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/vendor/+/1015371 removes it again but you did the same [18:31:33] (03Abandoned) 10Damilare Adedoyin: Remove coder [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015369 (owner: 10Damilare Adedoyin) [18:32:00] yep just abandoned mine [18:32:28] (03PS5) 10Eileen: Add currencyConvert function to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) [18:38:36] jgleeson: I renamed that fn ^^ [18:50:33] (03Merged) 10jenkins-bot: Remove incorrectly added coder file [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1015371 (owner: 10Eileen) [18:57:29] eileen: I'd update the vendor submodule on your patch since it's pretty much the same as mine [18:58:08] thanks eileen ! [18:58:38] jgleeson: I like currencyConvert - it's what we would say irl [18:58:54] damilare: so sorry - you are gonna do that? Or Ishould? [19:00:19] no it's problem [19:00:46] it's no problem* [19:00:47] (03CR) 10Jgleeson: [C:03+2] "LGTM thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:03:27] (03PS2) 10Damilare Adedoyin: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015366 (owner: 10Eileen) [19:05:17] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015366 (owner: 10Eileen) [19:06:01] (03Abandoned) 10Damilare Adedoyin: Remove dev dependencies for vendor [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015370 (owner: 10Damilare Adedoyin) [19:06:16] (03Abandoned) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015346 (owner: 10Damilare Adedoyin) [19:20:06] (03Merged) 10jenkins-bot: Add currencyConvert function to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014645 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:20:08] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015366 (owner: 10Eileen) [19:29:36] (03PS2) 10Umherirrender: Various changes to @param documentation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015093 [19:29:48] (03CR) 10Umherirrender: Various changes to @param documentation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015093 (owner: 10Umherirrender) [19:32:32] ok I'd be deploying that civi patch [19:34:41] !log civicrm upgraded from 2e0ac12f to ed776060 [19:34:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:35:34] civi frontend still loads, that's good [19:36:02] (03CR) 10Umherirrender: "I was suprised to see this when trying to run phan on all php files in this extension." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014616 (owner: 10Umherirrender) [19:41:49] the snooze is finally working! [19:43:51] thanks eileen for all the work on that [19:43:58] woohoo [19:44:36] (03PS4) 10Eileen: Move getContributionRecurValue to shared function, rename [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) [19:44:49] (03PS3) 10Eileen: Move gateway functions to base class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014727 (https://phabricator.wikimedia.org/T357469) [19:45:11] (03PS5) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [19:46:34] damilare: did you see I also got this working https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1011013 so it can be installed on install locally / jenkins [19:48:25] ohh cool, I had checked it out earlier when it was failing CI. Looks like it's all good now. [19:49:16] (03CR) 10Damilare Adedoyin: [C:03+2] Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:49:56] damilare: yeah I finally figured out that fredge was using a sneak create if not exists so I copied... [19:51:39] yh that part is neat, I had to do it manually when installing on the VM Tim shared at the sprint. This would make the installation easier [20:07:53] (03Merged) 10jenkins-bot: Enable Damaged extension on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011013 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:10:10] (03PS2) 10Ejegg: Avoid undeclared $start in DonationProfiler::getStopwatch [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014616 (owner: 10Umherirrender) [20:17:44] (03CR) 10Ejegg: [C:03+2] "Oh man, what a silly mistake. Thanks for the fix!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014616 (owner: 10Umherirrender) [20:19:42] (03PS4) 10Damilare Adedoyin: WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1014088 (https://phabricator.wikimedia.org/T349663) [20:19:51] (03Merged) 10jenkins-bot: Avoid undeclared $start in DonationProfiler::getStopwatch [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014616 (owner: 10Umherirrender) [20:20:08] (03CR) 10CI reject: [V:04-1] WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1014088 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [20:21:32] (03PS1) 10Damilare Adedoyin: WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [20:24:09] (03PS5) 10Damilare Adedoyin: WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1014088 (https://phabricator.wikimedia.org/T349663) [20:24:16] (03CR) 10CI reject: [V:04-1] WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [20:56:18] are the snooze fails ones that had been queued up forever that we just freed? [21:01:47] 06Fundraising-Backlog, 07Epic, 13Patch-For-Review: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9671505 (10Pcoombe) @Ejegg I've updated the Thank You page to cope with either wmf_ or utm_ prefixes (and convert to utm_ for the survey links until we... [21:04:29] (03CR) 10Ejegg: "OK fr-tech, this is ready for merge as Peter has upgraded the TY page Javascript." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) (owner: 10Ejegg) [22:13:10] fr-tech anyone want to give their opinion on these patches to log the client-side errors? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1015161 [22:13:49] Besides the not-required move to the namespace, does it seem like the extra API action was necessary? [22:14:20] Or should I just make the old action accept reports when no gateway is in session? [22:16:22] (03PS1) 10Ejegg: Convenience fn to get RecurUpgrade logger [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015403 [22:16:57] ok, that could be juggled to simplify the following patch [22:27:57] (03PS4) 10Ejegg: Extract base client-side error logging API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) [22:27:57] (03PS10) 10Ejegg: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 [22:27:57] (03PS2) 10Ejegg: Convenience fn to get RecurUpgrade logger [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015403 [22:27:57] (03PS3) 10Ejegg: Add new API action to log recurring upgrade errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015161 (https://phabricator.wikimedia.org/T360785) [22:27:58] (03PS1) 10Ejegg: WIP API to request new link from RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015406 [22:30:57] (03CR) 10CI reject: [V:04-1] WIP API to request new link from RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015406 (owner: 10Ejegg) [23:36:23] (03PS1) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1015429 [23:36:26] (03CR) 10Ejegg: [C:03+2] Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1015429 (owner: 10Ejegg) [23:45:09] (03Merged) 10jenkins-bot: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1015429 (owner: 10Ejegg) [23:56:40] !log payments-wiki upgraded from cca87e29 to 5e39bdc5 [23:56:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:57:26] !log donorwiki upgraded from c7f1325c to 5e39bdc5 [23:57:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:58:49] ok, looks like payments still works :) [23:58:59] woo