[00:08:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9671979 (10Cstone) okay debit recurring is not available in Brazil even though their documentation says o... [00:52:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9672020 (10Cstone) a:03Cstone [02:25:51] (03CR) 10Cstone: [C:03+2] Use wmf_ params for redirect to TY pages (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) (owner: 10Ejegg) [02:29:55] (03Merged) 10jenkins-bot: Use wmf_ params for redirect to TY pages (DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015351 (https://phabricator.wikimedia.org/T351325) (owner: 10Ejegg) [02:46:19] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014666 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:46:30] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014727 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:46:43] (03Abandoned) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1015168 (owner: 10Eileen) [02:49:29] (03PS3) 10Eileen: Test move preparation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011008 (https://phabricator.wikimedia.org/T357469) [03:08:42] (03CR) 10CI reject: [V:04-1] Test move preparation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011008 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:09:31] (03PS6) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [03:10:14] (03PS4) 10Eileen: Introduce RecurringModifyAmountQueueConsumer & also add RecurringModifyAmountMessage & use it for basic validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014669 (https://phabricator.wikimedia.org/T357469) [03:30:40] (03PS1) 10Eileen: Move WMFTransaction to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015442 (https://phabricator.wikimedia.org/T357469) [03:32:40] (03PS8) 10Eileen: Add a getter for PaymentInstrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012460 (https://phabricator.wikimedia.org/T357471) [03:32:40] (03PS5) 10Eileen: Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) [03:37:20] (03CR) 10Eileen: "Maybe we can make this change over the top of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1014669" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [03:44:48] (03PS2) 10Eileen: Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 [03:46:25] (03PS3) 10Eileen: Move some validation to the validate() function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014704 (https://phabricator.wikimedia.org/T357469) [03:49:33] (03CR) 10CI reject: [V:04-1] Move WMFTransaction to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015442 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:53:32] (03PS4) 10Eileen: Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) [03:53:33] (03PS3) 10Eileen: Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 [03:56:34] thanks for the CR cstone ! [03:57:28] (03PS2) 10Eileen: Move WMFTransaction to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015442 (https://phabricator.wikimedia.org/T357469) [03:58:10] (03PS5) 10Eileen: Introduce RecurringModifyAmountQueueConsumer & also add RecurringModifyAmountMessage & use it for basic validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014669 (https://phabricator.wikimedia.org/T357469) [03:59:44] looks like https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1014669 conflicts with some stuff Dami is working on - it's gonna be hard to work around with the big code move [04:01:18] (03PS6) 10Eileen: Introduce RecurringModifyAmountQueueConsumer & also add RecurringModifyAmountMessage & use it for basic validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014669 (https://phabricator.wikimedia.org/T357469) [04:01:18] (03PS7) 10Eileen: Rename get Amount functions to include usd [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014667 (https://phabricator.wikimedia.org/T357469) [04:01:18] (03PS4) 10Eileen: Move some validation to the validate() function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014704 (https://phabricator.wikimedia.org/T357469) [04:01:19] (03PS5) 10Eileen: Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) [04:01:20] (03PS4) 10Eileen: Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 [04:03:36] (03CR) 10CI reject: [V:04-1] Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 (owner: 10Eileen) [04:06:16] (03CR) 10CI reject: [V:04-1] Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:25:26] (03CR) 10CI reject: [V:04-1] Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:34:43] (03PS1) 10Eileen: Minor extration - getDonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015443 (https://phabricator.wikimedia.org/T357469) [04:53:29] (03Abandoned) 10Eileen: Test move preparation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1011008 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:02:46] (03PS6) 10Eileen: Consolidate amount handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014921 (https://phabricator.wikimedia.org/T357469) [05:02:46] (03PS5) 10Eileen: Use more get functions for amounts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1014705 [10:06:14] 06Fundraising-Backlog, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Priority Backlog 📥): 14Create composer-test-php70 docker image for fundraising tech's crm tests - 14https://phabricator.wikimedia.org/T230446#9672478 (10hashar) a:05hashar→03None [10:06:20] 06Fundraising-Backlog, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Priority Backlog 📥): 14Create composer-test-php70 docker image for fundraising tech's crm tests - 14https://phabricator.wikimedia.org/T230446#9672475 (10hashar) 05Stalled→03Resolved a:03hashar 14This is wha... [16:46:23] (03PS1) 10Ejegg: Add redirectUrl to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) [16:46:54] (03CR) 10CI reject: [V:04-1] Add redirectUrl to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [16:49:29] hmm, those redirect getters/setters could go in a trait [17:13:12] (03PS2) 10Ejegg: Use trait for redirect props/getters/setters [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015345 (https://phabricator.wikimedia.org/T317245) [17:13:12] (03PS2) 10Ejegg: Add redirectUrl to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) [17:13:12] (03PS1) 10Ejegg: Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) [17:13:46] (03CR) 10CI reject: [V:04-1] Add redirectUrl to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [17:13:47] (03CR) 10CI reject: [V:04-1] Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [17:16:42] (03PS3) 10Ejegg: Add redirect URL to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) [17:16:42] (03PS2) 10Ejegg: Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) [17:17:50] (03CR) 10Ejegg: [C:04-1] "Will update this using the redirect URL from the SmashPig layer after I2a5e98fe3328d25aebd7d063292b03e6e4888e1d merges" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [21:04:38] (03PS2) 10Umherirrender: Pass $knownData to AdyenCheckoutAdapter::getFieldsToRemove [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012443