[06:30:55] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1015745 (owner: 10L10n-bot) [11:36:44] (03PS1) 10Umherirrender: Replace isset() with null check in SpecialLandingCheck [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1015946 [14:20:08] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473 (10Jgreen) 03NEW [14:20:14] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676194 (10Jgreen) [14:29:32] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676208 (10Jgreen) [14:37:17] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676218 (10Jgreen) [14:42:28] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676240 (10Jgreen) [14:42:52] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676243 (10Jgreen) [14:45:16] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676251 (10Jgreen) [15:16:01] (03PS1) 10Ejegg: Map errors in PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015985 (https://phabricator.wikimedia.org/T317245) [15:16:40] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676295 (10Jgreen) [15:18:15] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676301 (10Jgreen) [15:27:19] (03PS9) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [15:29:22] (03CR) 10CI reject: [V:04-1] Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:31:38] (03PS10) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [15:33:22] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10MediaWiki-extensions-DonationInterface, and 2 others: Convert PayPal EC adapter to use SmashPig for API calls - https://phabricator.wikimedia.org/T336449#9676323 (10Ejegg) [16:09:43] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676422 (10Jgreen) [16:29:06] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T361473#9676551 (10Dwisehaupt) [16:40:30] (03CR) 10DannyS712: [C:03+2] Replace isset() with null check in SpecialLandingCheck [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1015946 (owner: 10Umherirrender) [17:17:17] fr-tech I've got some small SmashPig patches to review if anyone has a few minutes: https://gerrit.wikimedia.org/r/1015985 [17:33:53] ooh, couple tests failing with 'typed property must not be accessed before initialization' [17:34:09] I should update one of those smashpig patches then [17:40:57] (03Merged) 10jenkins-bot: Replace isset() with null check in SpecialLandingCheck [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1015946 (owner: 10Umherirrender) [17:41:13] (03PS3) 10Ejegg: Use trait for redirect props/getters/setters [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015345 (https://phabricator.wikimedia.org/T317245) [17:41:13] (03PS4) 10Ejegg: Add redirect URL to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) [17:41:13] (03PS3) 10Ejegg: Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) [17:41:14] (03PS2) 10Ejegg: Map errors in PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015985 (https://phabricator.wikimedia.org/T317245) [17:51:48] 06Fundraising-Backlog, 10Desktop Improvements (Vector 2022), 06Web-Team-Backlog: Plan for Donate Wiki and Thank You Wiki Rollback and Redesign - https://phabricator.wikimedia.org/T361500 (10KSarabia-WMF) 03NEW [17:53:51] 06Fundraising-Backlog, 10Desktop Improvements (Vector 2022), 06Web-Team-Backlog: Plan for Donate Wiki and Thank You Wiki Rollback and Redesign - https://phabricator.wikimedia.org/T361500#9677017 (10KSarabia-WMF) [17:57:02] (03PS4) 10Ejegg: Use trait for redirect props/getters/setters [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015345 (https://phabricator.wikimedia.org/T317245) [17:57:02] (03PS5) 10Ejegg: Add redirect URL to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) [17:57:02] (03PS4) 10Ejegg: Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) [17:57:03] (03PS3) 10Ejegg: Map errors in PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015985 (https://phabricator.wikimedia.org/T317245) [18:41:52] (03PS1) 10Cstone: WIP: Adding channel to endpoint for response testing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015998 [18:42:00] (03CR) 10CI reject: [V:04-1] WIP: Adding channel to endpoint for response testing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015998 (owner: 10Cstone) [18:47:16] (03PS2) 10Cstone: WIP: Adding channel to endpoint for response testing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015998 [18:59:54] (03CR) 10Cstone: [C:03+2] "looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015345 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:00:10] thanks cstone ! [19:00:31] (03Merged) 10jenkins-bot: Use trait for redirect props/getters/setters [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015345 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:10:58] (03PS11) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [19:13:49] (03PS6) 10Ejegg: WIP use SmashPig to get PayPal details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [19:15:17] (03PS7) 10Ejegg: Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [19:17:10] (03CR) 10CI reject: [V:04-1] Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [19:17:56] ok, that's just failing because of the unmerged SmashPig patch [19:19:16] (03CR) 10Cstone: [C:03+2] Add redirect URL to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:19:46] (03Merged) 10jenkins-bot: Add redirect URL to PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015544 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:19:48] (03CR) 10Cstone: [C:03+2] Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:19:57] (03CR) 10Cstone: [C:03+2] Map errors in PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015985 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:20:20] (03Merged) 10jenkins-bot: Set redirect URL for PayPal error 10486 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015545 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:20:25] woohoo, the soon-to-be-merged smashpig patch I mean! [19:20:31] (03Merged) 10jenkins-bot: Map errors in PayPal createSession response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1015985 (https://phabricator.wikimedia.org/T317245) (owner: 10Ejegg) [19:39:24] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert exchange rates module to an extension - https://phabricator.wikimedia.org/T270666#9677544 (10XenoRyet) [19:40:29] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-Adyen, 13Patch-For-Review: Epic: Remove old Adyen code - https://phabricator.wikimedia.org/T291448#9677545 (10AKanji-WMF) [19:47:29] 14Fundraising Sprint Uptown cURL, 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581#9677566 (10AKanji-WMF) [19:53:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Finish silverpop export setup during fundraising-tools build - https://phabricator.wikimedia.org/T360944#9677576 (10greg) p:05Triage→03Medium [19:54:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Fix reclone bug resulting in Docker bind-mount dir being deleted - https://phabricator.wikimedia.org/T360946#9677579 (10greg) p:05Triage→03Medium [19:54:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Received TY for recurring upgrade that did not occur? - https://phabricator.wikimedia.org/T361063#9677578 (10greg) p:05Triage→03High [19:55:04] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Split out consume-queues.sh scripts to stop failures locally - https://phabricator.wikimedia.org/T360943#9677582 (10greg) p:05Triage→03Medium [19:59:27] 06Fundraising-Analysis, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Gut-check new donor numbers - https://phabricator.wikimedia.org/T357348#9677601 (10AKanji-WMF) @JMando at our next analytics/FR-Tech call can we talk about how the Blackbaud data/reports will be applied to planning, and the impli... [20:02:50] 06Fundraising-Backlog: Matching gift company search changes required - https://phabricator.wikimedia.org/T357727#9677607 (10AKanji-WMF) @AKanji-WMF to request security review [20:24:44] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Upgrade centralnotice-staging to get off debian buster - https://phabricator.wikimedia.org/T360949#9677671 (10AKanji-WMF) @Dwisehaupt recommends shutting off the buster in favour of the bullseye [20:32:58] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Something is causing JPY Refunds that are separate line items in civi - https://phabricator.wikimedia.org/T360974#9677699 (10XenoRyet) [20:33:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Something is causing JPY Refunds that are separate line items in civi - https://phabricator.wikimedia.org/T360974#9677705 (10greg) p:05Triage→03Medium [20:54:50] 06Fundraising-Backlog, 10Desktop Improvements (Vector 2022), 06Web-Team-Backlog: Plan for Donate Wiki and Thank You Wiki Rollback and Redesign - https://phabricator.wikimedia.org/T361500#9677759 (10Jdlrobson) [21:33:00] ejegg|skoolrun: cstone I'm trying to figure out how much we can split out the recurring queue consumer. It feels like we should have a payment consumer and a manage subscription queue consumer but from what I can tell the problem is paypal (the problem is always paypal). The separation of concerns falls down when paypal sends a payment without first sending a sign up - but this also seems like maybe the thing that [21:33:05] doesn't happen anymore? [21:33:30] I guess I need to figure out which logs to trawl to try to get rid of the wmf_civicrm_get_legacy_paypal_subscription routine? [21:36:40] ah https://phabricator.wikimedia.org/T355448 [21:37:44] except - sorta [21:47:40] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448#9677863 (10Eileenmcnaughton) OK so this one is found recently... [22:13:41] eileen: i think the payment consumer would roll into donations queue consumer? [22:18:40] yeah, that's how i imagined it cstone [22:34:31] I'm going to bump up the SmashPig minor version to 0.8.10 [22:38:04] (03PS12) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [22:40:53] ok - I prob have some questions on that (e.g specific classes, code) but just with some people right now -but you are thinking that the payments part of the queue consumer would go into the donations queue rather than recurring queue? [22:42:06] that was the initial idea eileen just to try to have fewer deadlocks [22:42:32] but i see how it would leave some shared code [22:43:09] (03PS8) 10Ejegg: Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [22:43:19] hmm -shared code is ok in the right place.... [22:46:59] so if we have a paypal payment with no subscription it could throw it in a new queue - recurring-create which would maybe handle it & queue any payment portion? [22:47:33] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10MediaWiki-extensions-DonationInterface, and 2 others: Convert PayPal EC adapter to use SmashPig for API calls - https://phabricator.wikimedia.org/T336449#9677979 (10Ejegg) a:03Ejegg