[00:26:12] (03PS1) 10Eileen: Move first damaged test to Extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016466 (https://phabricator.wikimedia.org/T357469) [00:26:46] (03PS14) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [00:26:46] (03PS14) 10Ejegg: Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [00:26:46] (03PS5) 10Ejegg: WIP use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [00:28:58] (03CR) 10CI reject: [V:04-1] WIP use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [00:52:43] (03PS1) 10Eileen: Move another couple of tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016468 (https://phabricator.wikimedia.org/T357469) [01:17:20] (03PS1) 10Eileen: Move remaining Cancel tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016472 (https://phabricator.wikimedia.org/T357469) [01:22:52] (03PS6) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [01:24:43] (03CR) 10CI reject: [V:04-1] Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [01:28:28] (03PS7) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [01:39:48] (03PS1) 10Eileen: Move remaining Deadlock handling tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016473 (https://phabricator.wikimedia.org/T357469) [02:00:35] (03PS7) 10Ejegg: Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:01:27] (03CR) 10Ejegg: [C:03+2] "OK, I've gotten over my quibble about the sometimes-fibbing isPayment() :). Looks like a safe refactor, and moves more logic to the extens" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:02:12] (03CR) 10Eileen: "lol - it's not the final state - just a step on the journey" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:14:25] (03PS1) 10Ejegg: Always map errors in PayPal approvePayment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016476 [02:18:06] (03PS1) 10Eileen: Move last EOT message tests, remove some now-unused functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016477 (https://phabricator.wikimedia.org/T357469) [02:18:06] (03PS1) 10Eileen: Move IngenicoRecurringTest over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016478 (https://phabricator.wikimedia.org/T357469) [02:18:20] (03CR) 10CI reject: [V:04-1] Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:19:01] phew - down to the last 2 tests to move out of RecurringQueueTest [02:19:16] (03PS2) 10Eileen: Move IngenicoRecurringTest over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016478 (https://phabricator.wikimedia.org/T357469) [02:21:33] I think I might put the test for the monthly donate email into a separate class - as we could reasonably requeue that send to another wueue [02:22:24] ejegg: looks like validation failed on the rename to usd - perhaps you should merge the rename-again-to settlement before I fix it? [02:22:46] ie https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016419 [02:25:53] (03PS8) 10Eileen: Move validation of required fields, duplicates onto the message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) [02:34:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Something going on with Banner Status Codes in Brazil campaign? - https://phabricator.wikimedia.org/T360821#9682705 (10Cstone) @spatton what is the amount of 2.1s you do expect to see? [02:47:25] (03CR) 10Eileen: [C:03+2] "I'm gonna put the +2 back or we are gonna be in a loop here - the functions got slightly renamed after this was opened & are slated to be " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1012606 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [02:50:20] (03PS2) 10Eileen: Switch usd to Settled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016419 [02:59:11] (03PS3) 10Cstone: Minor extration - getDonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015443 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:59:30] eileen: is that one conflicting with your big chain ^ [02:59:44] cstone: yeah - I was just freaking out that it would! [02:59:52] should i stop that rebase [02:59:58] (03CR) 10Eileen: [C:04-1] Minor extration - getDonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015443 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:00:16] ok sorry! it worked for me this time though hah [03:00:39] lol [03:00:59] I just realised the whole chain is over https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016434/1 - but prob shouldn't be as the rest is all test only [03:01:23] ok ill ignore that one and look at the big chain? [03:01:57] That would be great - it starts at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016445/1 & if you ignore that one I should rebase out is only tests & chunks are smallish [03:02:31] idono that one you think you should rebase out might be fine to delete lemme test some weird things with it [03:03:04] oh ok - if you feel OK with it then yay - [03:04:49] as I get to the last ones I feel like I'm playing jenga & any moment it will all crash [03:05:17] thats old enough to be paypal only and if we can get an ec charge through without it it should be fine [03:05:45] cool - it looks like the very old idea was to us drupal hooks but I grepped & didn't find one [03:13:59] eileen: how hard would it be to rebase i forgot that this was more complicated to test im going to try for a bit though [03:14:18] cstone: not hard at all - it will just spam-a-lot [03:14:42] i thought wenjun and I had added example data somewhere but i cant find it [03:20:36] (03PS2) 10Eileen: Move some recur payment tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016445 (https://phabricator.wikimedia.org/T357469) [03:20:36] (03PS2) 10Eileen: Sync old RecurTest class with the new one a bit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016451 (https://phabricator.wikimedia.org/T357469) [03:20:36] (03PS3) 10Eileen: Further sync from old test class to new [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016455 (https://phabricator.wikimedia.org/T357469) [03:20:37] (03PS2) 10Eileen: Move 2 more tests over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016461 (https://phabricator.wikimedia.org/T357469) [03:20:38] (03PS2) 10Eileen: RecurTest - extract getDamagedRows() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016464 (https://phabricator.wikimedia.org/T357469) [03:20:39] (03PS2) 10Eileen: Move first damaged test to Extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016466 (https://phabricator.wikimedia.org/T357469) [03:20:42] (03PS2) 10Eileen: Move another couple of tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016468 (https://phabricator.wikimedia.org/T357469) [03:20:46] (03PS2) 10Eileen: Move remaining Cancel tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016472 (https://phabricator.wikimedia.org/T357469) [03:20:50] (03PS2) 10Eileen: Move remaining Deadlock handling tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016473 (https://phabricator.wikimedia.org/T357469) [03:20:54] (03PS2) 10Eileen: Move last EOT message tests, remove some now-unused functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016477 (https://phabricator.wikimedia.org/T357469) [03:20:56] ok - that is the rebase - now crossing everything it all passes [03:20:58] (03PS3) 10Eileen: Move IngenicoRecurringTest over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016478 (https://phabricator.wikimedia.org/T357469) [03:21:02] (03PS1) 10Eileen: Move second to last test out of class... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016481 (https://phabricator.wikimedia.org/T357469) [03:21:06] (03PS1) 10Eileen: Finish moving RecurQueue tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016482 (https://phabricator.wikimedia.org/T357469) [03:21:38] (03Abandoned) 10Eileen: Minor extration - getDonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015443 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:24:09] thanks eileen i did also dig up some test data i will save it in a good place this time [03:32:51] well for all that it's a lot of change in that chain it's not changing prod code [03:37:56] (03CR) 10Cstone: [C:03+2] "thanks for all the better names!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016445 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:48:58] cstone: they all passed!!! [03:49:05] woo!! [03:49:15] (03PS1) 10Eileen: Remove unused class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016484 (https://phabricator.wikimedia.org/T357469) [03:49:15] (03PS1) 10Eileen: Add deprecation note to function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016485 (https://phabricator.wikimedia.org/T357469) [03:51:54] (03CR) 10Cstone: [C:03+2] Sync old RecurTest class with the new one a bit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016451 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:56:26] (03CR) 10Cstone: [C:03+2] Further sync from old test class to new [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016455 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:00:56] (03Merged) 10jenkins-bot: Move some recur payment tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016445 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:07:40] eileen: did the extra last name sneak into the trait here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016461/2 [04:07:53] no i read it wrong [04:07:54] ignore [04:12:00] (03Merged) 10jenkins-bot: Sync old RecurTest class with the new one a bit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016451 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:12:31] (03CR) 10Cstone: [C:03+2] Move 2 more tests over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016461 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:15:43] (03Merged) 10jenkins-bot: Further sync from old test class to new [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016455 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:22:58] (03CR) 10Cstone: [C:03+2] RecurTest - extract getDamagedRows() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016464 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:31:09] (03Merged) 10jenkins-bot: Move 2 more tests over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016461 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:34:05] (03CR) 10Cstone: [C:03+2] Move first damaged test to Extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016466 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:42:19] (03CR) 10Cstone: [C:03+2] Move another couple of tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016468 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:42:31] (03Merged) 10jenkins-bot: RecurTest - extract getDamagedRows() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016464 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:51:10] (03CR) 10Cstone: [C:03+2] Move remaining Cancel tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016472 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:52:31] (03Merged) 10jenkins-bot: Move first damaged test to Extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016466 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:54:50] (03CR) 10Cstone: [C:03+2] Move remaining Deadlock handling tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016473 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:56:38] (03CR) 10Cstone: [C:03+2] Move last EOT message tests, remove some now-unused functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016477 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:59:54] (03CR) 10Cstone: [C:03+2] "if you run into more Ingenico specific tests we can just remove them" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016478 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:00:41] (03CR) 10Cstone: [C:03+2] Move second to last test out of class... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016481 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:01:42] (03Merged) 10jenkins-bot: Move another couple of tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016468 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:05:43] (03CR) 10Cstone: [C:03+2] "name fixing mvp! Also rip queue2civicrm/tests/phpunit/RecurringQueueTest.php" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016482 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:06:43] (03CR) 10Cstone: [C:03+2] Remove unused class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016484 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:07:09] (03CR) 10Cstone: [C:03+2] Add deprecation note to function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016485 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:09:42] (03Merged) 10jenkins-bot: Move remaining Cancel tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016472 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:14:13] (03Merged) 10jenkins-bot: Move remaining Deadlock handling tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016473 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:15:08] (03Merged) 10jenkins-bot: Move last EOT message tests, remove some now-unused functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016477 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:18:23] (03Merged) 10jenkins-bot: Move IngenicoRecurringTest over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016478 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:24:17] (03Merged) 10jenkins-bot: Move second to last test out of class... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016481 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:24:34] (03Merged) 10jenkins-bot: Finish moving RecurQueue tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016482 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:24:58] (03Merged) 10jenkins-bot: Remove unused class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016484 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:26:07] (03Merged) 10jenkins-bot: Add deprecation note to function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016485 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [08:57:05] 06Fundraising-Backlog, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680 (10Jdlrobson) 03NEW [10:16:57] 06Fundraising-Backlog, 10donate.wikimedia.org: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862#9683633 (10Pcoombe) @Ejegg @AKanji-WMF See discussion in Slack here https://wikimedia.slack.com/archives/C8W3HEHLG/p1711576458606369. It's probably worth at least thinking a... [10:24:37] 06Fundraising-Backlog, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9683647 (10Pcoombe) Is this the same as {T264375}? [12:12:48] (03PS1) 10Jdlrobson: Log central notice banner errors to their own channel [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) [12:13:31] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9684053 (10Jdlrobson) [12:13:49] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9684054 (10Jdlrobson) @pcoombe looks like a duplicate to me... [12:15:27] (03CR) 10CI reject: [V:04-1] Log central notice banner errors to their own channel [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) (owner: 10Jdlrobson) [12:44:22] (03PS8) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [12:53:56] anilk: this could be a fun one to work on soon, and maybe have a big lift on donations for campaigns where people have slow connections: https://phabricator.wikimedia.org/T257862#9683633 [13:06:37] (03PS1) 10Ejegg: Add getter for PayPal profileId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016787 (https://phabricator.wikimedia.org/T336449) [13:25:36] (03CR) 10Jforrester: [C:03+2] Migrate to IDatabase::newInsertQueryBuilder for upsert [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016353 (owner: 10Umherirrender) [13:36:56] 06Fundraising-Backlog, 10donate.wikimedia.org: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862#9684409 (10Ejegg) Thanks @Pcoombe . Creating a custom skin sounds fun, and the faster load times might give a nice boost for donations! [13:46:47] very cool ejegg thank you! [13:54:16] (03PS4) 10Damilare Adedoyin: WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [13:56:30] (03PS6) 10Damilare Adedoyin: WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1014088 (https://phabricator.wikimedia.org/T349663) [13:56:36] (03CR) 10CI reject: [V:04-1] WIP: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [14:24:31] (03CR) 10CI reject: [V:04-1] Migrate to IDatabase::newInsertQueryBuilder for upsert [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016353 (owner: 10Umherirrender) [14:27:48] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9684611 (10Pcoombe) Is it possible to log the banner name a... [15:03:09] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: 14Make Adyen IPN listener understand JSON messages - 14https://phabricator.wikimedia.org/T317833#9684759 (10Damilare) a:03Damilare [15:05:15] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-Adyen: Add ability to accept JSON notifications - https://phabricator.wikimedia.org/T289166#9684763 (10Damilare) a:03Damilare [15:53:01] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: 14Make Adyen IPN listener understand JSON messages - 14https://phabricator.wikimedia.org/T317833#9684968 (10Damilare) a:05Damilare→03None [17:04:29] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07JavaScript: 14Make it easier to identify client side errors from CentralNotice banners in logs - 14https://phabricator.wikimedia.org/T264375#9685341 (10Pcoombe) →14Duplicate dup:03T361680 [17:05:55] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9685343 (10Pcoombe) [17:13:19] (03PS1) 10Umherirrender: build: Swap phan-suppressions for backward-compatibility code [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016815 [18:22:45] (03PS15) 10Ejegg: Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [18:22:45] (03PS9) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [18:22:46] (03PS1) 10Ejegg: Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) [18:25:28] (03CR) 10CI reject: [V:04-1] Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:46:42] (03PS1) 10Ejegg: Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) [18:46:43] (03PS1) 10Ejegg: Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) [18:49:04] (03CR) 10CI reject: [V:04-1] Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:49:12] (03CR) 10CI reject: [V:04-1] Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:49:40] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1016832 [18:50:00] (03PS10) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [18:50:00] (03PS2) 10Ejegg: Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) [18:50:00] (03PS2) 10Ejegg: Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) [18:50:00] (03PS2) 10Ejegg: Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) [18:50:34] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1016832 (owner: 10Eileen) [18:51:31] !log config revision changed from 821f145b to 3ed18c47 [18:51:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:53:28] (03CR) 10CI reject: [V:04-1] Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:53:54] (03CR) 10CI reject: [V:04-1] Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:54:04] (03CR) 10CI reject: [V:04-1] Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [19:08:15] (03PS1) 10Ejegg: Add normalized errors to PayPal create profile [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016837 (https://phabricator.wikimedia.org/T336449) [19:21:57] (03PS1) 10Eileen: Move function in legacy code to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016838 (https://phabricator.wikimedia.org/T357469) [19:21:57] (03PS1) 10Eileen: Remove duplicate normalization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016839 (https://phabricator.wikimedia.org/T357469) [19:33:31] (03PS1) 10Eileen: Fold normalize call back into main caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016840 (https://phabricator.wikimedia.org/T357469) [19:33:31] (03PS1) 10Eileen: Move setting recurring = TRUE to the message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016841 (https://phabricator.wikimedia.org/T357469) [19:49:16] (03PS1) 10Jforrester: Banner: Drop references to old TranslateMetadata class to make phan happy [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016843 (https://phabricator.wikimedia.org/T353420) [19:53:35] (03CR) 10CI reject: [V:04-1] Move setting recurring = TRUE to the message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016841 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:20:44] (03CR) 10Jforrester: [C:03+2] "…" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016353 (owner: 10Umherirrender) [20:21:04] (03PS2) 10Jforrester: Migrate to IDatabase::newInsertQueryBuilder for upsert [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016353 (owner: 10Umherirrender) [20:25:56] (03Abandoned) 10Umherirrender: build: Swap phan-suppressions for backward-compatibility code [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016815 (owner: 10Umherirrender) [20:28:27] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Revisit deduper interface with a view to making it possible to do a search in search kit to dedupe - https://phabricator.wikimedia.org/T327728#9686029 (10greg) a:05Heatherjo550→03None [21:03:06] 06Fundraising-Backlog: Enable 90 day snooze: Comms Preferences Centre update - https://phabricator.wikimedia.org/T358878#9686138 (10AKanji-WMF) Noting we have copy now https://docs.google.com/document/d/1BNPWdQ12eA3Dymo7XcZeCc5Rz0RZwnwSHfA0LwU182g/edit#heading=h.8skob9yhpud9 - [21:04:11] (03PS1) 10Cstone: Remove Ingenico specific name and switch to adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016850 [21:05:15] (03PS2) 10Cstone: Remove Ingenico specific name and switch to adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016850 [21:07:35] (03PS3) 10Cstone: Remove Ingenico specific naming and switch to adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016850 [21:08:37] (03PS4) 10Cstone: Remove Ingenico specific naming and switch to adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016850 [21:16:33] (03CR) 10Eileen: [C:03+2] Remove Ingenico specific naming and switch to adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016850 (owner: 10Cstone) [21:35:39] (03Merged) 10jenkins-bot: Remove Ingenico specific naming and switch to adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016850 (owner: 10Cstone) [22:55:38] ejegg: I'm trying to figure out if this change is wrong or it's flushing out a way in which the test should be changed https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016841 [23:07:57] so cstone ejegg just picking up on whether we should create new users as I update these jobs - We could potentially create a user per queue-name - ie [23:07:57] queueName=opt-in [23:07:57] user=system-queue-opt-in [23:07:58] (assuming we can do hypens - might be underscores) [23:14:21] ok - it does accept System-RecurringModifyAmount [23:14:33] (that queue is camel ) [23:28:46] sorry - the queue is recurring-upgrade [23:33:32] (03PS1) 10Eileen: Migrate RecurringModifyAmount to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016863 (https://phabricator.wikimedia.org/T357470) [23:33:33] (03PS1) 10Eileen: Migrate Recurring to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016864 (https://phabricator.wikimedia.org/T357470) [23:33:35] (03PS1) 10Eileen: Migrate BannerHistory to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016865 (https://phabricator.wikimedia.org/T357470)