[00:00:43] (03PS1) 10Eileen: Migrate Unsubscribe to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016889 (https://phabricator.wikimedia.org/T357470) [00:00:45] (03PS1) 10Eileen: Migrate EmailPreferences to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016890 (https://phabricator.wikimedia.org/T357470) [00:00:46] (03PS1) 10Eileen: Migrate UpiDonations to use generic queue [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016891 (https://phabricator.wikimedia.org/T357470) [00:18:44] (03PS1) 10Eileen: Migrate Refund queue to use generic queue [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016893 (https://phabricator.wikimedia.org/T357470) [00:18:46] (03PS1) 10Eileen: Migrate ContributionTracking queue to use generic queue [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016894 (https://phabricator.wikimedia.org/T357470) [00:18:47] (03PS1) 10Eileen: Migrate Donation queue to use generic queue [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016895 (https://phabricator.wikimedia.org/T357470) [00:18:49] (03PS1) 10Eileen: Migrate PaymentsInit queue to use generic queue [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016896 (https://phabricator.wikimedia.org/T357470) [00:18:50] (03PS1) 10Eileen: Migrate Antifraud queue to use generic queue [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016897 (https://phabricator.wikimedia.org/T357470) [00:19:26] I did all ^^ as single line commits so we can merge in whatever order we do on prod [00:19:26] - each one permits some code to be removed as a follow up [00:37:42] (03PS2) 10Eileen: Move setting recurring = TRUE to the message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016841 (https://phabricator.wikimedia.org/T357469) [00:37:42] (03PS1) 10Eileen: Remove handling for 'custom' holding the contribution tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016900 (https://phabricator.wikimedia.org/T357469) [00:37:42] (03PS1) 10Eileen: Pass the message object deeper into the code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016901 (https://phabricator.wikimedia.org/T357469) [00:52:30] (03PS1) 10Eileen: Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) [00:58:22] (03CR) 10CI reject: [V:04-1] Move setting recurring = TRUE to the message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016841 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:02:17] (03CR) 10CI reject: [V:04-1] Pass the message object deeper into the code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016901 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:14:59] (03PS2) 10Eileen: Pass the message object deeper into the code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016901 (https://phabricator.wikimedia.org/T357469) [01:14:59] (03PS2) 10Eileen: Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) [01:16:00] (03CR) 10CI reject: [V:04-1] Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:18:42] 06Fundraising-Backlog: Adyen request for info / troubleshooting Maestro BIN - https://phabricator.wikimedia.org/T361610#9686715 (10Cstone) Here is the response with country=RO "merchantAccount" : "WikimediaDonations", "channel" : "iOS", "countryCode" : "RO" {"brands":["visa","mc","amex","cup","diners","discove... [01:25:40] (03PS2) 10Ejegg: Move function in legacy code to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016838 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:25:45] (03CR) 10Ejegg: [C:03+2] Move function in legacy code to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016838 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:29:44] (03PS2) 10Ejegg: Remove duplicate normalization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016839 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:29:49] (03CR) 10Ejegg: [C:03+2] Remove duplicate normalization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016839 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:30:36] (03PS1) 10Eileen: Fold createContact back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016904 (https://phabricator.wikimedia.org/T357469) [01:30:36] (03PS1) 10Eileen: Consolidate code to call WMFContact:save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016905 (https://phabricator.wikimedia.org/T357469) [01:33:16] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: 14Make Adyen IPN listener understand JSON messages - 14https://phabricator.wikimedia.org/T317833#9686720 (10Ejegg) 14I think it should accept them ever since this commit: https://phabricator.wikimedia.org/rWFSP3dee4c1549a8c4e6cfc760cb7a3f63d4ef1dad1a [01:40:39] ejegg: how do you feel about switching another job over onto the new queue - we get to rip out code :-) [01:43:15] (03PS2) 10Ejegg: Fold normalize call back into main caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016840 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:43:18] (03CR) 10Ejegg: [C:03+2] Fold normalize call back into main caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016840 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:44:45] (03PS2) 10Ejegg: Remove handling for 'custom' holding the contribution tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016900 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:44:48] (03CR) 10Ejegg: [C:03+2] Remove handling for 'custom' holding the contribution tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016900 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:44:57] (03Merged) 10jenkins-bot: Move function in legacy code to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016838 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:45:23] which one eileen ? [01:45:33] ah, the one you mentioned a few hours ago? [01:45:56] (03PS3) 10Eileen: Pass the message object deeper into the code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016901 (https://phabricator.wikimedia.org/T357469) [01:46:07] (03PS3) 10Eileen: Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) [01:46:17] (03PS2) 10Eileen: Fold createContact back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016904 (https://phabricator.wikimedia.org/T357469) [01:46:29] (03PS2) 10Eileen: Consolidate code to call WMFContact:save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016905 (https://phabricator.wikimedia.org/T357469) [01:47:07] ejegg: yeah so I figured out the commands & put them up as separate patches here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1016863 [01:47:42] - cos I figure then we can merge one of them + update process control + follow up with a code removal & it could be 'any one' as I think they will rebase out of the chain ok [01:48:29] on prod it would be slightly different but it took a bit of checking to get the queueConsumer / queueName combos [01:49:28] (03Merged) 10jenkins-bot: Remove duplicate normalization [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016839 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:50:12] (03CR) 10CI reject: [V:04-1] Consolidate code to call WMFContact:save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016905 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [01:54:29] well, I guess the recurring modify makes the most sense to switch over [01:54:37] let's make sure it can send mail! [01:54:53] (03CR) 10Ejegg: [C:03+2] Migrate RecurringModifyAmount to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016863 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [01:55:00] (03CR) 10Ejegg: [V:03+2 C:03+2] Migrate RecurringModifyAmount to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016863 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [02:00:30] ejegg: ok - if I push in the patch in process control now then? [02:01:10] (03Merged) 10jenkins-bot: Fold normalize call back into main caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016840 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:02:01] sure eileen [02:04:33] (03CR) 10Ejegg: [C:03+2] Pass the message object deeper into the code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016901 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:04:36] (03Merged) 10jenkins-bot: Remove handling for 'custom' holding the contribution tracking ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016900 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:05:48] ejegg: ok - I just pushed it up on frpm - [02:06:01] & ran the command ok on prod but there were no messages to check.... [02:06:15] ok, i'll queue up another 1 penny upgrade [02:06:16] one sec [02:06:46] want to run it again? [02:09:12] ejegg: shall we deploy the job first? Then we can test that it is working via process control rather than just on the command line [02:11:40] !log config revision changed from 3ed18c47 to abccfdc0 [02:11:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:14:40] ejegg: looks like the old job got to your test first - 5 mins ago the drush one ran & processed something. Then the new one ran & found nothing [02:14:59] oh right [02:15:52] k, just queued up another one [02:17:28] (03PS1) 10Eileen: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) [02:18:13] ejegg: it processed ok - did you get your email [02:21:03] hmm, still looking for it [02:21:07] did it go to spam? [02:21:22] i'm not seeing one from the earlier upgrade either [02:22:14] hmm so probably good that we accidentally tested both drush & the new thing [02:23:22] oops, was checking the wrong inbox - i see them both! [02:23:44] eileen: that seemed to work [02:23:59] so I guess we can remove the extra bit of code from the recurring queue consumer! [02:24:17] ejegg: your activity records look good too [02:25:35] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1016907 [02:25:51] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1016907 (owner: 10Eileen) [02:28:03] !log config revision changed from 3ed18c47 to abccfdc0 [02:28:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:28:55] ejegg: this removes that code - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016906 - do you feel up for moving another queue? [02:29:06] we get to rip out whole modules :-) [02:29:54] !log civicrm upgraded from a0fb57d3 to 8c7cc208 [02:29:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:36:17] (03CR) 10CI reject: [V:04-1] Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:37:54] oh shoot eileen the other usage of those txn_type='recurring_upgrade' messages is still alive [02:38:38] we need to stop sending them to the regular 'recurring' queue in check_recur_modification_and_queue before we delete that traffic controller [02:40:07] ejegg: the other usage is fundraise up? [02:42:17] (03PS1) 10Eileen: Use MessageObject for some checks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [02:42:51] yes eileen [02:44:15] (03PS2) 10Eileen: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) [02:44:15] (03PS1) 10Eileen: Fix modifyAmount tests to use new queuu directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016909 (https://phabricator.wikimedia.org/T357469) [02:44:37] ejegg: so the issue is the audit processor code needs to fire it into a different queue? [02:48:05] so I can see it putting messages into the queue but I can't see where it sets type to any of these 'recurring_upgrade', 'recurring_upgrade_decline', 'recurring_downgrade' [02:49:18] ah, it's not just int check_recur_modification_and_queue ? [02:49:37] shoot, I should really get to bed [02:49:40] (side thing - we should merge this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016419 may impact Dami's WIP patch) [02:53:29] (03PS3) 10Eileen: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) [02:53:29] (03PS1) 10Eileen: Fix modifyAmount tests to use new queuu directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016910 (https://phabricator.wikimedia.org/T357469) [02:53:31] (03PS1) 10Eileen: Push upgrades to the new queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016911 [02:53:50] ejegg: yeah - go to bed - it can wait [03:00:14] (03CR) 10CI reject: [V:04-1] Use MessageObject for some checks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:12:28] (03CR) 10CI reject: [V:04-1] Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [03:12:40] (03CR) 10CI reject: [V:04-1] Push upgrades to the new queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016911 (owner: 10Eileen) [04:18:11] (03PS2) 10Eileen: Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [04:22:12] (03PS2) 10Eileen: Push upgrades to the new queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016911 [04:22:12] (03PS4) 10Eileen: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) [04:36:59] (03CR) 10CI reject: [V:04-1] Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:41:08] (03CR) 10CI reject: [V:04-1] Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:45:53] (03CR) 10CI reject: [V:04-1] Push upgrades to the new queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016911 (owner: 10Eileen) [06:16:03] (03PS1) 10Eileen: Fix fundraise-up tests to use new queue directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016919 (https://phabricator.wikimedia.org/T357469) [06:18:57] (03PS5) 10Eileen: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) [06:19:13] (03Abandoned) 10Eileen: Push upgrades to the new queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016911 (owner: 10Eileen) [06:20:25] (03Abandoned) 10Eileen: Fix modifyAmount tests to use new queuu directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016909 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [06:35:21] (03CR) 10CI reject: [V:04-1] Fix fundraise-up tests to use new queue directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016919 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [06:37:39] (03CR) 10CI reject: [V:04-1] Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [07:11:22] (03PS1) 10Eileen: Start to move donationQueueTest to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016925 (https://phabricator.wikimedia.org/T357469) [07:12:49] (03PS2) 10Eileen: Start to move donationQueueTest to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016925 (https://phabricator.wikimedia.org/T357469) [07:17:49] (03PS2) 10Eileen: Fix fundraise-up tests to use new queue directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016919 (https://phabricator.wikimedia.org/T357469) [07:17:49] (03PS6) 10Eileen: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) [07:33:16] (03CR) 10CI reject: [V:04-1] Start to move donationQueueTest to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [07:57:41] (03PS3) 10Eileen: Start to move donationQueueTest to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016925 (https://phabricator.wikimedia.org/T357469) [08:12:25] 06Fundraising-Backlog, 10Desktop Improvements (Vector 2022), 10Web-Team-Backlog (FY2023-24 Q4 Sprint 2): Plan for Donate Wiki and Thank You Wiki Rollback and Redesign - https://phabricator.wikimedia.org/T361500#9687160 (10ovasileva) p:05Triage→03Medium [08:35:32] (03PS1) 10Eileen: Move 2 more tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017021 (https://phabricator.wikimedia.org/T357469) [08:48:53] (03PS1) 10Eileen: Move 2 more tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017022 (https://phabricator.wikimedia.org/T357469) [09:35:13] (03PS1) 10Eileen: Move another DonationQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017028 (https://phabricator.wikimedia.org/T357469) [10:03:52] (03PS1) 10Eileen: Move last DonationQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017033 (https://phabricator.wikimedia.org/T357469) [10:22:04] (03CR) 10CI reject: [V:04-1] Move last DonationQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017033 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [12:55:43] (03CR) 10Wangombe: [C:03+1] Banner: Drop references to old TranslateMetadata class to make phan happy [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016843 (https://phabricator.wikimedia.org/T353420) (owner: 10Jforrester) [14:41:31] 06Fundraising-Backlog: 14India recurring enablement - 14https://phabricator.wikimedia.org/T295798#9688707 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF 14I believe this is done [14:47:03] 06Fundraising-Backlog: 14Adyen request for info / troubleshooting Maestro BIN - 14https://phabricator.wikimedia.org/T361610#9688815 (10MBeat33) 05Open→03Resolved a:03MBeat33 14Thank you @Cstone  [15:39:04] hi fr-tech! If anyone has some spare brain cells while watching the meeting, I could use some review on these three tiny SmashPig patches [15:39:30] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1016837 and its two parents [15:39:43] ejegg: I'm reviewing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1004252 [15:39:55] or starting from the bottom, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1016476/1 and its two children [15:39:59] related? [15:40:02] oh awesome jgleeson [15:40:23] so those SmashPig patches are not needed for that first setup DI patch [15:40:33] but will be needed a couple patches down the DI chain [15:41:25] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016476 (owner: 10Ejegg) [15:41:30] :) [15:41:56] (03Merged) 10jenkins-bot: Always map errors in PayPal approvePayment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016476 (owner: 10Ejegg) [15:42:47] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016787 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:43:11] ejegg cool [15:43:25] (03Merged) 10jenkins-bot: Add getter for PayPal profileId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016787 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:51:01] oh hmm, maybe this was a rebase issue, but I think the DoExpressCheckoutPayment testresponse shouldn't be deleted in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1008584/15 [15:51:05] will rebase [15:52:27] (03PS15) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [15:52:41] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016837 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:53:27] (03Merged) 10jenkins-bot: Add normalized errors to PayPal create profile [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1016837 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:53:39] thanks jgleeson! now I can tag a new SmashPig version and add that dependency while I do this DI rebase [15:53:53] np! [15:57:19] oh phooey, i lost the overrideVarMap in my rebase [15:57:35] let me restore that [15:58:44] (03PS16) 10Ejegg: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) [16:02:06] (03PS16) 10Ejegg: Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) [16:02:06] (03PS11) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [16:02:06] (03PS3) 10Ejegg: Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) [16:02:06] (03PS3) 10Ejegg: Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) [16:02:07] (03PS3) 10Ejegg: Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) [16:04:47] (03CR) 10CI reject: [V:04-1] Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [16:04:48] (03CR) 10CI reject: [V:04-1] Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [16:05:01] (03CR) 10CI reject: [V:04-1] Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [16:05:35] ah dang [16:05:37] let's see [16:06:18] ooh, I hadn't be running that one locally [16:06:26] ok, shouldn't be too hard to fix I think [20:25:52] (03PS2) 10Eileen: Move last DonationQueueTest to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017033 (https://phabricator.wikimedia.org/T357469) [20:52:22] cstone: why do we track the directories for audit files in a variable ? Can't it just be calculated? [21:06:43] Probably because it's so old eileen ? We have had both dlocal and astropay going to astropay [21:07:20] I feel like the audit was built with grand intentions and we maybe never lived up to that in actual use [21:07:50] cstone: hmm - so could we get rid of the variable & just do like tempDir() + string? [21:08:36] or some other - I just had a go at moving the parent class from audit over & it's OK but not I have a variable_get in the new place -which is drupal speciic [21:09:10] I think the entire thing could be simplified but haven't thought yet about how to actually do it [21:09:39] (03PS1) 10Eileen: Move WMFAudit Base Test class to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017154 (https://phabricator.wikimedia.org/T357469) [21:10:31] actually I didn't move the variable_get - I just stared at it a bit :-) [21:14:23] do you want to jump into a call about it eileen ? now im thinking of how we can uncomplicate [21:14:25] so just looking & we have 2 types of directory [21:14:25] - working_log [21:14:25] - recon [21:14:25] So we could reduce down to just 2 settings to store those & calculate the rest based on those? [21:14:33] yeah - let's chat [21:15:00] standup link? [21:15:08] cstone: can we do in 45 mins tho - is that possible? [21:15:12] ok sure [21:15:16] cool [21:35:37] (03CR) 10Jgleeson: [C:03+2] "This is great! I really appreciate your approach of breaking apart the process request by request when refactoring to make it easier to re" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [21:41:21] (03Merged) 10jenkins-bot: Use SmashPig to make initial PayPal EC setup calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1004252 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [21:42:26] 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892 (10jgleeson) 03NEW [22:08:55] eileen: i can meet whenever is good for you [22:09:24] cool cstone will be just a few more minutes [22:09:30] ok no rush [22:17:13] cstone: ok am good now [22:17:40] I have 2 links so joined https://meet.google.com/ksg-mnkt-buh?authuser=0&hs=122&ijlm=1712269045339 [22:36:22] / directory_audit - /var/spool/audit [22:36:22] // directory_log /var/log [22:36:22] // directory_payments_log /srv/archive/frlog/logs [22:38:07] audit_directory [22:38:07] audit_directory_working [22:38:07] audit_director_payments [22:38:37] audit_directory_working_log [22:38:47] audit_director_payments_log [23:25:49] (03CR) 10Cstone: [C:03+2] Remove old hook call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016434 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:44:30] (03Merged) 10jenkins-bot: Remove old hook call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016434 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen)