[00:05:32] (03CR) 10Jdlrobson: Log central notice banner errors to their own channel (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) (owner: 10Jdlrobson) [00:06:26] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9691264 (10Jdlrobson) >>! In T361680#9684611, @Pcoombe wrot... [01:56:07] (03PS1) 10Eileen: Add Settings for WMF Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017175 (https://phabricator.wikimedia.org/T357469) [01:57:11] cstone: I just pushed up a patch to add the audit settings - I was thinking 'maybe I should migrate BrainTree first as it's pretty much inactive - but then I thought 'maybe we have no good way of testing Braintree'.... [02:16:49] hmm ok so locally there is a bit more difference in where the files point to [03:44:28] if you are still around eileen we should get some braintree activity as venmo is through there [03:44:59] (03PS1) 10Eileen: Set static in saner way in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017180 [03:44:59] (03PS1) 10Eileen: Move function called from only 1 place to that place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017181 (https://phabricator.wikimedia.org/T357469) [03:45:00] (03PS1) 10Eileen: Copy legacy function back to AuditProcessor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017182 (https://phabricator.wikimedia.org/T357469) [03:45:02] (03PS1) 10Eileen: Use Civi Setting for braintree (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 [03:45:23] oh right - so that make sense - I have just pushed up some changes I have locally - but still a failing braintree test [03:46:45] im heading back out though I can look at your earlier patches in the chain tomorrow [03:47:30] (03PS2) 10Eileen: Use Civi Setting for braintree (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 [03:47:56] cstone: yeah - I just got it working - it's a bit fugly - but *maybe* less so [04:07:32] (03CR) 10CI reject: [V:04-1] Use Civi Setting for braintree (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 (owner: 10Eileen) [04:10:33] (03PS3) 10Eileen: Use Civi Setting for braintree (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 [04:14:09] (03CR) 10Eileen: Use Civi Setting for braintree (only) (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 (owner: 10Eileen) [06:49:57] 06Fundraising-Backlog, 10donate.wikimedia.org: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862#9691680 (10Jdlrobson) I'm out next week but if no one gets round to looking at this next week I'd be happy to put up a proof of concept the week of 16th so we can run some... [10:08:55] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07affects-translatewiki.net, 07I18n, and 2 others: Remove " 06Fundraising-Backlog, 10donate.wikimedia.org: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862#9692575 (10Pcoombe) @Jdlrobson Feel free to work on a proof of concept, but I can't guarantee Online Fundraising will have time to work on implementing this in the near futu... [16:21:09] (03CR) 10Damilare Adedoyin: [C:03+1] "+1'ing because the test works locally and I saw the response object, but need confirmation on the dashboard as well." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 (owner: 10Jgleeson) [16:22:12] (03CR) 10Damilare Adedoyin: [C:03+2] Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 (owner: 10Jgleeson) [16:22:39] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 (owner: 10Jgleeson) [18:22:23] (03PS1) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [18:22:50] (03CR) 10CI reject: [V:04-1] Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [18:24:30] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-Adyen: Create ability to receive and process JSON authorisation notifications from Adyen - https://phabricator.wikimedia.org/T361963 (10Damilare) 03NEW [18:31:38] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10FR-Adyen: Write tests to ensure coverage on all message types in the Adyen SOAP to JSON transition. - https://phabricator.wikimedia.org/T361963#9693551 (10Damilare) [18:33:36] (03PS2) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [18:34:17] (03CR) 10CI reject: [V:04-1] Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [20:13:48] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Move DonationInterface messages used in banners to WikimediaMessages - https://phabricator.wikimedia.org/T231474#9693975 (10Jdforrester-WMF) [20:24:03] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Move DonationInterface messages used in banners to WikimediaMessages - https://phabricator.wikimedia.org/T231474#9693992 (10Jdforrester-WMF) The easiest thing to do would be to lift+shift all of them to WikimediaMessages and... [21:44:40] 06Fundraising-Backlog: Address too long causing failmail - https://phabricator.wikimedia.org/T361981 (10Cstone) 03NEW [21:53:42] (03CR) 10Cstone: [C:03+2] Start to move donationQueueTest to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:20:45] (03Merged) 10jenkins-bot: Start to move donationQueueTest to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016925 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:58:44] thanks cstone ! [22:59:10] ooh eileen i have a question [22:59:19] shoot [22:59:23] what do i need to do to get cv to work locally 🙃 [22:59:35] run it in the right directory I think [23:00:58] on prod wmf-cv handles that & here we handle in the script https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1016865 [23:02:34] LOL okay i guess i thought we would not be in the drupal directory [23:02:37] okay i got one of them running