[11:52:47] (03PS7) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1014088 (https://phabricator.wikimedia.org/T349663) [12:11:33] (03PS5) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [12:12:13] (03PS6) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [12:24:28] (03CR) 10CI reject: [V:04-1] Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [12:57:01] (03PS3) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [12:57:34] (03CR) 10CI reject: [V:04-1] Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [13:05:00] (03PS4) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [13:05:30] (03CR) 10CI reject: [V:04-1] Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [13:12:01] hmm looks like CI doesn't have SOAP enabled, making it difficult to run the new soap tests on CI. I'd skip those for now in order to make progress but I'd run them locally. [13:17:30] damilare: I thought I'd saw some `if(class_exists('SoapClient'))` hackery somewhere but I can't find it now [13:18:28] ahh yep that'd make a lot of sense for skipping the tests on CI [13:20:02] similar to what you described: PaymentProviders/Adyen/ExpatriatedMessages/AdyenMessage.php::L56 [13:25:11] (03PS5) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [13:36:54] looks like a lot of slow replicas in production [13:37:06] oh shoot, adding tests with SOAP? [13:37:38] yep, to ensure we aren't missing out anything in the new integration [13:37:56] ok, I guess that's good for completeness [13:38:00] though I' [13:38:11] d have been happy to just see tests on the new stuff! [13:38:13] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 10651 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:39:21] yh I'm writing the same tests on the new stuff. This just ensures there's an alignment [13:40:04] we'd take them out eventually with the legacy stuff [13:40:50] thanks! [13:42:14] (03PS3) 10Ejegg: Pass $knownData to AdyenCheckoutAdapter::getFieldsToRemove [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012443 (owner: 10Umherirrender) [13:42:18] (03CR) 10Ejegg: [C:03+2] Pass $knownData to AdyenCheckoutAdapter::getFieldsToRemove [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012443 (owner: 10Umherirrender) [13:43:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2104 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:44:17] (03CR) 10Jgleeson: [C:03+2] "This works great. Thanks. I considered asking for the test responses to be dropped in text files, but the visual load isn't too bad. I jus" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [13:44:44] (03Merged) 10jenkins-bot: Pass $knownData to AdyenCheckoutAdapter::getFieldsToRemove [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1012443 (owner: 10Umherirrender) [13:46:10] thanks jgleeson ! [13:46:15] np! [13:46:33] (03Merged) 10jenkins-bot: Use SmashPig to get PayPal donor details [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1008584 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [13:46:39] I'm just starting to fix that test failure two more patches along. Hopefully will have that one passing by the time you get to it [13:47:53] sounds good, thanks.I'm popping out now to pick up the kids so I'll continue when I get back in about 30 mins. [13:48:13] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 4564777 Threads: 4 Questions: 155062288 Slow queries: 2167 Opens: 4134 Open tables: 1149 Queries per second avg: 33.969 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:56:38] (03PS12) 10Ejegg: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) [13:56:38] (03PS4) 10Ejegg: Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) [13:56:38] (03PS4) 10Ejegg: Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) [13:56:39] (03PS4) 10Ejegg: Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) [13:59:18] (03CR) 10CI reject: [V:04-1] Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [13:59:19] (03CR) 10CI reject: [V:04-1] Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [13:59:26] hmm [13:59:58] oh just lint [14:01:37] (03PS5) 10Ejegg: Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) [14:18:44] (03PS5) 10Ejegg: Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) [14:25:22] ooh, jenkins 404 page now has creepy devil mask butler: https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_39-php74-docker/1705/console [14:34:20] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 07recurring upgrade: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087 (10Ejegg) 03NEW [14:41:03] that is creepy [14:41:44] so is 504 Gateway Time-out from dlocal [14:51:25] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops, 06SRE: Manage frack switches with Netbox - https://phabricator.wikimedia.org/T268802#9697900 (10joanna_borun) p:05Medium→03Low [15:00:07] (03CR) 10Jgleeson: [C:03+2] "Works great! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:02:14] (03Merged) 10jenkins-bot: Use SmashPig for PayPal approvePayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016388 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [17:11:16] (03PS1) 10Ejegg: Set drupal homepage to /civicrm [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1017912 [17:28:49] (03PS6) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [18:14:39] (03PS1) 10Ejegg: WIP: Allow manually creating Recur Upgrade Decline activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017917 (https://phabricator.wikimedia.org/T362087) [18:20:58] eclipse has started here... [18:42:34] (03PS2) 10Ejegg: Allow manually creating Recur Upgrade Decline activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017917 (https://phabricator.wikimedia.org/T362087) [18:46:30] (03CR) 10Jgleeson: [C:04-1] "The code looks okay here, but I'm getting errors when setting up a recurring donation using it. I keep getting:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:47:38] hmm why cant I delete damaged messages [18:47:43] (03CR) 10Jgleeson: [C:04-1] "I have smash-pig 0.8.10.1 installed https://github.com/wikimedia/wikimedia-fundraising-SmashPig/releases/tag/v0.8.10.1" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [18:49:12] (03PS1) 10Umherirrender: adyen: Fix call to PaymentError::getDebugMessage [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1017919 [18:58:04] 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892#9698780 (10jgleeson) [19:00:21] 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892#9698781 (10jgleeson) The dLocal sandbox is using IP allowlist access. I think we need to get the Gr4vy platform IP. I tried adding the dLocal connection today, but Gr4vy is requesting a "Merchant name" as part of t... [19:00:29] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892#9698782 (10jgleeson) [19:01:12] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892#9698787 (10jgleeson) a:03jgleeson [19:01:18] 14Fundraising Sprint Uptown cURL, 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581#9698784 (10jgleeson) a:05j... [19:21:04] (03CR) 10Eileen: [C:03+2] Allow manually creating Recur Upgrade Decline activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017917 (https://phabricator.wikimedia.org/T362087) (owner: 10Ejegg) [19:29:59] (03CR) 10Eileen: "There are some changes to the other functions to make them simpler that can be leveraged here - not https://gerrit.wikimedia.org/r/c/wikim" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [19:30:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: 14Received TY for recurring upgrade that did not occur? - 14https://phabricator.wikimedia.org/T361063#9698836 (10XenoRyet) 05Open→03Resolved [19:30:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: 14ACH recurring link not working - 14https://phabricator.wikimedia.org/T360123#9698838 (10XenoRyet) 05Open→03Resolved [19:30:26] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 13Patch-For-Review: 14Recurring charge job: what happens to a donation that gets skipped by the 2 within 23 days rule ... - https://phabricator.wikimedia.org/T357350#9698834 [19:31:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: 14Civi Snooze feature stopped working! - 14https://phabricator.wikimedia.org/T358259#9698840 (10XenoRyet) 05Open→03Resolved [19:32:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: 14Split out consume-queues.sh scripts to stop failures locally - 14https://phabricator.wikimedia.org/T360943#9698842 (10XenoRyet) 05Open→03Resolved [19:33:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: 14Fix reclone bug resulting in Docker bind-mount dir being deleted - 14https://phabricator.wikimedia.org/T360946#9698844 (10XenoRyet) 05Open→03Resolved [19:41:57] (03CR) 10Eileen: Fundraiseup audit import for recur plan change (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [19:43:12] (03Merged) 10jenkins-bot: Allow manually creating Recur Upgrade Decline activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017917 (https://phabricator.wikimedia.org/T362087) (owner: 10Ejegg) [19:43:40] thanks for the CR eileen [19:58:31] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9698917 (10Ejegg) [20:23:52] fr-tech if anyone has a minute to check this small fun-dev patch that's blocking a chain from merging that'd would be awesome https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1009751/5 [20:25:01] the update just copies the silverpop export default config.yaml to the project root after setting everything up to remove that last manual step [20:25:49] (03PS7) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [20:27:48] catch you all tomorrow o/ [20:31:28] ejegg|brb: are you up for switching over some more queues to use cv & ripping out the drush code? [20:31:51] eileen: do you want to meet sometime to look at my chaos audit thoughts [20:32:35] (03CR) 10Cstone: [V:03+2 C:03+2] Add setup of silverpop_export.yaml config during --tools build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009751 (https://phabricator.wikimedia.org/T360944) (owner: 10Jgleeson) [20:32:36] (03PS6) 10Ejegg: Add setup of silverpop_export.yaml config during --tools build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009751 (https://phabricator.wikimedia.org/T360944) (owner: 10Jgleeson) [20:32:39] (03CR) 10Ejegg: [V:03+2] Add setup of silverpop_export.yaml config during --tools build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009751 (https://phabricator.wikimedia.org/T360944) (owner: 10Jgleeson) [20:32:47] LOL ejegg who won [20:32:54] ohh hah [20:33:10] haha same timestamp [20:33:13] looks like i rebased right after you C+2ed [20:35:11] sure eileen, did dami's change to not send upgrade / downgrade to the regular recurring queue for frup get merged? [20:46:53] thanks for the smoke test jgleeson|away - i swear i thought i had that working, but it's giving me the same error here today! [21:16:15] ejegg|skoolrun: I think that was the change for that -https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016919 [21:17:56] cstone: sure we could catch up now if you want [21:20:56] sure eileen [21:22:39] back in end of sprint? [21:28:46] (03CR) 10Cstone: [C:03+2] Migrate EmailPreferences to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016890 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [21:33:20] (03PS2) 10Eileen: Migrate EmailPreferences to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016890 (https://phabricator.wikimedia.org/T357470) [21:33:28] (03CR) 10Eileen: [V:03+2] Migrate EmailPreferences to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016890 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [21:38:28] !log config revision changed from b08eb273 to fff12a6a [21:38:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:42:02] (03PS1) 10Eileen: Remove preferencesQueue.consume action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017940 [21:42:14] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1017940 [21:42:43] (03CR) 10Cstone: [C:03+2] "farewell" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017940 (owner: 10Eileen) [21:46:50] (03CR) 10Cstone: [V:03+2 C:03+2] Migrate BannerHistory to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016865 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [21:52:52] (03PS1) 10Eileen: Remove Banner History drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017941 [21:54:14] (03PS2) 10Eileen: Remove Banner History drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017941 [21:54:39] (03CR) 10Cstone: [C:03+2] Remove Banner History drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017941 (owner: 10Eileen) [21:55:13] !log config revision changed from fff12a6a to 3c1a0267 [21:55:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:55:38] (03PS2) 10Eileen: Migrate BannerHistory to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016865 (https://phabricator.wikimedia.org/T357470) [21:55:42] (03CR) 10Eileen: [V:03+2] Migrate BannerHistory to use cv [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1016865 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen) [21:58:10] we just switched email preferences & banner history to wmf-cv [22:04:51] (03Merged) 10jenkins-bot: Remove preferencesQueue.consume action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017940 (owner: 10Eileen) [22:09:27] (03PS1) 10Eileen: fold it back in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017943 [22:10:37] (03PS2) 10Eileen: fold it back in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017943 [22:16:01] (03PS3) 10Ejegg: Fix fundraise-up tests to use new queue directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016919 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:16:09] (03CR) 10Ejegg: [C:03+2] Fix fundraise-up tests to use new queue directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016919 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:19:09] (03Merged) 10jenkins-bot: Remove Banner History drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017941 (owner: 10Eileen) [22:19:50] (03PS1) 10Eileen: Wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017944 [22:26:34] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017175 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:31:00] ejegg: what's the verdict on this one - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016419/2/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/WMFQueueMessage/DonationMessage.php [22:35:22] (03Merged) 10jenkins-bot: Fix fundraise-up tests to use new queue directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016919 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:42:39] oh yeah, let's get that rename merged. Thanks! [22:43:01] (03PS3) 10Ejegg: Switch usd to Settled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016419 (owner: 10Eileen) [22:43:08] (03CR) 10Ejegg: [C:03+2] Switch usd to Settled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016419 (owner: 10Eileen) [23:07:00] (03Merged) 10jenkins-bot: Switch usd to Settled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016419 (owner: 10Eileen)