[02:24:52] omg found the comment that describes what I always thought the audit was doing hah [02:25:48] (03CR) 10Cstone: [C:03+2] "$confusing_thing makes an appearance" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017154 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:29:25] (03CR) 10Cstone: Add Settings for WMF Audit (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017175 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:44:17] (03Merged) 10jenkins-bot: Move WMFAudit Base Test class to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017154 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [02:59:16] (03CR) 10Abijeet Patro: [C:03+1] Banner: Drop references to old TranslateMetadata class to make phan happy [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016843 (https://phabricator.wikimedia.org/T353420) (owner: 10Jforrester) [04:59:02] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:05:38] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1017963 [12:22:32] thanks for the review cstone ejegg|afk damilare ! [12:23:09] (03PS7) 10Jgleeson: Change how we reclone projects to fix bind mount bug. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009777 (https://phabricator.wikimedia.org/T360946) [12:23:16] (03PS4) 10Jgleeson: Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 [12:23:28] (03CR) 10Jgleeson: [V:03+2] Change how we reclone projects to fix bind mount bug. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1009777 (https://phabricator.wikimedia.org/T360946) (owner: 10Jgleeson) [12:23:35] (03CR) 10Jgleeson: [V:03+2] Add gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1015067 (owner: 10Jgleeson) [12:39:31] np [13:38:12] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12192 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:43:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 10745 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:48:13] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 8785 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:53:13] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4967 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:58:13] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 4651777 Threads: 4 Questions: 161938681 Slow queries: 2208 Opens: 4151 Open tables: 1149 Queries per second avg: 34.812 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:54:50] (03PS8) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [14:57:32] ok so that's all the tests written to ensure Adyen JSON is consistent with SOAP [15:14:50] (03PS2) 10Ejegg: Fix modifyAmount tests to use new queuu directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016910 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:14:51] 06Fundraising-Backlog: Matching gift company search changes required - https://phabricator.wikimedia.org/T357727#9701430 (10AKanji-WMF) When asked about security review, Evelyn didn't think it was required "The donor is searching through a widget for companies that participate in matching. There is no access to... [15:14:54] (03CR) 10Ejegg: [C:03+2] Fix modifyAmount tests to use new queuu directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016910 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:30:09] (03PS7) 10Ejegg: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:30:24] (03CR) 10Ejegg: [C:03+2] Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:35:32] (03Merged) 10jenkins-bot: Fix modifyAmount tests to use new queuu directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016910 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:40:33] Is anyone able to see the UI to delete a damaged message ? [15:41:16] (03CR) 10Ejegg: "Aha, the error happens at this call with or without this patch (and the recurring profile creation call sends the same parameters either w" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:41:33] looking cstone [15:41:49] It's just a header when I look at it [15:42:25] oh yeah, all I sees is Resend on the overlay that pops up [15:42:43] Ok thanks for confirming [15:42:55] in the list view I can select one and choose 'Delete Damaged' from the action menu [15:44:24] (03CR) 10Jgleeson: [C:04-1] "ah maybe we missed it on the Smashpig patches" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [15:44:55] 06Fundraising-Backlog: Matching gift company search changes required - https://phabricator.wikimedia.org/T357727#9701655 (10Pcoombe) Yes, the code in the task description involves embedding external javascript [15:54:19] (03Merged) 10jenkins-bot: Remove traffic controller from RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016906 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [15:54:55] ok, yeah, there are some different fields in the new recurring setup call [16:22:56] (03PS1) 10Ejegg: PayPal: any truthy value for 'recurring' counts as true [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1018314 [16:23:09] jgleeson: it was just an extra-strict check in the SmashPig layer ^^^ [16:25:16] that will align things with how the Adyen SmashPig Api class interprets the 'recurring' parameter [16:37:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig: Standardize message and time limit options for all scripts - https://phabricator.wikimedia.org/T357001#9701837 (10Cstone) this is also in progress in the work eileen is doing to move things onto cv htt... [16:39:30] nice! gonna grab dinner and will test when I get back. thanks! [17:30:23] (03CR) 10Ejegg: [C:03+1] "Wow, this is an impressive amount of coverage! Could merge right now, or after one tiny cleanup." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [17:32:07] (03CR) 10Ejegg: [C:03+2] adyen: Fix call to PaymentError::getDebugMessage [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1017919 (owner: 10Umherirrender) [17:33:42] (03CR) 10Ejegg: "The setup call needs this fix: I092d02b5831d8e5ddd537c5b9847c146b1eb6501 to make this profile creation call work." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) (owner: 10Ejegg) [17:34:23] (03Merged) 10jenkins-bot: adyen: Fix call to PaymentError::getDebugMessage [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1017919 (owner: 10Umherirrender) [17:34:57] oh, I need to restore the fraud filter calls in that paypal refactor! [17:35:16] Had forgotten about it since it's buried in do_transaction_internal in the old code [18:30:08] (03PS5) 10Ejegg: Use SmashPig to create recurring profile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016828 (https://phabricator.wikimedia.org/T336449) [18:30:08] (03PS6) 10Ejegg: Delete PayPal refund & cancel scripts and API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016830 (https://phabricator.wikimedia.org/T336449) [18:30:08] (03PS6) 10Ejegg: Delete a lot of now-unused PayPal adapter stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1016831 (https://phabricator.wikimedia.org/T336449) [18:30:08] (03PS1) 10Ejegg: Restore onGatewayReady checks for PayPal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018326 [18:41:33] (03PS1) 10Ejegg: Restore pre-capture fraud check for PayPal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018328 [18:50:17] (03PS1) 10Cstone: Move logic from function only audit uses back into audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018329 (https://phabricator.wikimedia.org/T270675) [18:53:32] (03CR) 10Ejegg: "Want to delete it from wmf_civicrm.module here?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018329 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [18:54:22] hah i was following eileens example ejegg but that makes sense [18:55:12] (03PS2) 10Cstone: Move logic from function only audit uses back into audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018329 (https://phabricator.wikimedia.org/T270675) [18:55:28] oh, did she do the deletions in follow-on patches? [18:55:41] huh, I like the cleanup in the same patch better, so we don't forget [18:55:43] oh no she had done it haha [18:56:00] just was wrapping my head around it it makes a lot of sense to delete in the same [18:56:44] (03CR) 10Ejegg: [C:03+2] Move logic from function only audit uses back into audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018329 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [18:56:55] moving away from the get contributions was the next step [18:57:01] woo ejegg [19:08:58] (03PS9) 10Damilare Adedoyin: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) [19:12:49] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1017963 (owner: 10Eileen) [19:12:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: 14Finish silverpop export setup during fundraising-tools build - 14https://phabricator.wikimedia.org/T360944#9702124 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [19:13:21] 06Fundraising-Backlog: Matching gift company search changes required - https://phabricator.wikimedia.org/T357727#9702127 (10AKanji-WMF) @AKanji-WMF to follow up - will require a review (CSP change) [19:13:35] cstone: I'm gonna push out https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1017963 - which has that hook change in it [19:14:09] thanks eileen I'll keep an eye on logs [19:14:16] also - nice to see patches above deleting code :-) [19:14:52] it was your example patch in the first place! [19:14:58] :-) [19:20:00] (03Merged) 10jenkins-bot: Move logic from function only audit uses back into audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018329 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [19:20:03] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1017963 (owner: 10Eileen) [19:31:26] 06Fundraising-Backlog: India Recurring - Add retry and cancellation flow for failed recurrings - https://phabricator.wikimedia.org/T362191 (10Cstone) 03NEW [19:32:49] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448#9702220 (10AKanji-WMF) Team resolved to do another quick chec... [19:37:14] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog: 14Migrate Ingenico API URLs to new Worldline addresses - 14https://phabricator.wikimedia.org/T352197#9702231 (10AKanji-WMF) 05Open→03Declined 14Declining as we've removed Ingenico [19:38:34] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501#9702244 (10AKanji-WMF) [19:41:44] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog: Investigation: Migrating historical SurveyMonkey data - https://phabricator.wikimedia.org/T337880#9702261 (10AKanji-WMF) Awaiting Google Drive implementation - would support requirements listed above. [19:44:23] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, and 2 others: 14Move all our queue consumers into the extension space - 14https://phabricator.wikimedia.org/T357469#9702280 (10AKanji-W... [19:45:35] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, and 2 others: 14Move all our queue consumers into the extension space - 14https://phabricator.wikimedia.org/T357469#9702278 (10AKanji-W... [19:48:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig: Standardize message and time limit options for all scripts - https://phabricator.wikimedia.org/T357001#9702301 (10Cstone) civi parts are handled in {T357470} [20:00:38] 06Fundraising-Backlog: Save phonetic names into civi fields - https://phabricator.wikimedia.org/T362195 (10Cstone) 03NEW [20:00:53] 06Fundraising-Backlog: Save phonetic names into civi fields - https://phabricator.wikimedia.org/T362195#9702327 (10Cstone) [20:01:04] (03PS1) 10Umherirrender: adyen: Declare logger class property in AdyenSubmitPaymentApi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018337 [20:02:23] !log config revision changed from abccfdc0 to 3c1a0267 [20:02:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:03:08] 06Fundraising-Backlog: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196 (10Cstone) 03NEW [20:03:28] 06Fundraising-Backlog: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196#9702346 (10Cstone) [20:07:50] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the CR and for spotting that mistake, I've made the recommended change." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [20:08:35] 06Fundraising-Backlog: 2024 Sprint E - Priorities - https://phabricator.wikimedia.org/T359434#9702355 (10AKanji-WMF) [20:08:37] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181#9702357 (10AKanji-WMF) [20:08:39] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker log issues - https://phabricator.wikimedia.org/T355736#9702356 (10AKanji-WMF) [20:09:47] 03Fundraising Sprint: G thang , 06Fundraising-Backlog: Save phonetic names into civi fields - https://phabricator.wikimedia.org/T362195#9702359 (10AKanji-WMF) [20:09:47] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10FR-Adyen, 13Patch-For-Review: Write tests to ensure coverage on all message types in the Adyen SOAP to JSON transition. - https://phabricator.wikimedia.org/T361963#9702361 (10AKanji-WMF) [20:09:48] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9702363 (10AKanji-WMF) [20:09:49] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9702360 (10AKanji-WMF) [20:09:54] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 13Patch-For-Review: Turn on post MC for rtbt and ACH? - https://phabricator.wikimedia.org/T359877#9702362 (10AKanji-WMF) [20:09:56] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9702365 (10AKanji-WMF) [20:09:57] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate rest of normalize into WMFMessage class - https://phabricator.wikimedia.org/T357471#9702364 (10AKanji-WMF) [20:09:59] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9702366 (10AKanji-WMF) [20:10:02] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Add/ fix page to support 1-click-ubsubscribe - https://phabricator.wikimedia.org/T354587#9702367 (10AKanji-WMF) [20:10:07] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 13Patch-For-Review: Update contact on CiviCRM when FRUP donor updates their email through donor portal - https://phabricator.wikimedia.org/T349663#9702368 (10AKanji-WMF) [20:10:11] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert exchange rates module to an extension - https://phabricator.wikimedia.org/T270666#9702372 (10AKanji-WMF) [20:10:17] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10MediaWiki-extensions-DonationInterface, and 3 others: Convert PayPal EC adapter to use SmashPig for API calls - https://phabricator.wikimedia.org/T336449#9702369 (10AKanji-WMF) [20:10:21] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 13Patch-For-Review: SEPA direct debit as mainstream payment method in EU campaigns - https://phabricator.wikimedia.org/T324520#9702370 (10AKanji-WMF) [20:10:25] 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10FR-Adyen, 13Patch-For-Review: Epic: Remove old Adyen code - https://phabricator.wikimedia.org/T291448#9702371 (10AKanji-WMF) [20:10:31] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10FR-Email, and 3 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#9702373 (10AKanji-WMF) [20:14:22] 03Fundraising Sprint: G thang , 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892#9702375 (10AKanji-WMF) [20:14:51] 06Fundraising-Backlog: 142024 Sprint E - Priorities - 14https://phabricator.wikimedia.org/T359434#9702376 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [20:25:33] (03CR) 10Ejegg: [C:03+2] Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pa [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [20:26:10] (03Merged) 10jenkins-bot: Add tests for JSON and Soap Authorisation messages. Modified the AdyenRestListener class similar to the soap listener to get the tests to pass. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1017340 (https://phabricator.wikimedia.org/T289166) (owner: 10Damilare Adedoyin) [20:52:48] fr-tech does anyone have a minute to check this tiny SmashPig patch to help make PayPal recurring work after the refactor? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1018314 [20:53:14] it'll be consistent with how adyen smashpig layer interprets 'recurring' [20:53:24] gotta go pick up my kid, back in a bit! [21:21:57] looking now ejegg|skoolrun [21:22:19] sorry got sidetracked. lots of UEFA Champions League action tonight [21:30:58] we deployed the patch to stop putting fundraise up recurring modify in the recurring queue - what delay do we need before deploying the patch that handles fundraise up recurring modify in the recur queue? [21:36:09] eileen: just 10 min should be enough [21:36:19] cool - it's had that [21:37:48] actually it hadn't - I misblasted [21:37:57] lol [21:38:02] !log civicrm upgraded from 8c7cc208 to b05fd08f [21:38:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:39:35] ejegg: I've +2ed the smashpig patch and the DI patch it fixes. Not sure what happened to our annoucer [21:39:43] oh thanks! [21:40:04] I'll tag another release and update the composer.json requirement [21:40:25] huh, yeah, not kicked out of the channel, just silent [21:43:22] wikibugs what is wrong? [21:44:13] eileen: i left a comment on that next audit movever patch just need to add to the directory name [21:46:06] ok those deletion patches look good too [21:46:42] I'd like to smoke test the fraud check ones so I'll do that in the morn unless other folks get to 'em first [21:46:50] catch you all tomorrow [21:47:28] cstone: I can't find the comment? which patch [21:47:51] found it [21:48:13] cstone: I actually made that same change a few patches up as I worked through it [21:48:45] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1017183/4/drupal/sites/default/civicrm/extensions/wmf-civicrm/settings/audit.setting.php [21:49:55] ooho hah okay [21:49:59] that works [21:50:04] sorry i didnt see that! [22:03:33] !log civicrm upgraded from b05fd08f to a382a7b0 [22:03:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:11:45] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9702562 (10Ejegg) @AMJoh... [22:24:59] !log config revision changed from 3c1a0267 to 4638a4d2 [22:25:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:25:44] ejegg: when I deployed I think there might have been patches of yours that had an upgrade - I didn't run it - need to recheck [22:42:54] !log config revision changed from 075ddd44 to cea14e30 [22:42:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:48:13] !log config revision changed from cea14e30 to df416a50 [22:48:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:51:52] !log config revision changed from df416a50 to 8fb02f33 [22:51:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:57:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Add a time limit to contribution tracking queue consume - https://phabricator.wikimedia.org/T329600#9702654 (10Eileenmcnaughton) @Ejegg you dropped out before we discussed but status quo now is we have set to a 11 minute time out cos we thought we would s... [22:58:26] !log config revision changed from 8fb02f33 to 064d18b0 [22:58:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:08:25] !log config revision changed from 064d18b0 to 7908b55e [23:08:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:17:25] !log config revision changed from 7908b55e to 974afe9c [23:17:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:21:17] 06Fundraising-Backlog: We lost some stats moving the donations queue consumer form drush - https://phabricator.wikimedia.org/T362206 (10Cstone) 03NEW [23:26:51] 06Fundraising-Backlog: We lost some stats moving the donations queue consumer form drush - https://phabricator.wikimedia.org/T362206#9702734 (10Cstone) looks like it was called in queue2civicrm_batch_process and we lost that being called when switching to drush [23:29:39] I just ran the update eileen, thanks! [23:29:49] cool [23:34:44] ah - my issue with disabling recurring was cos I did it over the patch I had locally [23:40:06] so this one was part of the whole - get rid of paypal stuff based on logging - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1016903 - although I guess more based on db query