[00:07:13] ok - so looking for merges on the 2 stop enabling [00:07:13] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018364 [00:07:13] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018363 [00:07:13] so I don't start to get into merge conflicts - gonna disable them on prod / staging now [15:19:45] 06Fundraising-Backlog, 07Epic, 10MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), 13Patch-For-Review: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9704244 (10Pcoombe) [15:31:39] 06Fundraising-Backlog: Investigation: Migrating historical SurveyMonkey data - https://phabricator.wikimedia.org/T337880#9704305 (10AKanji-WMF) [15:32:02] 06Fundraising-Backlog: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168#9704314 (10AKanji-WMF) [16:15:25] (03PS1) 10Cstone: Wikibugs hello? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018741 [16:44:45] (03CR) 10Damilare Adedoyin: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) (owner: 10Ejegg) [16:54:44] (03Merged) 10jenkins-bot: Extract base client-side error logging API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015076 (https://phabricator.wikimedia.org/T360785) (owner: 10Ejegg) [16:54:45] (03CR) 10Damilare Adedoyin: [C:03+2] Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [16:55:06] (03CR) 10Damilare Adedoyin: [C:03+2] Convenience fn to get RecurUpgrade logger [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015403 (owner: 10Ejegg) [16:56:49] (03Merged) 10jenkins-bot: Namespace ClientError API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015088 (owner: 10Ejegg) [16:57:05] (03Merged) 10jenkins-bot: Convenience fn to get RecurUpgrade logger [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015403 (owner: 10Ejegg) [17:19:08] thanks, damilare ! [17:19:38] np [17:20:00] (03CR) 10Damilare Adedoyin: [C:03+2] Add new API action to log recurring upgrade errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015161 (https://phabricator.wikimedia.org/T360785) (owner: 10Ejegg) [17:44:11] (03Merged) 10jenkins-bot: Add new API action to log recurring upgrade errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015161 (https://phabricator.wikimedia.org/T360785) (owner: 10Ejegg) [18:25:02] 06Fundraising-Backlog, 07Epic, 10MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), 13Patch-For-Review: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9705037 (10Pcoombe) [18:52:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9705102 (10Cstone) a:05Cstone→03None [18:59:32] (03Abandoned) 10Cstone: Wikibugs hello? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018741 (owner: 10Cstone) [19:08:45] (03PS5) 10Ejegg: Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:08:51] (03CR) 10Ejegg: [C:03+2] Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:13:11] (03PS3) 10Ejegg: Fold createContact back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016904 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:13:13] (03CR) 10Ejegg: [C:03+2] Fold createContact back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016904 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:27:26] (03Merged) 10jenkins-bot: Remove paypal calculation of cycle date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016903 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:33:43] (03Merged) 10jenkins-bot: Fold createContact back into caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016904 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [19:51:16] (03Abandoned) 10Eileen: fold it back in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017943 (owner: 10Eileen) [20:11:28] (03PS1) 10Eileen: Rename BaseQueue to BaseQueueTestCase [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018781 [20:11:50] (03PS2) 10Eileen: Rename BaseQueue to BaseQueueTestCase [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018781 [20:11:58] cstone: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018781 [20:21:04] thanks eileen [20:21:32] no worries - good to get them the same [20:41:14] (03PS1) 10Eileen: Superficial cleanup in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018786 [20:47:23] (03PS1) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [20:47:48] ooh, what's all that failmail [20:47:52] deadlocks? [20:50:27] constraint validation in ct queue [20:50:39] i thought we made that skip [20:57:42] (03CR) 10CI reject: [V:04-1] Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [21:05:25] (03CR) 10CI reject: [V:04-1] Superficial cleanup in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018786 (owner: 10Eileen) [21:07:14] (03CR) 10Cstone: [C:03+2] "thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018781 (owner: 10Eileen) [21:11:25] (03PS2) 10Eileen: Superficial cleanup in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018786 [21:12:30] (03PS2) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [21:12:30] (03PS1) 10Eileen: Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018794 [21:18:55] (03PS1) 10Eileen: More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 [21:21:29] cstone: what should we do about these - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1017183 - do you want to merge that one with the slightly wrong setting on the basis it gets fixed later - or should I fix it up first [21:21:52] oh yeah sorry eileen my plan was to get those reviewed today [21:21:58] i think i did merge the one with the wrong settings so far [21:22:21] oh yes you did! [21:26:23] (03Merged) 10jenkins-bot: Rename BaseQueue to BaseQueueTestCase [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018781 (owner: 10Eileen) [21:27:46] 06Fundraising-Backlog, 10FR-donorservices: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#9705410 (10MBeat33) Thanks for adding these examples, @AMJohnson. We continue to see tickets where these accumulating "outstanding balances" are... [21:33:30] (03CR) 10CI reject: [V:04-1] Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [21:39:33] (03CR) 10CI reject: [V:04-1] More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 (owner: 10Eileen) [21:46:52] (03CR) 10Cstone: [C:03+2] Set static in saner way in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017180 (owner: 10Eileen) [21:47:14] cstone: are you able to tap this one & the one under it - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018794/1 - they are superficial but I keep making those changes as part of other commits :-) [21:47:44] sure eileen [21:48:39] (03CR) 10Cstone: [C:03+2] Superficial cleanup in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018786 (owner: 10Eileen) [21:49:07] you mean 5 isnt helpful [21:50:11] (03CR) 10Cstone: [C:03+2] Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018794 (owner: 10Eileen) [21:51:46] thanks! [21:51:57] well to be fair cstone .... number 5 is alive [21:53:24] (03CR) 10Cstone: [C:03+2] Move function called from only 1 place to that place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017181 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [21:53:58] oh nice eileen I was looking at the audit_log chaos [21:54:06] nice that you have started to free us [21:54:21] hopefully we will get there! [21:55:33] DATA_WEIRD haha [21:56:31] Appeareth a payment_method hitherto unknown... [21:56:55] why doesnt that one bubble up when the audit fails on that its great haha [21:58:56] (03CR) 10Cstone: [C:03+2] Copy legacy function back to AuditProcessor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017182 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:01:04] (03PS3) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [22:01:43] my money says that is Katie but prepared to accept Adam [22:02:20] (03PS3) 10Eileen: Superficial cleanup in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018786 [22:02:56] (03PS2) 10Eileen: Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018794 [22:04:02] lemme see [22:05:06] elliott :) [22:06:04] (03Merged) 10jenkins-bot: Set static in saner way in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017180 (owner: 10Eileen) [22:07:23] oh that's funny - well he was their protege..... [22:11:32] (03PS1) 10Eileen: Fully delete unsubscribe module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018799 (https://phabricator.wikimedia.org/T270672) [22:13:13] (03Merged) 10jenkins-bot: Move function called from only 1 place to that place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017181 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:16:04] (03PS1) 10Eileen: Fully delete recurring queue2civicrm module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018800 (https://phabricator.wikimedia.org/T270672) [22:17:40] (03Merged) 10jenkins-bot: Copy legacy function back to AuditProcessor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017182 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:20:48] (03CR) 10CI reject: [V:04-1] Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [22:40:53] eileen for the new settings i see the log_working as /srv/civi-sites/wmff/drupal/sites/default/files/civicrm/upload/braintree but maybe were these set with buildkit [22:41:04] there was something we setup audit somewhere for local [22:41:28] lemme step through better [22:44:21] cstone: its coming from https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1017183/4/drupal/sites/all/modules/wmf_audit/BaseAuditProcessor.php#28 - but I'm trying to figure out why that is in the live not test class [22:44:31] this part [22:44:32] srv/civi-sites/wmff/drupal/sites/default/files/civicrm/upload [22:44:41] is the civicrm uploadDir [22:45:27] & I figured if the files go there during tests it should be possible to find them without them going anywhere under git (looking at you import tests) [22:46:12] yeah sorry i was running the actual audit [22:46:16] but I feel like I should be setting that setting in the test class not the prod class [22:47:30] or like you say - in buildkit [22:47:44] - I wonder if I just put that there temporarily & forgot to remove it [22:48:32] side question - one we have this one on settings do you want to convert another one & I can review your change on it? [22:49:08] (03CR) 10Eileen: [V:03+2] Superficial cleanup in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018786 (owner: 10Eileen) [22:49:25] (03CR) 10Eileen: [V:03+2] Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018794 (owner: 10Eileen) [22:49:36] sure eileen [22:49:53] (03PS4) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [22:50:51] other question too i see the menu item for audit dont see anything when you actually go there [22:51:09] well not audit its just the list of everything [22:51:47] (03PS2) 10Eileen: More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 [22:54:51] cstone: that is the new menu item for the settings - I think some cache flushes will get you there & maybe a menu rebuild [22:55:22] cstone: do you think I should move that setting::set() to the test class - or just wait until you have finished looking [23:09:41] (03CR) 10CI reject: [V:04-1] Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [23:10:28] (03CR) 10CI reject: [V:04-1] More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 (owner: 10Eileen) [23:13:25] if it makes sense to move it eileen im still trying to wrap my head around how it works but also about to take a break to get food [23:28:07] (03PS5) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [23:28:28] (03PS3) 10Eileen: More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 [23:43:39] (03PS5) 10Eileen: Use Civi Setting for braintree (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 [23:47:43] (03CR) 10CI reject: [V:04-1] Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [23:49:03] (03CR) 10CI reject: [V:04-1] More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 (owner: 10Eileen)