[00:03:46] (03PS6) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [00:13:36] (03PS7) 10Eileen: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 [00:30:38] (03PS4) 10Eileen: More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 [00:30:38] (03PS1) 10Eileen: Further test consolidatin - make new functions available in trait [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018804 [00:31:20] did I jinx that patch by using the word minor in the commit message? [00:34:35] (03PS2) 10Ejegg: Update smash-pig for paypal recurring fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 [00:46:43] (03CR) 10Ejegg: Update smash-pig for paypal recurring fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 (owner: 10Ejegg) [00:46:47] (03CR) 10Ejegg: [C:03+2] Update smash-pig for paypal recurring fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 (owner: 10Ejegg) [00:47:39] (03CR) 10CI reject: [V:04-1] Update smash-pig for paypal recurring fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 (owner: 10Ejegg) [00:52:20] Hmm, SonarCloud? [01:08:21] huh [01:08:45] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [01:09:04] woohoo - it passed https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018788 [01:09:40] (03CR) 10Ejegg: Update smash-pig for paypal recurring fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 (owner: 10Ejegg) [01:09:49] (03CR) 10Ejegg: [C:03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 (owner: 10Ejegg) [01:11:48] (03Merged) 10jenkins-bot: Update smash-pig for paypal recurring fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018393 (owner: 10Ejegg) [01:18:35] ejegg: I'm hoping you can merge a couple of these test move ones - I am moving some functionality from the BaseQueueTestCase to a trait so it can be shared from more places - but obviously it's quite subject to merge conflicts - On the bright side they are test only changes & jenkins has kicked the tyres [01:18:38] haha everything I thought was the audit directory is not actually the audit directory, maybe that got lost in the docker update [01:19:05] cstone: but of course [01:20:24] i have a bookmarked folder to /home/cc/dockerdev/src/civi-sites/wmff/drupal/sites/default/files/wmf_audit/adyen/incoming but then in drupal its set to /srv/civi-sites/wmff/drupal/sites/all/modules/wmf_audit/tests/data/Adyen/refunded/ [01:20:53] and i kept putting files in the incoming but then it was secret running wahtever its in refunded haha [01:22:10] i always keep forgetting the rebuild url is it just after the civicrm? [01:23:52] cstone: yeah civicrm/menu/rebuild [01:24:31] menu! [01:24:54] i want to change the location of the new settings locally [01:25:08] ok cool yay [01:27:57] (03PS1) 10Eileen: Fix test to use new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018810 [01:39:50] eileen: im good with that braintree one, do we want to deploy it tonight and I can manually rerun the audit to test it? [01:40:09] cstone: if it's not too late for you then that would be cool [01:40:14] nope i can [01:40:41] (03CR) 10Cstone: [C:03+2] "woo!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 (owner: 10Eileen) [01:51:13] (03CR) 10Ejegg: [C:03+2] "Nice, the traits are starting to reduce boilerplate!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [01:51:31] thanks ejegg - it's starting to take shape... [01:55:26] (03CR) 10Ejegg: [C:03+2] More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 (owner: 10Eileen) [01:58:50] (03PS1) 10Eileen: Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018811 [01:58:57] (03Merged) 10jenkins-bot: Use Civi Setting for braintree (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1017183 (owner: 10Eileen) [02:00:06] (03PS1) 10Eileen: Switch another test over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018812 [02:07:20] (03CR) 10Ejegg: [C:03+2] Further test consolidatin - make new functions available in trait [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018804 (owner: 10Eileen) [02:07:39] so many tests to delete :) [02:10:37] eileen: this deploy has 2 of the module turn offs we need to do that in the UI before right? or ist hat waht these are doing I should actually look at them [02:11:00] cstone: I did those 2 already [02:11:05] ok cool! [02:11:11] but it's useful to do it in your own UI under modules [02:11:46] (03Merged) 10jenkins-bot: Minor consolidation in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018788 (owner: 10Eileen) [02:12:35] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1018813 [02:14:06] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1018813 (owner: 10Cstone) [02:15:38] (03Merged) 10jenkins-bot: More consolidation with old tests using new test traits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018795 (owner: 10Eileen) [02:20:53] (03PS1) 10Eileen: More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 [02:24:17] (03PS2) 10Eileen: More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 [02:26:18] (03Merged) 10jenkins-bot: Further test consolidatin - make new functions available in trait [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018804 (owner: 10Eileen) [02:26:19] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1018813 (owner: 10Cstone) [02:30:18] !log civicrm upgraded from a382a7b0 to c2569254 [02:30:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:33:19] (03CR) 10CI reject: [V:04-1] More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 (owner: 10Eileen) [02:33:52] hmm eileen should I have a mysql you need to run notice on civi i dont think we did anything there? or is this old [02:35:03] braintree audit ran nicely though eileen ! [02:35:12] where are you seeing that? [02:35:24] yay for braintree audit [02:35:26] after i did a menu rebuild [02:36:20] Oh - because it rebuilt the trigger script - that's OK - we only need to run it if db changes that matter have happened [02:36:31] ah okay i see! it didnt pop up for me locally [02:38:30] yeah locally we have a setting to update the db automatically for our sanity [02:38:38] makes sense haha [02:38:45] but remotely the civi mysql user does not have enough power [02:39:23] (03PS3) 10Eileen: More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 [02:41:09] hmmm the past days. [02:41:24] did we have a solution for that setting [02:43:51] ok getting late here I'll try the next audit move tomorrow, have a good rest of your day eileen [02:44:19] cstone: I feel like past days wasn't used ? [02:44:31] night [02:44:35] it caused UI spam in the tests [02:44:42] it might have a default in the code [02:45:29] braintree is newer and looks like escaped the pattern the older ones have [02:59:38] (03CR) 10CI reject: [V:04-1] More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 (owner: 10Eileen) [03:34:39] (03PS2) 10Eileen: Fix test to use new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018810 [03:34:39] (03PS2) 10Eileen: Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018811 [03:34:39] (03PS2) 10Eileen: Switch another test over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018812 [03:34:40] (03PS4) 10Eileen: More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 [03:41:08] (03PS1) 10Eileen: Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 [04:00:10] (03CR) 10CI reject: [V:04-1] Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 (owner: 10Eileen) [04:17:59] (03PS2) 10Eileen: Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 [04:37:35] (03PS1) 10Eileen: Convert test wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018822 [04:38:22] (03CR) 10CI reject: [V:04-1] Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 (owner: 10Eileen) [04:55:37] (03CR) 10CI reject: [V:04-1] Convert test wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018822 (owner: 10Eileen) [05:17:14] (03PS2) 10Eileen: Convert test wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018822 [05:37:07] (03CR) 10CI reject: [V:04-1] Convert test wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018822 (owner: 10Eileen) [05:56:33] (03PS3) 10Eileen: Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 [05:56:33] (03PS3) 10Eileen: Convert test wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018822 [06:15:35] (03CR) 10CI reject: [V:04-1] Convert test wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018822 (owner: 10Eileen) [12:38:29] (03CR) 10Jgleeson: [C:03+2] "Working for me! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018326 (owner: 10Ejegg) [12:40:35] (03Merged) 10jenkins-bot: Restore onGatewayReady checks for PayPal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018326 (owner: 10Ejegg) [13:08:21] (03CR) 10Jgleeson: [C:04-1] "Thanks! This is working, but I've requested an update to break up the method." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018328 (owner: 10Ejegg) [13:26:53] 06Fundraising-Backlog, 06SRE, 10SRE-Access-Requests: Can we please add our vendor to Google Postmaster Tools - https://phabricator.wikimedia.org/T360907#9706990 (10akosiaris) I don't think #SRE has ever administrated Google Postmaster Tools at all. In fact, a quick cross check in the team showcases almost ut... [14:45:13] (03PS8) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1014088 (https://phabricator.wikimedia.org/T349663) [14:46:45] (03PS7) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [14:46:59] (03CR) 10CI reject: [V:04-1] Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [14:51:36] (03PS8) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [14:52:46] (03PS9) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) [14:57:55] (03CR) 10Damilare Adedoyin: "Thanks for the CR eileen,went through and made a couple of changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [14:59:51] (03CR) 10Damilare Adedoyin: [C:03+2] Fix test to use new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018810 (owner: 10Eileen) [15:05:34] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: 14Add/ fix page to support 1-click-ubsubscribe - 14https://phabricator.wikimedia.org/T354587#9707554 (10AKanji-WMF) 05Open→03Resolved 14This ticke... [15:06:00] (03CR) 10CI reject: [V:04-1] Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [15:13:04] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 13Patch-For-Review: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236#9707609 (10jgleeson) [15:20:28] (03Merged) 10jenkins-bot: Fix test to use new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018810 (owner: 10Eileen) [16:02:47] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: G thang , 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9707794 (10krobinson) @E... [16:05:06] (03CR) 10Ejegg: [C:04-1] "One wrong field consulted, one bit of copypasta to update. In response to the commit message saying it's wrong to skip on recurring - we d" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018399 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [16:07:34] (03CR) 10Ejegg: [C:03+2] Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018811 (owner: 10Eileen) [16:26:55] (03Merged) 10jenkins-bot: Key test cases by description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018811 (owner: 10Eileen) [18:42:26] (03PS4) 10Eileen: Move a couple more checks to the Message Object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018399 (https://phabricator.wikimedia.org/T240581) [18:43:36] (03CR) 10Eileen: "thanks ejegg - I fixed those" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018399 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [19:27:05] 10fundraising-tech-ops: Deactivate fundraising accounts for dbu - https://phabricator.wikimedia.org/T362355 (10Dwisehaupt) 03NEW [19:30:08] 10fundraising-tech-ops: Deactivate fundraising accounts for dbu - https://phabricator.wikimedia.org/T362355#9708370 (10Dwisehaupt) [19:31:41] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic - request to store click data in mailing stats - https://phabricator.wikimedia.org/T344383#9708373 (10AKanji-WMF) Moving to triage to check in on what still needs to be done for this phab. [19:44:30] 10fundraising-tech-ops: Deactivate fundraising accounts for dbu - https://phabricator.wikimedia.org/T362355#9708404 (10Dwisehaupt) Removed from `ThankYouEmail` campaign notification but there are no other users on that notification. Just noting in case it is needed. [19:44:59] (03PS5) 10Ejegg: Move a couple more checks to the Message Object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018399 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [19:45:01] (03CR) 10Ejegg: [C:03+2] Move a couple more checks to the Message Object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018399 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [19:45:16] 10fundraising-tech-ops: Deactivate fundraising accounts for dbu - https://phabricator.wikimedia.org/T362355#9708405 (10Dwisehaupt) [19:49:28] whoa! ^^^ [19:49:52] I miss out on personnel things now that it's all in slack... [19:52:15] dbu [19:52:17] ? [19:54:07] Danny Bu, right? [19:57:07] (03PS4) 10Ejegg: Move soft credit handling to import code, add test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018403 (owner: 10Eileen) [19:57:33] (03CR) 10Ejegg: [C:03+2] "Looks clean and moves special-purpose code out of the generic path. I like it!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018403 (owner: 10Eileen) [20:01:21] (03PS3) 10Ejegg: Remove contribution_tags [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018405 (owner: 10Eileen) [20:03:12] (03CR) 10Ejegg: [C:03+2] "Seems like a fine simplification. We still have some special cases in the TY email when certain contribution tags exist (RecurringRestarte" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018405 (owner: 10Eileen) [20:04:34] (03Merged) 10jenkins-bot: Move a couple more checks to the Message Object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018399 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [20:05:08] ejegg: yay I was hoping you would be on board on that tags code going :-) [20:05:53] Oh right - just saw the account disable thing [20:10:49] 06Fundraising-Backlog, 10FR-endowment, 10Recurring-Donations: Review and close loophole allowing recurring Endowment gifts - https://phabricator.wikimedia.org/T269455#9708461 (10AKanji-WMF) @AParker is this still something we see? If not I'll put this one to rest. [20:19:10] 06Fundraising-Backlog, 10FR-endowment, 10Recurring-Donations: Review and close loophole allowing recurring Endowment gifts - https://phabricator.wikimedia.org/T269455#9708476 (10AParker) You can close this. We are aware that some donors hack the URL to make recurring donations to the Endowment. It's a small... [20:22:07] 06Fundraising-Backlog, 10FR-endowment, 10Recurring-Donations: 14Review and close loophole allowing recurring Endowment gifts - 14https://phabricator.wikimedia.org/T269455#9708485 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF 14Thank you! [20:25:30] (03Merged) 10jenkins-bot: Move soft credit handling to import code, add test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018403 (owner: 10Eileen) [20:25:32] (03Merged) 10jenkins-bot: Remove contribution_tags [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018405 (owner: 10Eileen) [20:36:12] (03PS1) 10Cstone: WIP: Use civi settings for dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019124 (https://phabricator.wikimedia.org/T270675) [20:41:26] (03PS2) 10Ejegg: Restore pre-capture fraud check for PayPal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018328 [20:42:51] jgleeson: sorry i left that till so late in your day. Perhaps tomorrow morning you can tell me if you like that arrangement better ^^ [20:58:03] cstone: that looks pretty sane [20:58:26] i think i can delete some contact stuff like you did out of braintree just making sure [21:00:30] okay maybe not hah [21:01:16] (03PS2) 10Cstone: Use civi settings for dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019124 (https://phabricator.wikimedia.org/T270675) [21:03:09] cstone: maybe remove rather than comment that block of code? [21:04:09] oh bah haha [21:04:45] (03PS3) 10Cstone: Use civi settings for dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019124 (https://phabricator.wikimedia.org/T270675) [21:14:06] (03PS1) 10Cstone: Add Maestro for RO and BE [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1019129 [21:17:13] np ejegg|afk thanks for the updates [21:18:20] (03PS2) 10Cstone: Add Maestro for RO and BE [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1019129 [21:19:55] (03CR) 10Jgleeson: [C:03+2] "Looks great! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018328 (owner: 10Ejegg) [21:20:04] (03CR) 10CI reject: [V:04-1] Add Maestro for RO and BE [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1019129 (owner: 10Cstone) [21:20:44] why yaml [21:21:12] (03PS3) 10Cstone: Add Maestro for RO and BE [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1019129 [21:21:41] that error is so weird [21:21:44] 22:19:57 [0] => Exception setting up GatewayPage with adapter class AdyenCheckoutAdapter: Indentation problem at line 26 (near " group: cc"). [21:21:55] its cause i messed up the yaml indentation 3 times in a row [21:21:59] even when i was trying to fix it haha [21:23:28] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1019129 (owner: 10Cstone) [21:23:45] thanks jgleeson [21:23:50] np [21:23:54] have a good evening all [21:26:54] (03Merged) 10jenkins-bot: Restore pre-capture fraud check for PayPal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1018328 (owner: 10Ejegg) [21:26:56] (03Merged) 10jenkins-bot: Add Maestro for RO and BE [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1019129 (owner: 10Cstone) [22:04:05] cstone: what do you want to do with that patch - it looks good to me - is it something we can deploy & watch? [22:04:40] We can merge and I'll deploy and test it like I did with Braintree [22:05:21] ok - I'll + 2 then [22:05:41] (03CR) 10Eileen: [C:03+2] Use civi settings for dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019124 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [22:05:49] Thanks ! [22:29:44] cstone: I also had some success getting the audit test to not call the to-get-rid-of functions directly - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018817/3/drupal/sites/all/modules/wmf_audit/tests/BraintreeAuditTest.php [22:31:29] (03CR) 10Eileen: Fix BrainTree Audit to use new helpers (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 (owner: 10Eileen) [22:43:47] huh eileen would the tests delete non test contacts [22:43:55] my contact has disappeared [22:44:03] is your contact a Mouse? [22:44:07] it was a jimmy [22:44:32] oh yeah - he is toast [22:44:42] it's in the EnvironmentTrait [22:44:44] $this->cleanupContact(['last_name' => 'McTest']); [22:44:44] $this->cleanupContact(['last_name' => 'Mouse']); [22:44:44] $this->cleanupContact(['last_name' => 'Russ']); [22:44:44] $this->cleanupContact(['last_name' => 'Wales']); [22:44:44] $this->cleanUpContact(['display_name' => 'Anonymous']); [22:45:02] oh hmmmmmm [22:45:02] but we could stop using Jimmy as a test contact & remove that? [22:45:05] yes please [22:45:48] i thought it was weird they were all gone but then I guess I thought I just hadn't done any test donations since i rebuilt LOL [22:46:16] we can also just change the autofill on all our test forms [22:46:54] but if we just use mouse in tests and wales in forms maybe then? [22:47:37] donor test is still there though [22:47:44] but because not mctest! [22:48:20] (03PS1) 10Eileen: In just 7 days I will make you a Mouse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019134 [22:48:33] cstone: if ^^passes it should be OK [22:48:43] LOL eileen [22:49:28] I've changes quite a lot of tests to be Mouse - it at least feels like a surname that wouldn't be there for any other reason [22:50:00] yeah if we just all agree to use this for unit tests and if we change forms to mouse itll go away I think will be fine [22:52:05] & also Mice are already covered by doMouseHunt() [22:52:48] I like the way the function starts `$traditionalMouseNames = [` [22:52:53] haha [22:53:27] classic mice like fox mulder [22:53:32] lol yeah [22:54:02] LOL elliotts comment [22:54:07] er commit msg [22:54:20] "X-FIles acquired by disney" I see it makes sense [23:00:03] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1019135 [23:02:16] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1019135 (owner: 10Cstone) [23:03:06] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1019135 (owner: 10Cstone) [23:04:34] !log civicrm upgraded from c2569254 to 4d5a4fc3 [23:04:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:06:28] dlocal audit running nicely [23:06:33] and finished haha [23:27:01] (03CR) 10Cstone: [C:03+2] Switch another test over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018812 (owner: 10Eileen) [23:27:28] cstone: yay [23:27:42] we maybe don't need to do the rest one by one then? [23:27:56] yeah i dont think so for me at least i just stepped through it a bunch [23:27:56] nice commit message re X files [23:28:25] (03CR) 10Cstone: [C:03+2] "Thanks for saving Jimmy!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019134 (owner: 10Eileen) [23:28:31] we just move the functions into the top level & do that test file re-org [23:46:28] (03Merged) 10jenkins-bot: Switch another test over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018812 (owner: 10Eileen) [23:53:09] (03Merged) 10jenkins-bot: In just 7 days I will make you a Mouse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019134 (owner: 10Eileen)