[00:30:07] lol, nice Rocky Horror reference [00:31:27] cstone are you reviewing more of eileen's patches? I thought I might do one more but could do other stuff so as not to interfere [00:32:39] (03PS3) 10Eileen: Move function to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018392 [00:33:14] looks like some of them need rebasing [00:36:35] (03PS2) 10Eileen: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018591 [00:37:08] (03CR) 10Ejegg: [C:03+2] Move function to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018392 (owner: 10Eileen) [00:41:15] (03PS4) 10Eileen: Move function to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018392 [00:41:15] (03PS3) 10Eileen: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018591 [00:41:15] (03PS2) 10Eileen: Move handling of saving contribution_tracking to main processing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018592 [00:42:05] thanks ejegg I fixed up the other one in case you get to it - although the module removals might be easier merges - I'm shooting out for a bit [00:51:37] (03CR) 10Ejegg: [C:03+2] Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018591 (owner: 10Eileen) [01:05:39] Sorry ejegg I was eating you're good I just looked at the one [01:09:59] (03Merged) 10jenkins-bot: Move function to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018392 (owner: 10Eileen) [01:11:14] (03Merged) 10jenkins-bot: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018591 (owner: 10Eileen) [01:15:18] (03CR) 10Ejegg: [C:03+2] "Looks like it works, and without making extra lookups in the cases I can puzzle through right now. getRecurringPriorContributionValue coul" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018592 (owner: 10Eileen) [01:34:27] (03Merged) 10jenkins-bot: Move handling of saving contribution_tracking to main processing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018592 (owner: 10Eileen) [02:41:00] 03Fundraising Sprint: gone(), 06Fundraising-Backlog: Save phonetic names into civi fields - https://phabricator.wikimedia.org/T362195#9708971 (10Cstone) a:03Cstone [02:50:30] (03PS1) 10Cstone: WIP: Add phonetic names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019141 [04:18:01] (03PS4) 10Eileen: Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [04:18:01] (03PS1) 10Eileen: Simplify isPayment(), setting contributionRecurID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 [04:27:36] (03CR) 10CI reject: [V:04-1] Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [04:27:39] (03CR) 10CI reject: [V:04-1] Simplify isPayment(), setting contributionRecurID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [05:13:43] (03PS5) 10Eileen: Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [05:13:43] (03PS2) 10Eileen: Simplify isPayment(), setting contributionRecurID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 [05:32:38] (03CR) 10CI reject: [V:04-1] Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [05:33:15] (03CR) 10CI reject: [V:04-1] Simplify isPayment(), setting contributionRecurID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [10:06:19] (03PS1) 10Thiemo Kreuz (WMDE): Fix a large amount of PHPCS code style violations [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1019256 [10:08:41] (03CR) 10CI reject: [V:04-1] Fix a large amount of PHPCS code style violations [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1019256 (owner: 10Thiemo Kreuz (WMDE)) [11:13:13] fr-tech I'm gonna be out for a few hours this afternoon as I have a Passport Renewal appointment in Liverpool which will hopefully result in me getting my new passport today just in time to book the offsite and civicamp flights. I'll be back in time for standup and social time. See you all then. [12:31:15] (03CR) 10Damilare Adedoyin: [C:03+2] Add rtbt and ach to adyen supported MC payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010682 (https://phabricator.wikimedia.org/T359877) (owner: 10Wfan) [12:33:26] (03Merged) 10jenkins-bot: Add rtbt and ach to adyen supported MC payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1010682 (https://phabricator.wikimedia.org/T359877) (owner: 10Wfan) [13:01:49] (03PS2) 10Thiemo Kreuz (WMDE): Fix a large amount of PHPCS code style violations [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1019256 [13:08:30] (03CR) 10Damilare Adedoyin: [C:03+2] More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 (owner: 10Eileen) [13:08:57] (03CR) 10Damilare Adedoyin: [C:03+2] Set drupal homepage to /civicrm [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1017912 (owner: 10Ejegg) [13:09:01] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Set drupal homepage to /civicrm [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1017912 (owner: 10Ejegg) [13:29:20] (03CR) 10Damilare Adedoyin: [C:03+2] Use new php function to detect string start [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014123 (owner: 10Ejegg) [13:31:00] (03CR) 10CI reject: [V:04-1] More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 (owner: 10Eileen) [13:36:36] (03Merged) 10jenkins-bot: Use new php function to detect string start [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1014123 (owner: 10Ejegg) [14:33:44] 03Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun), 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9710225 (10AMJohnson) @Eje... [14:54:07] (03CR) 10Damilare Adedoyin: [C:03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 (owner: 10Eileen) [15:15:28] (03Merged) 10jenkins-bot: More use of helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018814 (owner: 10Eileen) [15:28:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07recurring upgrade: Don't create recurring upgrade activities with $0 upgraded - https://phabricator.wikimedia.org/T362423#9710331 (10Ejegg) a:03Ejegg [15:28:57] (03PS1) 10Ejegg: Discard recurring upgrade messages with amount <= 0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) [15:29:08] (03CR) 10CI reject: [V:04-1] Discard recurring upgrade messages with amount <= 0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [15:30:00] (03PS2) 10Ejegg: Discard recurring upgrade messages with amount <= 0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) [15:33:38] (03CR) 10CI reject: [V:04-1] Discard recurring upgrade messages with amount <= 0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [15:38:09] (03CR) 10Damilare Adedoyin: [C:03+2] Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 (owner: 10Eileen) [15:42:21] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [15:42:39] oh man, it couldn't connect to github to douwnload buildkit! [15:43:06] When we first had CI for Civi, it would often have trouble dowanloading buildkit from Sourceforge [15:43:11] but they soon moved the repo [15:57:35] (03Merged) 10jenkins-bot: Fix BrainTree Audit to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018817 (owner: 10Eileen) [16:12:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9710489 (10Cstone) The same issue is happening with Maestro recurring, Adyen has this turned off on their... [16:50:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: Recurring dlocal donations sent to Civi with no token or recur_id - https://phabricator.wikimedia.org/T360900#9710649 (10MBeat33) Thanks for the info @Cstone. Adding folks for visibility. [19:06:36] (03PS1) 10Umherirrender: Migrate to IDatabase::newDeleteQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1019332 [19:09:30] (03CR) 10CI reject: [V:04-1] Migrate to IDatabase::newDeleteQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1019332 (owner: 10Umherirrender) [19:39:22] (03PS2) 10Umherirrender: Migrate to IDatabase::newDeleteQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1019332 [22:17:34] (03CR) 10Eileen: [C:03+1] "So this makes total sense for me when it is 0 - I'm just wondering if we should really ignore it if it is less than 0? Or should we treat " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [22:29:20] (03CR) 10Ejegg: "If it comes in as an upgrade but ends up being less than 0, I guess that means they submitted the form twice before the queue was consumed" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [22:41:56] (03CR) 10Eileen: [C:03+1] "I kinda think 2 activities makes sense in that scenario (as well as being easier) - it would be rare / maybe never but would be easier to " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg)