[04:36:48] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9716227 (10Eileenmcnaughton) [04:37:19] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9716229 (10Eileenmcnaughton) I've pulled this into the sprint because expiring imports are causing issues with figuring out import issues in the current sprint [04:37:36] (03PS1) 10Eileen: Port Import SearchKit improvements [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019954 (https://phabricator.wikimedia.org/T360137) [16:54:34] 06Fundraising-Backlog, 07Epic, 10MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), 13Patch-For-Review: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9719572 (10Pcoombe) [17:22:17] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9719722 (10MDemosWMF) @Eileenmcnaughton Thanks it seems to be working great! I tested with a gift that would create a new Org... [18:23:57] (03PS3) 10Wfan: Add SEPA as new instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010156 (https://phabricator.wikimedia.org/T324520) [20:11:56] (03PS1) 10Eileen: Remove call to get variable that is unused [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020345 [20:21:26] (03PS1) 10Eileen: Move function in legacy code with only one caller to that caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020346 [20:29:11] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720450 (10Eileenmcnaughton) @MDemosWMF ok - so it seems that we have made the high level default for "No thank you" 'Sent by... [20:35:41] (03CR) 10Eileen: "A couple of superficial things - I'm gonna take a deeper look" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin) [20:38:07] (03CR) 10Eileen: [C:03+2] Discard recurring upgrade messages with amount == 0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [20:57:56] (03PS3) 10Eileen: Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 [20:58:05] thanks eileen! [20:58:25] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720516 (10MDemosWMF) @Eileenmcnaughton My test import did have a "Thank You Date" field which I left blank to trigger the TY... [20:58:38] nw ejegg - I also think I got enough of a handle on isPayment() to remove that interim hack on it [21:00:24] (03Merged) 10jenkins-bot: Discard recurring upgrade messages with amount == 0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019293 (https://phabricator.wikimedia.org/T362423) (owner: 10Ejegg) [21:05:12] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720547 (10Eileenmcnaughton) @MDemosWMF - so in that import the thank you date is not set but the No TY reason field is set to... [21:20:42] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720576 (10MDemosWMF) Ok so the No TY reason = 'sent by portal' is a rule that is on the backend of the import? I'm not sure... [21:26:11] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720583 (10Eileenmcnaughton) Ok - so the current rule is "If the no thank you date field is not mapped on the import then add... [21:35:06] (03PS6) 10Eileen: Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [21:39:44] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720639 (10MDemosWMF) Ahh ok I see! Maybe @NNichols has some thoughts on what we could do for Benevity. I think that current... [21:55:54] (03CR) 10CI reject: [V:04-1] Use MessageObject to do additional lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [22:27:33] (03PS4) 10Eileen: Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 [22:27:33] (03PS1) 10Eileen: Specify & enforce our trxn_type list up front [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 [22:31:51] (03CR) 10CI reject: [V:04-1] Specify & enforce our trxn_type list up front [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 (owner: 10Eileen) [22:31:53] (03CR) 10CI reject: [V:04-1] Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [22:39:05] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9720813 (10Eileenmcnaughton) OK- well if Benevity is the only one where the new rule doesn't make sense I'm gonna work up the... [22:39:09] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 (owner: 10Eileen) [22:40:28] some easy review - [22:40:28] - search kit tweak already merged upstream (upstream review should suffice here) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1019954?usp=dashboard [22:40:28] - remove old drush code https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018800?usp=dashboard & https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1018799?usp=dashboard [22:47:50] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [22:55:10] (03PS7) 10Eileen: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [23:10:19] (03PS1) 10Eileen: Migrate another test to extension land [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020391 [23:10:19] (03PS1) 10Eileen: Move another test to import class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020392 [23:10:34] (03PS2) 10Eileen: Migrate another test to extension land [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020391 [23:10:42] (03PS2) 10Eileen: Move another test to import class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020392 [23:14:47] (03CR) 10CI reject: [V:04-1] Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:15:02] (03PS2) 10Eileen: Specify & enforce our trxn_type list up front [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 [23:16:24] (03PS5) 10Eileen: Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 [23:16:24] (03PS8) 10Eileen: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [23:30:38] (03CR) 10CI reject: [V:04-1] Migrate another test to extension land [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020391 (owner: 10Eileen) [23:30:39] (03CR) 10CI reject: [V:04-1] Move another test to import class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020392 (owner: 10Eileen) [23:32:14] (03CR) 10CI reject: [V:04-1] Move another test to import class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020392 (owner: 10Eileen) [23:35:41] (03CR) 10CI reject: [V:04-1] Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [23:50:12] fr-tech there's a fair amount in the deploy queue for payments [23:50:45] I think I should get it out while paypal donations are rolling in at a relatively slow rate [23:55:27] ejegg: good idea - I'm around to at least be rubber duck if there are issues [23:57:16] (03PS1) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401