[00:15:41] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401 (owner: 10Eileen)
[00:27:10] <wikibugs>	 (03PS1) 10Eileen: Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404
[00:27:10] <wikibugs>	 (03PS1) 10Eileen: Fold location update back into the last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020405
[00:27:41] <wikibugs>	 (03PS2) 10Eileen: Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404
[00:27:56] <wikibugs>	 (03PS2) 10Eileen: Fold location update back into the last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020405
[00:30:59] <eileen>	 ejegg: I feel like I got  to the bottom of what is happening in that recurring queue contact update - which is in the comments here
[00:30:59] <eileen>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1020404/2/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/WMFQueue/RecurringQueueTest.php
[00:31:00] <eileen>	 My question is whether the difference in name handling makes sense ie 
[00:31:00] <eileen>	 Main Queue - only updates first_name, last_name if not existing, does not update our database off a different name from if it has one
[00:31:01] <eileen>	 Recurring Queue - does update if incoming name differs
[00:31:02] <eileen>	 I guess you could argue that someone might update their name in paypal for *reasons* which should flow though but you could also argue that we should use the name they gave us if they gave us one. (The latter argument is also easier cos it just removes code :-))
[00:36:39] <wikibugs>	 (03PS9) 10Eileen: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469)
[00:50:55] <wikibugs>	 (03PS1) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862)
[00:50:57] <wikibugs>	 (03PS1) 10Jdlrobson: POC: Potential styles [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020409 (https://phabricator.wikimedia.org/T257862)
[00:51:45] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Fold location update back into the last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020405 (owner: 10Eileen)
[00:52:51] <wikibugs>	 (03CR) 10CI reject: [V:04-1] POC: Potential styles [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020409 (https://phabricator.wikimedia.org/T257862) (owner: 10Jdlrobson)
[00:52:59] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) (owner: 10Jdlrobson)
[00:54:28] <wikibugs>	 06Fundraising-Backlog, 10donate.wikimedia.org, 13Patch-For-Review: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862#9721047 (10Jdlrobson) Hi @Pcoombe https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1020408  provides some scaffolding for...
[00:58:24] <ejegg>	 looking eileen
[01:01:17] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen)
[01:10:17] <eileen>	 also ejegg if you have time to hang out I wonder if we could look at Dami's patch together - I have some minor things but also a couple of questions - I'd really like to see if we can get it merged with some follow ups because the ground just keeps moving under Dami on that patch
[01:10:54] <ejegg>	 sure eileen
[01:11:06] <ejegg>	 in today's standup link?
[01:11:13] <wikibugs>	 (03PS12) 10Eileen: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin)
[01:11:13] <wikibugs>	 (03PS1) 10Eileen: Minor follow ups on Previous Fundraise up patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020416 (https://phabricator.wikimedia.org/T349663)
[01:35:17] <wikibugs>	 (03CR) 10Eileen: Fundraiseup audit import for recur plan change (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin)
[01:51:50] <wikibugs>	 (03CR) 10Eileen: "Dami," [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin)
[02:14:41] <wikibugs>	 (03PS2) 10Eileen: Minor follow ups on Previous Fundraise up patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020416 (https://phabricator.wikimedia.org/T349663)
[02:19:21] <wikibugs>	 (03PS10) 10Eileen: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469)
[02:55:23] <wikibugs>	 (03PS3) 10Eileen: Migrate another test to extension land [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020391
[03:00:34] <wikibugs>	 (03PS3) 10Eileen: Move another test to import class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020392
[03:07:21] <wikibugs>	 (03PS1) 10Eileen: Move another test over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020442
[04:09:12] <wikibugs>	 (03PS1) 10Eileen: Prepare messageImport test for move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020454
[04:29:25] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Prepare messageImport test for move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020454 (owner: 10Eileen)
[04:32:49] <wikibugs>	 (03PS2) 10Eileen: Prepare messageImport test for move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020454
[04:32:49] <wikibugs>	 (03PS1) 10Eileen: Confirm, using test, that code we think can go can.... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020463
[04:58:58] <wikibugs>	 (03CR) 10DannyS712: [C:03+2] build: Updating eslint-config-wikimedia to 0.27.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020459 (owner: 10Libraryupgrader)
[05:03:34] <wikibugs>	 (03PS1) 10Eileen: Re-use McTest to leverage cleanup routine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020473
[05:36:10] <wikibugs>	 (03PS1) 10Eileen: Clean up Adyen Audit to use new helpers, purgeable contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020475
[05:36:10] <wikibugs>	 (03PS1) 10Eileen: Remove notes creation out of main insert handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020476
[06:08:51] <wikibugs>	 (03PS1) 10Eileen: Consolidate calls to message_import within Benevity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020478
[06:08:51] <wikibugs>	 (03PS1) 10Eileen: Separate import code from main message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020479
[06:12:45] <wikibugs>	 (03PS2) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401
[06:12:45] <wikibugs>	 (03PS3) 10Eileen: Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404
[06:29:15] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Separate import code from main message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020479 (owner: 10Eileen)
[06:32:34] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401 (owner: 10Eileen)
[06:32:39] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404 (owner: 10Eileen)
[11:13:58] <wikibugs>	 (03CR) 10CI reject: [V:04-1] build: Updating eslint-config-wikimedia to 0.27.0 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1020792 (owner: 10Libraryupgrader)
[11:48:26] <wikibugs>	 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9722189 (10NNichols) Yes, we should suppress all TYL for Benevity as well.  Although there are individual and corporate gifts...
[11:50:13] <wikibugs>	 (03PS13) 10Damilare Adedoyin: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663)
[11:51:58] <wikibugs>	 (03PS3) 10Eileen: Minor follow ups on Previous Fundraise up patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020416 (https://phabricator.wikimedia.org/T349663)
[12:12:02] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Minor follow ups on Previous Fundraise up patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020416 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen)
[13:01:21] <ejegg|away>	 /ni/nick ejegg
[13:32:08] <jgleeson>	 there was an interesting failmail to chew on from earlier ejegg 
[13:40:05] <ejegg>	 Recipient must be existing, and OPTED IN or SNOOZED, and either RESUME_SEND_DATE or DAYS_TO_SNOOZE ?
[13:40:27] <ejegg>	 Either someone set the snooze date in the past, or it sat in the queue a long time
[13:40:36] <ejegg>	 jgleeson: that one?
[13:40:58] <ejegg>	 We should see if we can put some validation on that edit form
[13:41:18] <ejegg>	 also I feel like a special purpose form would be better than that searchkit
[13:47:50] <jgleeson>	 yep that one
[13:49:03] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Fully delete unsubscribe module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018799 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen)
[13:52:46] <damilare>	 O agree
[13:52:52] <damilare>	 I*
[13:54:00] <wikibugs>	 (03PS1) 10Damilare Adedoyin: RecurUpgrade: error message for donors with no upgradable recur [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020841 (https://phabricator.wikimedia.org/T360052)
[13:56:31] <wikibugs>	 (03CR) 10CI reject: [V:04-1] RecurUpgrade: error message for donors with no upgradable recur [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020841 (https://phabricator.wikimedia.org/T360052) (owner: 10Damilare Adedoyin)
[13:58:07] <wikibugs>	 (03PS2) 10Damilare Adedoyin: RecurUpgrade: error message for donors with no upgradable recur [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020841 (https://phabricator.wikimedia.org/T360052)
[14:06:19] <wikibugs>	 (03PS3) 10Damilare Adedoyin: RecurUpgrade: error message for donors with no upgradable recur [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020841 (https://phabricator.wikimedia.org/T360052)
[14:07:28] <wikibugs>	 (03Merged) 10jenkins-bot: Fully delete unsubscribe module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018799 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen)
[14:09:56] <jgleeson>	 damilare: that patch looks good. I noticed that the top nav bar is missing in the new page. is that intentional?
[14:10:41] <damilare>	 yh it's the same as the recur upgrade page navbar
[14:10:47] <damilare>	 no nav bar
[14:11:08] <damilare>	 I guess it's intentional from the design
[14:11:58] <jgleeson>	 it looks like it was there prior so thought I'd ask
[14:11:59] <jgleeson>	 thanks
[14:12:54] <damilare>	 np
[14:13:37] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "LGTM! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020841 (https://phabricator.wikimedia.org/T360052) (owner: 10Damilare Adedoyin)
[14:14:20] <damilare>	 thanks for the CR jgleeson 
[14:14:36] <jgleeson>	 np!
[14:15:09] <jgleeson>	 hmm the issue with the sepa recurring import looks tricky
[14:15:40] <jgleeson>	 it looks like adyen doesn't return a subscription ID for sepa 
[14:17:04] <jgleeson>	 there's also confusion around why we need a one-time direct debit and recurring direct debit sepa payment, as a direct debit usually implies recurring
[14:35:50] <wikibugs>	 (03Merged) 10jenkins-bot: RecurUpgrade: error message for donors with no upgradable recur [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020841 (https://phabricator.wikimedia.org/T360052) (owner: 10Damilare Adedoyin)
[14:38:30] <wikibugs>	 (03PS2) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862)
[14:40:32] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) (owner: 10Jdlrobson)
[14:41:17] <wikibugs>	 (03PS2) 10Jdlrobson: POC: Potential styles [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020409 (https://phabricator.wikimedia.org/T257862)
[15:10:38] <ejegg>	 ooh, donate-wiki skin!
[15:16:54] <wikibugs>	 06Fundraising-Backlog: Greece - Campaign Readyness Checklist - https://phabricator.wikimedia.org/T362784 (10AKanji-WMF) 03NEW
[15:20:07] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Fully delete recurring queue2civicrm module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018800 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen)
[15:25:41] <ejegg>	 let's see, fr-tech, is now a good time to deploy those paypal changes?
[15:26:12] <ejegg>	 let's check the smashpig settings first
[15:30:03] <wikibugs>	 (03PS3) 10Jgleeson: Add SEPA as new instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010156 (https://phabricator.wikimedia.org/T324520) (owner: 10Wfan)
[15:30:03] <wikibugs>	 (03CR) 10Jgleeson: [C:04-1] "I wonder what we do for iDEAL recurring" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1010156 (https://phabricator.wikimedia.org/T324520) (owner: 10Wfan)
[15:36:31] <ejegg>	 ok, gonna get the current auto-merge translation updates deployed first along with that lil config change
[15:36:45] <ejegg>	 log payments-wiki upgraded from 5e39bdc5 to 72e3bf19
[15:37:05] <ejegg>	 oh hi wfan! how are you doing?
[15:38:28] <wfan>	 Tired with breastfeeding haha. I finally understand what means sleep when baby sleep>~< but today is 1 month for Alyssa ~
[15:38:43] <ejegg>	 wowow! happy one month old 
[15:39:37] <jgleeson>	 hello wfan !
[15:39:48] <jgleeson>	 how is baby Alyssa?
[15:39:56] <wikibugs>	 (03Merged) 10jenkins-bot: Fully delete recurring queue2civicrm module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018800 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen)
[15:40:00] <wfan>	 Thanks. Tired to have any plan for her 1month haha. Probably just do some photos at home
[15:40:34] <wfan>	 She is doing well! Growing from 5 lb 13oz to almost 8 lb~
[15:43:20] <cstone>	 aww happy one month wfan !
[15:43:42] <wfan>	 😊
[15:43:44] <jgleeson>	 wow nice!
[15:54:07] <jgleeson>	 it's great that you and baby are happy and healthy wfan ! sorry about the sleep.. that is really tough for mums for the early part 
[15:58:02] <wfan>	 It’s a brand new life experience and I am so thankful that my mom is here with us.
[16:06:27] <dwisehaupt>	 wfan: congrats. yeah, the one mantra we had when they were new is "mom sleeps when the kids do" otherwise you'll never feel right. :)
[16:07:48] <wfan>	 Thanks~ I will hop off now Alyssa is asking for food 😂
[16:07:54] <jgleeson>	 :)
[16:08:17] <jgleeson>	 good to hear from you!
[16:23:17] <wikibugs>	 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#9723421 (10Cstone) Possibly the same as {T360931}
[16:26:07] <wikibugs>	 06Fundraising-Backlog: Address too long causing failmail - https://phabricator.wikimedia.org/T361981#9723455 (10AKanji-WMF) p:05Triage→03Low
[16:36:24] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1020866
[16:36:35] <ejegg>	 damilare: there's the merge to deployment ^^^
[16:36:39] <ejegg>	 A lot of stuff!
[16:37:15] <damilare>	 yep!!
[16:37:22] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1020866 (owner: 10Ejegg)
[16:42:05] <wikibugs>	 (03PS1) 10Jgleeson: Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520)
[16:42:55] <wikibugs>	 (03PS2) 10Jgleeson: WIP: Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520)
[16:44:06] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1020866 (owner: 10Ejegg)
[16:44:39] <wikibugs>	 (03CR) 10CI reject: [V:04-1] WIP: Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520) (owner: 10Jgleeson)
[16:50:53] <wikibugs>	 (03PS3) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862)
[16:53:51] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) (owner: 10Jdlrobson)
[17:01:32] <wikibugs>	 (03PS4) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862)
[17:43:10] <wikibugs>	 (03PS1) 10Ejegg: Update composer.lock for new SmashPig [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1020878
[17:43:14] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Update composer.lock for new SmashPig [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1020878 (owner: 10Ejegg)
[17:47:47] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Port Import SearchKit improvements [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019954 (https://phabricator.wikimedia.org/T360137) (owner: 10Eileen)
[17:48:32] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Remove call to get variable that is unused [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020345 (owner: 10Eileen)
[17:51:47] <wikibugs>	 (03Merged) 10jenkins-bot: Update composer.lock for new SmashPig [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1020878 (owner: 10Ejegg)
[18:05:34] <wikibugs>	 (03Merged) 10jenkins-bot: Port Import SearchKit improvements [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019954 (https://phabricator.wikimedia.org/T360137) (owner: 10Eileen)
[18:08:38] <wikibugs>	 (03Merged) 10jenkins-bot: Remove call to get variable that is unused [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020345 (owner: 10Eileen)
[18:56:13] <ejegg>	 !log payments-wiki upgraded from 72e3bf19 to fb0367a4
[18:56:16] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[18:57:39] <ejegg>	 hmmm, looks like it's still working
[18:58:06] <ejegg>	 a lot less raw request data in the logs
[19:03:40] <eileen>	 thanks for merging thos damilare 
[19:03:52] <damilare>	 np
[19:06:26] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1020902
[19:07:53] <wikibugs>	 06Fundraising-Backlog, 07Epic, 10MW-1.42-notes (1.42.0-wmf.25; 2024-04-02): Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9724055 (10Pcoombe)
[19:27:18] <wikibugs>	 06Fundraising-Backlog, 10FR-donorservices: Civi: add new data type to Forget Me button - https://phabricator.wikimedia.org/T362821 (10MBeat33) 03NEW
[19:30:06] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1020902 (owner: 10Eileen)
[19:31:37] <wikibugs>	 (03PS2) 10Eileen: Clean up Adyen Audit to use new helpers, purgeable contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020475
[19:35:24] <wikibugs>	 (03PS4) 10Eileen: Move another test to import class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020392
[19:39:42] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Stop enabling remaining queue2civicrm drush modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018390 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen)
[19:46:57] <eileen>	 !log civicrm upgraded from fdd12ed1 to 28adb4da
[19:47:01] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[19:50:26] <wikibugs>	 (03PS1) 10Eileen: Remove thank you test form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020914
[19:59:20] <wikibugs>	 (03Merged) 10jenkins-bot: Stop enabling remaining queue2civicrm drush modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1018390 (https://phabricator.wikimedia.org/T357470) (owner: 10Eileen)
[20:03:10] <wikibugs>	 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9724239 (10Eileenmcnaughton) a:03Eileenmcnaughton @MDemosWMF  - there is now an editable field on https://civicrm.wikimedia.org/civicrm/imports/my-listing to...
[20:09:38] <wikibugs>	 (03PS1) 10Eileen: Remove more disabled queue modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020915 (https://phabricator.wikimedia.org/T270672)
[20:15:46] <wikibugs>	 (03PS1) 10Eileen: Remove queue2civicrm config form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020916 (https://phabricator.wikimedia.org/T270672)
[20:15:47] <wikibugs>	 (03PS1) 10Eileen: Remove some now-unused test data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020917 (https://phabricator.wikimedia.org/T270672)
[20:27:03] <eileen>	 cstone: so this did pass when re-based out - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1020475 so that't something (although the code to delete mouse@wikimedia.org is in another patch)
[20:27:14] <ejegg>	 ohh cstone all the 'donations queued by processor (per run)' stats are gone too
[20:27:28] <ejegg>	 right, it was the same place that the average import times were being written
[20:28:03] <wikibugs>	 (03PS3) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401
[20:28:25] <ejegg>	 dang, i was going to make sure there was a comparable paypal donation rate before and after that deploy
[20:30:13] <wikibugs>	 (03PS2) 10Eileen: Remove thank you test form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020914
[20:30:22] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Remove thank you test form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020914 (owner: 10Eileen)
[20:30:59] <ejegg>	 hah, I guess that's nice. It still shows Eileen as the doer of the patch in gerrit after I rebase it now
[20:31:16] <eileen>	 oh has that changed?
[20:31:44] <ejegg>	 eileen: the rebase dialog also added some 'rebase on behalf of eileen' text
[20:31:52] <eileen>	 oh cool
[20:32:02] <eileen>	 I was just looking at that donation stat stuff - it's basically the only code left in queue2civicrm now
[20:32:10] <eileen>	 but it hurt my brain
[20:32:57] <ejegg>	 fr-tech the payments-paypal logs no longer have the raw response from paypal since that deploy. I'm thinking I should add that back
[20:33:07] <wikibugs>	 (03PS4) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401
[20:33:59] <ejegg>	 eileen: ah yeah, there are a couple of stats-counting classes, right? One older but maybe simpler and then jgleeson|away's library which is very generalized
[20:34:05] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Remove some now-unused test data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020917 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen)
[20:34:08] <wikibugs>	 (03PS4) 10Eileen: Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404
[20:34:36] <eileen>	 yeah & I think the older one does a couple of extra things - which is why we still have it huh?
[20:36:10] <eileen>	 I suppose one way or another it needs to move to WMFQueue.consume() - which might mean we get more counting. That function might not need to call anything external to track stuff though cos it's really one function with a big loop
[20:39:10] <wikibugs>	 (03CR) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401 (owner: 10Eileen)
[20:39:47] <eileen>	 I feel like this would be the perfect place to describe what UPI is ... but I've forgotten again https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1020401/4/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/WMFQueueMessage/DonationMessage.php
[20:42:57] <wikibugs>	 (03PS5) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401
[20:46:20] <ejegg>	 UPI is a bank transfer standard for India
[20:46:26] <ejegg>	 oops XenoRyet maybe I was already?
[20:46:31] <ejegg>	 on the invite that is
[20:46:52] <XenoRyet>	 Yea, looks like it.  So all good then.
[20:49:01] <wikibugs>	 (03Merged) 10jenkins-bot: Remove thank you test form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020914 (owner: 10Eileen)
[20:50:02] <wikibugs>	 (03PS6) 10Eileen: Move the responsibility for updating the status, sched date for recurring payments to the contribution handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401
[20:54:18] <wikibugs>	 (03PS5) 10Eileen: Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404
[20:54:27] <wikibugs>	 (03PS3) 10Eileen: Fold location update back into the last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020405
[21:58:09] <eileen>	 So more questions - there is code in WMFContact::save() that I think exists only for the offline2civicrm legacy imports - ie handling for
[21:58:09] <eileen>	 name_prefix 
[21:58:09] <eileen>	 name_suffix
[21:58:09] <eileen>	 contact_groups
[21:58:10] <eileen>	 do_not_solicit
[21:58:10] <eileen>	 'org_contact_name'
[21:58:11] <eileen>	 org_contact_title (plus a few similar)
[21:58:11] <eileen>	 contact_tags
[21:58:12] <eileen>	 + handling for boolean fields to be 'Y'
[22:22:33] <eileen>	 cstone: if you are able to +2 some of the smaller test ones it might help a bit on conflicts - ie https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1020391/3
[22:23:26] <cstone>	 sure eileen i can start on it I have to go pick up bunbun soon but should be able to do a couple now and get back to it later
[22:23:51] <eileen>	 cstone: yeah - some of them should be pretty easy - not all of course
[22:23:54] <cstone>	 ooh eileen I think that was the code I found to add in the phonetic name
[22:24:07] <cstone>	 or maybe not
[22:24:07] <cstone>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1019141
[22:24:13] <cstone>	 or where should this go if this is not the place
[22:25:31] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Migrate another test to extension land [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020391 (owner: 10Eileen)
[22:26:00] <eileen>	 cstone: well it's not not the place for that sort of thing -  although I have some thoughts for where that might go - but my focus at the moment is to get the code that only exists for the legacy offline2civicrm out of the code that exists for the our queue messages - cos it's adding loads of complexity & when we delete offline2civicrm we don't want to leave complexity behind
[22:26:47] <eileen>	 so 'do_not_solicit' (for example) only comes in from offline2civicrm I'm pretty sure
[22:28:17] <eileen>	 -at the moment the Create path in Save uses apiv3 & update uses apiv4 - so I'm thking that I want both on apiv4 but I feel like making offline2civicrm do its own contact updates first might cut out about half the code
[22:31:39] <eileen>	 once they are both on apiv4 they can come out of message normalize on apiv4 keys & be passed straight through
[22:45:37] <wikibugs>	 (03Merged) 10jenkins-bot: Migrate another test to extension land [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020391 (owner: 10Eileen)
[22:47:00] <eileen>	 I'm tempted to rename classes like this \Civi\WMFHelper\ContributionSoft to
[22:47:00] <eileen>	 \Civi\WMFHelper\ContributionSoftHelper
[22:47:42] <eileen>	 Helper looks redundant when you see if like that but when you use use it gets messy with it looking like \Civi\Api4\ContributionSoft
[22:49:59] <wikibugs>	 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9724705 (10Eileenmcnaughton) a:03Eileenmcnaughton
[23:16:43] <wikibugs>	 (03CR) 10Eileen: [C:03+2] "We discussed this today and Dami identified that he needed to add some more code into the FundraiseupAuditProcessor to redirect the messag" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin)
[23:19:41] <wikibugs>	 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review: Update contact on CiviCRM when FRUP donor updates their email through donor portal - https://phabricator.wikimedia.org/T349663#9724749 (10Eileenmcnaughton) @Damilare after thinking about our discussion today I decided to merge your patc...
[23:35:30] <wikibugs>	 (03Merged) 10jenkins-bot: Fundraiseup audit import for recur plan change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1015383 (https://phabricator.wikimedia.org/T349663) (owner: 10Damilare Adedoyin)
[23:37:22] <wikibugs>	 (03PS1) 10Eileen: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020952 (https://phabricator.wikimedia.org/T360150)
[23:37:22] <wikibugs>	 (03PS1) 10Eileen: Only set no-thank-you reason for matchig gift or workplace giving [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020953 (https://phabricator.wikimedia.org/T360150)
[23:41:01] <wikibugs>	 (03Merged) 10jenkins-bot: Minor follow ups on Previous Fundraise up patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020416 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen)
[23:52:15] <wikibugs>	 (03PS1) 10Eileen: Fix composer-in-a-mess [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020956
[23:52:51] <eileen>	 that composer patch ^^ needs to be merged before our next deploy or something will go wrong .....