[09:08:41] looks like dlocal was down a few minutes ago with the timeouts failmail [09:09:22] not sure we have banners but would keep watch for new incidents [11:57:52] damilare: some of those failures look a bit fishy [11:58:20] pretty much all of them look like fraud attempts [11:58:52] hmm although one or two look ok [12:01:11] eileen: :) [12:49:15] ahh, those werent UPI failures? [12:49:45] there's a few MX ones [12:49:48] i see prenotify true in one failmail [12:49:57] oh i missed those [12:51:37] yep [12:53:46] I really like the UX of this years annual report https://wikimediafoundation.org/news/reports/2022-2023-annual-report/ [12:58:14] wow, the endowment made £10.7mln investment returns this year! That's pretty for good for what I imagine is a low risk profile. [13:01:43] huh, Elon Musk donated $2mln this year. I wasn't expecting that [13:02:28] lots of glitz on the Musk Foundation website https://www.muskfoundation.org/ [13:06:29] wow who needs css and images [13:06:37] right lol? [13:06:53] I'm guessing he did that himself [13:07:22] based on the invalid html :S [13:07:22] probably, else I'm available for this kind of contracts [13:07:26] ha [13:10:05] tbf some websites need to take inspiration from this. [14:15:04] (03PS1) 10Thiemo Kreuz (WMDE): Replace a lot of more trivial Xml::… calls with Html::… [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1021962 (https://phabricator.wikimedia.org/T341775) [14:18:15] (03CR) 10CI reject: [V:04-1] Replace a lot of more trivial Xml::… calls with Html::… [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1021962 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [14:23:34] (03PS3) 10Damilare Adedoyin: Use helper to call round, exchange convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020968 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [14:23:34] (03PS2) 10Damilare Adedoyin: Switch FundraiseUp Audit to use new helpers for processing messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020975 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [14:43:26] (03PS2) 10Thiemo Kreuz (WMDE): Replace a lot of more trivial Xml::… calls with Html::… [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1021962 (https://phabricator.wikimedia.org/T341775) [14:53:50] (03PS2) 10Eileen: Remove queue2civicrm config form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020916 (https://phabricator.wikimedia.org/T270672) [14:54:29] (03CR) 10Ejegg: [C:03+2] "Breaks queue2civicrm_batch_process, but that's on its way out anyway. Confirmed no longer used in production." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020916 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [15:04:19] (03CR) 10Ejegg: [C:04-1] "There's another tricky edge case this opens up. At least once, DR has canceled an adyen recurring while the recurring charge job was proce" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401 (owner: 10Eileen) [15:15:31] (03Merged) 10jenkins-bot: Remove queue2civicrm config form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020916 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [15:17:10] I saw "The Giuliani Family Foundation" and worried for a second ;) [15:17:18] (it's not him) [15:17:22] (03CR) 10Damilare Adedoyin: [C:03+2] Switch FundraiseUp Audit to use new helpers for processing messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020975 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [15:17:55] (03PS4) 10Damilare Adedoyin: Use helper to call round, exchange convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020968 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [15:38:26] (03CR) 10Damilare Adedoyin: [C:03+2] Use helper to call round, exchange convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020968 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [15:38:35] (03PS3) 10Damilare Adedoyin: Switch FundraiseUp Audit to use new helpers for processing messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020975 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [15:39:13] (03PS2) 10Eileen: Confirm, using test, that code we think can go can.... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020463 [15:39:27] (03CR) 10Ejegg: [C:03+2] Confirm, using test, that code we think can go can.... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020463 (owner: 10Eileen) [15:41:34] 06Fundraising-Backlog: Enable Amazon Pay through Adyen (via Gr4vy?) - https://phabricator.wikimedia.org/T362991 (10EMartin) 03NEW [15:46:10] PROBLEM - check_memory on fran1001 is CRITICAL: CRIT Memory 98% used. Largest process: python3 (3057382) = 90.4% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [15:52:56] (03PS1) 10Jgleeson: Update Gr4vy POC to refer to new wmf instance [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1022051 [15:53:38] (03PS2) 10Jgleeson: Update Gr4vy POC to refer to new wmf instance [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1022051 [15:56:12] RECOVERY - check_memory on fran1001 is OK: OK Memory 88% used https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [16:03:28] (03Merged) 10jenkins-bot: Use helper to call round, exchange convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020968 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [16:03:29] (03Merged) 10jenkins-bot: Confirm, using test, that code we think can go can.... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020463 (owner: 10Eileen) [16:03:55] (03PS3) 10Eileen: Prepare messageImport test for move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020454 [16:04:49] (03CR) 10Ejegg: [C:03+2] Prepare messageImport test for move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020454 (owner: 10Eileen) [16:13:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Donations QC not sending messages to damaged on deadlocks - https://phabricator.wikimedia.org/T362997 (10Ejegg) 03NEW [16:13:03] 06Fundraising-Backlog: Add Amazon Pay through Adyen - https://phabricator.wikimedia.org/T362998 (10Cstone) 03NEW [16:20:23] (03PS3) 10Jgleeson: Update Gr4vy POC to refer to new wmf instance [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1022051 [16:29:40] (03Merged) 10jenkins-bot: Prepare messageImport test for move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020454 (owner: 10Eileen) [17:51:05] (03PS3) 10Eileen: Specify & enforce our trxn_type list up front [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 [17:51:09] (03CR) 10Ejegg: [C:03+2] Specify & enforce our trxn_type list up front [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 (owner: 10Eileen) [18:00:33] (03PS6) 10Eileen: Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 [18:02:36] (03CR) 10Ejegg: [C:03+2] "Hooray for getting rid of those setIsPayment calls!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [18:03:29] (03CR) 10CI reject: [V:04-1] Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [18:03:41] oh hmm [18:03:44] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9730389 (10MDemosWMF) That's great! So this will apply to any errors involved with that import, correct? [18:04:10] oh, cloning from github failing [18:04:26] (03CR) 10Ejegg: Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [18:04:32] (03CR) 10Ejegg: [C:03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [18:08:54] (03PS2) 10Eileen: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020952 (https://phabricator.wikimedia.org/T360150) [18:09:01] (03CR) 10Ejegg: [C:03+2] Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020952 (https://phabricator.wikimedia.org/T360150) (owner: 10Eileen) [18:12:06] (03Merged) 10jenkins-bot: Specify & enforce our trxn_type list up front [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020382 (owner: 10Eileen) [18:18:14] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Matching EFT import error - but not duplicate - https://phabricator.wikimedia.org/T358143#9730483 (10MDemosWMF) @Eileenmcnaughton Got it! These gifts are being pulled form different portals which have their own ID system - since we... [18:23:15] (03Merged) 10jenkins-bot: Simplify isPayment() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1019144 (owner: 10Eileen) [18:26:40] (03Merged) 10jenkins-bot: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020952 (https://phabricator.wikimedia.org/T360150) (owner: 10Eileen) [18:26:51] 06Fundraising-Backlog, 10FR-donorservices: Merging oddity - https://phabricator.wikimedia.org/T362928#9730523 (10SHust) **Update:** Another odd behavior has come up with a merge 'Could Not Find Valid Value for CID'. On the bright side, the merge happened as anticipated, CID 63239146, and in case this helps, af... [18:29:10] 06Fundraising-Backlog: Civi batch data entry tool build out - https://phabricator.wikimedia.org/T360139#9730524 (10MDemosWMF) @Eileenmcnaughton I am on staging in the batch data entry page, but I'm not seeing the new field when I start a new batch for entry - can you share a screenshot of what I'm looking for? T... [18:38:41] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9730569 (10MDemosWMF) Thanks @Eileenmcnaughton ! Just to confirm: - Anything with soft credit type of workplace giving or mat... [21:22:40] (03PS2) 10Eileen: Re-use McTest to leverage cleanup routine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020473 [21:22:46] (03CR) 10Ejegg: [C:03+2] Re-use McTest to leverage cleanup routine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020473 (owner: 10Eileen) [21:23:47] (03PS11) 10Eileen: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [21:25:39] (03CR) 10Eileen: "ejegg so if we check the existing status is not cancelled that would be correct for everything except paypal?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020401 (owner: 10Eileen) [21:26:43] (03PS2) 10Eileen: Remove some now-unused test data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020917 (https://phabricator.wikimedia.org/T270672) [21:27:30] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020975 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [21:30:11] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Matching EFT import error - but not duplicate - https://phabricator.wikimedia.org/T358143#9730852 (10Eileenmcnaughton) @MDemosWMF So the transaction ID needs to be unique per gateway - but if you don't pass in a gateway the gateway... [21:31:19] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9730854 (10Eileenmcnaughton) @MDemosWMF Yes - the import data is removed at or around that expires date - so if you change the date the error data is kept unti... [21:42:30] (03Merged) 10jenkins-bot: Re-use McTest to leverage cleanup routine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020473 (owner: 10Eileen) [21:43:01] (03PS2) 10Eileen: Remove notes creation out of main insert handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020476 [21:43:20] (03PS2) 10Eileen: Consolidate calls to message_import within Benevity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020478 [21:46:23] (03PS4) 10Damilare Adedoyin: Switch FundraiseUp Audit to use new helpers for processing messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020975 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [21:48:41] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Matching EFT import error - but not duplicate - https://phabricator.wikimedia.org/T358143#9730876 (10MDemosWMF) @Eileenmcnaughton I thought the gateway was always 'matching gift' since it's a matching gift import? Is there any iss... [21:49:02] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Import error pages expiring - https://phabricator.wikimedia.org/T360137#9730877 (10MDemosWMF) Great! Thanks for confirming! [21:50:27] (03CR) 10CI reject: [V:04-1] Remove some now-unused test data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020917 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [21:50:53] (03PS2) 10Eileen: WIP - test using donor advised field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1021084 (https://phabricator.wikimedia.org/T360139) [21:54:00] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Matching EFT import error - but not duplicate - https://phabricator.wikimedia.org/T358143#9730887 (10Eileenmcnaughton) @MDemosWMF the gateway is the default - but you can override it if you map the field. I think the only thing yo... [21:56:54] 06Fundraising-Backlog: Civi batch data entry tool build out - https://phabricator.wikimedia.org/T360139#9730890 (10Eileenmcnaughton) It looks like I hadn't deployed the field yet - it should be there now {F47595809} It probably still needs to be added to the fields here https://civicrm.frdev.wikimedia.org/civi... [21:58:46] (03PS2) 10Eileen: Only set no-thank-you reason for matchig gift or workplace giving [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020953 (https://phabricator.wikimedia.org/T360150) [22:00:09] 03Fundraising Sprint: gone(), 06Fundraising-Backlog, 13Patch-For-Review, 07Unplanned-Sprint-Work: Mapping Import Project - Engage import - https://phabricator.wikimedia.org/T360150#9730893 (10Eileenmcnaughton) This code is on staging now - obviously emails don't go out from staging so you would be checking... [22:03:23] (03CR) 10Eileen: [V:03+2] "Gerrit is being weird - comments show this +2 added but it's not there" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020975 (https://phabricator.wikimedia.org/T349663) (owner: 10Eileen) [22:03:43] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020917 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [22:04:35] (03PS6) 10Eileen: Establish Contact Update behaviour in test, remove extraneous code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020404 [22:07:37] (03PS2) 10Eileen: Separate import code from main message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020479 [22:18:06] (03PS1) 10Eileen: Update AmazonAuditTest to use new helpers, tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022205 [22:27:13] (03CR) 10CI reject: [V:04-1] Separate import code from main message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020479 (owner: 10Eileen) [22:30:17] (03PS1) 10Eileen: Mous-ify Dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022212 [22:31:33] (03CR) 10CI reject: [V:04-1] Update AmazonAuditTest to use new helpers, tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022205 (owner: 10Eileen) [22:33:29] phew, zuul is screwy today, huh? [22:42:03] (03CR) 10CI reject: [V:04-1] Mous-ify Dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022212 (owner: 10Eileen) [22:53:13] yeah really screwy [22:54:49] (03PS2) 10Eileen: Mous-ify Dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022212 [22:56:50] (03PS3) 10Eileen: Mous-ify Dlocal audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022212 [23:11:26] (03PS1) 10Eileen: Update IngenicoAuditTest to use new helpers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022242 [23:19:47] (03PS2) 10Jdlrobson: Log central notice banner errors to their own channel [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) [23:22:42] (03CR) 10CI reject: [V:04-1] Log central notice banner errors to their own channel [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) (owner: 10Jdlrobson) [23:23:29] (03PS1) 10Eileen: Update AddressImportTest, prior to move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022254 [23:26:57] (03CR) 10Ejegg: [C:03+2] "Thanks! The readability/maintainability improvement in CentralNoticeLogs is especially nice." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1021962 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [23:27:16] (03PS3) 10Jdlrobson: Log central notice banner errors to their own channel [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) [23:30:17] (03CR) 10CI reject: [V:04-1] Log central notice banner errors to their own channel [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) (owner: 10Jdlrobson) [23:31:04] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9731032 (10Jdlrobson) @AKanji-WMF could somebody in fundrai... [23:33:29] (03Merged) 10jenkins-bot: Replace a lot of more trivial Xml::… calls with Html::… [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1021962 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [23:58:22] (03PS1) 10Eileen: Cleanup Recurring Test preparatory to move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022275