[01:56:11] thanks eileen ! [02:01:43] no worries ejegg|away [02:14:58] (03PS4) 10Eileen: Move over Adyen audit tests to settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023133 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [02:15:42] (03CR) 10Eileen: [C:03+2] "I put back one variable_set to get this to pass - it will need to be removed but I think doing that as a follow up is easier" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023133 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [02:16:21] (03CR) 10Eileen: [C:03+2] "oh - the reason we got away without doing that before is it leaks through from the other tests so it's set in Amazon so braintree didn't n" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023133 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [02:35:03] (03Merged) 10jenkins-bot: Move over Adyen audit tests to settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023133 (https://phabricator.wikimedia.org/T270675) (owner: 10Cstone) [04:30:40] Ooooh Eileen it was really melting my brain trying to figure out what was going on there [06:15:13] cstone: yeah it was a bit gnarly! When I tested braintree locally to see why it worked ... it didn't & then I figured out the alpha-order connection [13:12:17] (03PS1) 10Thiemo Kreuz (WMDE): Replace all Xml::tags calls with Html::rawElement [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1024664 (https://phabricator.wikimedia.org/T341775) [13:14:19] (03CR) 10CI reject: [V:04-1] Replace all Xml::tags calls with Html::rawElement [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1024664 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [13:27:57] 06Fundraising-Backlog, 10FR-donorservices: Unusual Inclusion of Non-3C Donors in Springlish Segmentation - https://phabricator.wikimedia.org/T363498#9747914 (10SHust) Adding another CID 59489888 --> This donor has always been in Ireland, how would he end up in the Springlish (US, UK, and CA) segmentation list? [14:01:31] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove unused import code from main codebase - https://phabricator.wikimedia.org/T363524#9748013 (10MDemosWMF) @Eileenmcnaughton The only one that I am fami... [15:50:55] (03PS5) 10Jgleeson: Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520) [15:52:42] (03CR) 10CI reject: [V:04-1] Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520) (owner: 10Jgleeson) [18:31:39] (03PS2) 10Jforrester: Replace all Xml::tags calls with Html::rawElement [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1024664 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [18:36:35] i guess we should retry when we get a 503 required resource temporarily unavailable [18:36:38] from adyen [18:36:39] ? [18:36:45] (03CR) 10Jforrester: [C:03+2] Replace all Xml::tags calls with Html::rawElement [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1024664 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [18:40:47] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Retry (with idempotency ID) when Adyen returns error code 703 - https://phabricator.wikimedia.org/T363603 (10Ejegg) 03NEW [18:44:54] (03PS3) 10Eileen: Move function in legacy code with only one caller to that caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020346 [18:44:59] (03CR) 10Ejegg: [C:03+2] Move function in legacy code with only one caller to that caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020346 (owner: 10Eileen) [19:00:32] (03Merged) 10jenkins-bot: Replace all Xml::tags calls with Html::rawElement [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1024664 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [19:05:27] (03Merged) 10jenkins-bot: Move function in legacy code with only one caller to that caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020346 (owner: 10Eileen) [19:14:47] sounds good ejegg [19:57:38] (03PS14) 10Eileen: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) [19:57:46] (03CR) 10Ejegg: [C:03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:22:45] (03Merged) 10jenkins-bot: Move auto-rescue look ups to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1016908 (https://phabricator.wikimedia.org/T357469) (owner: 10Eileen) [20:23:20] (03PS3) 10Eileen: Remove code for contact tag handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023565 (https://phabricator.wikimedia.org/T286225) [20:24:13] (03CR) 10Ejegg: [C:03+2] "Verified, looks like we're not using this in the queue consumer any more." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023565 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [20:44:36] (03Merged) 10jenkins-bot: Remove code for contact tag handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023565 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [21:07:10] (03PS7) 10Eileen: Consolidate calls to message_import within Benevity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020478 (https://phabricator.wikimedia.org/T240581) [21:07:10] (03PS8) 10Eileen: Separate import code from main message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020479 (https://phabricator.wikimedia.org/T240581) [21:07:11] (03PS10) 10Eileen: Get rid of name_prefix & name_suffix in favour of the api fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022309 (https://phabricator.wikimedia.org/T240581) [21:07:11] (03PS7) 10Eileen: Move clean up of incoming strings to the Normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022492 (https://phabricator.wikimedia.org/T357471) [21:07:12] (03PS2) 10Eileen: Clean up handling of fiscal_number / legal_identifier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023564 (https://phabricator.wikimedia.org/T357471) [21:07:30] (03PS6) 10Eileen: Fold location update back into the last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020405 [21:11:39] (03PS1) 10Eileen: Remove handling for contact_groups & relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1024809 (https://phabricator.wikimedia.org/T363524) [21:14:20] ejegg: looks like you've been doing a bit of review - thanks! [21:14:56] I think Melanie is quite keen to 'test in production' on this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1020953 [21:27:32] (03CR) 10CI reject: [V:04-1] Fold location update back into the last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020405 (owner: 10Eileen) [21:47:51] ok eileen, lemme read that phab [21:52:58] yeah, seems like the right rule! [22:39:26] (03PS3) 10Eileen: Only set no-thank-you reason for matchig gift or workplace giving [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020953 (https://phabricator.wikimedia.org/T360150) [22:40:58] (03CR) 10Ejegg: [C:03+2] "Logic looks solid, some good lil readability improvements too! Could clean up a few unused use statements in a follow-on (besides the ones" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020953 (https://phabricator.wikimedia.org/T360150) (owner: 10Eileen) [23:00:29] (03Merged) 10jenkins-bot: Only set no-thank-you reason for matchig gift or workplace giving [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020953 (https://phabricator.wikimedia.org/T360150) (owner: 10Eileen)