[00:13:22] 06Fundraising-Backlog: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#9762645 (10Eileenmcnaughton) [00:16:55] (03CR) 10CI reject: [V:04-1] WIP - move tests to DonationQueueTest, preparatory to adding [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026186 (owner: 10Eileen) [01:20:01] looks like that deploy stopped the failmail eileen ? [01:23:23] oh, or are the failmails from isReHomingRequired TypeErrors? [01:24:32] ah that seems to be the case [01:26:30] huh, that typehint has been there since 2020 [01:28:43] and the calling fn resolveLocationsPreferringContactToRemove has been the same since 2021 [01:29:01] a change up in MergeHandler maybe? [01:29:13] It's working with that crazy nested array [01:30:30] ah those previous Undefined offset warnings are probably good clues to follow [01:30:50] Undefined offset: 0 Merger.php:3019 [01:30:54] Undefined offset: 1 MergeHandler.php:780 [01:30:59] Undefined offset: 1 PreferredContactLocationResolver.php:123 [01:31:33] Too bad it doesn't say exactly which pair it's deduping when it crashes [01:33:05] ok so in MergeHandler.php:780 it's trying to get the mainContactEmail and the 1 is the $emailBlockNumber [01:38:35] eileen: how about we make the batch size tiny, like just a few, so we can figure out which contacts are causing the failmails? [01:42:40] ok, I just changed the batch size from 6000 to 6 [01:43:11] If we don't get any failmail overnight we can push it back up a bit [01:51:42] oops, i hadn't rsynced. just did that [01:54:35] (03PS2) 10Eileen: Remove handling for contact_groups & relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1024809 (https://phabricator.wikimedia.org/T363524) [01:55:10] (03CR) 10Ejegg: [C:03+2] "Chipping away at it! I'm happy to see this go if the people doing the imports say they don't need it." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1024809 (https://phabricator.wikimedia.org/T363524) (owner: 10Eileen) [02:14:53] ejegg: it's specific contacts that cause it - havne't gotten to the botto of it [02:15:59] eileen: I realize we could do the bifurcation search by alternating calls to vset and to the merger on the command line with smaller and smaller batches [02:16:19] just searching within one of the batches of 6000 that had the error [02:16:39] ejegg: yeah - I did get there & found one - but another has popped up - I'll dig again but in 30 mins [02:16:45] but it seems like a lot of work to me at this time of night so I just made the tiny batches to see if we get lucky before i wake up [02:16:52] oho, what CID? [02:17:07] json '{"to_keep_id":135090,"to_remove_id":299459,"mode":"safe"}' [02:18:36] huh, just one email on the to_keep, and it's marked primary [02:19:25] to_remove has 3, and the one marked primary is not the same as the to_keep's email [02:19:37] (03Merged) 10jenkins-bot: Remove handling for contact_groups & relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1024809 (https://phabricator.wikimedia.org/T363524) (owner: 10Eileen) [02:20:40] eh, I need to head to bed. have a good rest of your day eileen ! [02:56:16] (03PS3) 10Eileen: Rename WMF folder to match capitalization on similar folders [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023561 [02:57:53] (03PS14) 10Eileen: Get rid of name_prefix & name_suffix in favour of the api fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022309 (https://phabricator.wikimedia.org/T240581) [03:20:38] (03PS11) 10Eileen: Move clean up of incoming strings to the Normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022492 (https://phabricator.wikimedia.org/T357471) [03:20:38] (03PS6) 10Eileen: Clean up handling of fiscal_number / legal_identifier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023564 (https://phabricator.wikimedia.org/T357471) [03:20:38] (03PS3) 10Eileen: Add saving of phonetic fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026183 (https://phabricator.wikimedia.org/T362195) [03:20:39] (03PS5) 10Eileen: Move tests to DonationQueueTest, preparatory to adding phonetic name test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026186 [03:29:45] (03PS6) 10Eileen: Move tests to DonationQueueTest, preparatory to adding phonetic name test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026186 [03:30:09] (03PS7) 10Eileen: Move tests to DonationQueueTest, preparatory to adding phonetic name test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026186 [03:37:17] (03PS1) 10Eileen: Move statistics tests over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026236 [03:39:58] (03CR) 10CI reject: [V:04-1] Move tests to DonationQueueTest, preparatory to adding phonetic name test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026186 (owner: 10Eileen) [04:30:24] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: How to deal with clearly bad email addresses in Civi - https://phabricator.wikimedia.org/T363946#9762774 (10Eileenmcnaughton) This is probably a bit of a question for @SHust - I think in the past @MBeat33 was in favor of merging them into contact 72? [05:38:04] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Analytics request for 5 years of donor segment & status fields - https://phabricator.wikimedia.org/T344215#9762834 (10Eileenmcnaughton) @JMando FYI I'm looking at planning for our July 1 handling of the segmentation / status fields at the moment - my curr... [05:40:05] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9762835 (10Eileenmcnaughton) @KHaggard this is something I'm worki... [05:41:17] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9762836 (10Eileenmcnaughton) [05:41:18] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Analytics request for 5 years of donor segment & status fields - https://phabricator.wikimedia.org/T344215#9762837 (10Eileenmcnaughton) [05:47:34] 06Fundraising-Backlog, 10FR-Civi-Dedupe: Fail mail on dedupe - https://phabricator.wikimedia.org/T363965 (10Eileenmcnaughton) 03NEW [05:51:29] (03Abandoned) 10Eileen: WIP debug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025880 (owner: 10Eileen) [09:08:33] 06Fundraising-Backlog, 10FR-Civi-Dedupe: Dedupe failure on typing - https://phabricator.wikimedia.org/T363962#9763178 (10Peachey88) [13:17:28] (03PS2) 10Ejegg: Move exchange rates tests to the Civi extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023141 (https://phabricator.wikimedia.org/T270666) (owner: 10Cstone) [13:19:08] 06Fundraising-Backlog: Add expiration period of 12 months to the 'Recurring Upgrade Declined' activity type in Civi - https://phabricator.wikimedia.org/T363433#9763810 (10MSuijkerbuijk_WMF) [13:26:45] (03PS3) 10Ejegg: Move exchange rates tests to the Civi extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023141 (https://phabricator.wikimedia.org/T270666) (owner: 10Cstone) [14:03:31] (03PS1) 10Ejegg: Move files from exchange_rates/retrievers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026570 (https://phabricator.wikimedia.org/T270666) [14:07:33] 06Fundraising-Backlog, 10FR-AutoTY-Email, 10FR-France: French Thank You email - https://phabricator.wikimedia.org/T285209#9764023 (10AKanji-WMF) [14:09:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 10FR-France: Card type not shown on Civi for French donations - https://phabricator.wikimedia.org/T360503#9764025 (10AKanji-WMF) [14:21:24] (03PS1) 10Ejegg: Small code reformat for exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026579 (https://phabricator.wikimedia.org/T270666) [14:23:48] (03PS2) 10Ejegg: Small code reformat for exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026579 (https://phabricator.wikimedia.org/T270666) [14:35:04] 14Fundraising Sprint Judgement Suspenders, 14Fundraising Sprint Kickstopper, 14Fundraising Sprint Loose Lego Carpeting, 06Fundraising-Backlog, and 2 others: Spike: Investigate cause of large banner impression surge in NL and ES fr campaigns - https://phabricator.wikimedia.org/T164996#9764098 (10AKanji-W... [14:48:33] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9764136 (10KHaggard) Got it, thanks @Eileenmcnaughton Do you have... [15:35:37] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Docker: Docker wishlist - git config - https://phabricator.wikimedia.org/T354062#9764300 (10jgleeson) @Eileenmcnaughton I feel like we figured this one out with a cli command? [15:36:45] 06Fundraising-Backlog, 10FR-Docker: Fundraising-dev: Upgrade Node in fundraising-bullseye-php74 docker image - https://phabricator.wikimedia.org/T351804#9764305 (10jgleeson) 05Open→03Resolved a:03jgleeson [15:38:34] 06Fundraising-Backlog, 10FR-Docker: Docker dev setup: Be able to skip pulling down the private config repo - https://phabricator.wikimedia.org/T328371#9764308 (10jgleeson) 05Open→03Resolved a:03jgleeson [15:40:09] 06Fundraising-Backlog, 10FR-Docker: fundraising-dev: decouple application config '/config' from main docker stack project - https://phabricator.wikimedia.org/T327401#9764315 (10jgleeson) 05Open→03Resolved a:03jgleeson We can rebuild much quicker now so this isn't as much of a problem. [15:52:28] 06Fundraising-Backlog, 10FR-Docker: Docker: add links to other services to start page - https://phabricator.wikimedia.org/T326966#9764369 (10jgleeson) 05Open→03Resolved a:03jgleeson We now have `./setup.sh urls` which kidna does the same thing so I think we're good here. [15:57:52] 06Fundraising-Backlog, 10FR-Docker: [Bug] Docker dev setup: civibuild create wmff fails when wmff/vendor iexists - https://phabricator.wikimedia.org/T281647#9764383 (10jgleeson) 05Open→03Resolved a:03jgleeson [15:59:22] 06Fundraising-Backlog: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#9764385 (10bsisolak) So you will be moving to an non-email keyed database as yo are adding SMS/MMS to Acoustic. That won't change much about this project, bu... [16:02:01] 06Fundraising-Backlog, 10FR-Docker: Docker dev setup: replace setup.sh with something better - https://phabricator.wikimedia.org/T278728#9764394 (10jgleeson) 05Open→03Resolved We did this with [[ https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/953984 | fundraising-dev v2 ]]. [16:08:08] 06Fundraising-Backlog, 10FR-Docker: Fix Docker performance on Mac - https://phabricator.wikimedia.org/T274339#9764438 (10jgleeson) 05Open→03Resolved Installing on Mac is now pretty fast after we added a bunch of Mac optimisations in the new build scripts, e.g. It takes 5 minutes to install CiviCRM vs t... [16:50:05] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog: Enable Recurring Annual Donations - https://phabricator.wikimedia.org/T358914#9764608 (10Ejegg) Other work to do: Support annual donations in PayPal EC, update our logic that cancels active recurrings with no payments in 90 days, to ex... [16:56:26] 06Fundraising-Backlog, 10FR-Civi-Dedupe: Fail mail on dedupe - https://phabricator.wikimedia.org/T363965#9764654 (10AKanji-WMF) p:05Triage→03Medium [17:20:37] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add dropdown with standard reasons to refunded donation area. - https://phabricator.wikimedia.org/T125224#9764754 (10MBeat33) @Ejegg I've been thinking about how Poliane and I generally perform fraud refunds at the PSP consoles rather than directly in Civ... [17:22:02] ejegg|food: based on your comment on this older phab - is this resolved? https://phabricator.wikimedia.org/T313720 [17:22:19] we may be retesting this payment method for the france campaign [17:23:42] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: How to deal with clearly bad email addresses in Civi - https://phabricator.wikimedia.org/T363946#9764772 (10SHust) I'll include these unusual emails in the weekly admin deduplication task to prevent them from accumulating. However, there's an issue outlin... [17:50:01] anilk: hmmm, I guess maybe? [17:50:22] jgleeson|dinner wrote that ticket, maybe let's ask him if he considers it closeable [17:53:43] huh, that batch size setting doesn't seem to have shrunk the dedupe range like I expected it to [17:59:07] oh derp, did I screw up with the deploy? still shows --batch=6000 in the top line [18:00:53] weird, looks like it was all deployed [18:02:26] ohh, i was grepping for the same error I saw last night [18:02:39] and it was just coming up with the logs from last night [18:02:49] ok, so what are the newer errors? [18:03:37] right, this is a much smaller batch [18:03:47] TypeError: Return value of CRM_Deduper_BAO_MergeHandler::getAddressBlock() must be of the type array, null returned in CRM_Deduper_BAO_MergeHandler->getAddressBlock() [18:03:59] MergeHandler.php line 287 [18:04:17] somewhere from CID 180358 to 180366 [18:04:40] 10fundraising-tech-ops: Fundraising access request for jcraig - https://phabricator.wikimedia.org/T363949#9764909 (10Dwisehaupt) Sent details to jcraig on information needed to set up accounts. Once that is provided I'll move forward. [18:05:43] ok, so it's 180366 and 730314 [18:07:33] email looks totally standard [18:07:45] ah, there are 5 address rows between those two contacts [18:08:52] huh, but they look fine [18:09:15] each has 1 primary, with location_type_id 1 [18:43:43] anilk: that one does look closable now after ejegg's comment [18:44:11] gracias! [18:44:48] 06Fundraising-Backlog: Adyen Carte Bancaire transaction log weirdness - https://phabricator.wikimedia.org/T313720#9764991 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Resolving based on Ejegg's comment. [19:01:47] hmmm jgleeson a lot of the php8 warnings in Civi seem to be from Smarty 3 [19:01:57] I wonder if we'll be able to move to Smarty 4 [19:08:43] Here's eileen's upstream issue to go to Smarty 5: https://lab.civicrm.org/dev/core/-/issues/4955 [19:10:13] oho, it references a pull request from feb 6 that adds smarty 4 to packages [19:10:53] so we could maybe get rid of most of those civi warnings you see on 8.2 if we just do a minor civi version updgrade and enable smarty4 [19:13:06] oh right [19:18:40] 10fundraising-tech-ops: Fundraising access request for PPenloglou - https://phabricator.wikimedia.org/T363936#9765062 (10spatton) [19:20:40] 06Fundraising-Backlog, 10fundraising-tech-ops: Staging - issues I hit today - https://phabricator.wikimedia.org/T362842#9765081 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Received confirmation from eileen that the permissions changes worked. Closing this request and coworker portions can be done... [19:21:41] 06Fundraising-Backlog, 10FR-Civi-Dedupe: Fail mail on dedupe - https://phabricator.wikimedia.org/T363965#9765086 (10Ejegg) There's another class of failmail coming in, e.g. contacts 730314 and 180366: Undefined offset: 2 MergeHandler.php:891 Undefined offset: 2 MergeHandler.php... [19:22:48] I can't quite reproduce that error, so I'm just going to disable the dedupe job for now to keep doing sprint things [19:24:53] thanks for looking at it ejegg I can dig in too [19:25:04] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9765094 (10Dwisehaupt) Created ITS request for yubikey. [19:38:35] 06Fundraising-Backlog: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#9765161 (10Ejegg) @bsisolak we should figure out what else we need to change on the Civi side to accommodate that change. I guess we can stop deduping by ema... [20:04:01] 14Fundraising Sprint Pluto is still a planet, 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: implement IDEAL in new ingenico integration - https://phabricator.wikimedia.org/T201626#9765204 (10AKanji-WMF) 05Open→03Declined No longer applicable - resolving [20:04:49] fr-tech there are a couple tickets for the snooze feature ready for review: https://gerrit.wikimedia.org/r/q/topic:%22emailSnooze%22 [20:05:05] 06Fundraising-Backlog: iDEAL logo not ideally located - https://phabricator.wikimedia.org/T256078#9765209 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF This appears to be resolved in the current version of the form (cc: @Pcoombe) [20:05:25] lol nice ticket title [20:07:27] hah - I just got that now that you said it [20:24:00] 06Fundraising-Backlog: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#9765255 (10KHaggard) @ejegg Honestly, to me it's not super clear how that would work but I think it's possible to re-key the database with CID instead of em... [21:02:19] (03CR) 10DannyS712: [C:03+2] Migrate to IReadableDatabase::newSelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025863 (https://phabricator.wikimedia.org/T312369) (owner: 10Umherirrender) [21:04:11] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 06Fundraising-Backlog, 06Wikipedia-iOS-App-Backlog, 10Wikipedia-Android-App-Backlog (Android Release - FY2023-24): Standardize utm_source from app donations without a banner and clean up old data - https://phabricator.wikimedia.org/T350919#9765332 (10Tse... [21:15:56] (03PS1) 10Ejegg: Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) [21:24:06] (03Merged) 10jenkins-bot: Migrate to IReadableDatabase::newSelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025863 (https://phabricator.wikimedia.org/T312369) (owner: 10Umherirrender) [21:25:48] (03PS1) 10Jgleeson: WIP: Add stats collection to new queue consumers. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026688 (https://phabricator.wikimedia.org/T362206) [21:28:42] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), 13Patch-For-Review, 07Technical-Debt: Migrate usage of Database::select to SelectQueryBuilder in CentralNotice - https://phabricator.wikimedia.org/T312369#9765408 (10Umherirrender) 05Open→03Res... [21:30:16] (03CR) 10CI reject: [V:04-1] Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:35:14] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Wikipedia-iOS-App-Backlog: Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9765449 (10Tsevener) a:03Tsevener [21:35:21] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9765450 (10Tsevener) [21:35:47] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): [S] Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9765453 (10Tsevener) [21:38:19] (03PS2) 10Jgleeson: WIP: Add stats collection to new queue consumers. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026688 (https://phabricator.wikimedia.org/T362206) [21:45:46] 06Fundraising-Backlog: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#9765471 (10bsisolak) Let's move that conversation to another ticket, once the texting contract is signed. Then get back to this ticket after that. [21:46:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Add Gr4vy's API for data deletion requests to Civi's Forget Me action - https://phabricator.wikimedia.org/T364051 (10MBeat33) 03NEW [21:56:10] (03CR) 10CI reject: [V:04-1] WIP: Add stats collection to new queue consumers. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026688 (https://phabricator.wikimedia.org/T362206) (owner: 10Jgleeson) [23:45:09] (03CR) 10Eileen: "interesting - I'm a +1 on having these stats on as many queues as possible/relevant" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026688 (https://phabricator.wikimedia.org/T362206) (owner: 10Jgleeson)