[00:04:16] (03CR) 10CI reject: [V:04-1] Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [00:06:04] (03CR) 10CI reject: [V:04-1] Do any tests notice this? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030615 (owner: 10Eileen) [00:34:27] (03PS2) 10Eileen: Move handling of field 'partner' to shared function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030613 [00:34:27] (03PS1) 10Eileen: Copy handleUpdate back to ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030616 [00:34:27] (03PS1) 10Eileen: Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 [00:42:47] (03PS2) 10Eileen: Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 [00:46:38] (03Abandoned) 10Eileen: Move email update to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030572 (owner: 10Eileen) [00:46:58] (03Abandoned) 10Eileen: Move address update to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030580 (owner: 10Eileen) [00:47:30] (03Abandoned) 10Eileen: Decommission unhelpful function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030581 (owner: 10Eileen) [00:51:28] (03PS2) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [00:54:10] (03PS3) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [00:55:06] (03CR) 10CI reject: [V:04-1] Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 (owner: 10Eileen) [00:55:11] (03CR) 10CI reject: [V:04-1] Copy handleUpdate back to ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030616 (owner: 10Eileen) [00:55:23] (03PS4) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [01:03:06] (03PS2) 10Eileen: Copy handleUpdate back to ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030616 [01:03:09] (03CR) 10CI reject: [V:04-1] Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 (owner: 10Eileen) [01:15:23] (03CR) 10CI reject: [V:04-1] Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [01:23:15] (03Abandoned) 10Eileen: Do any tests notice this? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030615 (owner: 10Eileen) [01:32:33] (03PS3) 10Eileen: Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 [01:48:28] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Consider population address source fields - https://phabricator.wikimedia.org/T364700 (10Eileenmcnaughton) 03NEW [01:55:06] (03PS4) 10Eileen: Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 [01:55:06] (03PS5) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [07:06:45] (03PS5) 10Eileen: Restore stats reporting for DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029232 (https://phabricator.wikimedia.org/T362206) (owner: 10Ejegg) [07:06:46] (03PS1) 10Eileen: Fix environment handling of metrics [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030747 (https://phabricator.wikimedia.org/T362206) [07:16:58] (03PS1) 10Eileen: Remove calls to metric_reporting via module_invoke [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030750 (https://phabricator.wikimedia.org/T362206) [07:17:02] (03PS1) 10Eileen: Fully remove drush queue.consume action, last call to metrics drupal fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030751 (https://phabricator.wikimedia.org/T362206) [07:21:22] (03PS1) 10Eileen: Simplify time handling in (outgoing) tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030752 [07:26:42] (03PS3) 10Ejegg: Remove unused use statements [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029762 [07:28:47] (03CR) 10Eileen: [C:03+2] Remove unused use statements [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029762 (owner: 10Ejegg) [07:29:31] (03CR) 10Eileen: [C:03+2] "Ok - this is passing now - although it needs the patch under it merged to pass / merge" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029232 (https://phabricator.wikimedia.org/T362206) (owner: 10Ejegg) [07:48:06] (03Merged) 10jenkins-bot: Remove unused use statements [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029762 (owner: 10Ejegg) [09:07:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-Translate, 10ci-test-error (WMF-deployed Build Failure): phpunit test failure for extension FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T357804#9789325 (10taavi) {{ping}} - this is blocking merges to a Wikim... [11:59:59] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9789862 (10MoritzMuehlenhoff) @Dwisehaupt @Jgreen The kafka cert issued by the PKI is now getting deployed to /etc/fr-tech-kafka-client on cumin1002/cumin2002. Could you please sync... [12:58:20] (03PS1) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [13:11:18] ^^ this should fix the failmails we've been getting on AutoRescue [13:18:21] (03CR) 10CI reject: [V:04-1] Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [13:29:10] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [13:52:54] (03PS8) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [14:00:29] (03PS2) 10Eileen: Fix environment handling of metrics [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030747 (https://phabricator.wikimedia.org/T362206) [14:00:48] (03CR) 10Ejegg: [C:03+2] Fix environment handling of metrics [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030747 (https://phabricator.wikimedia.org/T362206) (owner: 10Eileen) [14:21:53] (03PS6) 10Eileen: Restore stats reporting for DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029232 (https://phabricator.wikimedia.org/T362206) (owner: 10Ejegg) [14:40:53] Let's see if we can do a couple months worth of backfill for the contribution_recur.payment_instrument_id [14:41:00] at least for things with a rescue_reference [14:41:25] If they are monthly convert we should be able to find the previous contribution by create_date and contact_id [14:44:18] oh and let's make sure we add the payment_method & submethod to the subscr_start message from the front end [14:48:05] ok, yep, they seem to be there [14:50:08] Hmm, but it's still not populating in the contribution_recur table [14:50:30] at least it didn't for this one, processed just a little while ago: select * from civicrm_contribution_recur where processor_id='TRD9WCLVB7MDP672'; [14:51:55] oh hey, that processor_id would be an even better way of joining to backfill the payment_instrument_id; [14:52:00] lol semicolon [15:03:49] ahh, eileen's patch only added it to the code that creates the new recur from an initial payment: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1029271/4/drupal/sites/all/modules/wmf_civicrm/recurring.inc [15:03:57] so we need to add it to the recurring queue consumer too [15:16:40] (03CR) 10Ejegg: [C:03+2] "Re-applying Eileen's C+2 to nudge zuul" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029232 (https://phabricator.wikimedia.org/T362206) (owner: 10Ejegg) [15:27:16] ejegg: when we broke banner out of utm_source in contribution tracking was there plans to break it out in the url too? [15:28:14] cstone potentially long-term, sure [15:28:39] but nothing we had discussed with the banner team at that point [15:29:09] I think we talked about that some at a recent meeting with Nora about her campaign/source codes vision [15:31:40] Toni is doing the task about web urls from the app, do you think the vision would happen soon? we could just have banner= there in the app urls along with utm_source just until we eventually use it [15:32:13] (03PS1) 10Ejegg: Populate payment_instrument_id from subscr_start [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031003 [15:39:04] cstone what else does the app concatenate on to utm_source? [15:39:24] payment method [15:39:37] and then its hard coding the landing page part to be the inapp [15:40:30] I'd say we're probably going to be passing utm_source (or wmf_source) along from payments for a good year or more at least [15:41:03] and we don't pass through the individual components from payments yet, do we? [15:41:14] (03Merged) 10jenkins-bot: Fix environment handling of metrics [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030747 (https://phabricator.wikimedia.org/T362206) (owner: 10Eileen) [15:41:15] (03Merged) 10jenkins-bot: Restore stats reporting for DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1029232 (https://phabricator.wikimedia.org/T362206) (owner: 10Ejegg) [15:41:51] I'mma deploy ^^^ plus the other pending updates [15:42:05] then let's try to get that failmail fix from dami plus a couple supporting patches out [15:43:35] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031007 [15:45:20] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031007 (owner: 10Ejegg) [15:46:09] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031007 (owner: 10Ejegg) [15:47:55] thanks ejegg, yep the backfill is important. Just need to get this patch to pass CI. [15:50:59] hmm, enough QC changes that I think I want to pause queues [15:52:34] (03PS2) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [15:54:25] !log disabled fundraising scheduled jobs for CiviCRM deploy [15:54:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:55:32] !log fundraising civicrm upgraded from c0d2fa95 to 3fef5849 [15:55:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:58:06] (03CR) 10Bartosz Dziewoński: [C:03+2] Migrate IReadableDatabase::buildGroupConcatField to SelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [15:59:57] dang, failmail on donations queue consumer [16:00:06] maybe just needs that prometheus patch set? [16:00:36] Huh, I definitely ran the extension update that should have set it [16:03:09] let's try a system.flush [16:04:30] ok, that got it showing up at /civicrm/admin/setting/wmf-civicrm [16:06:36] great, and queue consumer is happy now too [16:06:45] let's look at those names [16:09:26] ah dang [16:09:40] broke something in the contact summary [16:09:54] reverting [16:11:28] !log fundraising civicrm rolled back from 3fef5849 to c0d2fa95 [16:11:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:11:36] (03CR) 10CI reject: [V:04-1] Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [16:11:46] ok, looks like queue consumers still work [16:11:54] will turn those back on [16:13:09] !log restarted fundraising scheduled jobs [16:13:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:13:46] ok, that's fixed the contact summaries [16:13:53] ahh, I see where that came from [16:19:15] (03PS1) 10Ejegg: Fix error with preferencesLink hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031015 [16:19:41] ejegg: is the snooze field that DI patch for new? [16:20:00] cstone: yep, that DI patch is all there is left to be able to deploy an MVP [16:20:09] just trying to test it and failing haha [16:20:15] ah ive broken my civi now [16:20:22] fr-tech can anyone take a look at that preferencesLink patch? https://gerrit.wikimedia.org/r/1031015 [16:20:34] cstone: oh if you have latest master it's broken for everyone [16:20:44] oh hey thats how mine is broken:P [16:20:46] ok yes i can test [16:20:49] (and was briefly broken in prod till rollback) [16:20:54] thanks! [16:21:24] yep fixes it! [16:21:33] whew [16:21:41] (03CR) 10Cstone: [C:03+2] "thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031015 (owner: 10Ejegg) [16:30:19] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9791128 (10Dwisehaupt) [16:31:12] ejegg: is the snooze field visible in the UI? [16:31:16] in civi [16:31:17] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9791129 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Verified logins are working. [16:31:36] cstone: I think only via that searchkit [16:31:53] we should make it visible on the contact summary though [16:36:49] (03CR) 10CI reject: [V:04-1] Migrate IReadableDatabase::buildGroupConcatField to SelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [16:39:04] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031022 [16:39:08] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031022 (owner: 10Ejegg) [16:39:19] OK, I'll deploy that once those merge [16:40:32] (03Merged) 10jenkins-bot: Fix error with preferencesLink hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031015 (owner: 10Ejegg) [16:40:33] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031022 (owner: 10Ejegg) [16:46:16] !log fundraising civicrm upgraded from c0d2fa95 to 4f55a7cf [16:46:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:54:40] yay, the graph has new donation stats! [16:54:42] https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?orgId=1&refresh=1m&from=now-30m&to=now&viewPanel=60 [16:56:01] (03CR) 10Bartosz Dziewoński: [C:03+2] "Failure is: `includes/UserMergeHookHandlers.php:33 PhanUndeclaredInterface Class implements undeclared interface \MediaWiki\Extension\User" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [17:00:51] (03PS3) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [17:10:12] (03CR) 10CI reject: [V:04-1] Migrate IReadableDatabase::buildGroupConcatField to SelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [17:24:58] (03CR) 10CI reject: [V:04-1] Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [17:27:46] (03CR) 10Bartosz Dziewoński: Migrate IReadableDatabase::buildGroupConcatField to SelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [17:44:37] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9791429 (10Jgreen) >>! In T360779#9789862, @MoritzMuehlenhoff wrote: > @Dwisehaupt @Jgreen The kafka cert issued by the PKI is now getting deployed to /etc/fr-tech-kafka-client on cu... [17:50:41] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9791480 (10Jgreen) 05Open→03Resolved a:03Jgreen [17:51:22] (03PS4) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [18:00:46] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9791531 (10Jgreen) 05Resolved→03Open Hmmmm. I'm seeing this occasionally: Kafka error (-195): ssl://kafka-jumbo1010.eqiad.wmnet:9093/1010: Connect to ipv4#10.64.130.10:9093 fail... [18:10:38] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9791591 (10Jgreen) This isn't limited to the two hosts I mentioned above. It seems like at any given time one of the kafka-jumbo is refusing connections. [18:29:24] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9791682 (10Jgreen) 05Open→03Resolved Looks like coincidental rolling kafka restarts. [18:37:10] (03PS2) 10Umherirrender: Migrate IReadableDatabase::buildGroupConcatField to SelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 [18:37:13] (03CR) 10Umherirrender: "Yes, that is related" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [18:40:29] (03CR) 10CI reject: [V:04-1] Migrate IReadableDatabase::buildGroupConcatField to SelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1027595 (owner: 10Umherirrender) [18:56:03] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Consider population address source fields - https://phabricator.wikimedia.org/T364700#9791835 (10NNichols) I think that's a good idea. If we're tracking it from one place, we should do so wherever we can. What other sources do you see? [19:03:39] 06Fundraising-Backlog: Japan Email Campaign Records - Incorrect utm_campaign Causing Duplicate Records - https://phabricator.wikimedia.org/T364515#9791858 (10JMando) Just for more context: email stats query: ` SELECT DISTINCT pop.id, sp.mailing_identifier, pop.mailing_name, pop.created_date,... [19:24:43] (03CR) 10Eileen: Fix fail mail when autorescue from monthly convert tries to find payment_instrument (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [19:26:36] (03CR) 10Eileen: "So this one can create the donation because the contribution recur record has a payment instrument ID - but the ones I looked at that are " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [19:29:33] (03CR) 10Eileen: [C:03+2] Populate payment_instrument_id from subscr_start [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031003 (owner: 10Ejegg) [19:32:47] hi eileen, per your comments on the patch we'd do a backfill on the missing payment_instrument_id [19:33:23] had to push the patch up when I tried to requeue the messages after manually filling the payment_instrument_id [19:33:36] ok - have you figured out how? - I just gave this +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1031003 [19:35:30] (03CR) 10Cstone: [C:03+2] "I see it snoozing" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1026948 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [19:35:52] Some of the recurring were created from Monthly convert, we can either use the invoice id or processor id to match with the initial contribution and populate from there. [19:36:27] 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9791957 (10Eileenmcnaughton) [19:36:59] then I'd requeue anyone that's left manually, filling the id with data from Adyen [19:37:33] (03Merged) 10jenkins-bot: Fix prefs display when contact snoozed [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1026948 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [19:38:55] damilare: if they have an initial contribution we can soup up `getRecurringPriorContributionValue()` to get it - although the ones I looked at were failing on the first contribution [19:39:20] (03PS2) 10Eileen: Remove calls to metric_reporting via module_invoke [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030750 (https://phabricator.wikimedia.org/T362206) [19:39:35] ahh then I'd have to get the payment instrument from the Adyen console then. [19:39:43] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), 13Patch-For-Review: Placeholder - Research Task - Implementing GPay on Android - https://phabricator.wikimedia.org/T360377#9791970 (10Cstone) a:03Cstone [19:39:45] 06Fundraising-Backlog, 13Patch-For-Review: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236#9791971 (10XenoRyet) [19:40:12] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Spike - do practice standalong installs locally to get our heads around it - https://phabricator.wikimedia.org/T276395#9791975 (10XenoRyet) [19:43:00] (03PS5) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [19:43:51] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 13Patch-For-Review: Civi shouldn't show "cancellation not supported" message for processors where we handle schedule - https://phabricator.wikimedia.org/T335712#9791986 (10Eileenmcnaughton) [19:44:03] (03PS2) 10Eileen: Simplify time handling in (outgoing) tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030752 [19:48:44] (03Merged) 10jenkins-bot: Populate payment_instrument_id from subscr_start [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031003 (owner: 10Ejegg) [19:56:48] 06Fundraising-Backlog: Engage mapping import - Individual - https://phabricator.wikimedia.org/T364653#9792065 (10Eileenmcnaughton) The TY email depends on how busy the server is [19:59:19] 06Fundraising-Backlog: Japan Email Campaign Records - Incorrect utm_campaign Causing Duplicate Records - https://phabricator.wikimedia.org/T364515#9792070 (10AKanji-WMF) p:05Triage→03High @Cstone to review solve from a previous instance to see if it could apply here [20:01:39] (03CR) 10Eileen: "OK - I get it now we have that extra exception in the helper class. The more I think about that one I think it can just go as we also have" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [20:02:48] 06Fundraising-Backlog: Some Japan donations coming in USD - https://phabricator.wikimedia.org/T364482#9792094 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Email team will hard code country links into URL to minimize this issue recurring [20:05:33] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fail mail - auto rescue with no predecessor - https://phabricator.wikimedia.org/T364438#9792100 (10AKanji-WMF) p:05Triage→03High [20:08:54] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031055 [20:09:07] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031055 (owner: 10Eileen) [20:10:18] 06Fundraising-Backlog: Dark Mode - Codex on Payments Forms - https://phabricator.wikimedia.org/T364434#9792113 (10Cstone) With Mediawiki 1.39 we are on v0.1.1 of codex, once we go to 1.43 in January 2025 we will have access to more codex elements [20:10:40] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: We're recording the wrong amount from Adyen Capture IPNs in JPY - https://phabricator.wikimedia.org/T364392#9792116 (10AKanji-WMF) p:05Triage→03High [20:12:40] (03PS6) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [20:13:03] 06Fundraising-Backlog: Renew Paypal API Certificate by September 19, 2024 - https://phabricator.wikimedia.org/T348725#9792121 (10Cstone) [20:14:30] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031055 (owner: 10Eileen) [20:15:53] (03CR) 10Damilare Adedoyin: "Thanks for the CR eileen, I've updated the patch and responded to a comment inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [20:21:10] 06Fundraising-Backlog, 07Epic: Gravy frontend createPayment - https://phabricator.wikimedia.org/T364508#9792134 (10Dwisehaupt) [20:22:32] 06Fundraising-Backlog, 07Epic, 13Patch-For-Review: Gravy backend createPayment - https://phabricator.wikimedia.org/T364506#9792135 (10Dwisehaupt) [20:23:14] 06Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Deduper Issue - https://phabricator.wikimedia.org/T363958#9792138 (10Dwisehaupt) [20:25:07] 06Fundraising-Backlog: Paypal Giving Fund donations added to Civi under incorrect CID - https://phabricator.wikimedia.org/T363768#9792140 (10Dwisehaupt) [20:26:32] (03PS3) 10Eileen: Move handling of field 'partner' to shared function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030613 [20:26:32] (03PS3) 10Eileen: Copy handleUpdate back to ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030616 [20:26:32] (03PS5) 10Eileen: Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 [20:26:32] (03PS6) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [20:26:33] (03PS1) 10Eileen: Remove last call to handleUpdate from outside the class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031059 [20:27:54] 06Fundraising-Backlog: Jazz up the mailcheck.js suggestion text - https://phabricator.wikimedia.org/T363473#9792144 (10Dwisehaupt) [20:28:45] 06Fundraising-Backlog: Add expiration period of 12 months to the 'Recurring Upgrade Declined' activity type in Civi - https://phabricator.wikimedia.org/T363433#9792145 (10Dwisehaupt) [20:29:59] !log civicrm upgraded from 4f55a7cf to 447e1472 [20:30:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:31:28] (03CR) 10CI reject: [V:04-1] Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [20:31:53] 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#9792147 (10Dwisehaupt) [20:34:48] (03PS7) 10Damilare Adedoyin: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 [20:41:00] 06Fundraising-Backlog: JSON->CSV tool for Pats - https://phabricator.wikimedia.org/T192956#9792178 (10AKanji-WMF) 05Open→03Declined We no longer accept BitPay. [20:41:13] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9792180 (10spatton) [20:41:37] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove Bitpay import, possibly stripe - https://phabricator.wikimedia.org/T364784 (10Eileenmcnaughton) 03NEW [20:48:58] (03CR) 10CI reject: [V:04-1] Remove last call to handleUpdate from outside the class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031059 (owner: 10Eileen) [20:54:39] ok the patch finally passed CI [21:02:47] (03CR) 10Eileen: [C:03+2] Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [21:23:46] (03Merged) 10jenkins-bot: Fix fail mail when autorescue from monthly convert tries to find payment_instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030946 (owner: 10Damilare Adedoyin) [21:27:14] (03PS2) 10Eileen: Remove last call to handleUpdate from outside the class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031059 [21:29:09] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031064 [21:29:18] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031064 (owner: 10Eileen) [21:30:02] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1031064 (owner: 10Eileen) [21:31:30] (03PS1) 10Eileen: Remove BitPay file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031087 (https://phabricator.wikimedia.org/T364784) [21:39:28] !log civicrm upgraded from 447e1472 to c854dd3a [21:39:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:59:51] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9792424 (10Dwisehaupt) 05Resolved→03Open [22:02:08] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9792427 (10Dwisehaupt) [22:02:25] 10fundraising-tech-ops: Fundraising access request for KMorrow - https://phabricator.wikimedia.org/T363937#9792428 (10Dwisehaupt) Set up with mysql access for getting data with scripts. Ready for testing. [22:04:52] 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792 (10EMartin) 03NEW [22:11:25] 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9792450 (10EMartin) I am seeing in the console that we are capturing so asking Dlocal for more info. {F52997440} [22:20:10] PROBLEM - Host frauth1002 is DOWN: PING CRITICAL - Packet loss = 100% [22:20:25] 14fundraising sprint Roller Toaster, 14fundraising sprint Screaming Goats Yelling Zoo, 14Fundraising Sprint Technical debt house of horrors, 06Fundraising-Backlog, and 2 others: Add 3 email preference fields to civi - https://phabricator.wikimedia.org/T278858#9792512 (10AKanji-WMF) I'm closing this in favo... [22:21:05] ^^^ that was me doing an update. frauth1002 is back online [22:21:16] RECOVERY - Host frauth1002 is UP: PING OK - Packet loss = 0%, RTA = 0.41 ms [22:21:36] (03CR) 10Jdlrobson: [C:04-1] "I setup a meeting for 23rd." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) (owner: 10Jdlrobson) [23:05:36] PROBLEM - Host frmx1001 is DOWN: PING CRITICAL - Packet loss = 100% [23:06:37] ^^^ me again. [23:06:56] it's already back up. [23:07:12] RECOVERY - Host frmx1001 is UP: PING OK - Packet loss = 0%, RTA = 0.41 ms [23:22:31] (03PS4) 10Eileen: Move handling of field 'partner' to shared function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030613 [23:22:31] (03PS4) 10Eileen: Copy handleUpdate back to ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030616 [23:22:31] (03PS6) 10Eileen: Minor simplification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030617 [23:22:32] (03PS7) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [23:22:33] (03PS3) 10Eileen: Remove last call to handleUpdate from outside the class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031059 [23:22:35] (03PS1) 10Eileen: Remove legacy-code function is_addess_valid [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031092 [23:22:39] (03PS1) 10Eileen: Switch to a slightly less magic way of denoting how address should be updated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031093 (https://phabricator.wikimedia.org/T280501) [23:32:44] (03PS2) 10Eileen: Fully remove drush queue.consume action, last call to metrics drupal fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030751 (https://phabricator.wikimedia.org/T362206) [23:42:59] (03CR) 10CI reject: [V:04-1] Switch to a slightly less magic way of denoting how address should be updated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031093 (https://phabricator.wikimedia.org/T280501) (owner: 10Eileen) [23:49:27] (03PS1) 10Eileen: Remove remaining code from metrics_reporting module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031094 (https://phabricator.wikimedia.org/T270668) [23:52:03] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Convert metrics reporting to a drupal module - https://phabricator.wikimedia.org/T270668#9792763 (10Eileenmcnaughton) I just pushed up the various code removals we can do to...