[00:43:06] hmm deadlocks are back? [00:44:38] or hmm [00:47:02] what is going on [00:49:28] is this like that other time the donations queue randomly backed up [00:50:14] hmm and because I looked at it its suddenly faster? haha [00:57:34] this is again after the queries an hour or so back? [01:00:15] yeah I think its different? it just fixed 10 minutes ago [01:01:05] only long running query I could see while it was still slow was a fr-stats one that had only been then running for 10 minutes (After it had been happening for ~hour) [01:51:31] (03PS3) 10Ejegg: ExchangeRate::updateAll API4 action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) [01:51:31] (03PS1) 10Ejegg: Exchange Rates entity: support composite key [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) [02:39:47] (03PS1) 10Eileen: Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) [02:41:55] ejegg: that `writeRecord` override should really be on the BAO not DAO (extra complexity Coleman is getting rid of generated DAOs I think - but we aren't quite in that world yet) [02:53:24] (03CR) 10Eileen: "This looks good but the override should really be in a BAO file that overrides the DAO file" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [02:53:36] ah ok eileen [02:54:06] i was just wondering if the cache stuff I'm writing for the next patch should go on BAO or DAO, but I guess it's BAO too! [02:54:15] yep [02:54:58] ejegg: I'm assuming the upgrade patch should not be merged until we are all ready but it's too painful to have it at the top of the chain? [02:55:17] ah yeah, I can move it to the end [02:55:55] (03PS1) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [02:56:17] I'll move that writeRecords to the BAO tomorrow - gotta head to bed now! [02:59:13] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9802830 (10Eileenmcnaughton) @MDemosWMF @NNichols I have put some code onto staging to... [02:59:29] (03CR) 10CI reject: [V:04-1] Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [03:04:38] (03CR) 10Cstone: [C:03+2] Remove unused function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031531 (owner: 10Eileen) [03:06:41] (03CR) 10Cstone: [C:03+2] Another test move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031129 (owner: 10Eileen) [03:21:40] (03CR) 10Cstone: [C:03+2] Unset any exceptions on WMFException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031629 (owner: 10Eileen) [03:29:24] (03Merged) 10jenkins-bot: Remove unused function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031531 (owner: 10Eileen) [03:29:25] (03Merged) 10jenkins-bot: Another test move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031129 (owner: 10Eileen) [03:30:26] (03PS1) 10Eileen: WTF - is this problem [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032112 [03:30:58] (03CR) 10Cstone: [C:03+2] Fix Handling of DBQueryException if it bubbles up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031630 (owner: 10Eileen) [03:31:19] thanks cstone - I'll deploy that in case any are getting up that far! [03:32:26] (03CR) 10Cstone: [C:03+2] Fix capitalisation in our transform file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031634 (owner: 10Eileen) [03:33:34] we need to get you an address award for dealing with that [03:39:49] cstone: I'm still kinda broken - & we haven't actually got it all merged & deployed yet - but when we do I might buy myself something nice [03:40:28] it just shows what happens when code is too scary for too long [03:42:09] (03Merged) 10jenkins-bot: Unset any exceptions on WMFException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031629 (owner: 10Eileen) [03:47:38] (03PS2) 10Eileen: Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) [03:50:57] (03CR) 10CI reject: [V:04-1] WTF - is this problem [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032112 (owner: 10Eileen) [03:52:10] (03Abandoned) 10Eileen: WTF - is this problem [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032112 (owner: 10Eileen) [03:55:34] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9802844 (10Eileenmcnaughton) Hmm there is the odd one where the NCOA address has LESS d... [03:55:42] (03Merged) 10jenkins-bot: Fix Handling of DBQueryException if it bubbles up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031630 (owner: 10Eileen) [03:55:43] (03Merged) 10jenkins-bot: Fix capitalisation in our transform file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031634 (owner: 10Eileen) [03:59:59] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1032113 [04:00:15] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1032113 (owner: 10Eileen) [04:01:01] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1032113 (owner: 10Eileen) [04:02:38] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Greece - Campaign Readyness Checklist - https://phabricator.wikimedia.org/T362784#9802847 (10Cstone) a:03Cstone [04:02:42] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Greece - Campaign Readyness Checklist - https://phabricator.wikimedia.org/T362784#9802846 (10Cstone) GR is a little different as it's been out in the wild for a while, I grabbed transactions we've had in the last two months: Successful Payment Methods Apple... [04:04:17] !log civicrm upgraded from 26e7422a to 4f6f2dc3 [04:04:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:05:47] (03PS5) 10Eileen: Fix Error handling to check if we already know it is a retry first [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 [04:05:55] (03PS12) 10Eileen: Improve deadlock handling on contribution Insert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 [04:43:23] (03PS1) 10Eileen: Decommission Banner History module, add column to contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032117 (https://phabricator.wikimedia.org/T270672) [04:46:48] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert banner history from a drupal table to a column in contribution_tracking - https://phabricator.wikimedia.org/T365090 (10Eileenmcnaughton) 03NEW [04:47:44] (03CR) 10CI reject: [V:04-1] Decommission Banner History module, add column to contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032117 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [04:49:05] 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9802913 (10Eileenmcnaughton) [04:55:43] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert banner history from a drupal table to a column in contribution_tracking - https://phabricator.wikimedia.org/T365090#9802917 (10Eileenmcnaughton)... [04:56:01] (03PS2) 10Eileen: Decommission Banner History module, add column to contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032117 (https://phabricator.wikimedia.org/T270672) [05:03:23] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert banner history from a drupal table to a column in contribution_tracking - https://phabricator.wikimedia.org/T365090#9802929 (10Eileenmcnaughton) [05:23:28] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move the last 2 drush functions from queue2civicrm to the extension - https://phabricator.wikimedia.org/T365091 (10Eileenmcnaughton) 03NEW [05:31:56] (03PS1) 10Eileen: Move the last test out of queue2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) [05:55:53] (03CR) 10CI reject: [V:04-1] Move the last test out of queue2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [06:12:30] (03PS1) 10Eileen: Create new api to process a record from file, replacing on drush commands [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032146 (https://phabricator.wikimedia.org/T365091) [06:13:44] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert banner history from a drupal table to a column in contribution_tracking - https://phabricator.wikimedia.org/T365090#9803066 (10Eileenmcnaughton) [06:31:29] (03CR) 10CI reject: [V:04-1] Create new api to process a record from file, replacing on drush commands [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032146 (https://phabricator.wikimedia.org/T365091) (owner: 10Eileen) [06:32:18] (03PS2) 10Eileen: Create new api to process a record from file, replacing on drush commands [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032146 (https://phabricator.wikimedia.org/T365091) [07:28:51] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1032316 (owner: 10L10n-bot) [07:47:20] (03CR) 10Wangombe: "This change is ready for review" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1029486 (https://phabricator.wikimedia.org/T340724) (owner: 10Wangombe) [08:23:54] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1032316 (owner: 10L10n-bot) [08:32:01] 06Fundraising-Backlog: Enable Retry logic for ACH transactions - https://phabricator.wikimedia.org/T365100 (10RKumar_WMF) 03NEW [08:52:20] 06Fundraising-Backlog: Enable Recurring for SEPA transactions in all EU countries - https://phabricator.wikimedia.org/T365106 (10RKumar_WMF) 03NEW [08:54:06] 06Fundraising-Backlog: Enable Recurring for SEPA transactions in all EU countries - https://phabricator.wikimedia.org/T365106#9803467 (10RKumar_WMF) https://phabricator.wikimedia.org/T324520 - SEPA direct debit as mainstream payment method in EU campaigns. Adding here for reference. [12:41:40] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert banner history from a drupal table to a column in contribution_tracking - https://phabricator.wikimedia.org/T365090#9804301 (10Pcoombe) Thanks for letting us know @Eileenmcnaughton, sounds... [13:02:49] 06Fundraising-Backlog: Japan Email Campaign Records - Incorrect utm_campaign Causing Duplicate Records - https://phabricator.wikimedia.org/T364515#9804351 (10NCreasy) @Cstone Thank you, end of May sounds good for a clean up and we will manage the cube update for the campaign in the interim. The email team have u... [13:04:42] (03PS1) 10Damilare Adedoyin: Add test for fundraisup email address modification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032478 [13:12:23] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for this eileen, I added a FRUP test in a follow on patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1032478/1" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031572 (owner: 10Eileen) [13:17:11] (03CR) 10Damilare Adedoyin: "Hi eileen, I added a suggestion that could help get this test to pass." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031570 (owner: 10Eileen) [13:23:28] (03CR) 10CI reject: [V:04-1] Add test for fundraisup email address modification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032478 (owner: 10Damilare Adedoyin) [13:25:20] (03PS2) 10Damilare Adedoyin: Add test for fundraisup email address modification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032478 [13:45:35] (03PS2) 10Ejegg: Exchange Rates entity: support composite key [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) [13:45:35] (03PS4) 10Ejegg: ExchangeRate::updateAll API4 action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) [13:45:35] (03PS2) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [13:45:36] (03PS10) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [13:46:21] (03CR) 10Ejegg: "Thanks, Eileen. I've moved the override to the BAO in PS2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [13:57:47] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: How to deal with clearly bad email addresses in Civi - https://phabricator.wikimedia.org/T363946#9804772 (10AKanji-WMF) Came across this phab - related? @Eileenmcnaughton @Ejegg {T249160} [13:57:51] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9804774 (10MDemosWMF) @Eileenmcnaughton I noticed that too, let's do that so we are not... [14:00:15] 10fundraising-tech-ops: Fundraising access request for PPenloglou - https://phabricator.wikimedia.org/T363936#9804786 (10ppenloglou) Hey @Dwisehaupt, I've created my fr specific SSH key pair! These are the contents of my public key **fr_id_ed25519.pub**: ` ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJF9eHBPcPfXJ7VM6w... [14:19:43] (03PS3) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [14:19:43] (03PS11) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [14:23:04] (03PS4) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [14:23:05] (03PS12) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [14:59:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: New recurring donation that gets stopped at auth makes INVALID_RECURRING Recurring donation, but no subscription ID or recurring payment token found. - https://phabricator.wikimedia.org/T360122#9805220 (10Damilare) I looked into this today, I believe this... [15:21:50] (03PS5) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [15:21:50] (03PS13) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [15:21:50] (03PS1) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [15:33:04] (03PS6) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [15:33:05] (03PS14) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [15:33:05] (03PS2) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [15:34:34] (03PS3) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [15:35:58] (03PS4) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [15:44:16] (03PS7) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [15:44:16] (03PS15) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [15:44:16] (03PS5) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [16:01:06] 10fundraising-tech-ops: Fundraising access request for PPenloglou - https://phabricator.wikimedia.org/T363936#9805546 (10Dwisehaupt) [16:01:28] 10fundraising-tech-ops: Fundraising access request for PPenloglou - https://phabricator.wikimedia.org/T363936#9805551 (10Dwisehaupt) Thanks. Public key added to puppet and pushed out. [16:04:47] (03CR) 10CI reject: [V:04-1] Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [16:07:12] (03PS1) 10C. Scott Ananian: Use OutputPage::setPageTitleMsg() instead of ::setPageTitle() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1032527 (https://phabricator.wikimedia.org/T343994) [16:11:08] (03CR) 10CI reject: [V:04-1] Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [16:11:46] (03PS1) 10C. Scott Ananian: Use OutputPage::setPageTitleMsg() instead of ::setPageTitle() [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1032530 (https://phabricator.wikimedia.org/T343994) [16:15:43] (03PS7) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [16:24:24] 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9805675 (10Dwisehaupt) Moving to sprint +1 as it's time. [16:51:03] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Japan: Mock-ups for japanese form variants - https://phabricator.wikimedia.org/T299567#9806050 (10Aklapper) a:05spatton→03None @spatton: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on... [16:51:13] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Japan: translations needed for japan form - https://phabricator.wikimedia.org/T299566#9806053 (10Aklapper) a:05spatton→03None @spatton: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on... [16:57:10] PROBLEM - check_mysql on frdb2001 is CRITICAL: Access denied for user nagios@localhost https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [17:01:15] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Japan: Mock-ups for japanese form variants - https://phabricator.wikimedia.org/T299567#9806188 (10spatton) 05Open→03Resolved a:03spatton [17:02:10] PROBLEM - check_mysql on frdb2001 is CRITICAL: Access denied for user nagios@localhost https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [17:07:12] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 207 Threads: 4 Questions: 22004 Slow queries: 0 Opens: 1040 Open tables: 1034 Queries per second avg: 106.299 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [17:08:22] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 06Fundraising-Backlog, 10Wikipedia-Android-App-Backlog (Android Release - FY2023-24), 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): Standardize utm_source from app donations without a banner and clea... - https://phabricator.wikimedia.org/T350919#9806279 [17:10:11] 06Fundraising-Backlog, 06Product-Analytics, 10Wikimedia-CentralNotice-Administration: Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387#9806275 (10Aklapper) a:05Effeietsanders→03None @Effeietsanders: Removing task assignee as this open task has been assigned for mo... [17:22:13] woo, it's got a V+2 on it [17:22:23] ok, lemme see about the annual donations [17:36:15] (03PS1) 10Ejegg: Allow importing annual recurring donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032539 (https://phabricator.wikimedia.org/T358914) [17:36:34] cstone: OK, I think that's what I was missing in the Civi side of the import ^^^ [17:48:41] (03PS1) 10Ejegg: Fix WS in SmashPig payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032540 [17:50:13] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 06Fundraising-Backlog, 10Wikipedia-Android-App-Backlog (Android Release - FY2023-24), 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): Standardize utm_source from app donations without a banner and clea... - https://phabricator.wikimedia.org/T350919#9806454 [17:57:56] (03PS3) 10Ejegg: Implement cancelSubscription for SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/976262 (https://phabricator.wikimedia.org/T335712) [18:09:04] (03CR) 10Ejegg: "Thanks for the review cstone! I've made the required Civi-side changes in I0441e0f7e93bce814a703cbf112c90a112ae16d9" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028528 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [18:10:50] (03PS3) 10Cstone: Add appversion for googlepay and unify with iOS code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1027089 (https://phabricator.wikimedia.org/T360377) [18:10:54] (03CR) 10Ejegg: [C:03+2] Add appversion for googlepay and unify with iOS code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1027089 (https://phabricator.wikimedia.org/T360377) (owner: 10Cstone) [18:12:55] (03Merged) 10jenkins-bot: Add appversion for googlepay and unify with iOS code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1027089 (https://phabricator.wikimedia.org/T360377) (owner: 10Cstone) [18:13:32] (03PS4) 10Ejegg: Allow annual donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028528 (https://phabricator.wikimedia.org/T358914) [18:13:32] (03PS3) 10Ejegg: Pass frequency_unit for PayPal profile creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028561 (https://phabricator.wikimedia.org/T358914) [18:51:09] thanks ejegg on both [18:51:30] :) [19:14:39] 06Fundraising-Backlog: Better CC Validation and Error Messages - https://phabricator.wikimedia.org/T143427#9806693 (10spatton) 05Open→03Resolved a:03spatton Just closing these as it's quite outdated and we're not working on it actively. [19:15:03] 06Fundraising-Backlog: Skeuomorphic interface for entering CC details - https://phabricator.wikimedia.org/T143426#9806698 (10spatton) 05Open→03Resolved a:03spatton Closing as it's quite outdated and we're not working on it. [19:52:17] (03CR) 10Eileen: [C:03+2] Fix WS in SmashPig payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032540 (owner: 10Ejegg) [19:53:54] (03CR) 10Eileen: Update Recurring ModifyAmountTest to check address updated (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031570 (owner: 10Eileen) [19:54:32] (03CR) 10Eileen: "argh - it won't rebase cleanly - I need this to go through first" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031570 (owner: 10Eileen) [19:55:17] damilare: that test patch is failing on purpose cos it needs the next patch which you gave +2 - are you able to +2 it & I can merge them both [19:56:09] oh [19:56:10] sure [19:56:14] thanks [19:57:04] ejegg: just looking at Sam's email - I don't know that we have a reason to say don't go ahead with the Acoustic approach if they need to move soon do we - I'm nervous about it but .... [19:57:28] (03PS2) 10Eileen: Update Recurring ModifyAmountTest to check address updated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031570 [19:57:37] (03CR) 10Damilare Adedoyin: [C:03+2] Update Recurring ModifyAmountTest to check address updated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031570 (owner: 10Eileen) [19:57:52] (03PS2) 10Eileen: Directly save the Email, address, contact in Recurring Modify [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031572 [19:58:00] (03PS3) 10Damilare Adedoyin: Add test for fundraisup email address modification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032478 [19:58:07] (03CR) 10Eileen: [V:03+2] "adding +2 as it passes WITH the follow on" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031570 (owner: 10Eileen) [20:00:03] (03CR) 10Eileen: [C:03+2] "Cool. I'm not 100% sure if the contact will get cleaned up - there are some specific names & emails that get deleted in the tearDown - but" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032478 (owner: 10Damilare Adedoyin) [20:02:31] (03CR) 10Eileen: [C:03+1] "I love seeing all this code ripped out - do we have test cover?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032539 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [20:03:57] (03CR) 10Ejegg: "There is plenty of coverage for the Scheduler itself: https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/drupal/sites/default/" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032539 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [20:09:10] (03CR) 10Ejegg: "Looking really good as far as I can tell. Just one question about a potential removal" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [20:14:23] (03Merged) 10jenkins-bot: Fix WS in SmashPig payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032540 (owner: 10Ejegg) [20:25:59] (03PS11) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [20:26:07] (03CR) 10CI reject: [V:04-1] Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [20:26:43] (03CR) 10Eileen: Move unpacking of external identifiers to message class (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [20:27:50] (03PS12) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [20:28:24] (03PS1) 10Eileen: Whitespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032575 [20:28:25] PROBLEM - Host frlog1002 is DOWN: PING CRITICAL - Packet loss = 100% [20:28:45] ooh, frlog [20:28:55] ah just rebooting [20:30:15] yeah. it's back already. [20:33:13] RECOVERY - Host frlog1002 is UP: PING OK - Packet loss = 0%, RTA = 0.44 ms [20:36:04] (03Merged) 10jenkins-bot: Directly save the Email, address, contact in Recurring Modify [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031572 (owner: 10Eileen) [20:36:05] (03Merged) 10jenkins-bot: Add test for fundraisup email address modification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032478 (owner: 10Damilare Adedoyin) [20:37:38] (03CR) 10Eileen: [C:03+2] "OK - the test cover looks good & it seems like the code it's now calling started out as a copy of this code with some class-adjustments - " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032539 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [20:38:49] thanks eileen! [20:39:39] ejegg: nice to see all that code go - I had a brief misgiving over not having end-to-end test on the next sched date calculation - but it's really hard to do that [20:40:02] ah yeah [20:40:59] (03PS13) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [20:41:13] (03Abandoned) 10Eileen: Whitespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032575 (owner: 10Eileen) [20:49:51] (03CR) 10Eileen: [C:03+2] Exchange Rates entity: support composite key (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [20:51:55] (03CR) 10CI reject: [V:04-1] Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [20:54:15] (03PS14) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [20:56:09] (03Merged) 10jenkins-bot: Allow importing annual recurring donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032539 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [20:58:13] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Declare all our message object fields - https://phabricator.wikimedia.org/T365202 (10Eileenmcnaughton) 03NEW [21:04:04] (03PS3) 10Ejegg: Exchange Rates entity: support composite key [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) [21:04:05] (03PS5) 10Ejegg: ExchangeRate::updateAll API4 action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) [21:04:05] (03PS8) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [21:04:06] (03PS16) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [21:04:07] (03PS8) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [21:04:35] I moved the patch to copy the rates from the old table after most of the others eileen [21:05:40] oh i see now, you gave the first one a C+2 - thanks! [21:10:28] (03CR) 10Eileen: "I went through & this is all the same code as the module with ONE exception - which is the only blocking thing in this patch" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:13:16] (03CR) 10Eileen: ExchangeRate::updateAll API4 action (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:18:27] (03CR) 10CI reject: [V:04-1] Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [21:20:59] (03PS6) 10Ejegg: ExchangeRate::updateAll API4 action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) [21:21:34] (03PS9) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [21:21:35] (03PS17) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [21:21:35] (03PS9) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [21:22:07] (03CR) 10Eileen: [C:03+2] ExchangeRate::updateAll API4 action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:22:21] (03CR) 10Ejegg: "Thanks for the review. Stuff is fixed in PS6!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:25:39] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9807174 (10Eileenmcnaughton) @MDemosWMF it's probably quite a chunk of mucking around t... [21:37:09] (03PS15) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [21:38:01] (03CR) 10Eileen: Move unpacking of external identifiers to message class (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [21:39:00] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9807221 (10MDemosWMF) I'm not sure, possibly USPS provided it that way? There is a form... [21:41:12] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9807224 (10Eileenmcnaughton) I can have a go at doing it in the sql query [21:42:02] dang that's annoying Data Axle sent us addresses with every ucase but Melanie wants it ucfirst - why would they do that if it's not the way it should be done :-( [21:44:10] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9807225 (10Eileenmcnaughton) @MDemosWMF - should city also be mixed case (Seattle) rath... [21:45:52] (03Merged) 10jenkins-bot: Exchange Rates entity: support composite key [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032102 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:45:53] (03Merged) 10jenkins-bot: ExchangeRate::updateAll API4 action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027016 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:59:52] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9807252 (10MDemosWMF) Yes, thanks! [23:57:40] (03PS16) 10Eileen: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 [23:57:48] (03CR) 10Ejegg: [C:03+2] Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen)