[00:00:56] (03PS5) 10Eileen: Remove legacy-code function is_addess_valid [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031092 [00:01:28] (03CR) 10Ejegg: [C:03+2] Remove legacy-code function is_addess_valid [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031092 (owner: 10Eileen) [00:07:46] (03CR) 10Ejegg: "Seems good to do it first, but wouldn't we want to do the "if ($this->getErrorCharacteristic('requeue'... " check outside if the "if (extr" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 (owner: 10Eileen) [00:13:45] (03PS6) 10Eileen: Update recurringQueueTest to our agreed behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031617 [00:17:12] (03Merged) 10jenkins-bot: Move unpacking of external identifiers to message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1030614 (owner: 10Eileen) [00:18:59] (03PS6) 10Eileen: Fix Error handling to check if we already know it is a retry first [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 [00:19:09] (03CR) 10Eileen: "yep - totally - fixed" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 (owner: 10Eileen) [00:19:43] (03Merged) 10jenkins-bot: Remove legacy-code function is_addess_valid [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031092 (owner: 10Eileen) [00:23:20] (03PS7) 10Eileen: Update recurringQueueTest to our agreed behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031617 [00:23:20] (03PS6) 10Eileen: Fix Paypal recur handling to our agreed behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031618 [00:23:20] (03PS4) 10Eileen: Push donation handling to donation queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031626 [00:24:17] (03PS13) 10Eileen: Improve deadlock handling on contribution Insert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 [00:24:30] (03CR) 10CI reject: [V:04-1] Improve deadlock handling on contribution Insert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 (owner: 10Eileen) [00:26:07] (03PS7) 10Eileen: Fix Error handling to check if we already know it is a retry first [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 [00:36:53] (03CR) 10Ejegg: [C:03+2] Fix Paypal recur handling to our agreed behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031618 (owner: 10Eileen) [00:37:48] ejegg: yay - it's going through!! [00:37:56] :) [00:38:11] I was thinking not to deploy this week tho - too close to (your) Friday [00:39:20] I'm confused - the patch I just rebased over git fetch https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm refs/changes/35/1031635/7 has a merge conflict - but I don't think anything merged in the meantime [00:40:08] yeah, i sure wouldn't deploy any queue handling changes tonight [00:41:00] agree [00:42:14] (03PS2) 10Eileen: Superficial clean up in Test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032087 (https://phabricator.wikimedia.org/T357345) [00:42:37] (03CR) 10Ejegg: [C:03+2] Superficial clean up in Test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032087 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [00:42:48] ejegg: are you ok to + 2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1031635 now - I'm just trying to figure out the rebasing over it - but that one I fixed per your comments [00:43:01] oh sure [00:43:23] (03PS8) 10Eileen: Fix Error handling to check if we already know it is a retry first [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 [00:43:29] (03CR) 10Ejegg: [C:03+2] Fix Error handling to check if we already know it is a retry first [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031635 (owner: 10Eileen) [00:43:41] (03CR) 10Ejegg: [V:03+2 C:03+2] Update recurringQueueTest to our agreed behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031617 (owner: 10Eileen) [00:44:10] also this one - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1032107 - I feel like Melanie has confirmed it on staging - we are still having some back & forth but it's on the query not on that part (if you feel like her testing is enough to make it an easy review) [00:44:26] just looking at that one now [00:45:00] yeah I saw the you did one under it which is why I commented on it [00:45:36] I did a trial import on staging & put them in a group - Melanie has some feedback on casing which requires me to change the sql query I'm using - but not the code [00:45:48] & its kinda yuck but .... [00:46:00] why doesn't SQL do a uc_words fn [00:46:16] & why doesn't data axle give us data cased like we want it [00:47:16] Maybe they just get it straight from the USPS? [00:48:55] (03PS3) 10Eileen: Move the last test out of queue2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) [00:49:13] ejegg: yeah if that is the case then why isn't that the 'right' version ? [00:49:35] anyway I'm embracing the joy of CONCAT(UCASE(LEFT(ah_mb_coa_primary_name_72, 1)),LCASE(SUBSTRING(ah_mb_coa_primary_name_72, 2))) [00:49:44] eeeewww [00:49:56] (03CR) 10Cstone: [C:03+2] "thanks for the civi patch, this looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028528 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [00:50:03] lol - that's the simple version - it gets worse but I've fill up your irc [00:50:40] +1 to eew [00:51:02] thanks for the CR cstone ! [00:51:58] (03Merged) 10jenkins-bot: Allow annual donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028528 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [00:53:23] Hmm - I'm thinking about added Address custom data to the demo custom data set - if themers see it looking so 'big' they might update the themes :-) [00:53:46] currently doing the wildest am I human test ive seen from paypal [00:53:59] its a bunch of hedgehogs and a toaster on a rainbow background and i have to click the toaster [00:54:04] Oh wow [00:54:08] oh theres a lion [00:54:10] and a lettuce [00:54:12] amazing [00:54:21] I was locked out of twitter for weeks cos I couldn't figure out how to prove I was human [00:56:05] https://usercontent.irccloud-cdn.com/file/mXyjwnfj/human.png [00:58:26] (03CR) 10Cstone: [C:03+2] Pass frequency_unit for PayPal profile creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028561 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [00:59:52] eileen I'm seeing ncoa in some places and NOCA in others. Is the NOCA/noca a typo? [01:00:28] ejegg: yeah - but I think ncoa is right but we have already put NOCA out there as an option value :-( [01:00:32] (03Merged) 10jenkins-bot: Pass frequency_unit for PayPal profile creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1028561 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [01:00:47] argh! No way to clean that up? [01:00:52] I should confirm with Nora/Melanie & update the option value [01:01:06] that would be way less confusing [01:01:16] but at this stage I think it's 'right' if the text says NCOA but references to the option value are NOCA [01:01:32] I'll add that question on the phab now for for a follow up [01:02:01] OK, it's still pretty confusing to see the 'ncoa' in the comment and the 'noca' in the code [01:02:06] I don't know for sure if the original mistake was mine or Nora's [01:02:14] maybe make that a constant in the code and put a comment on its value? [01:03:21] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9807519 (10Eileenmcnaughton) @MDemosWMF @NNichols we created the data source option val... [01:03:26] https://phabricator.wikimedia.org/T357345#9807519 [01:03:33] thanks! [01:03:59] yeah I think the best is to rename the option value & update the code once they confirm [01:04:07] it will require an upgrader [01:04:16] yep yep [01:07:20] (03CR) 10Ejegg: Add handling to keep old address when a new NCOA address comes in (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [01:07:37] oh ignore those "typo?" comments [01:08:19] I'm happy to see the logic to try to avoid unneeded dupes, just a random suggestion to minutely improve it [01:11:06] (03CR) 10Eileen: "The original function handles formatted amounts -ie" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [01:12:00] ah right, amounts with commas [01:12:45] now that I'm aware of locales which use comma for the decimal separator it feels really wrong to do that [01:14:29] ah, that's too bad the output needs to be an array [01:15:17] The new API action was already feeling a lot more clunky to use than the simple fn [01:15:52] (03PS3) 10Eileen: Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) [01:15:56] (03CR) 10Eileen: Add handling to keep old address when a new NCOA address comes in (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [01:17:52] ejegg: yeah I think it does need to be an array though. (its' mostly used in tests though & I would wrap it on the WMFEnvironmentTrait in a function - also to handle exceptions coming from it) [01:17:52] I'm less sure on whether we need to handled the commas [01:18:11] it does feel fugly & wrong & like it should already be dealt with [01:18:37] any idea why API4 doesn't have a float type? [01:18:44] for parameters? [01:18:47] oversight I think [01:19:03] we do clean up money in the DonationMessage - so prob don't need to in the exchange convert? [01:19:16] ok, I'll assume we don't [01:22:38] those last 2 patches seem OK (aside from the array thing) - but they are the ones that alter the live thing so I feel like they should probably not be merged until next week so we can be careful about the deploy? [01:22:57] yep, sounds fine [01:23:27] also, I think I need to call it quits for the night, so I'll finish reviewing the change-of-address patch and make that array fix tomorrow [01:23:38] have a good rest of your day! [01:25:40] (03PS14) 10Eileen: Improve deadlock handling on contribution Insert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 [01:25:50] night [01:48:36] (03PS1) 10Eileen: Remove now unused get/set contactID from WMFContact.save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032612 (https://phabricator.wikimedia.org/T357471) [02:33:26] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: On import, widen the existing contact lookup to include subset & reversed - https://phabricator.wikimedia.org/T365216 (10Eileenmcnaughton) 03NEW [02:43:34] (03PS1) 10Eileen: Sample code to show how we might prevent more dupes on ingress [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032614 (https://phabricator.wikimedia.org/T365216) [02:44:19] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: On import, widen the existing contact lookup to include subset & reversed - https://phabricator.wikimedia.org/T365216#9807580 (10Eileenmcnaughton) [02:46:44] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10FR-Civi-Dedupe: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196#9807583 (10Eileenmcnaughton) The easiest win here is probably to do something on ingress - ie https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/10... [03:14:17] (03PS3) 10Cstone: Remove href from donate_interface-email-unsub-fail and into the template [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1027139 (https://phabricator.wikimedia.org/T360500) [04:02:31] (03PS1) 10Eileen: Fix mishandling of > & < when importing from sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032617 (https://phabricator.wikimedia.org/T357345) [11:52:09] (03CR) 10Damilare Adedoyin: [C:03+2] Remove now unused get/set contactID from WMFContact.save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032612 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [12:12:05] (03Merged) 10jenkins-bot: Remove now unused get/set contactID from WMFContact.save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032612 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [13:59:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 10FR-France: Card type not shown on Civi for French donations - https://phabricator.wikimedia.org/T360503#9808814 (10Damilare) a:03Damilare [14:30:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9808893 (10SHust) @Damilare we're seeing captured transactions on the dLocal console dated May 15th, but they are still not showing in Civi! Is this normal? [14:30:14] 06Fundraising-Backlog: ACH on PaymentsWiki - Form Changes - https://phabricator.wikimedia.org/T360825#9808895 (10AKanji-WMF) FR-Tech has determined that while we can't put an image inline, we can put a link to a helper image. @RLopez-WMF has drafted this [[ https://asana-user-private-us-east-1.s3.us-east-1.amazo... [15:03:34] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9809003 (10Damilare) Hi @SHust, yes this payments were captured on the 15th but Dlocal hasn't provided the nightly reports since 18th of March, 2024 and as such we are unable to... [15:22:12] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): [S] Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9809137 (10Tsevener) [15:27:47] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): [S] Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9809168 (10Tsevener) [16:09:15] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 13Patch-For-Review: Civi shouldn't show "cancellation not supported" message for processors where we handle schedule - https://phabricator.wikimedia.org/T335712#9809314 (10Ejegg) a:03Ejegg [16:09:29] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): [S] Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9809316 (10Tsevener) a:05Tsevener→03None [16:09:33] 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9809317 (10Dwisehaupt) [16:12:21] 06Fundraising-Backlog: ACH on PaymentsWiki - Form Changes - https://phabricator.wikimedia.org/T360825#9809343 (10EMartin) Thanks @AKanji-WMF I can't see the image but that link approach works. [16:41:05] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9809483 (10MDemosWMF) @Eileenmcnaughton Thanks! I am seeing capitalized street types t... [17:20:30] (03CR) 10Ejegg: "Let's assume it has no commas. I'd really like to enforce the type on input, so I've filed this issue upstream: https://lab.civicrm.org/de" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [17:39:22] (03PS1) 10Damilare Adedoyin: Set payment submethod in Card Create payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1032840 (https://phabricator.wikimedia.org/T360503) [17:41:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9809704 (10SHust) Thanks for the update @Damilare. [17:41:49] (03PS1) 10Damilare Adedoyin: WIP: Check authorize result if payment submethod is empty [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1032841 (https://phabricator.wikimedia.org/T360503) [17:41:59] (03PS4) 10Eileen: Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) [17:42:03] (03CR) 10Ejegg: [C:03+2] Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [17:45:52] (03PS3) 10Eileen: Fix mishandling of > & < when importing from sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032617 (https://phabricator.wikimedia.org/T357345) [17:46:23] (03CR) 10Ejegg: [C:03+2] "fbe6a17fe0471b62e085188cd762ea3aaf9996db" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032617 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [17:50:15] (03PS4) 10Eileen: Move the last test out of queue2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) [17:50:17] (03CR) 10Ejegg: [C:03+2] Move the last test out of queue2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [18:05:14] (03Merged) 10jenkins-bot: Add handling to keep old address when a new NCOA address comes in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032107 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [18:24:02] (03PS3) 10Eileen: Create new api to process a record from file, replacing on drush commands [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032146 (https://phabricator.wikimedia.org/T365091) [18:24:05] (03CR) 10Ejegg: [C:03+2] Create new api to process a record from file, replacing on drush commands [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032146 (https://phabricator.wikimedia.org/T365091) (owner: 10Eileen) [18:43:53] (03Merged) 10jenkins-bot: Create new api to process a record from file, replacing on drush commands [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032146 (https://phabricator.wikimedia.org/T365091) (owner: 10Eileen) [19:12:17] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Something is causing JPY Refunds that are separate line items in civi - https://phabricator.wikimedia.org/T360974#9809955 (10XenoRyet) [19:12:18] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Something going on with Banner Status Codes in Brazil campaign? - https://phabricator.wikimedia.org/T360821#9809956 (10XenoRyet) [19:12:20] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Add a job to check that deleted contact donations are not lost. - https://phabricator.wikimedia.org/T359422#9809957 (10XenoRyet) [19:12:23] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Matching gift import - https://phabricator.wikimedia.org/T356445#9809958 (10XenoRyet) [19:12:24] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Email sent through civi giving Mailing Error Unable to send email. Please report this message to the site administrator - https://phabricator.wikimedia.org/T353975#9809960 (10XenoRyet) [19:12:25] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Change URL in WMF Recurring Failure template - https://phabricator.wikimedia.org/T354185#9809959 (10XenoRyet) [19:12:26] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Pending transaction resolver resolving multiple donations per donor per run - https://phabricator.wikimedia.org/T353089#9809962 (10XenoRyet) [19:12:28] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: fail to import recurring donation to civi due to missing recurring token which exist - https://phabricator.wikimedia.org/T353930#9809961 (10XenoRyet) [19:12:32] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343#9809964 (10XenoRyet) [19:12:36] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: missing recurring donation record in civicrm_contritbution table - https://phabricator.wikimedia.org/T350754#9809967 (10XenoRyet) [19:12:40] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Error upon event import (Stripe) - https://phabricator.wikimedia.org/T336895#9809968 (10XenoRyet) [19:12:44] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10FR-Adyen: Better handle terse Adyen idempotency result - https://phabricator.wikimedia.org/T331319#9809969 (10XenoRyet) [19:12:53] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Add gateway label to 'IP repeat count' grafana graph - https://phabricator.wikimedia.org/T327958#9809971 (10XenoRyet) [19:12:57] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10FR-Adyen: Handle issuer timeouts via Adyen - https://phabricator.wikimedia.org/T331317#9809970 (10XenoRyet) [19:13:01] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Something is causing a lot of deadlocks in ConfigAndLog - https://phabricator.wikimedia.org/T320287#9809973 (10XenoRyet) [19:13:05] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Adyen error code 703 crashes recurring charge job - https://phabricator.wikimedia.org/T360399#9809976 (10XenoRyet) [19:13:09] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Documentation: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583#9809974 (10XenoRyet) [19:13:15] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Issue mapping Adyen error code leads to bad payments-init message - https://phabricator.wikimedia.org/T360901#9809975 (10XenoRyet) [19:13:21] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Find all the places we aren't rounding properly resulting in weird floating point issues - https://phabricator.wikimedia.org/T353378#9809978 (10XenoRyet) [19:13:25] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig: Standardize message and time limit options for all scripts - https://phabricator.wikimedia.org/T357001#9809977 (10XenoRyet) [19:13:29] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Uncaught TypeError: Cannot read properties of undefined (reading 'origin') - https://phabricator.wikimedia.org/T352458#9809980 (10XenoRyet) [19:13:33] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Adyen Invalid card number breaking error logs - https://phabricator.wikimedia.org/T352254#9809981 (10XenoRyet) [19:13:41] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Documentation: Add new diagram to dlocal docs covering the new 'Wallet disabled' flow - https://phabricator.wikimedia.org/T345752#9809982 (10XenoRyet) [19:13:45] 06Fundraising Tech Chaos Holding Pen: error from Amazon: InvalidParameterValue - https://phabricator.wikimedia.org/T344451#9809983 (10XenoRyet) [19:13:49] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Attempt id not resetting when testing repeatedly locally with dlocal - https://phabricator.wikimedia.org/T335601#9809984 (10XenoRyet) [19:13:53] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: ApplePay token amount-mismatch - https://phabricator.wikimedia.org/T324413#9809985 (10XenoRyet) [19:13:57] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Documentation: Document Donor Data Delivery Tool - https://phabricator.wikimedia.org/T323144#9809986 (10XenoRyet) [19:14:01] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Documentation: Document which tables are hit by each process-control job - https://phabricator.wikimedia.org/T322243#9809987 (10XenoRyet) [19:14:05] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Documentation: Documentation: Banner data flow and data stores - https://phabricator.wikimedia.org/T296222#9809989 (10XenoRyet) [19:14:11] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: import contact with 4 parts of addressee_display, find our if add suffix or middle name - https://phabricator.wikimedia.org/T326585#9809990 (10XenoRyet) [19:14:17] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Can’t mark CentralNotice translations as reviewed - https://phabricator.wikimedia.org/T308614#9809988 (10XenoRyet) [19:16:49] ooo, fun phab spam [19:19:15] Chaos cleanup. I moved everything that wasn't high priority, and the latest update was more than 30 days ago over to the Chaos Holding Pen. [19:19:51] We can fine tune when we want stuff to go over there, but I figured this was a good start. [19:22:36] * greg-g nods [19:22:40] good start [19:55:29] (03approved) 10dwisehaupt: Upgrade civi to 5.73.1 on bookworm (php8.2) [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/8 [19:55:48] (03open) 10dwisehaupt: Upgrade civi to 5.73.1 on bookworm (php8.2) [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/8 [19:56:10] hmmm... new wikibugs things for gitlab repos. [19:58:43] i think that was done at the hackathon something related at least [19:58:50] (03CR) 10Ejegg: "I think the move to API4 and the handling looks good, but I realize we have been silently swallowing the exceptions when they don't match " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 (owner: 10Eileen) [19:59:19] ejegg: do you know if we purposely stopped pulling in the device width and height into the utmkey [19:59:34] cstone: I think that's from the banner team [19:59:46] yeah i asked them too just not sure if i missed something [19:59:52] we don't have any code that touches it in donationinterface [20:00:00] oh what did they say? [20:00:06] its late in the UK haha [20:00:24] no answer yet [20:10:24] looks like they removed it cause they weren't using it so on purpose [20:16:31] thanks for clearing that up! [20:55:11] (03merge) 10dwisehaupt: Upgrade civi to 5.73.1 on bookworm (php8.2) [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/8 [20:56:39] (03PS1) 10Ejegg: Update phpseclib [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032865 [20:56:41] (03CR) 10Ejegg: [C:03+2] Update phpseclib [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032865 (owner: 10Ejegg) [21:03:07] (03CR) 10Ejegg: [V:03+2 C:03+2] Update phpseclib [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032865 (owner: 10Ejegg) [21:03:19] (03PS4) 10Eileen: Fix mishandling of > & < when importing from sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032617 (https://phabricator.wikimedia.org/T357345) [21:03:21] (03CR) 10Ejegg: [V:03+2 C:03+2] Fix mishandling of > & < when importing from sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032617 (https://phabricator.wikimedia.org/T357345) (owner: 10Eileen) [21:03:29] (03PS5) 10Eileen: Move the last test out of queue2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) [21:03:58] (03CR) 10Ejegg: [C:03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032120 (https://phabricator.wikimedia.org/T270672) (owner: 10Eileen) [21:06:35] (03PS15) 10Eileen: Improve deadlock handling on contribution Insert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 [21:06:38] (03CR) 10Eileen: Improve deadlock handling on contribution Insert (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1031162 (owner: 10Eileen) [21:11:27] (03CR) 10Eileen: Exchange Rate Convert API action (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:13:28] hi eileen ! [21:13:45] hey ejegg [21:13:54] I was just getting some review in first, to later rebase and fix that convert patch [21:15:06] oh cool - I' was just checking up on all the stuff that has happened [21:15:20] (03PS1) 10Eileen: Remove always-true-if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) [21:15:30] well let me do that rebase + fix now, while you're checking in [21:17:52] cool [21:19:51] oh hey we should throw an ExchangeRatesException if the currency has no rate [21:20:02] oh i see, we do [21:20:14] nvm [21:20:18] :-) [21:20:54] just wasn't being noticed by the IDE, i guess because it can't quite follow that API wiring [21:21:16] (03PS10) 10Ejegg: Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) [21:21:16] (03PS18) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [21:21:16] (03PS10) 10Ejegg: Switch exchange_rates_convert calls to new API [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032511 (https://phabricator.wikimedia.org/T270666) [21:21:20] we are really starting to see some code reduction on the drupal side now huh? [21:21:27] yes! [21:21:46] (03CR) 10Eileen: [C:03+2] Exchange Rate Convert API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032109 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [21:21:55] I guess we should start thinking about replacing the contrib stuff too, like the environment indicator [21:23:24] oh yeah - that one is quite nice isn't it [21:23:49] are there any others we'd miss? [21:23:58] ctools I think is just to support the indicator [21:24:13] not sure admin_menu or advanced_help are doing much for us these days [21:25:40] yeah I think admin menu is useful for managing drupal menus but not relevant to standalone [21:26:10] I put a question out on chat about env indicator [21:26:23] & can also discuss in Hamburg [21:26:30] ooh, one more thing I need to move for the exchange rates - generating that static file :) [21:27:43] that's not blocking though, we only update that every 6 months or so [21:28:27] ejegg: yeah - the main thing is I was gonna leave those last 2 patches until next week just so we can be careful about the deployment [21:28:40] sounds good [21:29:51] also - I pasted this here before - but worth doing this locally [21:29:52] drush @wmff dis -y metrics_reporting [21:30:00] oh yep, I just did that [21:30:01] so it's not annoying when that patch gets merged [21:30:16] cstone: ^^^ [21:32:30] (03PS2) 10Eileen: Remove always-true-if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) [21:37:45] (03CR) 10Eileen: Remove always-true-if (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [21:38:49] (03CR) 10Ejegg: Remove always-true-if (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [21:39:15] (03PS3) 10Eileen: Remove always-true-if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) [21:39:20] (03CR) 10Ejegg: [C:03+2] Remove always-true-if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [21:45:35] (03PS4) 10Eileen: Remove always-true-if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) [21:45:35] (03PS1) 10Eileen: More follow on clean up - remove contact_id variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032878 (https://phabricator.wikimedia.org/T357471) [21:49:19] (03PS2) 10Eileen: More follow on clean up - remove contact_id variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032878 (https://phabricator.wikimedia.org/T357471) [21:53:54] (03CR) 10Ejegg: "hmm, I'm not sure this is exactly the way either, in case some languages need to put something after the email address to say 'please cont" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1027139 (https://phabricator.wikimedia.org/T360500) (owner: 10Cstone) [22:03:54] (03CR) 10CI reject: [V:04-1] More follow on clean up - remove contact_id variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032878 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:06:05] (03PS2) 10Eileen: Fully remove metrics reporting module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032049 (https://phabricator.wikimedia.org/T270668) [22:06:11] (03CR) 10Ejegg: [C:03+2] Fully remove metrics reporting module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032049 (https://phabricator.wikimedia.org/T270668) (owner: 10Eileen) [22:07:59] (03CR) 10CI reject: [V:04-1] More follow on clean up - remove contact_id variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032878 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:17:03] (03PS3) 10Eileen: More follow on clean up - remove contact_id variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032878 (https://phabricator.wikimedia.org/T357471) [22:29:42] thanks rip metrics_reporting [22:29:49] (03PS1) 10Eileen: WIP - out of interest - lets see what fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032886 [22:32:59] eileen: so we should start adding that banner history log id directly to the contribution tracking message, right? [22:35:19] (03Merged) 10jenkins-bot: Remove always-true-if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032870 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:35:20] (03Merged) 10jenkins-bot: Fully remove metrics reporting module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032049 (https://phabricator.wikimedia.org/T270668) (owner: 10Eileen) [22:41:23] (03PS1) 10Ejegg: Add banner history log ID directly to c_t message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1032889 (https://phabricator.wikimedia.org/T270672) [22:51:15] (03CR) 10CI reject: [V:04-1] WIP - out of interest - lets see what fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032886 (owner: 10Eileen) [22:59:17] (03PS1) 10Ejegg: Use banner_history_log_id from c_t queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032893 (https://phabricator.wikimedia.org/T270672) [23:06:17] (03PS2) 10Ejegg: Use banner_history_log_id from c_t queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032893 (https://phabricator.wikimedia.org/T270672) [23:15:06] (03PS1) 10Ejegg: Remove BannerHistoryQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032895 (https://phabricator.wikimedia.org/T270672) [23:23:54] (03PS1) 10Ejegg: Stop sending messages to banner history queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1032896 (https://phabricator.wikimedia.org/T270672)