[00:34:03] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9828315 (10Dwisehaupt) [01:09:43] (03PS2) 10Eileen: Fix WMFDonor.update to work on non-donors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034643 (https://phabricator.wikimedia.org/T363959) [01:10:05] (03PS3) 10Eileen: Fix WMFDonor.update to work on non-donors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034643 (https://phabricator.wikimedia.org/T363959) [01:11:09] (03CR) 10Eileen: "I've fixed the issue -but I do have some reseverations about this change - because it would make it possible to populate non donors in wmf" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034643 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [01:40:23] (03PS1) 10Ejegg: Upgrade eligibility: ignore declines after 1 year [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) [02:07:04] (03PS2) 10Ejegg: WIP Show custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035575 (https://phabricator.wikimedia.org/T364913) [02:07:43] eileen: ^^^ does the basic job of showing any old custom email data in the summary, though it needs work [02:17:14] ejegg|afk: ok - will look [02:18:04] (03PS3) 10Ejegg: WIP Show custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035575 (https://phabricator.wikimedia.org/T364913) [02:21:34] later all [02:42:34] (03PS2) 10Eileen: Move Exchange Rates exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034525 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [02:47:12] (03CR) 10Eileen: [C:03+2] "I just rebased this & fixed the whitespace" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034525 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [02:47:47] (03CR) 10Eileen: [C:03+2] Update CurrencyRates.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1034509 (owner: 10Ejegg) [02:49:55] (03CR) 10Eileen: "I wonder if our locals are already getting this - I see" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035067 (owner: 10Ejegg) [03:10:52] (03Merged) 10jenkins-bot: Move Exchange Rates exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034525 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [03:10:53] (03Merged) 10jenkins-bot: Update CurrencyRates.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1034509 (owner: 10Ejegg) [05:30:45] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1035117 (owner: 10L10n-bot) [11:17:17] (03Abandoned) 10Jgleeson: DO NOT MERGE: sticky tape to get the silverpop export running on vagrant. Should not be needed for new builds as a result of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/609557/ [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/616114 (owner: 10Jgleeson) [11:44:11] (03CR) 10Jgleeson: "The SQL looks good. The surrounding SQL took a while for my brain to parse and I'm slightly worried at how complicated these SQL files are" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) (owner: 10Ejegg) [11:44:35] (03CR) 10Jgleeson: [C:03+2] "LGTM! left some thoughts in earlier comment." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) (owner: 10Ejegg) [11:45:29] (03CR) 10CI reject: [V:04-1] Upgrade eligibility: ignore declines after 1 year [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) (owner: 10Ejegg) [11:46:39] huh CI doesn't like it [11:51:25] ok the tests do fail for me locally [11:51:51] (03CR) 10Jgleeson: [C:04-1] "tests also failing locally :(" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) (owner: 10Ejegg) [12:40:19] (03CR) 10Jgleeson: [C:04-1] "I think this is a flakey test problem. At first the test below failed, but then it passed..." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) (owner: 10Ejegg) [12:48:23] https://www.bbc.co.uk/news/articles/czkkr8l7jjxo :( [12:50:44] (03CR) 10Jgleeson: [C:03+2] "Woop woop" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1034582 (owner: 10Ejegg) [13:14:50] thanks for all the CR jgleeson ! [13:14:58] np! [13:15:00] I'll look at that silverpop export patch [13:15:04] and try to figure out those tests [13:15:14] been a while since I had to debug python tests... [13:15:20] same [13:18:12] (03CR) 10Ejegg: "Oh nice, maybe we can just add the vendor dir to that pattern. Would that be coming from buildkit?" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035067 (owner: 10Ejegg) [13:19:21] (03Merged) 10jenkins-bot: Remove all curl overrides in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1034582 (owner: 10Ejegg) [13:20:08] (03CR) 10Jgleeson: [C:03+2] "This feels like a big step forward! maybe cause of how many times we get lost in these methods debugging? Nice job." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035444 (owner: 10Ejegg) [13:25:54] (03Merged) 10jenkins-bot: Remove curl_transaction and associated methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035444 (owner: 10Ejegg) [13:36:06] (03CR) 10Jgleeson: [C:03+2] "I spent longer than expected on this one, reading https://developer.mozilla.org/en-US/docs/Web/CSS/white-space :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1031945 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [13:41:55] (03CR) 10Jgleeson: [C:03+2] "Uncle Bob would be proud." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1031931 (owner: 10Ejegg) [13:42:22] (03Merged) 10jenkins-bot: PHPdoc comments and typehints for Fundraiseup audit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1031931 (owner: 10Ejegg) [13:46:23] jgleeson: hah, I initially just put tags around it but the IDE's deprecation warning reminded me I'm a dinosaur [13:46:33] :) [13:46:48] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: Gravy backend createPayment - https://phabricator.wikimedia.org/T364506#9829695 (10Damilare) a:03Damilare [13:48:12] oh i mean [13:48:14] [13:48:38] [13:48:47] back soon [13:48:57] jgleeson: now that we have civi upgraded and can use smarty5 I'm going to try using bookworm again [13:50:51] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate turning off smarty pre-compile - https://phabricator.wikimedia.org/T227039#9829701 (10Ejegg) @Eileenmcnaughton is this still relevant? [13:51:18] argh, so many google things are broken in firefox right now [13:51:28] keyboard shortcuts firing when i'm trying to type text [13:51:43] the chat in meet has been doing it for a few weeks [13:51:49] and now the search in gmail :(( [13:51:59] chromIE [13:53:10] (03Merged) 10jenkins-bot: Don't wrap text in 'change email' link [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1031945 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [14:00:36] (03PS1) 10Ejegg: Update composer.lock to match vendor [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1035782 [14:00:39] (03CR) 10Ejegg: [C:03+2] Update composer.lock to match vendor [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1035782 (owner: 10Ejegg) [14:07:43] (03PS1) 10Ejegg: Remove unneeded anchor link in email preferences form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035784 [14:10:01] (03Merged) 10jenkins-bot: Update composer.lock to match vendor [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1035782 (owner: 10Ejegg) [14:17:34] (03PS3) 10Ejegg: Use bookworm images by default [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1025454 [14:17:34] (03PS1) 10Ejegg: Remove obsolete 'version' from docker-compose [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035786 [14:51:05] 06Fundraising-Backlog: Scoping: Supporting SMS campaign functionality in Acoustic - https://phabricator.wikimedia.org/T365826 (10AKanji-WMF) 03NEW [14:52:08] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic - request to store click data in mailing stats - https://phabricator.wikimedia.org/T344383#9829885 (10AKanji-WMF) @JMando - this should be in place now - do you have what you need? [15:07:12] (03PS2) 10Ejegg: Remove obsolete 'version' from docker-compose [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035786 [15:07:12] (03PS1) 10Ejegg: Delete banner history qc from scripts [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035790 [15:10:41] jgleeson: i just rebuilt local images on bookworm and there are basically no warnings now! [15:10:51] awesome! [15:10:56] will take a look [15:12:46] unfortunately now I can't seem to run the tools tests because of the new python version :P [15:12:54] figuring that out... [15:19:58] so ejegg I need to pull down https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1025454 again and rebuild civicrm on the latest? [15:20:26] yep yep [15:20:30] cool [15:20:33] also make sure you have the latest civicrm too [15:21:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9830011 (10MBeat33) Refunds from the script in {T365751} also seem to be missing from Civi for the lack of these audit files. [15:22:12] hi jgleeson please can you help reset my gr4vy details whenever you get the chance [15:23:16] will do! [15:29:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9830022 (10Damilare) Thanks @MBeat33, they've included a manual export for the reports in the last update they sent. We'd review them and hopefully would be able to get the miss... [15:30:52] ok rebuilt and reinstalled [15:31:13] I did see a few warnings during the build but I guess that's builtkit [15:33:29] hmm this one stood out when consuming the queues [15:33:31] [PHP Warning] file_put_contents(/var/spool/prometheus/donations.prom): Failed to open stream: No such file or directory at /srv/civi-sites/wmff/vendor/jackgleeson/stats-collector/src/Exporter/Prometheus.php:124 [15:33:54] did we change how that stuff works ejegg [15:33:57] oh odd, i didn't see that [15:34:09] it's using a civi setting for the path now [15:34:48] I recloned buildkit [15:34:56] also I'm seeoing civicrm.wmf.INFO: Executing: banner-history {"queue_consumer":"banner-history"} [15:34:58] In Consume.php line 75: [15:35:00] [15:35:02] [Error] [15:35:04] Class "\Civi\WMFQueue\BannerHistoryQueueConsumer" not found [15:35:06] -o [15:35:18] https://gerrit.wikimedia.org/r/1035790 [15:35:30] we got rid of that [15:35:33] when running ./scripts/consume-queues.sh [15:35:41] it's just a column on c_t now [15:35:43] ah [15:36:23] (03CR) 10Jgleeson: [C:03+2] Remove obsolete 'version' from docker-compose [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035786 (owner: 10Ejegg) [15:36:51] (03CR) 10Jgleeson: [V:03+2 C:03+2] Remove obsolete 'version' from docker-compose [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035786 (owner: 10Ejegg) [15:37:02] (03CR) 10Jgleeson: [V:03+2 C:03+2] Delete banner history qc from scripts [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035790 (owner: 10Ejegg) [15:37:14] thanks! [15:38:26] (03PS4) 10Jgleeson: Exclude dirs from scanning under CiviCRM [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035067 (owner: 10Ejegg) [15:38:26] (03PS4) 10Jgleeson: Use bookworm images by default [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1025454 (owner: 10Ejegg) [15:38:31] just rebasing [15:38:35] yep yep [15:38:48] oh eileen said that exclude dir one might not be needed [15:39:16] but I didn't see where else that was being set [15:41:42] ok queues script is happy [15:41:52] how about the prometheus out path [15:42:05] I guess that is unrelated to bookworm [15:43:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Not capturing transactions in ZAR - https://phabricator.wikimedia.org/T364792#9830072 (10MBeat33) Thanks Damilare [15:45:26] jgleeson: ah, latest buildkit may be needed too [15:45:31] in wmff/install.sh [15:45:33] drush vset metrics_reporting_prometheus_path "${CMS_ROOT}/sites/default/files/prometheus/" [15:45:39] oh wait, that's the drush var [15:46:20] yeah I recloned buildkit [15:46:22] **** Clone CiviCRM Buildkit [15:46:24] src/civicrm-buildkit exists. Remove and re-clone CiviCRM Buildkit repo? [yN] y [15:46:26] Are you sure? This will delete src/civicrm-buildkit, including local branches. [yN] y [15:46:28] Cloning into 'src/civicrm-buildkit'... [15:46:30] so that should be good [15:47:08] anyway based on this latest test, I'd say bookworm is good to go locally [15:47:10] hmm do I have it overridden in a local file? [15:47:12] hello PHP 8 [15:47:15] woohoo php8! [15:49:28] ok, i guess we should get the CI runners to use bookworm soon too [15:52:23] ok that's +2ed and merged. I had to rebase it on master to get it mergable and I guess we can work out what to do with Eileen's scan patch when she's around Monday [15:52:34] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1025454 [15:52:52] not sure why wikibugs is quiet about it [15:52:57] (03PS5) 10Jgleeson: Use bookworm images by default [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1025454 (owner: 10Ejegg) [15:53:03] ah [15:53:05] (03CR) 10Jgleeson: [V:03+2] Use bookworm images by default [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1025454 (owner: 10Ejegg) [15:57:15] it dropped/was probably restarted [15:59:25] ahh [15:59:54] just grabbing coffee be there in 2 mins [15:59:58] arr, looks like the end of the line for nosetests [16:01:04] oh look there's a pynose project to make it work after python 3.10 [16:22:17] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9830146 (10KHaggard) >>! In T363959#9827632, @Eileenmcnaughton wrote: > @KHaggard we are also pushing up slightly different words - Non donor vs No... [17:40:08] (03PS1) 10Jgleeson: Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) [17:41:37] have a good weekend fr-tech! catch you all tuesday (wednesday cstone!) [17:42:06] (03CR) 10CI reject: [V:04-1] Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) (owner: 10Jgleeson) [17:42:16] boo [17:43:06] oh wow. do we really have that many tests checking the log output [17:45:20] oh I see, Request URL is not set in the tests [17:45:48] ok I'll look at that next week, it was a nice to have for today [17:45:51] I'll mark it as WIP [17:51:37] damilare: are those failmails because the email header is wrong? [17:52:39] no it had to do with the syntax and the test file name I was using, I was able to resolve them using csvformat to change from comma to semicolon separator [17:53:25] and also adding quotes to the strings [17:53:45] I also renamed the header [18:00:25] (03PS1) 10Pcoombe: Updating from utm_ to wmf_ parameters [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1035806 (https://phabricator.wikimedia.org/T351325) [18:10:52] ejegg: how can I check if a trxn made it to the donations queue from the audit import? [18:13:10] 06Fundraising-Backlog, 07Epic, 10MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), 13Patch-For-Review: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9830761 (10Pcoombe) I've updated the donatewiki on-wiki javascript to accept either utm_ or wmf_ style pa... [18:13:43] damilare: well, it should show up in civi soon enough [18:13:52] or at least in the donations queue log [18:14:00] queue consumer log that is [18:15:40] does the audit runner log the number of things sent to queues too? [18:16:01] hmm haven't seen any of the transactions in the logs for the last hour [18:16:11] huh [18:16:20] Missing transaction summary: [18:16:21] Regular donations: 3 [18:16:23] 20240515: 3 [18:16:25] Refunds and chargebacks: 0 [18:16:27] Recurring donations: 0 [18:16:29] Transaction IDs: [18:16:31] DLOCAL T-648-92272b72-ac4d-485d-9a50-b74e214b1614 [18:16:33] DLOCAL T-648-967cd563-1c01-4421-beff-a5b6573d5242 [18:16:35] DLOCAL T-648-0cf2d9a4-a32a-422b-8f59-b5eb474fff62 [18:20:41] 14Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 07recurring upgrade: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9830787 (10AMJohnson) Hey @Ejegg! I'm writi... [18:20:54] 14Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 07recurring upgrade: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9830788 (10AMJohnson) 05Resolved→03Open [18:28:16] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Sprint H - Priorities (WIP) - https://phabricator.wikimedia.org/T363121#9830819 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [18:31:05] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9830824 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Work complete for this week. Closing. [18:35:32] 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2425Q1 maintenance window - https://phabricator.wikimedia.org/T337582#9830841 (10Dwisehaupt) [18:35:54] 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2425Q1 maintenance window - https://phabricator.wikimedia.org/T337582#9830842 (10Dwisehaupt) [18:51:17] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9830856 (10KHaggard) Also @Eileenmcnaughton Can I just confirm: you would like me to run a query in Acoustic for all non-donors and manually set th... [19:07:38] (03PS2) 10Ejegg: Upgrade eligibility: ignore declines after 1 year [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035600 (https://phabricator.wikimedia.org/T363433) [19:07:38] (03PS1) 10Ejegg: Use pynose to provide nosetests [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035813 [19:09:10] OK, so that test runs correctly for me locally if I install the newer version of nosetests [19:09:20] ahh, it's also the second time I've run it [19:09:31] but I think we drop all the tables between tests [19:09:39] so hopefully that doesn't matter [19:18:29] (03CR) 10Ejegg: [C:03+2] "Thanks, pcoombe, this looks good!" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1035806 (https://phabricator.wikimedia.org/T351325) (owner: 10Pcoombe) [19:24:10] (03Merged) 10jenkins-bot: Updating from utm_ to wmf_ parameters [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1035806 (https://phabricator.wikimedia.org/T351325) (owner: 10Pcoombe) [19:27:42] (03PS2) 10Eileen: Fail exchange rates more gracefully on locals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034559 (https://phabricator.wikimedia.org/T270666) [19:27:47] (03CR) 10Ejegg: [C:03+2] Fail exchange rates more gracefully on locals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034559 (https://phabricator.wikimedia.org/T270666) (owner: 10Eileen) [19:31:54] (03PS3) 10Eileen: Move wrapper function for contribution_recur_insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035563 (https://phabricator.wikimedia.org/T365415) [19:38:38] (03CR) 10Ejegg: [C:03+2] Move wrapper function for contribution_recur_insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035563 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [19:46:49] (03PS3) 10Eileen: Take a copy of contribution_insert back to the checks class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035564 (https://phabricator.wikimedia.org/T365415) [19:47:16] (03CR) 10Ejegg: [C:03+2] "OK, agreed that the temporary code duplication is worth the simplification in the main queue insert function." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035564 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [19:47:46] (03PS4) 10Eileen: Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) [19:47:50] (03CR) 10Ejegg: [C:03+2] Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [19:48:49] (03Merged) 10jenkins-bot: Fail exchange rates more gracefully on locals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034559 (https://phabricator.wikimedia.org/T270666) (owner: 10Eileen) [20:00:24] (03Merged) 10jenkins-bot: Move wrapper function for contribution_recur_insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035563 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:10:27] (03Merged) 10jenkins-bot: Take a copy of contribution_insert back to the checks class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035564 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:10:29] (03Merged) 10jenkins-bot: Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:27:53] (03PS1) 10Ejegg: Delete 'isBatchProcessor' in extras [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035821 (https://phabricator.wikimedia.org/T336024) [20:28:05] 06Fundraising-Backlog: utm log is showing values when utm info in contribution tracking is NULL - https://phabricator.wikimedia.org/T365883 (10Cstone) 03NEW [20:29:26] (03Abandoned) 10Ejegg: Stop using batch_mode in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/934374 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [20:37:00] (03PS1) 10Ejegg: Stop using batch_mode in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035823 (https://phabricator.wikimedia.org/T336024) [20:42:41] (03PS2) 10Ejegg: Delete 'isBatchProcessor' in extras [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035821 (https://phabricator.wikimedia.org/T336024) [20:42:41] (03PS2) 10Ejegg: Stop using batch_mode in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035823 (https://phabricator.wikimedia.org/T336024) [20:42:41] (03PS1) 10Ejegg: Get rid of the rest of batch processor code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035824 (https://phabricator.wikimedia.org/T336024) [20:43:19] the lure of code deletion has me messing around in DonationInterface rather than trying to upstream that email custom field stuff [20:44:54] (03CR) 10CI reject: [V:04-1] Get rid of the rest of batch processor code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035824 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [20:50:06] (03PS3) 10Ejegg: Stop using batch_mode in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035823 (https://phabricator.wikimedia.org/T336024) [20:50:06] (03PS2) 10Ejegg: Get rid of the rest of batch processor code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035824 (https://phabricator.wikimedia.org/T336024) [21:24:07] (03Merged) 10jenkins-bot: Remove soft credit handling from newly split code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035567 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [21:29:55] where did we get on giving each job its own user, just that it would be possible but annoying to set up? [21:30:54] I think we just never quite got to the point of discussing / agreeing it - esp around the naming convention [21:31:14] ahh well if naming was involved then thats going to take even longer :P [21:31:18] it's not bad to set up if we only do it on prod - it's more annoying if we want to replicate locally [21:31:20] :-) [21:31:33] there was also a question of which jobs [21:31:43] mainly for me audit [21:32:13] OK - well maybe if you want to propose something? Basically to set up on prod there are 2 things [21:32:13] 1) create a user (manually) [21:32:27] 2) alter the process control job to refer to the user [21:33:56] (03PS1) 10Eileen: Consolidate naming on non-donor fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035833 (https://phabricator.wikimedia.org/T363959) [21:34:14] ok cool ill add to my next week list, its the level of dont really need it until couple very specific situations like right now where there is mystery donation with no ct id [21:34:29] (03CR) 10Eileen: [C:03+2] "oops my original was merged to deploy..." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035833 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [21:35:34] (03Merged) 10jenkins-bot: Consolidate naming on non-donor fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035833 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [21:36:30] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035834 [21:36:45] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035834 (owner: 10Eileen) [21:37:04] (03CR) 10Eileen: [V:03+2 C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035834 (owner: 10Eileen) [21:37:06] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035834 (owner: 10Eileen) [21:37:40] !log tools upgraded from 36840b71 to 8c98b674 [21:37:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:46:38] (03Merged) 10jenkins-bot: Consolidate non-donor label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035830 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [21:50:04] im gona head out going to see fiddler on the roof and need to fight traffic [21:52:13] (03PS1) 10Ejegg: Remove ext-curl dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035835 [21:52:14] (03PS1) 10Ejegg: Remove code to generate XML trees [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035836 [22:01:28] (03PS1) 10Ejegg: Remove communicationType and response parsing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035838 [22:02:58] enjoy! [22:06:21] (03PS1) 10Ejegg: Delete old globalcollect js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035839 [22:08:25] (03CR) 10CI reject: [V:04-1] Delete old globalcollect js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035839 (owner: 10Ejegg) [22:16:08] (03PS2) 10Ejegg: Delete old globalcollect js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035839 [22:16:08] (03PS1) 10Ejegg: Delete a bunch more unused functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035840 [22:19:41] (03PS1) 10Ejegg: Delete ReturnValueMap [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035841 [22:24:29] (03PS1) 10Ejegg: Delete a drupal shim [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035842 [23:53:04] (03PS8) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) [23:59:05] (03PS9) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) [23:59:10] (03CR) 10Jdlrobson: "Yeh currently that was by design but we can change that for now (I would advise on the long term, you may want to remove that support for " [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) (owner: 10Jdlrobson)