[00:48:37] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1039886 [00:48:43] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1039886 (owner: 10Ejegg) [00:49:50] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1039886 (owner: 10Ejegg) [01:34:32] !log fundraising civicrm upgraded from 286bd2b8 to 757f8528 [01:34:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:36:08] ejegg: did you ever get the test paypal account saying You've been inactive for a while, so we logged you out to protect your account. Return to the merchant and restart the payment process. [01:36:28] ive tried incognito and switching back to donor and it doesnt change it its also going to the prod one but the urls locally are all sandbox [01:37:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Move donation missing from donation ... menu in civi - https://phabricator.wikimedia.org/T366768#9869670 (10Ejegg) OK, this is back on production and the upstream patch is merged. [01:38:15] cstone: oh weird [01:38:24] no, i haven't gotten that [01:41:43] cstone wait, so you can't even log in as facilitator at https://www.sandbox.paypal.com/signin [01:41:46] ? [01:42:02] i can its from the redirect [01:42:21] oh when making the donation [01:42:21] i logged in, found the ipn, changed it to mine then failing at making a donation [01:42:23] huh [01:42:38] I can try again [01:42:56] but I guess the IPN wouldn't match with the ct_id on your side [01:43:32] wouldnt a new one get me a new ipn or no? [01:43:41] im gona try from other computer since tunnel is up [01:44:09] ah yeah, I could just hit your endpoint! [01:44:14] what's your url ? [01:44:18] oh that works toO! [01:44:20] 4 [01:44:31] k, will do [01:44:46] i wonder if i banned my ip somehow? [01:44:52] lol [01:45:02] i don't think we have ip velocity on in dev, do we? [01:45:18] like paypal banned it [01:45:41] oh no, I'm getting the 'inactive' screen! [01:45:46] oh no [01:45:48] haha [01:45:55] wait, but it was the prod site I think... [01:46:04] yeah it goes to the prod site idono how [01:46:17] i stepped through it far enough to see its pulling the test credentials [01:46:50] look at the redirect-url in config-private/smashpig/paypal/main.yaml [01:46:57] is that with sandbox? [01:47:05] gonna try locally too [01:47:30] i thought thats what i chcked lemme check again [01:47:33] ok, locally I still get to sandbox [01:47:54] endpoint: https://api.sandbox.paypal.com/nvp ? [01:48:03] no the redirect-url: [01:48:09] hmm [01:48:12] is that not there? [01:48:25] redirect-url: 'https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token=' [01:48:36] haha its not there which maybe my config private is cursed [01:48:44] i see it in the clean one i pulled [01:49:08] weird, ok [01:49:13] yah, just delete and reclone [01:49:28] yeah wtf okay [01:49:30] working now [01:51:09] ehh, who knows what gremlins lurk in the tangle of docker / git / filesystem mount [01:52:43] did the ipn send right away for you? [01:53:31] omg I typod it [01:53:34] failing everywhere [01:54:52] now its not going to sandbox?? [01:55:14] uhhh do you have some weird overlay mount or something? [01:55:25] some automatic script messing with your main.yaml? [01:55:33] i shouldnt and i removed my overrides [01:56:58] if i did a fresh clone of config-private is there some test setting I lost? [01:57:07] although it juts worked after I did that I thought [01:57:57] cstone config-private should be all test settings [01:58:08] i think i'm on a clean checkout of that [01:58:26] yah [01:58:54] hmmm https://api.paypal.com/nvp |is what im calling somehow [01:59:21] lemme restart the container maybe it doesnt see it at all? [01:59:22] dang, that seems wrong [01:59:30] yeah, i guess restart [01:59:36] are you on mac or linux? [01:59:43] linux [02:00:02] odd, i haven't had such problems on linux ever [02:00:10] yeah its my personal curse [02:00:12] happens all the time [02:01:11] restarting fixed it [02:01:33] but thats weird is it like if no credentials = prod credentials? [02:02:12] well, if it can't find that main.yaml it uses the defaults from the src/smashpig/config/paypal folder [02:02:19] and those defaults are the prod endpoints [02:02:36] ahhh okay [02:02:59] i tried searching that endpoint and nothing was coming up but maybe thats not indexed right now [02:03:36] anway theres an ipn! says invalid but whatever haha [02:03:54] ohhh [02:04:08] yay okay second one is valid [02:04:10] the postback URL needs to point to sandbox too [02:04:17] oh ok [02:04:25] great! [02:06:05] ahh i see the runnables you were fixing [02:07:21] yeah, i want to get rid of that noise [02:11:09] f doner just makes me think of https://en.wikipedia.org/wiki/Doner_kebab and now im hungry [02:12:58] wooo [02:12:58] Subscription Info [02:12:58] Subscription ID: I-YT070HS7P1GLStatus: Canceled [02:13:20] :) [02:13:33] (03CR) 10Cstone: [C:03+2] "this is awesome!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/976262 (https://phabricator.wikimedia.org/T335712) (owner: 10Ejegg) [02:14:07] (03CR) 10Cstone: [C:03+2] Fix a bit of outdated documentation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1039286 (owner: 10Ejegg) [02:14:16] yayay [02:15:32] looks like the runnable patch has the linter mad at it [02:16:08] (03Merged) 10jenkins-bot: Fix a bit of outdated documentation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1039286 (owner: 10Ejegg) [02:16:17] yeah my smashpig isnt indexed why not [02:16:26] oh huh, let me check on that runnable one [02:17:00] oh, unused 'use' [02:18:48] (03PS6) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [02:18:48] (03PS1) 10Ejegg: WIP DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) [02:19:11] (03CR) 10CI reject: [V:04-1] WIP DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [02:19:16] (03CR) 10CI reject: [V:04-1] Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [02:19:38] ahhh in the test [02:20:03] i wanted to see how old that object comment was haha 2016! [02:20:09] or older [02:20:59] (03PS7) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [02:20:59] (03PS2) 10Ejegg: WIP DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) [02:21:22] (03CR) 10CI reject: [V:04-1] WIP DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [02:22:27] hah im out on my balcony i had no idea how late it was [02:22:40] its still 85 out! [02:27:46] (03PS3) 10Ejegg: DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) [02:28:08] (03CR) 10CI reject: [V:04-1] DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [02:29:45] SmashPig\Core\DataStores\DataSerializationException@/srv/smashpig/Core/DataStores/JsonSerializableObject.php:131 (Class 'SmashPig\PaymentProviders\PayPal\Job' does not implement fromJson()! Cannot deserialize data.) is this the sameish issue or a different one? it updated my images when I restarted so might be from that [02:30:26] cstone ohh you need to clear out all your existing jobs before you pull down the patch [02:30:45] so revert and run the jobs queues till they are empty [02:31:44] ah okay lemme retry [02:34:24] (03CR) 10DannyS712: [C:03+2] Fix a few easy to fix PHPCS doc style exceptions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1039716 (owner: 10Thiemo Kreuz (WMDE)) [02:35:23] (03Merged) 10jenkins-bot: Implement cancelSubscription for SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/976262 (https://phabricator.wikimedia.org/T335712) (owner: 10Ejegg) [02:37:34] Ooh, I want to deploy that before I head to bed [02:37:50] (03CR) 10Cstone: [C:03+2] "looks good! thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [02:38:23] ty cstone ! [02:39:02] (03Merged) 10jenkins-bot: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [02:40:15] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1039898 [02:40:17] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1039898 (owner: 10Ejegg) [02:41:27] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1039898 (owner: 10Ejegg) [02:44:35] !log fundraising civicrm upgraded from 757f8528 to ebfbad86 [02:44:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:47:59] 03Fundraising Sprint K (placeholder name), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when humans cancel recurrings - https://phabricator.wikimedia.org/T361636#9869753 (10Ejegg) OK, this is done! @SHust / @AMJohnson / @krobinson: The Civi UI's... [02:48:30] time to cancel a paypal?? [02:48:44] do you have one? [02:48:53] I just realized my recurrings are both adyen [02:49:16] yeah I just did my 1 euro one [02:49:19] :) [02:49:21] i have 3 i want to cancel 2 of them haha [02:49:28] k, i'm going to bed! [02:49:33] thanks ejegg good night! [02:49:34] cya tomorrow [02:50:03] (03Merged) 10jenkins-bot: Fix a few easy to fix PHPCS doc style exceptions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1039716 (owner: 10Thiemo Kreuz (WMDE)) [02:56:05] 03Fundraising Sprint K (placeholder name), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when humans cancel recurrings - https://phabricator.wikimedia.org/T361636#9869758 (10Cstone) I cancelled one of mine I-90ADK9UBH20V The user UI is kind of con... [14:26:10] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Civi Error Message - https://phabricator.wikimedia.org/T366652#9871133 (10AMJohnson) Thank you, @Ejegg! [14:55:56] (03CR) 10Ejegg: "I think we need to override get_log_distilling_grep_string too - that's used for the first pass over all the log files to make smaller fil" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037094 (owner: 10Damilare Adedoyin) [14:56:06] damilare: sorry it took me so long to look at that stuff [14:57:22] (03PS1) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [14:58:30] (03PS2) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [15:00:44] no p ejegg thanks for looking into it. I'd look into that override [15:01:04] oh wait, now looking at that get_logs_on_error_days function [15:01:17] does that avoid using the 'distilled' logs [15:01:32] sorry, it's a bit hard to recreate the situation locally [15:02:34] (03PS3) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [15:02:59] damilare: ah i see, you directly zgrep in those files [15:03:31] yep, it's just suppose to help only for the backlogs. [15:04:20] (03CR) 10CI reject: [V:04-1] Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [15:05:02] it checks all the logs around the trxn date and if no results, then it checks the logs on the set dates. [15:08:26] huh we never check that $errorlevel [15:12:55] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: Update fundraising mail settings to use new production mx hosts - https://phabricator.wikimedia.org/T366740#9871245 (10jhathaway) @Dwisehaupt let me know if you want to do any canary tests, I'm happy to look at raw emails to assess whether they we... [15:16:48] 03Fundraising Sprint K (placeholder name), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when humans cancel recurrings - https://phabricator.wikimedia.org/T361636#9871248 (10MBeat33) This is **totally great news**, thank you @Ejegg and @Cstone T... [15:20:15] 03Fundraising Sprint K (placeholder name), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when humans cancel recurrings - https://phabricator.wikimedia.org/T361636#9871262 (10Ejegg) > Can this new functionality be made to cover legacy recurrings, o... [15:28:28] ejegg: theres a question in our talk to about the recurring cancel error when its already cancelled in paypal, they could click the no on the processor send part on that one right and it would just cancel in civi? [15:29:24] (here: https://wikimedia.slack.com/archives/C045WH0QYS2/p1717738798015329 ) [15:29:55] cstone ah I need to check on that [15:30:08] this is where it was already cancelled in paypal [15:30:31] * greg-g is in standup [15:32:58] right, I'm just checking if the 'send to processor' checkbox is consulted in the core code or if our code is expected to respect it [17:56:29] 03Fundraising Sprint K (placeholder name), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when humans cancel recurrings - https://phabricator.wikimedia.org/T361636#9871737 (10Ejegg) @MBeat33 the PayPal documentation suggests that the same command w... [18:03:18] 03Fundraising Sprint K (placeholder name), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices: ask Civi to use PayPal's API when humans cancel recurrings - https://phabricator.wikimedia.org/T361636#9871748 (10MBeat33) Thanks for checking into it @Ejegg We can test it a little more,... [18:06:31] damilare|brb: one more question about your audit patch when you're back [18:08:39] looks like the grep for the error days will return multiple rows for each order_id [18:09:06] then we loop over those and call extract_raw_data_from_logline with &$raw_data as a param [18:09:54] we would want to get the info from all of those lines merged into a single array, right? [18:10:31] but it looks like the value of $raw_data that's passed in gets discarded and overwritten with the $donor_info + $payment_info from a single line [18:10:48] am I missing something? [18:19:41] (03PS3) 10Eileen: Add test & fix for issue with type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036576 (https://phabricator.wikimedia.org/T363965) [18:19:46] (03CR) 10Ejegg: [C:03+2] Add test & fix for issue with type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036576 (https://phabricator.wikimedia.org/T363965) (owner: 10Eileen) [18:37:33] hello [18:37:41] hi eileen ! [18:37:47] how's it going? [18:38:09] work-wise, pretty good! [18:38:33] (/me ignores screams of kid resisting naptime in the other room) [18:38:41] how's Hamburg? [18:38:56] lol [18:39:09] yeah good - am tired but it has been a good week [18:41:40] (03Merged) 10jenkins-bot: Add test & fix for issue with type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036576 (https://phabricator.wikimedia.org/T363965) (owner: 10Eileen) [19:39:05] 06Fundraising-Backlog: New data flows in support of reconciliation related to the Gr4vy payment orchestration project - https://phabricator.wikimedia.org/T366840#9871995 (10greg) (@EMartin Andre added it when he left his comment :) ) [20:02:32] 06Fundraising-Backlog: run PayPal refund script for May - https://phabricator.wikimedia.org/T366943 (10MBeat33) 03NEW [20:07:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: run PayPal refund script for May - https://phabricator.wikimedia.org/T366943#9872070 (10greg) p:05Triage→03High "High" because we should just do it. For internal reference: https://wikimedia.slack.com/archives/C045WH0QYS2/p1717790650647069 [21:15:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: run PayPal refund script for May - https://phabricator.wikimedia.org/T366943#9872276 (10Cstone) these have been refunded [21:20:56] sorry ejegg|afk, I went off for dinner. So the grep only return 1 line each as the search is quite specific. The first one is checking for the raw response from the initial authorization and the second one is the outbound request. [21:21:19] These searches are suppose to help get pieces of info about the trxns [21:23:22] cstone: ty for the refund script run! [21:25:08] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: run PayPal refund script for May - https://phabricator.wikimedia.org/T366943#9872290 (10MBeat33) thank you @Cstone [21:25:13] ok I see what you mean, I had an oversight thinking the variable wasn't declared earlier. I'd update that [21:25:54] (03PS6) 10Damilare Adedoyin: Attempt to recreate and import missed Dlocal trxns through audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037094 [21:34:15] ok, I think I was a bit confused. The donor info and payment info were pulled from different log lines as explained earlier. However, the results were concatenated on one string [21:35:28] so I can run a demo next tech talk to explain step by step what's happening [21:36:35] ohhh, weird, ok [22:42:25] (03PS1) 10Ejegg: Add test for ACH donation in Audit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1040276 [22:42:46] (03CR) 10CI reject: [V:04-1] Add test for ACH donation in Audit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1040276 (owner: 10Ejegg) [22:46:55] hmm, timezone dependence [23:06:32] urgh, I apparently don't understand PHP DateTime objects [23:06:41] we're constructing it with an explicit TimeZone [23:06:50] then pulling getTimestamp() [23:07:07] shouldn't that insulate us from the local machine's TZ? [23:12:38] time is a mystery [23:14:00] timelines doubly so [23:16:27] (03PS2) 10Ejegg: Add test for ACH donation in Audit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1040276 [23:16:40] ugh, ok, there it is in the CI timezone [23:27:42] stack trace on php8 deprecated msg is insane [23:28:33] (03PS1) 10Cstone: Add unique_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1040282 [23:30:24] ^ that's just to stop the giant stack trace from the unit test hah