[06:35:17] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1041955 (owner: 10L10n-bot) [06:52:07] 06Fundraising-Backlog: Scoping: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#9883185 (10MSuijkerbuijk_WMF) @AKanji-WMF confirming that the content doc is now ready with the right sender (Sandra) as per above details [10:13:31] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi related - donor status and donor segment fields in Civi - https://phabricator.wikimedia.org/T367276 (10RLewis) 03NEW [11:50:59] (03PS29) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [11:51:23] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [11:52:08] (03PS30) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [12:02:54] (03PS14) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [13:46:25] Ughhh, trying to delete a batch of *8* contributions in SQL and it's still not happy [13:46:32] been like a minute already [13:47:31] (03PS1) 10Damilare Adedoyin: Fix dlocal audit fallback error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042259 [13:49:39] ok, 5 minutes now [13:49:54] that'll be causing queue failmail, won't it [13:50:10] killing the query [13:58:03] (03CR) 10Ejegg: [C:03+2] Fix dlocal audit fallback error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042259 (owner: 10Damilare Adedoyin) [14:01:05] so... I guess I queue up 35k deletes via the API? [14:04:59] thanks for the cr ejegg [14:12:37] sure thing! [14:18:38] (03Merged) 10jenkins-bot: Fix dlocal audit fallback error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042259 (owner: 10Damilare Adedoyin) [14:22:48] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042272 [14:32:46] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042272 (owner: 10Damilare Adedoyin) [14:33:29] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042272 (owner: 10Damilare Adedoyin) [14:59:47] (03PS1) 10Damilare Adedoyin: Fix dlocal audit fallback assumption that all payments are card payments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042289 [15:03:42] (03CR) 10Ejegg: [C:03+2] Fix dlocal audit fallback assumption that all payments are card payments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042289 (owner: 10Damilare Adedoyin) [15:10:58] (03PS1) 10Ejegg: Clean up bad donations one by one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042293 (https://phabricator.wikimedia.org/T365519) [15:16:06] OK fr-tech those commented-out API helpers seem to work fine ^^^ [15:16:22] ah let me smoketest one more time with the weight added [15:17:54] (03PS8) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [15:19:59] (03CR) 10CI reject: [V:04-1] Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [15:21:31] oh and I could take that extra logging out [15:23:11] (03PS2) 10Ejegg: Clean up bad donations one by one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042293 (https://phabricator.wikimedia.org/T365519) [15:29:39] (03Merged) 10jenkins-bot: Fix dlocal audit fallback assumption that all payments are card payments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042289 (owner: 10Damilare Adedoyin) [15:33:58] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042300 [15:36:04] (03PS3) 10Ejegg: Clean up bad donations one by one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042293 (https://phabricator.wikimedia.org/T365519) [15:39:29] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042300 (owner: 10Damilare Adedoyin) [15:40:16] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042300 (owner: 10Damilare Adedoyin) [16:01:51] (03CR) 10Damilare Adedoyin: [C:03+2] Clean up bad donations one by one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042293 (https://phabricator.wikimedia.org/T365519) (owner: 10Ejegg) [16:07:19] (03PS1) 10Damilare Adedoyin: Not all card responses contain card_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042304 [16:21:43] (03Merged) 10jenkins-bot: Clean up bad donations one by one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042293 (https://phabricator.wikimedia.org/T365519) (owner: 10Ejegg) [16:24:13] 06Fundraising-Backlog: Need to not autocancel recurring iDEAL/SEPA chargebacks - https://phabricator.wikimedia.org/T366769#9885477 (10Dwisehaupt) [16:31:39] thanks for the review damilare ! [16:35:43] hmm, I guess I'll wait till after lunch to deploy that [16:36:00] damilare: it's ok if that goes out (in case you need to do another deploy for the audit) [16:36:13] we can just hold off running the extension upgrades till I'm back at the keyboard [16:47:55] yep ejegg|food, I just have that one patch but it can wait till you're back [16:48:06] https://gerrit.wikimedia.org/r/1042304 [18:11:21] (03PS9) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [18:13:28] (03CR) 10CI reject: [V:04-1] Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [18:14:33] (03CR) 10Ejegg: [C:03+2] Not all card responses contain card_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042304 (owner: 10Damilare Adedoyin) [18:14:38] (03PS2) 10Damilare Adedoyin: Not all card responses contain card_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042304 [18:14:43] (03CR) 10Ejegg: [V:03+2 C:03+2] Not all card responses contain card_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042304 (owner: 10Damilare Adedoyin) [18:15:12] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042330 [18:15:18] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042330 (owner: 10Ejegg) [18:16:05] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1042330 (owner: 10Ejegg) [18:24:08] !log fundraising civicrm upgraded from 955166d1 to 76857844 [18:24:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:24:16] ok, gonna kick off the deletions [18:30:28] 06Fundraising-Backlog: Determining from which banner an RML donation originated - https://phabricator.wikimedia.org/T318887#9886140 (10KHaggard) 05Open→03Resolved Chiming in here after syncing with Eric. The data stored in Civi were clarified and Eric was able to get the data requested from Joseph, so we... [18:32:11] seems to be getting through multiple ones per second! [18:34:23] yep, bogon count steadily dropping with no deadlocks so far [18:34:58] wooo ejegg [18:36:45] 14Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 06Fundraising-Backlog: Adding and storing rml_source data for RML donations reporting - https://phabricator.wikimedia.org/T321163#9886178 (10KHaggard) Hi @AKanji-WMF - sorry for the delay getting back to you. I... [18:37:28] so it'll be about 8 hours to get them all [18:56:23] anilk: what do you think about pulling this into the sprint https://phabricator.wikimedia.org/T341247 ? Mariana is looking at email cancellation stats and I am sure we will want that more in the future but we wont have them unless we are tying cancellations to something [19:35:22] (03PS1) 10Umherirrender: Use namespaced classes [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1042358 [19:36:06] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9886377 (10Cstone) @SHust is there a most common cancel reason you want autoselected by default? then the others would be available in... [19:55:21] (03CR) 10DannyS712: [C:03+2] Use namespaced classes [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1042358 (owner: 10Umherirrender) [20:01:01] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9886470 (10SHust) @Cstone if a default reason is required the 'Other and Unspecified' would be the one. Thanks for asking! [20:06:21] 06Fundraising-Backlog, 10wikimediafoundation.org: Update donation links on wikimediafoundation.org to use wmf_ parameters - https://phabricator.wikimedia.org/T367357 (10Pcoombe) 03NEW [20:06:53] 06Fundraising-Backlog, 10Wikimedia-Portals, 07Epic: Update donation links on Portal to use wmf_ parameters - https://phabricator.wikimedia.org/T367358 (10Pcoombe) 03NEW [20:06:59] 06Fundraising-Backlog, 10Wikimedia-Portals: Update donation links on Portal to use wmf_ parameters - https://phabricator.wikimedia.org/T367358#9886506 (10Pcoombe) [20:07:24] 06Fundraising-Backlog, 07Epic, 10MW-1.43-notes (1.43.0-wmf.7; 2024-05-28): Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9886508 (10Pcoombe) [20:12:36] (03PS2) 10Ejegg: Don't queue a job for ended autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041185 [20:13:01] (03CR) 10CI reject: [V:04-1] Don't queue a job for ended autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041185 (owner: 10Ejegg) [20:14:05] 06Fundraising-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog: Update donation links in apps to use wmf_ parameters - https://phabricator.wikimedia.org/T367360 (10Pcoombe) 03NEW [20:14:05] (03PS3) 10Ejegg: Don't send ProcessCaptureRequestJob for ended autorescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041185 [20:16:39] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9886563 (10Cstone) @SHust For Other and Unspecified would just having no reason make more sense? I think it would align more with our... [20:16:43] cstone: can you remind me where we are changing the contribution_recur status on failed autorescue? [20:17:09] 06Fundraising-Backlog: Update web sidebar donation links to use wmf_ parameters - https://phabricator.wikimedia.org/T367361 (10Pcoombe) 03NEW [20:21:17] (03Merged) 10jenkins-bot: Use namespaced classes [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1042358 (owner: 10Umherirrender) [20:25:46] (03PS1) 10Damilare Adedoyin: make sure only Authorized payments are pulled from logs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042364 [20:28:13] 06Fundraising-Backlog, 07Epic, 10MW-1.43-notes (1.43.0-wmf.7; 2024-05-28): Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9886611 (10Pcoombe) [20:29:21] 06Fundraising-Backlog, 07Epic, 10MW-1.43-notes (1.43.0-wmf.7; 2024-05-28): Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325#9886613 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Closing this, the main work is done and I sent an email to fr-all e... [20:30:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi / Adyen mismatch re: recurring retries - https://phabricator.wikimedia.org/T365519#9886620 (10MBeat33) Thanks so much for the group @Ejegg. @SHust and I will concentrate on reaching out to the one-time donors in it, and trust Civi to email the recurr... [20:36:05] ejegg: did you find it, I think its right in the failure part of the recurring charge [20:36:31] or failed as in final status? [20:41:29] ejegg: here's the patch to streamline the grep: https://gerrit.wikimedia.org/r/1042364 [20:42:13] I'd complete the import tomorrow, hopefully that should get the other recurrings in. [20:46:27] cstone: sorry, I saw some processing on the IPN jobs but it seemed like it wasn't doing the right thing. Tried removing it in this patch https://gerrit.wikimedia.org/r/1041185 [20:46:40] but are we sending a subscr_cancel to the recurring queue at some point? [20:46:45] looking dami [20:47:02] (03CR) 10Ejegg: [C:03+2] make sure only Authorized payments are pulled from logs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042364 (owner: 10Damilare Adedoyin) [20:48:10] ejegg: like it failed with fraud? [20:51:08] cstone no, just it ran out of retries [20:51:18] don't we want to cancel the recurring at that point? [20:51:48] like we used to do after 3 failed charges with the old retry logic [20:51:53] ahh okay i see [20:53:56] it should be either in the recurring queue or whatever queue we moved it to? [20:54:20] ok, but we would need to send that from the IPN listener, wouldn't we? [20:54:26] Are we actually doing that yet? [20:55:28] theres cancel reasons somewhere hmm [20:55:53] 06Fundraising-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog: Update donation links in apps to use wmf_ parameters - https://phabricator.wikimedia.org/T367360#9886718 (10Tsevener) Options: 1. iOS changes looking for `utm_source` in campaign urls to `wmf_source` instead. 2. iOS instead... [20:58:27] the only thing I see being pushed to the recurring queue in all of the Adeyn folder is that one subscr_payment when $this->isSuccessfulAutoRescue [20:59:00] so I'm thinking we may have a lot of recurrings that should be cancelled at this point [20:59:24] hmmmm [20:59:42] unless we're picking up those final failures on the audit someplace? [21:00:27] anyway, i was looking for that because i was thinking i needed to do one more cleanup step from my boolean bug [21:01:04] i.e. cancel recurrings who got to the end of the line [21:02:13] Payment cannot be rescued: Blocked Card theres ones with cancel reasons like this [21:02:17] but thats the inital [21:03:50] ok, this looks like the ticket: https://phabricator.wikimedia.org/T340159 [21:05:05] 133641227 was cancelled after a bunch of attempts? [21:05:16] ah interesting, let's see how that happened [21:05:37] is that a contribution ID? [21:06:01] oooh wait its not cancelled hmm [21:08:01] why does it have a cancelled reason [21:08:17] no it is cancelled [21:09:17] (03Merged) 10jenkins-bot: make sure only Authorized payments are pulled from logs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042364 (owner: 10Damilare Adedoyin) [21:09:59] did it not actually cancel then like you are seeing but we are giving it a cancel reason? [21:10:13] wait it says status cancelled but the UI says in progress? [21:10:46] odd [21:11:09] so that looks like an initial attempt [21:11:11] from the log [21:11:14] ok i think im just super confused [21:11:24] maybe what I thought i searched on adyen was not it [21:11:26] i.e. we got the response back in realtime from the API [21:11:40] I don't think that ever went into 'pending' [21:11:54] yeah, select * from log_civicrm_contribution_recur where id=1298694; [21:12:36] shows that it was in status 2, then flipped to 14 (processing), then to 3 [21:12:42] ok that one i said failed out on the first api call then on may 7 and was cancelled may 7 [21:13:21] so all that happened within a couple sec [21:13:58] yeah, what I want to know is how do we cancel one that goes into autorescue / pending, but after a few tries Adyen tells us they can't make it work [21:14:05] and I think we're just not handling that [21:14:07] so are you saying we never actually cancelled it when it fails after all the attenpts? [21:14:11] yeah [21:14:19] is adyen actually saying it wont work? [21:14:32] should have been done as part of https://phabricator.wikimedia.org/T340164 maybe [21:14:59] cstone: adyen is giving up after a bunch of tries and saying they're ending the attempt [21:15:20] so I think we don't want to waste our time / reputation by trying to charge again the next month [21:15:52] yeah like they send us some end of attempts message? [21:15:56] yeah they do [21:16:12] and for some reason we're currently just sending them a 'cancel auth' API call [21:16:35] which isn't really helpful, so I'm removing it in this patch: https://gerrit.wikimedia.org/r/1041185 [21:17:04] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9886763 (10AMJohnson) Sorry to hop in @SHust. Feel free to add if I'm missing anything! @Cstone - Kristie and I put together this li... [21:17:25] I think I'll add a follow-on patch to send that subscr_cancel message [21:17:30] ok, gotta pick up my kid! [21:44:02] i'm doing to shift the thank you sending back to using both frmx hosts evenly. [21:59:34] ok. verified mail is flowing through both as desired. [22:05:59] +1 [22:25:24] cstone: that would be nice - Yes, Mariana was talking about this in another call today too (cancel stats). Seems like there's good momentum, am just wary of our need to focus on payment integration. https://phabricator.wikimedia.org/T341247 - XenoRyet what do you think? [22:35:03] 06Fundraising-Backlog: Compliance requirement re: account validation for ACH - https://phabricator.wikimedia.org/T367078#9886889 (10EMartin) I have spoken to Gr4vy about this requirement and trying to solve for it through our connection to them. [23:15:03] 06Fundraising-Backlog, 10fundraising-tech-ops, 10observability: Shift frack alerting to use alertmanager instead of icinga - https://phabricator.wikimedia.org/T367370 (10Dwisehaupt) 03NEW [23:26:48] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9887005 (10Cstone) Thanks for the info @AMJohnson ! We have complete control of how the dropdown works so we can make it do whatever i... [23:27:36] 06Fundraising-Backlog, 10fundraising-tech-ops, 10observability: Shift frack alerting to use alertmanager instead of icinga - https://phabricator.wikimedia.org/T367370#9887010 (10Dwisehaupt) In the puppet-private repo: commit f94d1d4501e54136766722074b6821502213ccc1 staged on `T367370_prom_alerts` branch for...